GNU bug report logs - #34104
26.1; Inaccurate error report of (sort "cba" #'<)

Previous Next

Package: emacs;

Reported by: mail <at> xuchunyang.me

Date: Wed, 16 Jan 2019 14:54:03 UTC

Severity: minor

Found in version 26.1

Done: Philipp Stephani <p.stephani2 <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34104 in the body.
You can then email your comments to 34104 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#34104; Package emacs. (Wed, 16 Jan 2019 14:54:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to mail <at> xuchunyang.me:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 16 Jan 2019 14:54:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: mail <at> xuchunyang.me
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; Inaccurate error report of (sort "cba" #'<)
Date: Wed, 16 Jan 2019 22:53:19 +0800
Eval (sort "cba" #'<) gives

Debugger entered--Lisp error: (wrong-type-argument sequencep "cba")
  sort("cba" <)
  eval((sort "cba" (function <)) nil)
  elisp--eval-last-sexp(nil)
  eval-last-sexp(nil)
  funcall-interactively(eval-last-sexp nil)
  call-interactively(eval-last-sexp nil nil)
  command-execute(eval-last-sexp)

the error is inaccurate since "cba" is indeed a sequence

(sequencep "cba")
;; => t

it should report "cba" is not a list or vector instead.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34104; Package emacs. (Thu, 17 Jan 2019 22:44:02 GMT) Full text and rfc822 format available.

Message #8 received at 34104 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: mail <at> xuchunyang.me
Cc: 34104 <at> debbugs.gnu.org
Subject: Re: bug#34104: 26.1; Inaccurate error report of (sort "cba" #'<)
Date: Thu, 17 Jan 2019 23:43:16 +0100
[Message part 1 (text/plain, inline)]
Am Mi., 16. Jan. 2019 um 15:54 Uhr schrieb <mail <at> xuchunyang.me>:
>
>
> Eval (sort "cba" #'<) gives
>
> Debugger entered--Lisp error: (wrong-type-argument sequencep "cba")
>   sort("cba" <)
>   eval((sort "cba" (function <)) nil)
>   elisp--eval-last-sexp(nil)
>   eval-last-sexp(nil)
>   funcall-interactively(eval-last-sexp nil)
>   call-interactively(eval-last-sexp nil nil)
>   command-execute(eval-last-sexp)
>
> the error is inaccurate since "cba" is indeed a sequence
>
> (sequencep "cba")
> ;; => t
>
> it should report "cba" is not a list or vector instead.
>


Here's a patch.
[0001-Improve-error-data-when-passing-a-wrong-type-to-sort.txt (text/plain, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34104; Package emacs. (Fri, 18 Jan 2019 08:32:02 GMT) Full text and rfc822 format available.

Message #11 received at 34104 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: mail <at> xuchunyang.me, 34104 <at> debbugs.gnu.org
Subject: Re: bug#34104: 26.1; Inaccurate error report of (sort "cba" #'<)
Date: Fri, 18 Jan 2019 10:30:57 +0200
> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Thu, 17 Jan 2019 23:43:16 +0100
> Cc: 34104 <at> debbugs.gnu.org
> 
> > Debugger entered--Lisp error: (wrong-type-argument sequencep "cba")
> >   sort("cba" <)
> >   eval((sort "cba" (function <)) nil)
> >   elisp--eval-last-sexp(nil)
> >   eval-last-sexp(nil)
> >   funcall-interactively(eval-last-sexp nil)
> >   call-interactively(eval-last-sexp nil nil)
> >   command-execute(eval-last-sexp)
> >
> > the error is inaccurate since "cba" is indeed a sequence
> >
> > (sequencep "cba")
> > ;; => t
> >
> > it should report "cba" is not a list or vector instead.
> >
> 
> 
> Here's a patch.

LGTM, thanks.




Reply sent to Philipp Stephani <p.stephani2 <at> gmail.com>:
You have taken responsibility. (Sat, 19 Jan 2019 23:06:02 GMT) Full text and rfc822 format available.

Notification sent to mail <at> xuchunyang.me:
bug acknowledged by developer. (Sat, 19 Jan 2019 23:06:02 GMT) Full text and rfc822 format available.

Message #16 received at 34104-done <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: mail <at> xuchunyang.me, 34104-done <at> debbugs.gnu.org
Subject: Re: bug#34104: 26.1; Inaccurate error report of (sort "cba" #'<)
Date: Sun, 20 Jan 2019 00:05:04 +0100
Am Fr., 18. Jan. 2019 um 09:31 Uhr schrieb Eli Zaretskii <eliz <at> gnu.org>:
>
> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
> > Date: Thu, 17 Jan 2019 23:43:16 +0100
> > Cc: 34104 <at> debbugs.gnu.org
> >
> > > Debugger entered--Lisp error: (wrong-type-argument sequencep "cba")
> > >   sort("cba" <)
> > >   eval((sort "cba" (function <)) nil)
> > >   elisp--eval-last-sexp(nil)
> > >   eval-last-sexp(nil)
> > >   funcall-interactively(eval-last-sexp nil)
> > >   call-interactively(eval-last-sexp nil nil)
> > >   command-execute(eval-last-sexp)
> > >
> > > the error is inaccurate since "cba" is indeed a sequence
> > >
> > > (sequencep "cba")
> > > ;; => t
> > >
> > > it should report "cba" is not a list or vector instead.
> > >
> >
> >
> > Here's a patch.
>
> LGTM, thanks.

Pushed as 551051596f.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 17 Feb 2019 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 41 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.