GNU bug report logs - #34117
26.1; Incorrect byte-compile warnings

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Thu, 17 Jan 2019 19:32:01 UTC

Severity: wishlist

Tags: notabug, wontfix

Merged with 24353

Found in versions 25.1.1, 26.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34117 in the body.
You can then email your comments to 34117 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#34117; Package emacs. (Thu, 17 Jan 2019 19:32:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Drew Adams <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 17 Jan 2019 19:32:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; Incorrect byte-compile warnings
Date: Thu, 17 Jan 2019 11:31:16 -0800 (PST)
Byte-compiling a sexp such as this:

 (make-obsolete-variable 'foo 'bar)

raises a warning such as this:

 Warning: make-obsolete-variable called with 2 arguments, but requires
 3-4

That's wrong.  It is incorrect that it requires 3 or 4.  It requires
only 2.

The code for `make-obsolete-variable' has this comment, which betrays
the probable (misguided) motivation for the warning:

 "New code should always provide the `when' argument."

New code?  This comment, and the resulting warning, seem to be targeted
at core Emacs developers, not users.

"Require" means require.  This function does NOT require 3 or 4 args.

It is important for backward compatibility that requier only 2 args.  It
might be desirable for users, as well as core Emacs developers, to use 3
or 4 args, but neither the 3rd nor the 4th should be required (and
neither IS required).  The warning should be removed - there is nothing
to warn about.

There are ways to _encourage_ users to add a third arg (WHEN).  Warning
them that it is _required_ is not appropriate.  The byte-compiler should
not lie.

Same misguided approach to `make-obsolete'.  Only 2 args are required.
It is inappropriate, misleading, and unnecessary to tell users that 3
are required.


In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
 of 2018-05-30
Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea
Windowing system distributor `Microsoft Corp.', version 10.0.17134
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''




Forcibly Merged 24353 34117. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Thu, 17 Jan 2019 22:15:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34117; Package emacs. (Thu, 17 Jan 2019 22:21:03 GMT) Full text and rfc822 format available.

Message #10 received at 34117 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 34117 <at> debbugs.gnu.org
Subject: Re: bug#34117: 26.1; Incorrect byte-compile warnings
Date: Thu, 17 Jan 2019 17:20:39 -0500
This attempts to relitigate bug#24353.





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34117; Package emacs. (Fri, 18 Jan 2019 00:47:02 GMT) Full text and rfc822 format available.

Message #13 received at 34117 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Glenn Morris <rgm <at> gnu.org>, 34117 <at> debbugs.gnu.org
Subject: RE: bug#34117: 26.1; Incorrect byte-compile warnings
Date: Thu, 17 Jan 2019 16:46:16 -0800 (PST)
> This attempts to relitigate bug#24353.

Not at all.  This is about an inappropriate byte-compiler warning.  It is not about the doc or function signatures.

And it reports a bug.  It doesn't litigate or "attempt to litigate" anything.  The warning message is incorrect, inaccurate.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34117; Package emacs. (Fri, 18 Jan 2019 08:40:01 GMT) Full text and rfc822 format available.

Message #16 received at 34117 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: rgm <at> gnu.org, 34117 <at> debbugs.gnu.org
Subject: Re: bug#34117: 26.1; Incorrect byte-compile warnings
Date: Fri, 18 Jan 2019 10:39:24 +0200
> Date: Thu, 17 Jan 2019 16:46:16 -0800 (PST)
> From: Drew Adams <drew.adams <at> oracle.com>
> 
> The warning message is incorrect, inaccurate.

From my POV, that warning does the job we wanted it to do.  So this is
not a bug, IMO.





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 15 Feb 2019 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 42 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.