GNU bug report logs - #34129
[PATCH] gnu: Add emacs-magit-gerrit.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34129 in the body.
You can then email your comments to 34129 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-magit-gerrit.
Date: Fri, 18 Jan 2019 22:42:32 -0500

[0001-gnu-Add-emacs-magit-gerrit.patch (text/x-patch, attachment)]

From 5b7c68203c3311e1e282414353d0bbf442744c20 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Date: Fri, 18 Jan 2019 22:23:59 -0500
Subject: [PATCH] gnu: Add emacs-magit-gerrit.

* gnu/packages/emacs-xyz.scm (emacs-magit-gerrit): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e6f81d05f..6c7a7facf 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -10131,6 +10131,32 @@ time is being spent during Emacs startup in order to optimize startup time.")
   ;; A new mpv backend is included in Emms from 5.0.
   (deprecated-package "emacs-emms-player-simple-mpv" emacs-emms))
 
+(define-public emacs-magit-gerrit
+  (let ((version "0.3")
+        (revision "1")
+        (commit "ece6f369694aca17f3ac166ed2801b432acfe20d"))
+    (package
+      (name "emacs-magit-gerrit")
+      (version (git-version version revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/terranpro/magit-gerrit.git")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0mms0gxv9a3ns8lk5k2wjibm3088y1cmpr3axjdh6ppv7r5wdvii"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       `(("emacs-magit" ,emacs-magit)))
+      (home-page "https://github.com/terranpro/magit-gerrit")
+      (synopsis "Magit extension for Gerrit")
+      (description "This Magit extension provides integration with Gerrit,
+which makes it possible to conduct Gerrit code reviews directly from within
+Emacs.")
+      (license license:gpl3+))))
+
 (define-public emacs-magit-org-todos-el
   (let ((commit "df206287737b9671f2e36ae7b1474ebbe9940d2a"))
     (package
-- 
2.20.1

Message #8 received at 34129 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 34129 <at> debbugs.gnu.org
Subject: Re: [bug#34129] [PATCH] gnu: Add emacs-magit-gerrit.
Date: Tue, 22 Jan 2019 22:48:54 +0100

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

>>From 5b7c68203c3311e1e282414353d0bbf442744c20 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Fri, 18 Jan 2019 22:23:59 -0500
> Subject: [PATCH] gnu: Add emacs-magit-gerrit.
>
> * gnu/packages/emacs-xyz.scm (emacs-magit-gerrit): New variable.

LGTM, thanks!

Ludo'.

Message #13 received at 34129-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 34129-done <at> debbugs.gnu.org
Subject: Re: [bug#34129] [PATCH] gnu: Add emacs-magit-gerrit.
Date: Wed, 23 Jan 2019 08:02:54 -0500

Ludovic Courtès <ludo <at> gnu.org> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>>>From 5b7c68203c3311e1e282414353d0bbf442744c20 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Fri, 18 Jan 2019 22:23:59 -0500
>> Subject: [PATCH] gnu: Add emacs-magit-gerrit.
>>
>> * gnu/packages/emacs-xyz.scm (emacs-magit-gerrit): New variable.
>
> LGTM, thanks!
>
> Ludo'.

Pushed with commit f0caf7607.

Thanks!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.