GNU bug report logs - #34144
guix import github crash

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34144 in the body.
You can then email your comments to 34144 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: bug-guix <at> gnu.org
Cc: arunisaac <at> systemreboot.net, bavier <at> member.fsf.org
Subject: guix import github crash
Date: Sun, 20 Jan 2019 11:32:06 +0200

[Message part 1 (text/plain, inline)]

$ ./pre-inst-env guix refresh mujs
Backtrace:
          14 (apply-smob/1 #<catch-closure d12200>)
In ice-9/boot-9.scm:
    705:2 13 (call-with-prompt _ _ #<procedure default-prompt-handle…>)
In ice-9/eval.scm:
    619:8 12 (_ #(#(#<directory (guile-user) daa140>)))
In guix/ui.scm:
  1639:12 11 (run-guix-command _ . _)
In ice-9/boot-9.scm:
    829:9 10 (catch _ _ #<procedure 7f096bb0d9b0 at guix/ui.scm:617…> …)
    829:9  9 (catch _ _ #<procedure 7f096bb0d9c8 at guix/ui.scm:735…> …)
In guix/scripts/refresh.scm:
    513:8  8 (_)
In guix/store.scm:
  1693:24  7 (run-with-store _ _ #:guile-for-build _ #:system _ # _)
In guix/scripts/refresh.scm:
   538:14  6 (_ _)
In srfi/srfi-1.scm:
    640:9  5 (for-each #<procedure 1ab7680 at guix/scripts/refresh.…> …)
In guix/scripts/refresh.scm:
    346:2  4 (check-for-package-update #<package mujs <at> 1.0.5 gnu/pac…> …)
In guix/import/github.scm:
   229:25  3 (latest-release #<package mujs <at> 1.0.5 gnu/packages/javas…>)
   172:15  2 (latest-released-version "https://git.ghostscript.com/…" …)
   143:19  1 (fetch-releases-or-tags "https://git.ghostscript.com/mu…")
    120:2  0 (github-user-slash-repository _)

guix/import/github.scm:120:2: In procedure github-user-slash-repository:
Throw to key `match-error' with args `("match" "no matching pattern" ("" "mujs.git"))'.

mujs isn't a github repo, and it looks like there's some checking to be
done somwhere to make sure that the source is actually from a github
repo before checking the github importer for an update.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 34144 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 34144 <at> debbugs.gnu.org, bavier <at> member.fsf.org
Subject: Re: guix import github crash
Date: Mon, 21 Jan 2019 00:11:56 +0530

[Message part 1 (text/plain, inline)]

I've attached a patch addressing this issue. May I push it?

[0001-import-github-Check-if-git-URIs-are-GitHub-URIs.patch (text/x-patch, inline)]

From 57fa15ef15d1fdb0896ce139e1e02c459b285743 Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac <at> systemreboot.net>
Date: Sun, 20 Jan 2019 22:18:32 +0530
Subject: [PATCH] import: github: Check if git URIs are GitHub URIs.

This fixes a regression introduced in 9a5091d0c181453d0f31ce97f96a4e577a25e796
whereby packages with git origin URIs not hosted on GitHub would be wrongly
detected as being covered under the github updater.
Reported by Efraim Flashner <efraim <at> flashner.co.il>.

* guix/import/github.scm (updated-github-url): Check if git URIs are GitHub
URIs.
---
 guix/import/github.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guix/import/github.scm b/guix/import/github.scm
index b287313d98..e17ef0b840 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -98,7 +98,9 @@ false if none is recognized"
               (updated-url source-uri))
              ((source-uri ...)
               (find updated-url source-uri))))
-     ((eq? fetch-method download:git-fetch)
+     ((and (eq? fetch-method download:git-fetch)
+           (string-prefix? "https://github.com/"
+                           (download:git-reference-url source-uri)))
       (download:git-reference-url source-uri))
      (else #f))))
 
-- 
2.19.2

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 34144 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 34144 <at> debbugs.gnu.org, bavier <at> member.fsf.org,
 Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: bug#34144: guix import github crash
Date: Sun, 20 Jan 2019 20:16:23 +0100

Hi Arun,

> I've attached a patch addressing this issue. May I push it?

This looks fine to me.  Thanks!

-- 
Ricardo

Message #16 received at 34144-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: bavier <at> member.fsf.org, 34144-done <at> debbugs.gnu.org,
 Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: bug#34144: guix import github crash
Date: Mon, 21 Jan 2019 01:21:11 +0530

[Message part 1 (text/plain, inline)]

> This looks fine to me.  Thanks!

Pushed, thanks!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.