GNU bug report logs - #34147
27.0.50; M-x describe-package groovy-mode breaks

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34147 in the body.
You can then email your comments to 34147 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xu Chunyang <mail <at> xuchunyang.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; M-x describe-package groovy-mode breaks
Date: Sun, 20 Jan 2019 23:17:38 +0800

I've setup Melpa, C-h P groovy-mode breaks, here is the backtrace

Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
  #f(compiled-function (pkg) #<bytecode 0x45e6b941>)(groovy-mode)
  apply(#f(compiled-function (pkg) #<bytecode 0x45e6b941>) groovy-mode)
  describe-package-1(groovy-mode)
  describe-package(groovy-mode)
  funcall-interactively(describe-package groovy-mode)
  call-interactively(describe-package nil nil)
  command-execute(describe-package)

By evaluating describe-package-1 to get detailed Backtrace (I didn't
paste it since it is very long), it seems the error is caused by the
"last" expression of describe-package-1:

(insert readme-string)

when readme-string is nil.

I notice Melpa fails to provide the readme file, this URL is 404

https://melpa.org/packages/groovy-mode-readme.txt

--
In GNU Emacs 27.0.50
Repository revision: 436c225f1b8ca48fa7c7e769fe6b7055f37af95d
Repository branch: master
Windowing system distributor 'Apple', version 10.3.1671
System Description:  Mac OS X 10.14.2

Message #8 received at 34147 <at> debbugs.gnu.org (full text, mbox):

From: Federico Tedin <federicotedin <at> gmail.com>
To: Xu Chunyang <mail <at> xuchunyang.me>
Cc: 34147 <at> debbugs.gnu.org
Subject: Re: bug#34147: 27.0.50; M-x describe-package groovy-mode breaks
Date: Tue, 05 Feb 2019 20:08:11 -0300

> By evaluating describe-package-1 to get detailed Backtrace (I didn't
> paste it since it is very long), it seems the error is caused by the
> "last" expression of describe-package-1:
>
> (insert readme-string)
>
> when readme-string is nil.
>
> I notice Melpa fails to provide the readme file, this URL is 404
>
> https://melpa.org/packages/groovy-mode-readme.txt

It looks like when a package doesn't provide a 'Commentary' field, the
xyz-readme.txt file isn't generated by MELPA (see
https://github.com/melpa/package-build/blob/master/package-build.el#L382).

Other packages without 'Commentary' (in no particular order):
- instapaper
- javap-mode
- tdd-status-mode-line
- jknav
- runtests

Using C-h P on these packages will trigger the same error. I guess we
could replace:

(insert readme-string)

with:

(when readme-string
  (insert readme-string))

or:

(if readme-string
    (insert readme-string)
  (insert "This package does not provide a description."))

to cover cases where the xyz-readme.txt file for the package doesn't
exist.

Message #11 received at 34147 <at> debbugs.gnu.org (full text, mbox):

From: Federico Tedin <federicotedin <at> gmail.com>
To: Xu Chunyang <mail <at> xuchunyang.me>
Cc: 34147 <at> debbugs.gnu.org
Subject: Re: bug#34147: 27.0.50; M-x describe-package groovy-mode breaks
Date: Tue, 12 Mar 2019 21:39:11 -0300

[Message part 1 (text/plain, inline)]

I'm attaching a small patch with the changes I suggested above.

[package.patch (text/x-diff, attachment)]

Message #16 received at 34147-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Federico Tedin <federicotedin <at> gmail.com>
Cc: Xu Chunyang <mail <at> xuchunyang.me>, monnier <at> iro.umontreal.ca
Subject: Re: bug#34147: 27.0.50; M-x describe-package groovy-mode breaks
Date: Fri, 22 Mar 2019 00:10:02 -0400

Version:27.1

> I'm attaching a small patch with the changes I suggested above.

Pushed, but inserting a fall back text.
Thank you very much,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.