GNU bug report logs - #34153
[PATCH] Update fish to 3.0.0.

Previous Next

Package: guix-patches;

Reported by: Meiyo Peng <meiyo <at> disroot.org>

Date: Mon, 21 Jan 2019 08:21:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34153 in the body.
You can then email your comments to 34153 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#34153; Package guix-patches. (Mon, 21 Jan 2019 08:21:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Meiyo Peng <meiyo <at> disroot.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 21 Jan 2019 08:21:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Meiyo Peng <meiyo <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update fish to 3.0.0.
Date: Mon, 21 Jan 2019 16:19:29 +0800
[Message part 1 (text/plain, inline)]
Hi,

This patch series updates fish shell to 3.0.0 and enable fish to source
/etc/profile using fish-foreign-env.

[0001-gnu-fish-Update-to-3.0.0.patch (text/x-patch, attachment)]
[0002-gnu-Add-fish-foreign-env.patch (text/x-patch, attachment)]
[0003-gnu-fish-Use-fish-foreign-env-to-source-etc-profile.patch (text/x-patch, attachment)]
[Message part 5 (text/plain, inline)]
--
Meiyo Peng
https://www.pengmeiyu.com/

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 28 Jan 2019 22:14:01 GMT) Full text and rfc822 format available.

Notification sent to Meiyo Peng <meiyo <at> disroot.org>:
bug acknowledged by developer. (Mon, 28 Jan 2019 22:14:01 GMT) Full text and rfc822 format available.

Message #10 received at 34153-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Meiyo Peng <meiyo <at> disroot.org>
Cc: 34153-done <at> debbugs.gnu.org
Subject: Re: [bug#34153] [PATCH] Update fish to 3.0.0.
Date: Mon, 28 Jan 2019 23:13:21 +0100
Hello Meiyo,

Meiyo Peng <meiyo <at> disroot.org> skribis:

> This patch series updates fish shell to 3.0.0 and enable fish to source
> /etc/profile using fish-foreign-env.

I don’t use Fish so I don’t really have an opinion but it looks
reasonable to me.  If it breaks, users will yell at you anyway.  ;-)

>>From 8d20b9d62d0d6c6c9c572b5871d0063c8b4fdf07 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng <at> gmail.com>
> Date: Sun, 6 Jan 2019 22:11:36 +0800
> Subject: [PATCH 1/3] gnu: fish: Update to 3.0.0.
>
> * gnu/packages/shells.scm (fish): Update to 3.0.0.
>   [source]: Remove dead URL.
>   [inputs]: Remove bc.  Replace python-wrapper with python.
>   [arguments]: Remove configure-flags.  Enable fish to source
>   /etc/fish/config.fish.  Enable completions, functions and configurations
>   in user's and system's guix profiles.

[...]

>>From da8487fe9b9a0a0308f7b929f9e95e8e8297de26 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng <at> gmail.com>
> Date: Sun, 20 Jan 2019 21:41:21 +0800
> Subject: [PATCH 2/3] gnu: Add fish-foreign-env.
>
> * gnu/packages/shells.scm (fish-foreign-env): New variable.

[...]

>>From aadeb9dea8aff0db8a339cc11d006abff4736fdb Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng <at> gmail.com>
> Date: Sun, 20 Jan 2019 21:42:15 +0800
> Subject: [PATCH 3/3] gnu: fish: Use fish-foreign-env to source /etc/profile.
>
> * gnu/packages/shells.scm (fish): Use fish-foreign-env to source /etc/profile
>   when user logs in.

Applied all three patches.  Thanks for working on it!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#34153; Package guix-patches. (Tue, 29 Jan 2019 00:46:01 GMT) Full text and rfc822 format available.

Message #13 received at 34153 <at> debbugs.gnu.org (full text, mbox):

From: Meiyo Peng <meiyo <at> disroot.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 34153 <at> debbugs.gnu.org
Subject: Re: [bug#34153] [PATCH] Update fish to 3.0.0.
Date: Tue, 29 Jan 2019 08:45:38 +0800
Hi Ludovic,

Ludovic Courtès writes:

>> This patch series updates fish shell to 3.0.0 and enable fish to source
>> /etc/profile using fish-foreign-env.
>
> I don’t use Fish so I don’t really have an opinion but it looks
> reasonable to me.  If it breaks, users will yell at you anyway.  ;-)

Yells are welcome. ;-)


--
Meiyo Peng
https://www.pengmeiyu.com/




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 26 Feb 2019 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 32 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.