GNU bug report logs - #34170
bitcoin-core bundles leveldb

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix; Reported by: Danny Milosavljevic <dannym@HIDDEN>; dated Tue, 22 Jan 2019 21:57:01 UTC; Maintainer for guix is bug-guix@HIDDEN.

Message received at 34170 <at> debbugs.gnu.org:


Received: (at 34170) by debbugs.gnu.org; 13 Jul 2022 15:10:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 13 11:10:51 2022
Received: from localhost ([127.0.0.1]:47536 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oBe0p-0002df-FO
	for submit <at> debbugs.gnu.org; Wed, 13 Jul 2022 11:10:51 -0400
Received: from mail-qv1-f51.google.com ([209.85.219.51]:39534)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1oBe0n-0002dR-NB
 for 34170 <at> debbugs.gnu.org; Wed, 13 Jul 2022 11:10:50 -0400
Received: by mail-qv1-f51.google.com with SMTP id nd6so5022608qvb.6
 for <34170 <at> debbugs.gnu.org>; Wed, 13 Jul 2022 08:10:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=+k3hU54AjQRD6zUtPGIPe/7xtRgbQJOf8+1Bp/cpy6w=;
 b=Fw8AIAXHj5aGQBbxKFlG97YwTS5rRN3yMYnsoryXeDoPEs5ChSDZFoPidP1u3a3Wio
 ZrzdS+mv/1WLkAytnwX0BFCp2vdzpGi906Vbx0BhczcRJr66FSSSU1ziGiyVJGCPjzqL
 /AekgRG2IdMmMHTc5pLLNa4FYz9mVvEOj/DMiJso7WShjN/nAdU+t7MinU+MHpplDe1s
 0YKfeAa5QQGf+zS9TqJFCXVviyZ1iOcJDIPVTcy/TbsYTXZkHXPn5mdS2aAKCqIPxKgq
 pUf1sl9ncy57X8zzTw8ql5E9voYM5kl/A5t7syHdoLF9URD6JuVQKl5LqjomHE52LhL/
 rV9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=+k3hU54AjQRD6zUtPGIPe/7xtRgbQJOf8+1Bp/cpy6w=;
 b=8JqMX0ap3AQARs0Q69D1hGVPSrH+N/M3MvFitVoUGqKxh5Xxjkw4dnWHKMtSdv83fr
 C4xWLYTQD9F3RYynWuw01kUqzUzMQjpOve8I/h1sWaFg29SjTpwuvaMt/+cMzQHvkL3D
 lap9HjhUHx6jUyeIeLn69Wlsua6R95bvz7u7JRRwvPcio8VwJoL3J79D9oEz2JKDybhd
 z4wmP09vjD5lERkF1Yzge7A35PX1rKCv2xB00pOBVTp9GiNHiQ6yuZD696xA9Evt/ueQ
 Br/omGrPuQBv4GozOfAsJ8xDbkOK+2boxF5CC0QtOqa25zJ1gjh//jQslkoupIWK7mF0
 i36Q==
X-Gm-Message-State: AJIora93lFfIK+vtTShRj7Wi7kJenwlwoM0McL583sis4FSxKczdkcOX
 K/udTmn5tUbi4aYsS8KUK98=
X-Google-Smtp-Source: AGRyM1vz3MRTTw0+sWIM1AiavmCy3PG6AgziftZROr7Nh7YlGUK5XkPuBv7Yj2MmNDRoUYdh0+rAZA==
X-Received: by 2002:a05:6214:2b0d:b0:473:80c9:c0b6 with SMTP id
 jx13-20020a0562142b0d00b0047380c9c0b6mr3478318qvb.82.1657725043580; 
 Wed, 13 Jul 2022 08:10:43 -0700 (PDT)
Received: from hurd (dsl-10-133-49.b2b2c.ca. [72.10.133.49])
 by smtp.gmail.com with ESMTPSA id
 u13-20020a05620a0c4d00b006a6ebde4799sm11998813qki.90.2022.07.13.08.10.42
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 13 Jul 2022 08:10:43 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Carl Dong <contact@HIDDEN>
Subject: Re: bug#34170: bitcoin-core bundles leveldb
References: <20190122133124.7ca032d7@HIDDEN>
 <865ys6m168.fsf@HIDDEN>
 <df96d7bdccb0a6a4ae1b7aa9da8c8d30f97360c3.camel@HIDDEN>
 <86lezu8qj4.fsf@HIDDEN>
 <26B84833-6F9F-4C5D-8448-715C67C16768@HIDDEN>
 <563546ec57ff4726bf4138c16be6304c869119ce.camel@HIDDEN>
 <70A07344-0DA9-4A8E-B3B0-FAE1721FE2D2@HIDDEN>
Date: Wed, 13 Jul 2022 11:10:42 -0400
In-Reply-To: <70A07344-0DA9-4A8E-B3B0-FAE1721FE2D2@HIDDEN> (Carl Dong's
 message of "Thu, 6 Jan 2022 19:17:13 -0500")
Message-ID: <87k08hyrnx.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 34170
Cc: 34170 <at> debbugs.gnu.org, Danny Milosavljevic <dannym@HIDDEN>,
 Maxime Devos <maximedevos@HIDDEN>, zimoun <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Carl,

Carl Dong <contact@HIDDEN> writes:

>> If desired, it would also be possible to do something in-between
>> unbundling and using bitcoin's leveldb: define a 'leveldb/bitcoin'
>> variant of the 'leveldb' package (using package/inherit or (package
>> (inherit ...) ...)), add it as input to the 'bitcoin' package and tell
>> and/or patch bitcoin's buid scripts to use that leveldb.
> Yes I think that would be a splendid idea! With regards to patching
> bitcoin=E2=80=99s builds scripts, Bitcoin Knots follows Bitcoin Core clos=
ely,
> but has a bunch of patches which allow for using system libs, so that
> might be good to reference:
> https://github.com/bitcoin/bitcoin/compare/master...bitcoinknots:21.x-sys=
libs
> <https://github.com/bitcoin/bitcoin/compare/master...bitcoinknots:21.x-sy=
slibs>
>
>> As source code, use an appropriate commit from
>> <https://github.com/bitcoin-core/leveldb-subtree> (and add a comment
>> to the definition of bitcoin-core to keep leveldb/bitcoin in-sync).
>
> FYI, according to https://github.com/bitcoin/bitcoin/pull/17398
> <https://github.com/bitcoin/bitcoin/pull/17398>, we are currently
> using the upstream LevelDB commit
> 0c40829872a9f00f38e11dc370ff8adb3e19f25b

Would you like to give the idea discussed above a try and send a patch?
That'd bring closure to this old issue :-).

Thanks,

Maxim




Information forwarded to bug-guix@HIDDEN:
bug#34170; Package guix. Full text available.

Message received at 34170 <at> debbugs.gnu.org:


Received: (at 34170) by debbugs.gnu.org; 7 Jan 2022 00:17:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 06 19:17:31 2022
Received: from localhost ([127.0.0.1]:42673 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1n5cwk-0002qs-GQ
	for submit <at> debbugs.gnu.org; Thu, 06 Jan 2022 19:17:31 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35765)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <contact@HIDDEN>) id 1n5cwh-0002qQ-HZ
 for 34170 <at> debbugs.gnu.org; Thu, 06 Jan 2022 19:17:28 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B51EC5C0138;
 Thu,  6 Jan 2022 19:17:21 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 06 Jan 2022 19:17:21 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; h=
 from:message-id:content-type:mime-version:subject:date
 :in-reply-to:cc:to:references; s=fm2; bh=qSVtEvNdenrW1qZuGUit6lF
 e0N4Itk7WdBXLmIvK+JM=; b=kj/ThT5HNrmgHHEm+j77yhBK1/ansZBZBuJrQdt
 NLxRSUzAxzrRzZ/Gh+yc3Tit31OYVU4KuTuUWDqkBb+01JrOBKv5zCr9z5t4m7LT
 kpc8YUQZZlFw1GiAA2toJeV4juJhmHYznX1LpY7l/q3WLv8acGS5MVmReVyuh2OV
 rxdurpLSz6lJCMTmykb52klhvhMnnxWZIzCsSB+b5QZSav8A7OIuXEDtX5c70+jD
 b9kUc5wN265eUMv9UyJ8L7RJ7m7xpT++LPvZA8M57v4mWrskVaRXi0TbC900DKra
 M3HmNTdB33B6JXqGFkaV5VH1iBwv0T7741rkgBoivJdemdg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=qSVtEv
 NdenrW1qZuGUit6lFe0N4Itk7WdBXLmIvK+JM=; b=KBWnk56uWEosaIVAVULv2r
 86i2O7KBnEVvDiOVLRey28ifdfqk7oxHc4axnYkrA9zo639C3lV6x2It8ryD8riQ
 stshbfJ8lrl567537sPrYMTw0kuqpDgHroPYoU1hVbqTY1ypoWM0YHYIHmpZ6L9C
 NmYt2IBQQICh0GyWpH1JK5zBOw2b4UIp3zWX2DEhNeHjKlhaynSy0F0vqaYDXDxx
 v4wlpCM0sseyF5usa5XKCbEEtTvtLhyx7EXhMQryudQrj8mtT+WhdyDRdpwNYnV/
 ypaHUdANxtTZT5f3z2HLn8hf8zTAJzCKxfOQ+3j07tnRba9M5/q3TYN6A9sYzazw
 ==
X-ME-Sender: <xms:kYbXYdj1P0WZWK6wL4f3g37YCjIZBTbomc0_TG8d6iKLIFN6JxTSVQ>
 <xme:kYbXYSDZMS5RwCjZ-PNdeZDVT4VbSDLK5udWVddm2Hyi0AvY9dJIy0d-N_pT68iwe
 Hs4jUiObxriiroP6w>
X-ME-Received: <xmr:kYbXYdGKLFW8eJXCYeMaa8uQgAQMegyTM5R4ZRAesPBikgzWUAg-ReaExt0z-jfidFT8Yg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudegtddgudejucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffktgggufffjgfvfhfosehgtdhmrehhtdejnecuhfhrohhmpeevrghrlhcu
 ffhonhhguceotghonhhtrggtthestggrrhhlughonhhgrdhmvgeqnecuggftrfgrthhtvg
 hrnhepudduhfefgeeuleelueehgfekjeejjefgvdetleffueegleeifeejffelfeffveeh
 necuffhomhgrihhnpehgihhthhhusgdrtghomhdpuggvsghirghnrdhorhhgpdgsihhtmh
 gvgidrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr
 ohhmpegtohhnthgrtghtsegtrghrlhguohhnghdrmhgv
X-ME-Proxy: <xmx:kYbXYSRNPsRDex2FpTRhqmw7r7tQFpAi2Ghir53H6Vjr68gjKRrdTg>
 <xmx:kYbXYaz0SBn2hel7CXrqnHwNmAyxWQ2Lrl2fCOuM1LqbUKiZGD5NHQ>
 <xmx:kYbXYY5RWYd15JeFOdb7sbRHkNYz7ZgwQqg82eUOEdH9-lor0Fm5Tw>
 <xmx:kYbXYV9rBYBSFerABfN5LpV0piE5a3Dw4gIVujTl3ErhKD_TQ67jUg>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 6 Jan 2022 19:17:21 -0500 (EST)
From: Carl Dong <contact@HIDDEN>
Message-Id: <70A07344-0DA9-4A8E-B3B0-FAE1721FE2D2@HIDDEN>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_6138C549-0547-443F-A5D5-DA86153C4A4E";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\))
Subject: Re: bug#34170: bitcoin-core bundles leveldb
Date: Thu, 6 Jan 2022 19:17:13 -0500
In-Reply-To: <563546ec57ff4726bf4138c16be6304c869119ce.camel@HIDDEN>
To: Maxime Devos <maximedevos@HIDDEN>
References: <20190122133124.7ca032d7@HIDDEN>
 <865ys6m168.fsf@HIDDEN>
 <df96d7bdccb0a6a4ae1b7aa9da8c8d30f97360c3.camel@HIDDEN>
 <86lezu8qj4.fsf@HIDDEN> <26B84833-6F9F-4C5D-8448-715C67C16768@HIDDEN>
 <563546ec57ff4726bf4138c16be6304c869119ce.camel@HIDDEN>
X-Mailer: Apple Mail (2.3693.40.0.1.81)
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 34170
Cc: 34170 <at> debbugs.gnu.org, Danny Milosavljevic <dannym@HIDDEN>,
 zimoun <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--Apple-Mail=_6138C549-0547-443F-A5D5-DA86153C4A4E
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_197A65E3-A5A8-4610-B7FB-FE262E4037E8"


--Apple-Mail=_197A65E3-A5A8-4610-B7FB-FE262E4037E8
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> If desired, it would also be possible to do something in-between
> unbundling and using bitcoin's leveldb: define a 'leveldb/bitcoin'
> variant of the 'leveldb' package (using package/inherit or (package
> (inherit ...) ...)), add it as input to the 'bitcoin' package and tell
> and/or patch bitcoin's buid scripts to use that leveldb.
Yes I think that would be a splendid idea! With regards to patching =
bitcoin=E2=80=99s builds scripts, Bitcoin Knots follows Bitcoin Core =
closely, but has a bunch of patches which allow for using system libs, =
so that might be good to reference: =
https://github.com/bitcoin/bitcoin/compare/master...bitcoinknots:21.x-sysl=
ibs =
<https://github.com/bitcoin/bitcoin/compare/master...bitcoinknots:21.x-sys=
libs>

> As source code, use an appropriate commit from
> <https://github.com/bitcoin-core/leveldb-subtree> (and add a comment
> to the definition of bitcoin-core to keep leveldb/bitcoin in-sync).

FYI, according to https://github.com/bitcoin/bitcoin/pull/17398 =
<https://github.com/bitcoin/bitcoin/pull/17398>, we are currently using =
the upstream LevelDB commit 0c40829872a9f00f38e11dc370ff8adb3e19f25b

Cheers,
Carl Dong


> On Jan 5, 2022, at 2:13 PM, Maxime Devos <maximedevos@HIDDEN> =
wrote:
>=20
> Hi,
>=20
> Carl Dong schreef op wo 05-01-2022 om 12:40 [-0500]:
>> Simon, Maxime, Danny,
>>=20
>> Thanks for CCing me on this message! The rationale for bundling
>> leveldb in Bitcoin Core goes a bit beyond convenience, it is several
>> things:
>>=20
>> 1. The original reason for sub-treeing is that Bitcoin Core used to
>> maintain its own version of leveldb with its own fixes
>> here: https://github.com/bitcoin-core/leveldb-subtree, since then
>> most of these fixes have been upstreamed as
>> of: https://github.com/bitcoin/bitcoin/pull/17398
>=20
> Seems reasonable to me, but the bitcoin project is upstreaming the
> changes it made and most are already upstream, so I would prefer
> to use upstream's leveldb.
>=20
>> 2. We also used to support using an external leveldb, however, it
>> seems that it was fragile to rely on external projects to maintain
>> ABI compatibility, see the quoted IRC bug report
>> here: https://github.com/bitcoin/bitcoin/pull/23282. Reasonable minds
>> may disagree on this point, especially coming from Guix where
>> patching is convenient.
>=20
> The quoted ABI incompatibility
>=20
>    <Talkless> bitcoind fails to start with undefined symbol:
> _ZTIN7leveldb6LoggerE in Debian Sid after leveldb upgraded from 1.22 =
to
> 1.23: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D996486
>=20
> doesn't apply in Guix, because guix uses RUNPATH and multiple library
> versions can exist in the same store (in different directories in the
> store).
>=20
>> In addition to the above, Bitcoin Core experienced a hard fork in
>> 2013 due to database incompatibilities, which has predisposed
>> maintainers towards a more stringent approach with pinning
>> dependencies and their configure/build-time flags.
>> See: https://blog.bitmex.com/bitcoins-consensus-forks/#was-the-2013-
>> incident-a-hardfork
>=20
> I doubt that Guix has sufficient Bitcoin Core users to cause
> a hard fork, but yes, this is an understandable reason to bundle
> things.  But any such problem seems easy to resolve (at the guix =
side):
> we could simply temporarily switch to an older version of leveldb.
>=20
> If desired, it would also be possible to do something in-between
> unbundling and using bitcoin's leveldb: define a 'leveldb/bitcoin'
> variant of the 'leveldb' package (using package/inherit or (package
> (inherit ...) ...)), add it as input to the 'bitcoin' package and tell
> and/or patch bitcoin's buid scripts to use that leveldb.
>=20
> As source code, use an appropriate commit from
> <https://github.com/bitcoin-core/leveldb-subtree> (and add a comment
> to the definition of bitcoin-core to keep leveldb/bitcoin in-sync).
>=20
> A benefit of this approach (if done properly, with (origin (inherit
> ...) ...) such that patches of 'leveldb' are inherited) above the
> status quo, is that is that if for some reason 'leveldb' is patched in
> Guix, then 'leveldb/bitcoin' receives the patch as well. Another
> benefit is that the dependency 'googletest' and 'benchmark' of leveldb
> would remain unbundled.
>=20
> Greetings,
> Maxime.
>=20


--Apple-Mail=_197A65E3-A5A8-4610-B7FB-FE262E4037E8
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;" =
class=3D""><blockquote type=3D"cite" class=3D""><div =
class=3D"content-isolator__container">If desired, it would also be =
possible to do something in-between<br class=3D"">unbundling and using =
bitcoin's leveldb: define a 'leveldb/bitcoin'<br class=3D"">variant of =
the 'leveldb' package (using package/inherit or (package<br =
class=3D"">(inherit ...) ...)), add it as input to the 'bitcoin' package =
and tell<br class=3D"">and/or patch bitcoin's buid scripts to use =
that&nbsp;leveldb.</div></blockquote>Yes I think that would be a =
splendid idea! With regards to patching bitcoin=E2=80=99s builds =
scripts, Bitcoin Knots follows Bitcoin Core closely, but has a bunch of =
patches which allow for using system libs, so that might be good to =
reference:&nbsp;<a =
href=3D"https://github.com/bitcoin/bitcoin/compare/master...bitcoinknots:2=
1.x-syslibs" =
class=3D"">https://github.com/bitcoin/bitcoin/compare/master...bitcoinknot=
s:21.x-syslibs</a><div class=3D""><div class=3D""><br =
class=3D""></div><div class=3D""><blockquote type=3D"cite" class=3D""><div=
 class=3D"content-isolator__container">As source code, use an =
appropriate commit from<br class=3D"">&lt;<a =
href=3D"https://github.com/bitcoin-core/leveldb-subtree" =
class=3D"">https://github.com/bitcoin-core/leveldb-subtree</a>&gt; (and =
add a comment<br class=3D"">to the definition of bitcoin-core to keep =
leveldb/bitcoin in-sync).</div></blockquote></div><div class=3D"">FYI, =
according to&nbsp;<a =
href=3D"https://github.com/bitcoin/bitcoin/pull/17398" =
class=3D"">https://github.com/bitcoin/bitcoin/pull/17398</a>, we are =
currently using the upstream LevelDB commit&nbsp;<span =
class=3D"sha-block">0c40829872a9f00f38e11dc370ff8adb3e19f25b</span><div =
class=3D""><br class=3D""></div><div class=3D"">Cheers,</div><div =
class=3D"">Carl Dong</div><div class=3D""><br class=3D""><div><br =
class=3D""><blockquote type=3D"cite" class=3D""><div class=3D"">On Jan =
5, 2022, at 2:13 PM, Maxime Devos &lt;<a =
href=3D"mailto:maximedevos@HIDDEN" =
class=3D"">maximedevos@HIDDEN</a>&gt; wrote:</div><br =
class=3D"Apple-interchange-newline"><div class=3D""><div class=3D""><div =
class=3D"content-isolator__container">Hi,<br class=3D""><br =
class=3D"">Carl Dong schreef op wo 05-01-2022 om 12:40 [-0500]:<br =
class=3D""><blockquote type=3D"cite" class=3D"">Simon, Maxime, Danny,<br =
class=3D""><br class=3D"">Thanks for CCing me on this message! The =
rationale for bundling<br class=3D"">leveldb in Bitcoin Core goes a bit =
beyond convenience, it is several<br class=3D"">things:<br class=3D""><br =
class=3D"">1. The original reason for sub-treeing is that Bitcoin Core =
used to<br class=3D"">maintain its own version of leveldb with its own =
fixes<br class=3D"">here:&nbsp;<a =
href=3D"https://github.com/bitcoin-core/leveldb-subtree" =
class=3D"">https://github.com/bitcoin-core/leveldb-subtree</a>, since =
then<br class=3D"">most of these fixes have been upstreamed as<br =
class=3D"">of:&nbsp;<a =
href=3D"https://github.com/bitcoin/bitcoin/pull/17398" =
class=3D"">https://github.com/bitcoin/bitcoin/pull/17398</a><br =
class=3D""></blockquote><br class=3D"">Seems reasonable to me, but the =
bitcoin project is upstreaming the<br class=3D"">changes it made and =
most are already upstream, so I would prefer<br class=3D"">to use =
upstream's leveldb.<br class=3D""><br class=3D""><blockquote type=3D"cite"=
 class=3D"">2. We also used to support using an external leveldb, =
however, it<br class=3D"">seems that it was fragile to rely on external =
projects to maintain<br class=3D"">ABI compatibility, see the quoted IRC =
bug report<br class=3D"">here:&nbsp;<a =
href=3D"https://github.com/bitcoin/bitcoin/pull/23282" =
class=3D"">https://github.com/bitcoin/bitcoin/pull/23282</a>. Reasonable =
minds<br class=3D"">may disagree on this point, especially coming from =
Guix where<br class=3D"">patching is convenient.<br =
class=3D""></blockquote><br class=3D"">The quoted ABI incompatibility<br =
class=3D""><br class=3D""> &nbsp;&nbsp;&nbsp;&lt;Talkless&gt; bitcoind =
fails to start with undefined symbol:<br class=3D"">_ZTIN7leveldb6LoggerE =
in Debian Sid after leveldb upgraded from 1.22 to<br class=3D"">1.23: <a =
href=3D"https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D996486" =
class=3D"">https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D996486</a><=
br class=3D""><br class=3D"">doesn't apply in Guix, because guix uses =
RUNPATH and multiple library<br class=3D"">versions can exist in the =
same store (in different directories in the<br class=3D"">store).<br =
class=3D""><br class=3D""><blockquote type=3D"cite" class=3D"">In =
addition to the above, Bitcoin Core experienced a hard fork in<br =
class=3D"">2013 due to database incompatibilities, which has =
predisposed<br class=3D"">maintainers towards a more stringent approach =
with pinning<br class=3D"">dependencies and their configure/build-time =
flags.<br class=3D"">See:&nbsp;<a =
href=3D"https://blog.bitmex.com/bitcoins-consensus-forks/#was-the-2013-" =
class=3D"">https://blog.bitmex.com/bitcoins-consensus-forks/#was-the-2013-=
</a><br class=3D"">incident-a-hardfork<br class=3D""></blockquote><br =
class=3D"">I doubt that Guix has sufficient Bitcoin Core users to =
cause<br class=3D"">a hard fork, but yes, this is an understandable =
reason to bundle<br class=3D"">things. &nbsp;But any such problem seems =
easy to resolve (at the guix side):<br class=3D"">we could simply =
temporarily switch to an older version of leveldb.<br class=3D""><br =
class=3D"">If desired, it would also be possible to do something =
in-between<br class=3D"">unbundling and using bitcoin's leveldb: define =
a 'leveldb/bitcoin'<br class=3D"">variant of the 'leveldb' package =
(using package/inherit or (package<br class=3D"">(inherit ...) ...)), =
add it as input to the 'bitcoin' package and tell<br class=3D"">and/or =
patch bitcoin's buid scripts to use that&nbsp;leveldb.<br class=3D""><br =
class=3D"">As source code, use an appropriate commit from<br =
class=3D"">&lt;<a href=3D"https://github.com/bitcoin-core/leveldb-subtree"=
 class=3D"">https://github.com/bitcoin-core/leveldb-subtree</a>&gt; (and =
add a comment<br class=3D"">to the definition of bitcoin-core to keep =
leveldb/bitcoin in-sync).<br class=3D""><br class=3D"">A benefit of this =
approach (if done properly, with (origin (inherit<br class=3D"">...) =
...)&nbsp;such that patches of 'leveldb' are inherited) above the<br =
class=3D"">status quo, is that is that if for some reason 'leveldb' is =
patched in<br class=3D"">Guix, then 'leveldb/bitcoin' receives the patch =
as well. Another<br class=3D"">benefit is that the dependency =
'googletest' and 'benchmark' of leveldb<br class=3D"">would remain =
unbundled.<br class=3D""><br class=3D"">Greetings,<br =
class=3D"">Maxime.<br class=3D""><br =
class=3D""></div></div></div></blockquote></div><br =
class=3D""></div></div></div></body></html>=

--Apple-Mail=_197A65E3-A5A8-4610-B7FB-FE262E4037E8--

--Apple-Mail=_6138C549-0547-443F-A5D5-DA86153C4A4E
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEECc3SW1JEo3Z49u6oDMUhUxl5kaUFAmHXhokACgkQDMUhUxl5
kaXf6Q/+Ia5jCiSY7hC0o1wR1B+ZfxMtxEPTrGk93P+7HOASskMZEcKDNFkoKbSK
s/BZT22vfjo6yLle+JWRDXaR+9lhvyGtjQ1aiSCrRMtCPX8k1sBIiVFxYA/E0A4t
WUVN1aS4B2h9wc5olT4vVWwwmjZpUBCpdiCXeSMLDhB6w85HHFxVAmmrPUaghxYb
obvu24Pajrgvi8CndUJjPBUV0iWq0b6g/Ri6DiB9rUKbNghZp6S4twoKR3VqKbrd
6C/zeKWBBNrTPmrQMb13PezPTU3gK76tZ2r472W+ZRGWqLM5BTPmkJcV8UA8Ac57
yZkKkfYn5EDX8KU/2mssODwaLpURZfcTZEHsEbWzHje8+6uXbSRehnwXIbRdwvs7
P/doZTa5H9oau+IS07d6j7Z+/Oe5A801YPbuzzVxDSwAhcHZqI471WrcI6TbFixL
TEdQTRqU8w0EjlD9LVJC2t+W7B3rNuWfeMRuS48yFkf7g2YtKInF2oK0hvR5LAem
akbO4Fh1GGeIZ7cpLqq4V9HL3IodiZEUTBMBuF8P+x61DsW99mf/yjzUBW+RSS2j
ABsKPYr37Bz+4I9OslPsEE9yRLclc1HTF3FuCZuQl1qEUWHOkJP/aeCZW/sdgMxi
yp4GaPXdWeKacosCN/4xehlOkZyIeCya3PlIm9TnYQ0o48p5Hps=
=vXwb
-----END PGP SIGNATURE-----

--Apple-Mail=_6138C549-0547-443F-A5D5-DA86153C4A4E--




Information forwarded to bug-guix@HIDDEN:
bug#34170; Package guix. Full text available.

Message received at 34170 <at> debbugs.gnu.org:


Received: (at 34170) by debbugs.gnu.org; 5 Jan 2022 19:14:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 05 14:14:15 2022
Received: from localhost ([127.0.0.1]:41877 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1n5Bjj-000355-Hx
	for submit <at> debbugs.gnu.org; Wed, 05 Jan 2022 14:14:15 -0500
Received: from michel.telenet-ops.be ([195.130.137.88]:59032)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1n5Bjh-00034v-7j
 for 34170 <at> debbugs.gnu.org; Wed, 05 Jan 2022 14:14:14 -0500
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by michel.telenet-ops.be with bizsmtp
 id f7E92600K4UW6Th067EADp; Wed, 05 Jan 2022 20:14:10 +0100
Message-ID: <563546ec57ff4726bf4138c16be6304c869119ce.camel@HIDDEN>
Subject: Re: bug#34170: bitcoin-core bundles leveldb
From: Maxime Devos <maximedevos@HIDDEN>
To: Carl Dong <contact@HIDDEN>, zimoun <zimon.toutoune@HIDDEN>
Date: Wed, 05 Jan 2022 19:13:57 +0000
In-Reply-To: <26B84833-6F9F-4C5D-8448-715C67C16768@HIDDEN>
References: <20190122133124.7ca032d7@HIDDEN>
 <865ys6m168.fsf@HIDDEN>
 <df96d7bdccb0a6a4ae1b7aa9da8c8d30f97360c3.camel@HIDDEN>
 <86lezu8qj4.fsf@HIDDEN>
 <26B84833-6F9F-4C5D-8448-715C67C16768@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-zkNV0HsANboj3EbQlwrb"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1641410050; bh=BgIkWpnkrdzXu+40o8jGCCxWOpta/z48x4D+b8Dq82I=;
 h=Subject:From:To:Cc:Date:In-Reply-To:References;
 b=GzhDKgNQ5H9IQjrrQJ7CgoJHl3F7befDyEGHd+E5+W1V+Gs/r4aDUPo+aOfIR8VOH
 r6QIjf8i6Hr+IadJS1O02pGgqqSjDryMfB6EXe/c6FIqRt68ra7shGSyfocggMAaJq
 JAzKHpbcLOkcdd5i3vQZD2aKVr+EyIG0GVNM1xdq3jBUVd8aO53rZ4jyhsSCfyMYNJ
 hWbZRWKAXbvnWC5ecFooDsrW7SufNe74aFoytxyCjPpOX81OnShiCC2zCPphJl/OG7
 hdZQRpnqV0UyNgETwFRvqbQWO5aDFDPOUD8uId3UZWI6EmbqyqV7gW6Js9JEt9aAzi
 rBzJyiOfNVnqw==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 34170
Cc: 34170 <at> debbugs.gnu.org, Danny Milosavljevic <dannym@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--=-zkNV0HsANboj3EbQlwrb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Carl Dong schreef op wo 05-01-2022 om 12:40 [-0500]:
> Simon, Maxime, Danny,
>=20
> Thanks for CCing me on this message! The rationale for bundling
> leveldb in Bitcoin Core goes a bit beyond convenience, it is several
> things:
>=20
> 1. The original reason for sub-treeing is that Bitcoin Core used to
> maintain its own version of leveldb with its own fixes
> here:=C2=A0https://github.com/bitcoin-core/leveldb-subtree, since then
> most of these fixes have been upstreamed as
> of:=C2=A0https://github.com/bitcoin/bitcoin/pull/17398

Seems reasonable to me, but the bitcoin project is upstreaming the
changes it made and most are already upstream, so I would prefer
to use upstream's leveldb.

> 2. We also used to support using an external leveldb, however, it
> seems that it was fragile to rely on external projects to maintain
> ABI compatibility, see the quoted IRC bug report
> here:=C2=A0https://github.com/bitcoin/bitcoin/pull/23282. Reasonable mind=
s
> may disagree on this point, especially coming from Guix where
> patching is convenient.

The quoted ABI incompatibility

    <Talkless> bitcoind fails to start with undefined symbol:
_ZTIN7leveldb6LoggerE in Debian Sid after leveldb upgraded from 1.22 to
1.23: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D996486

doesn't apply in Guix, because guix uses RUNPATH and multiple library
versions can exist in the same store (in different directories in the
store).

> In addition to the above, Bitcoin Core experienced a hard fork in
> 2013 due to database incompatibilities, which has predisposed
> maintainers towards a more stringent approach with pinning
> dependencies and their configure/build-time flags.
> See:=C2=A0https://blog.bitmex.com/bitcoins-consensus-forks/#was-the-2013-
> incident-a-hardfork

I doubt that Guix has sufficient Bitcoin Core users to cause
a hard fork, but yes, this is an understandable reason to bundle
things.  But any such problem seems easy to resolve (at the guix side):
we could simply temporarily switch to an older version of leveldb.

If desired, it would also be possible to do something in-between
unbundling and using bitcoin's leveldb: define a 'leveldb/bitcoin'
variant of the 'leveldb' package (using package/inherit or (package
(inherit ...) ...)), add it as input to the 'bitcoin' package and tell
and/or patch bitcoin's buid scripts to use that=C2=A0leveldb.

As source code, use an appropriate commit from
<https://github.com/bitcoin-core/leveldb-subtree> (and add a comment
to the definition of bitcoin-core to keep leveldb/bitcoin in-sync).

A benefit of this approach (if done properly, with (origin (inherit
...) ...)=C2=A0such that patches of 'leveldb' are inherited) above the
status quo, is that is that if for some reason 'leveldb' is patched in
Guix, then 'leveldb/bitcoin' receives the patch as well. Another
benefit is that the dependency 'googletest' and 'benchmark' of leveldb
would remain unbundled.

Greetings,
Maxime.


--=-zkNV0HsANboj3EbQlwrb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYdXt9RccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hu6AQDW+ScMM2tEpvFe43jOShlsOqpP
dx6ANkesoO7UUd9PZwD/VNJ4E+LxegBqgypK8t/JFixNJ1YAfCgdb9wkC2XezgU=
=mfVJ
-----END PGP SIGNATURE-----

--=-zkNV0HsANboj3EbQlwrb--





Information forwarded to bug-guix@HIDDEN:
bug#34170; Package guix. Full text available.

Message received at 34170 <at> debbugs.gnu.org:


Received: (at 34170) by debbugs.gnu.org; 5 Jan 2022 17:40:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 05 12:40:55 2022
Received: from localhost ([127.0.0.1]:41680 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1n5AHP-0006mX-IO
	for submit <at> debbugs.gnu.org; Wed, 05 Jan 2022 12:40:55 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53927)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <contact@HIDDEN>) id 1n5AHO-0006m7-Ir
 for 34170 <at> debbugs.gnu.org; Wed, 05 Jan 2022 12:40:55 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 1F5D25C0153;
 Wed,  5 Jan 2022 12:40:49 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 05 Jan 2022 12:40:49 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; h=
 from:message-id:content-type:mime-version:subject:date
 :in-reply-to:cc:to:references; s=fm2; bh=JRleEb/mGdchHT3MIE0cNXP
 I+f17nvaT0mACCWklTz4=; b=OblnjhT1X6FK8Md745fXP7jrPTwcNaGvrsdyN7e
 srxJ4VSbJiUqPDvffSKY9qZPyzMcTmbcq4NZzGLLALY6WSz2tchCvqPsE62s+AOY
 8sgyHmhYI0DVhXpm+Rr6guA6lVJ+bmmQ0BhaFRbXo9LwiLavXOALoMR9rWyfxcAN
 QP/smcQUuzIYaTyRF4sfwLwnjvEDmdtI3gpOBANqoWsNMB/j4TtCprg930SbrETc
 Ohi5Eb3C+x/MlomGBYuSrrVh7mKZfuYmq8AhEbB2HSvjDuSYMXIRCQIX3xI0LsCv
 B0FfO7+KWTmiw/I1WcAvLfsb7pJ65BmNnUxvIpwBGPv+/CA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=JRleEb
 /mGdchHT3MIE0cNXPI+f17nvaT0mACCWklTz4=; b=LGq2HQZko6shRVcdpB/iBk
 aq2rPrC/LuS57O50gfg2RkC+5WakWLr0P3KRRk+XLWPkuBObZ10wzLExR5cYfnZI
 ACXYqpJMJVGzmW7xheV4UlnAQcAuaFIBAZTH634ZynDLY3o+y130PPVmR+j+Dv9G
 z7k8K2/AyfaTHv3KyPiWLoxACU7UTLZ/AUra/RkteisZ1jRuOk53fgfkObM3kDwf
 X8CP+V9WxjNFUm2vb0KbiO0VNt4WowlUn4Cbw3Rlzhh30m6d6HvOLeZUDR14djE7
 3F88jgVM45+hcMS7G8d3GDei6uxiYqhiYrxV580dYxZfk1rtyz6OTcW6q/vCP6Xg
 ==
X-ME-Sender: <xms:INjVYQNM0peZfxPIR67QDdg9SzJHOP-LGjo8E6rIhH-yXJl5eOHANA>
 <xme:INjVYW8rj4nIarulXS5qpLxGrY7FtD_3PWne_K3j-0i_HFS6BDaiQJi8kI4gOiT-W
 czkyPn8VjAaLeHN0g>
X-ME-Received: <xmr:INjVYXSQr3Z9ASDESfaVlE0h2krc0TTefQQWhkOfpwz93rAwEPXScce-yZJPtqIZTBkLEQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudefjedgudekucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffktgggufffjgfvfhfosegrtdhmrehhtdejnecuhfhrohhmpeevrghrlhcu
 ffhonhhguceotghonhhtrggtthestggrrhhlughonhhgrdhmvgeqnecuggftrfgrthhtvg
 hrnhepffejgfetffejfefgheeuvdffhfehffeffedtffeffedvieeiveektedtgfelffei
 necuffhomhgrihhnpehgihhthhhusgdrtghomhdpsghithhmvgigrdgtohhmnecuvehluh
 hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghonhhtrggtthes
 tggrrhhlughonhhgrdhmvg
X-ME-Proxy: <xmx:INjVYYslXEzh8Dd_HA07lHaTbhP2QqNy-bOYLAPF8_Uouc8E0b4QqQ>
 <xmx:INjVYYeiXq-GNd74f5dg5G7V23Th5eEGW5sDpetTRy1kN8X3w7lgEQ>
 <xmx:INjVYc0ZqxjwXdKGx_a310EiSgAr7wAFoGlfsfYRMHRc0cj_7itCUQ>
 <xmx:IdjVYZrZcnWP30kPHvLMNysH7VTWhCQrMNKpJlhg2DEHm5erV3WNdg>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 5 Jan 2022 12:40:48 -0500 (EST)
From: Carl Dong <contact@HIDDEN>
Message-Id: <26B84833-6F9F-4C5D-8448-715C67C16768@HIDDEN>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_EC7E2094-152E-45AD-AABD-1B9A07852BBA"
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\))
Subject: Re: bug#34170: bitcoin-core bundles leveldb
Date: Wed, 5 Jan 2022 12:40:48 -0500
In-Reply-To: <86lezu8qj4.fsf@HIDDEN>
To: zimoun <zimon.toutoune@HIDDEN>
References: <20190122133124.7ca032d7@HIDDEN>
 <865ys6m168.fsf@HIDDEN>
 <df96d7bdccb0a6a4ae1b7aa9da8c8d30f97360c3.camel@HIDDEN>
 <86lezu8qj4.fsf@HIDDEN>
X-Mailer: Apple Mail (2.3693.40.0.1.81)
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 34170
Cc: 34170 <at> debbugs.gnu.org, Danny Milosavljevic <dannym@HIDDEN>,
 Maxime Devos <maximedevos@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--Apple-Mail=_EC7E2094-152E-45AD-AABD-1B9A07852BBA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Simon, Maxime, Danny,

Thanks for CCing me on this message! The rationale for bundling leveldb =
in Bitcoin Core goes a bit beyond convenience, it is several things:

1. The original reason for sub-treeing is that Bitcoin Core used to =
maintain its own version of leveldb with its own fixes here: =
https://github.com/bitcoin-core/leveldb-subtree =
<https://github.com/bitcoin-core/leveldb-subtree>, since then most of =
these fixes have been upstreamed as of: =
https://github.com/bitcoin/bitcoin/pull/17398 =
<https://github.com/bitcoin/bitcoin/pull/17398>
2. We also used to support using an external leveldb, however, it seems =
that it was fragile to rely on external projects to maintain ABI =
compatibility, see the quoted IRC bug report here: =
https://github.com/bitcoin/bitcoin/pull/23282 =
<https://github.com/bitcoin/bitcoin/pull/23282>. Reasonable minds may =
disagree on this point, especially coming from Guix where patching is =
convenient.

In addition to the above, Bitcoin Core experienced a hard fork in 2013 =
due to database incompatibilities, which has predisposed maintainers =
towards a more stringent approach with pinning dependencies and their =
configure/build-time flags. See: =
https://blog.bitmex.com/bitcoins-consensus-forks/#was-the-2013-incident-a-=
hardfork =
<https://blog.bitmex.com/bitcoins-consensus-forks/#was-the-2013-incident-a=
-hardfork>

Let me know if I can provide more context!

Cheers,
Carl Dong

> On Jan 5, 2022, at 4:45 AM, zimoun <zimon.toutoune@HIDDEN> wrote:
>=20
> Hi Maxime,
>=20
> On Wed, 05 Jan 2022 at 10:39, Maxime Devos <maximedevos@HIDDEN> =
wrote:
>=20
>>> The package bitcore-core still provides =E2=80=99leveldb=E2=80=99:
>>>=20
>>> [...]
>>>=20
>>> and I am not sure to get what is the issue.  Some explanations?
>>=20
>> The issue is that bitcoin-core bundles leveldb (which you have shown
>> is still the case), even though leveldb is packaged in Guix.
>=20
> Thanks, I missed that =E2=80=99leveldb=E2=80=99 is packaged in Guix.  =
Indeed, it should
> preferably be used.
>=20
> So reopen. :-)
>=20
>=20
> Cheers,
> simon


--Apple-Mail=_EC7E2094-152E-45AD-AABD-1B9A07852BBA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;" =
class=3D"">Simon, Maxime, Danny,<div class=3D""><br class=3D""></div><div =
class=3D"">Thanks for CCing me on this message! The rationale for =
bundling leveldb in Bitcoin Core goes a bit beyond convenience, it is =
several things:</div><div class=3D""><br class=3D""></div><div =
class=3D"">1. The original reason for sub-treeing is that Bitcoin Core =
used to maintain its own version of leveldb with its own fixes =
here:&nbsp;<a href=3D"https://github.com/bitcoin-core/leveldb-subtree" =
class=3D"">https://github.com/bitcoin-core/leveldb-subtree</a>, since =
then most of these fixes have been upstreamed as of:&nbsp;<a =
href=3D"https://github.com/bitcoin/bitcoin/pull/17398" =
class=3D"">https://github.com/bitcoin/bitcoin/pull/17398</a></div><div =
class=3D"">2. We also used to support using an external leveldb, =
however, it seems that it was fragile to rely on external projects to =
maintain ABI compatibility, see the quoted IRC bug report here:&nbsp;<a =
href=3D"https://github.com/bitcoin/bitcoin/pull/23282" =
class=3D"">https://github.com/bitcoin/bitcoin/pull/23282</a>. Reasonable =
minds may disagree on this point, especially coming from Guix where =
patching is convenient.</div><div class=3D""><br class=3D""></div><div =
class=3D"">In addition to the above, Bitcoin Core experienced a hard =
fork in 2013 due to database incompatibilities, which has predisposed =
maintainers towards a more stringent approach with pinning dependencies =
and their configure/build-time flags. See:&nbsp;<a =
href=3D"https://blog.bitmex.com/bitcoins-consensus-forks/#was-the-2013-inc=
ident-a-hardfork" =
class=3D"">https://blog.bitmex.com/bitcoins-consensus-forks/#was-the-2013-=
incident-a-hardfork</a></div><div class=3D""><br class=3D""></div><div =
class=3D"">Let me know if I can provide more context!</div><div =
class=3D""><br class=3D""></div><div class=3D"">Cheers,</div><div =
class=3D"">Carl Dong</div><div class=3D""><div><br class=3D""><blockquote =
type=3D"cite" class=3D""><div class=3D"">On Jan 5, 2022, at 4:45 AM, =
zimoun &lt;<a href=3D"mailto:zimon.toutoune@HIDDEN" =
class=3D"">zimon.toutoune@HIDDEN</a>&gt; wrote:</div><br =
class=3D"Apple-interchange-newline"><div class=3D""><div class=3D"">Hi =
Maxime,<br class=3D""><br class=3D"">On Wed, 05 Jan 2022 at 10:39, =
Maxime Devos &lt;<a href=3D"mailto:maximedevos@HIDDEN" =
class=3D"">maximedevos@HIDDEN</a>&gt; wrote:<br class=3D""><br =
class=3D""><blockquote type=3D"cite" class=3D""><blockquote type=3D"cite" =
class=3D"">The package bitcore-core still provides =E2=80=99leveldb=E2=80=99=
:<br class=3D""><br class=3D"">[...]<br class=3D""><br class=3D"">and I =
am not sure to get what is the issue. &nbsp;Some explanations?<br =
class=3D""></blockquote><br class=3D"">The issue is that bitcoin-core =
bundles leveldb (which you have shown<br class=3D"">is still the case), =
even though leveldb is packaged in Guix.<br class=3D""></blockquote><br =
class=3D"">Thanks, I missed that =E2=80=99leveldb=E2=80=99 is packaged =
in Guix. &nbsp;Indeed, it should<br class=3D"">preferably be used.<br =
class=3D""><br class=3D"">So reopen. :-)<br class=3D""><br class=3D""><br =
class=3D"">Cheers,<br class=3D"">simon<br =
class=3D""></div></div></blockquote></div><br =
class=3D""></div></body></html>=

--Apple-Mail=_EC7E2094-152E-45AD-AABD-1B9A07852BBA--




Information forwarded to bug-guix@HIDDEN:
bug#34170; Package guix. Full text available.

Message received at 34170 <at> debbugs.gnu.org:


Received: (at 34170) by debbugs.gnu.org; 5 Jan 2022 09:55:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 05 04:55:38 2022
Received: from localhost ([127.0.0.1]:39607 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1n5318-0001vs-3O
	for submit <at> debbugs.gnu.org; Wed, 05 Jan 2022 04:55:38 -0500
Received: from mail-wr1-f46.google.com ([209.85.221.46]:46655)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1n5316-0001ve-3w
 for 34170 <at> debbugs.gnu.org; Wed, 05 Jan 2022 04:55:36 -0500
Received: by mail-wr1-f46.google.com with SMTP id i22so81778871wrb.13
 for <34170 <at> debbugs.gnu.org>; Wed, 05 Jan 2022 01:55:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=96rl6hoPWt6jhGebRM0RO7IyUG7PtKISe/E/4EyIzGA=;
 b=iGV1ZjlpJclSqnFNBm20GbmV2DLcv4mtftQbTu5Y5gTNWlb3g5tHr02pbmtzZny2Dk
 7n7W99zcfq1He+qmSRGGMBnMnIQ5Ea+4r9vL+opm26YlyxXbvzIwwMdAQpAn7NPWeqBT
 q1ViG5h0ui2BBV25M2OYVV7lRETzy0xrFJCqNGcmgKNprX5YMuHAz6xHGK+B5RBEnh6R
 vP2ppAxgPs5+24iiFXx4zXw/PETbVoQQCGajR37G911pfRQaEif1EpoVqr94zZMqAFDJ
 qZsJRqWFM7j5UV7LwEjsDdTwe1anY+JyaUaxHKOL90DgMd15VDT1VyfDvFl5Grp4Nuzy
 kkfA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=96rl6hoPWt6jhGebRM0RO7IyUG7PtKISe/E/4EyIzGA=;
 b=CVUNRsMNfLzinNHbCQePGxP9usegPMr3mLF5jw+ZLh338DKw0NPKWlUh+6QcbThuR5
 iHC5TX9yITTgrBh4zpMFSJgHWMFjaotMZZLUKV7Fh7Fpc2bjKiOSofP8UtW23PZTYTcX
 XYKdqIdli4c3FVMu2yc8pKMQMk9HVmRzxmYZnQPMLCqASYdDO6ky9ljhMApRwfS8u/Pu
 BoOSGHJHWrv5eDUyXQKjnZ+unb805adncfBHCDp4BTyDjfr9sqozyJr9NcXorRQF6yW9
 TsBtqrMPtaSRRFAKTlM5Uad56V8Bgt5YCarionSRb8s1PK4+pGLi2shnre993gY5UpXt
 QZLg==
X-Gm-Message-State: AOAM5337nq/a/9gEKxW7GEBx7Lfi8UotAkdz6jZx/dOu6Zw/8LN4Qa5r
 H5N27OYbBGXhDGnIxK63Lgw=
X-Google-Smtp-Source: ABdhPJwgLbOqlPolWSLKQMYHopzVh4t+TTT+LUjLLyS04k2mmVnKCdK7eDwtDIN7jPz4vExgSzdM8w==
X-Received: by 2002:adf:aad6:: with SMTP id i22mr45025844wrc.40.1641376530289; 
 Wed, 05 Jan 2022 01:55:30 -0800 (PST)
Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e])
 by smtp.gmail.com with ESMTPSA id o11sm2240629wmq.15.2022.01.05.01.55.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 05 Jan 2022 01:55:29 -0800 (PST)
From: zimoun <zimon.toutoune@HIDDEN>
To: Maxime Devos <maximedevos@HIDDEN>
Subject: Re: bug#34170: bitcoin-core bundles leveldb
References: <20190122133124.7ca032d7@HIDDEN>
 <865ys6m168.fsf@HIDDEN>
 <df96d7bdccb0a6a4ae1b7aa9da8c8d30f97360c3.camel@HIDDEN>
Date: Wed, 05 Jan 2022 10:45:19 +0100
In-Reply-To: <df96d7bdccb0a6a4ae1b7aa9da8c8d30f97360c3.camel@HIDDEN>
 (Maxime Devos's message of "Wed, 05 Jan 2022 10:39:19 +0100")
Message-ID: <86lezu8qj4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 34170
Cc: 34170 <at> debbugs.gnu.org, Danny Milosavljevic <dannym@HIDDEN>,
 contact@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Maxime,

On Wed, 05 Jan 2022 at 10:39, Maxime Devos <maximedevos@HIDDEN> wrote:

>> The package bitcore-core still provides =E2=80=99leveldb=E2=80=99:
>>
>> [...]
>>
>> and I am not sure to get what is the issue.  Some explanations?
>
> The issue is that bitcoin-core bundles leveldb (which you have shown
> is still the case), even though leveldb is packaged in Guix.

Thanks, I missed that =E2=80=99leveldb=E2=80=99 is packaged in Guix.  Indee=
d, it should
preferably be used.

So reopen. :-)


Cheers,
simon




Information forwarded to bug-guix@HIDDEN:
bug#34170; Package guix. Full text available.
Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs@HIDDEN> to internal_control <at> debbugs.gnu.org. Full text available.

Message received at 34170 <at> debbugs.gnu.org:


Received: (at 34170) by debbugs.gnu.org; 5 Jan 2022 09:39:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 05 04:39:30 2022
Received: from localhost ([127.0.0.1]:39582 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1n52lV-0007gW-S9
	for submit <at> debbugs.gnu.org; Wed, 05 Jan 2022 04:39:30 -0500
Received: from andre.telenet-ops.be ([195.130.132.53]:46812)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1n52lT-0007gN-Qz
 for 34170 <at> debbugs.gnu.org; Wed, 05 Jan 2022 04:39:28 -0500
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by andre.telenet-ops.be with bizsmtp
 id exfQ2600f4UW6Th01xfRq4; Wed, 05 Jan 2022 10:39:25 +0100
Message-ID: <df96d7bdccb0a6a4ae1b7aa9da8c8d30f97360c3.camel@HIDDEN>
Subject: Re: bug#34170: bitcoin-core bundles leveldb
From: Maxime Devos <maximedevos@HIDDEN>
To: zimoun <zimon.toutoune@HIDDEN>, Danny Milosavljevic
 <dannym@HIDDEN>
Date: Wed, 05 Jan 2022 10:39:19 +0100
In-Reply-To: <865ys6m168.fsf@HIDDEN>
References: <20190122133124.7ca032d7@HIDDEN>
 <865ys6m168.fsf@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-s50yUeSiHcQskHa5xJ4i"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1641375566; bh=dRbmvpX7SPc4ybaKUi9U1S2bc1hLQOMoWZkKclwAbBk=;
 h=Subject:From:To:Cc:Date:In-Reply-To:References;
 b=XPFZOSWioTirXVmXOza6mQBo3t2mPThT2bSMS1JLOXGM7SuOgitwtxURY5eweHKVW
 RnP7VamR7foTI+fUsYSE7iCCm4z9wT2vtoJ6X1xu62CUlxlNViXeXXgmjFqTH+KSgb
 eazPCPNmwKJtUQE2Kq55Ka3LVeLq8u/WH570kTUwcIJX0hpo1MozqGH3gSKO9feomL
 VxXN0fxwdHYiCaYW9cSpxOzAh98x3obhMTH0rLhxlG+AWrKYsftW4Iy857256wxOw6
 aSOj5iy573DfpFG0sziLdagukPC0TXoEbwDZzF/E1m6qQJSl7/gexZqvhCcwTETePY
 bsJcEwPSyx+4w==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 34170
Cc: 34170 <at> debbugs.gnu.org, contact@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--=-s50yUeSiHcQskHa5xJ4i
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

zimoun schreef op vr 03-12-2021 om 11:29 [+0100]:
> Hi,
>=20
> This old bug#34170 [1] provides only the =E2=80=99Subject=E2=80=99 as ele=
ments.
> The package bitcore-core still provides =E2=80=99leveldb=E2=80=99:
>=20
> [...]
>=20
> and I am not sure to get what is the issue.  Some explanations?

The issue is that bitcoin-core bundles leveldb (which you have shown
is still the case), even though leveldb is packaged in Guix. See, e.g.
=E2=80=98(guix)Snippets versus Phases=E2=80=99 and the following from =E2=
=80=98(guix)Submitting
Patches=E2=80=99:

  7. Make sure the package does not use bundled copies of software
     already available as separate packages.

     Sometimes, packages include copies of the source code of their
     dependencies as a convenience for users.  However, as a
     distribution, we want to make sure that such packages end up using
     the copy we already have in the distribution, if there is one.
     This improves resource usage (the dependency is built and stored
     only once), and allows the distribution to make transverse changes
     such as applying security updates for a given software package in a
     single place and have them affect the whole system=E2=80=94something t=
hat
     bundled copies prevent.

Greetings,
Maxime.

--=-s50yUeSiHcQskHa5xJ4i
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYdVnRxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rbGAQDs9M72x4vWmzGBMDCgAS3xvuGS
WLrER2FZy3j4vEi2HwEA+yb+GJB1iN2vBY0t9rMHnjerWYCEyXm5JP7bAjI3BgI=
=cyUF
-----END PGP SIGNATURE-----

--=-s50yUeSiHcQskHa5xJ4i--





Information forwarded to bug-guix@HIDDEN:
bug#34170; Package guix. Full text available.

Message received at 34170-done <at> debbugs.gnu.org:


Received: (at 34170-done) by debbugs.gnu.org; 4 Jan 2022 23:30:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 04 18:30:06 2022
Received: from localhost ([127.0.0.1]:39126 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1n4tFl-0004uB-Oh
	for submit <at> debbugs.gnu.org; Tue, 04 Jan 2022 18:30:06 -0500
Received: from mail-wm1-f50.google.com ([209.85.128.50]:44610)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1n4tFh-0004sG-Lu
 for 34170-done <at> debbugs.gnu.org; Tue, 04 Jan 2022 18:30:04 -0500
Received: by mail-wm1-f50.google.com with SMTP id
 f134-20020a1c1f8c000000b00345c05bc12dso2285855wmf.3
 for <34170-done <at> debbugs.gnu.org>; Tue, 04 Jan 2022 15:30:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=mi9+Xa6pBDNIaiM8lrDnbxTK6gfb61Ml+0+2zYktJeM=;
 b=fNQLLiWXpzyXtfY96jcIgR5wSts5MC/MHqLkJBAJEOkIfPGvHsmbsUm31PoDVrvAtA
 4Tw44+02mqIrNOI+/lawm8Af+bwH53HLNVE4DxKlwqalAuthC2Fqaswhlyzt4xRb39YN
 PICN16uxffj6QV3ULQI3ycgORizJOyhSOCjql2DTq8eG08JuDwNzrWX8Xj5m4EpITS8q
 4TJYxOUWsuK8A2gFQhjEpIjECoeAkK3LxFQ4AZLcZBrXzY1oP/jGBjUWu3DvqHxt1370
 h183ffB/86AxBkkFNUSgwB/m3VfaNMF2i2KbtfDE6TTNjC56CZPatXXpuEcSYQGl7D72
 k7dg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=mi9+Xa6pBDNIaiM8lrDnbxTK6gfb61Ml+0+2zYktJeM=;
 b=Aiq4zduHX5ZDWA1REzCI1lxxdwPs2TBq9h+ETTqfbnd+WzxyFJssoMI5/4Ih9eJxY9
 IVHn9ntDQZQpBEjNbB+7x/djk+IoMLtFwAlIT2do2xw87ZNIKERJnV7R2VNx5/MUITWO
 NWdLhWTZyX9pxRl58BOTUysMpHEjRvIkFOsSZybYmoGj7Da+8OqpTpa1Nry1A4tnhaRF
 aGpZ+2sXgtwwpnoFm0DcDgmte6sJc01tZ2yTF8MK4OEGZrqqqUd18epu8YQOCl8Hp1/R
 WWTftf/oZoEmW2DUrQbGCjuM3ScG81x6J0+Z/v90XRix46s6NROUDxkmH3zWq5RKjj0c
 qCLg==
X-Gm-Message-State: AOAM530Lh6/qv+wIJhn/YVoLHK1mL30C0cy81l9KfYLvedxtTG6zUq7w
 FI82W4Lm1hsezZ5QEFyAbOnGvMUxmDc=
X-Google-Smtp-Source: ABdhPJwd1Ot0niIeWu1gvErHhKe+AtIG7u/5IgdUxCX/ZI3fPOB0m0Xl1XMU03yxFvkUjKRCuzQzaw==
X-Received: by 2002:a7b:c10d:: with SMTP id w13mr501800wmi.11.1641338996125;
 Tue, 04 Jan 2022 15:29:56 -0800 (PST)
Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e])
 by smtp.gmail.com with ESMTPSA id d4sm38907669wrx.102.2022.01.04.15.29.55
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 04 Jan 2022 15:29:55 -0800 (PST)
From: zimoun <zimon.toutoune@HIDDEN>
To: Danny Milosavljevic <dannym@HIDDEN>
Subject: Re: bug#34170: bitcoin-core bundles leveldb
References: <20190122133124.7ca032d7@HIDDEN>
 <865ys6m168.fsf@HIDDEN>
Date: Wed, 05 Jan 2022 00:29:05 +0100
In-Reply-To: <865ys6m168.fsf@HIDDEN> (zimoun's message of "Fri, 03 Dec 2021
 11:29:35 +0100")
Message-ID: <86a6gbaxmm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 34170-done
Cc: 34170-done <at> debbugs.gnu.org, contact@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

On Fri, 03 Dec 2021 at 11:29, zimoun <zimon.toutoune@HIDDEN> wrote:

> This old bug#34170 [1] provides only the =E2=80=99Subject=E2=80=99 as ele=
ments.
> The package bitcore-core still provides =E2=80=99leveldb=E2=80=99:
>
> $ tar xf $(guix build -S bitcoin-core)
> $ ls -1 bitcoin-0.21.2/src/leveldb
> AUTHORS
> benchmarks
> cmake
> CMakeLists.txt
> CONTRIBUTING.md
> db
> doc
> helpers
> include
> issues
> LICENSE
> NEWS
> port
> README.md
> table
> TODO
> util
>
> and I am not sure to get what is the issue.  Some explanations?
>
> 1: <http://issues.guix.gnu.org/issue/34170>

I am closing.  Feel free to reopen if I miss something.


Cheers,
simon




Notification sent to Danny Milosavljevic <dannym@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to zimoun <zimon.toutoune@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 34170 <at> debbugs.gnu.org:


Received: (at 34170) by debbugs.gnu.org; 3 Dec 2021 10:34:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 03 05:34:32 2021
Received: from localhost ([127.0.0.1]:50079 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mt5tf-0001ps-SN
	for submit <at> debbugs.gnu.org; Fri, 03 Dec 2021 05:34:32 -0500
Received: from mail-wm1-f52.google.com ([209.85.128.52]:45609)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1mt5ta-0001pX-LR
 for 34170 <at> debbugs.gnu.org; Fri, 03 Dec 2021 05:34:30 -0500
Received: by mail-wm1-f52.google.com with SMTP id
 g191-20020a1c9dc8000000b0032fbf912885so1840722wme.4
 for <34170 <at> debbugs.gnu.org>; Fri, 03 Dec 2021 02:34:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=UjSMVmxInJGq+P8DP+Jp7tTrF2CJJea/4RCBmdQ4nLU=;
 b=Q1P07Ns31p/tb3sPs5HqQ/JriL6RsORwQ5s5yyq6svKr70G5u48oHrCvVPSNLn/jF3
 Z8uTbtCHE7kjPxUW48p6kqGOGydcNtJ1lf/uG6LsyBi5mtIRjDWlE5428/sXfhHQUlYt
 3dz1RoegyfrtNAEdZAUNRWaQ+m5VhniocGufJZPfB37elHa2nnZvS/GIa4MCKRGF2wVg
 ShQgZwg0h2nJKRoqP+hjEYn/RyD1gQc/0JMgoITbVF4JtazcIIPftWOwNPMt235Li6nW
 FsleTNP1A41VgTSMedi21cts2oC9NPcXecQvTFtow8p8qLZ4x2ySTyV4uEJ8wxd5GrY9
 iLYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=UjSMVmxInJGq+P8DP+Jp7tTrF2CJJea/4RCBmdQ4nLU=;
 b=TK0gkkx44BOYL5nPmGp/++Gq0BevZ92nMY1QGI4W2v31xLurUcqk4wnhUW6B127d7w
 lI8f0rEePIwuWQsgfKasClqzA1DWhVro1Hz0hdk7Ljq1id+pvgYNa5/6ZrTxqEIpcXnd
 OnKzNdl1Y2kYPHz4nZkyW+fKpJg8UoyS8wxUf93UHGntiYxANSa/nBFI+9QzmTEc93zH
 6pyxCe9HMI4QqiLH8YiHdfZs7HodLllp4DTAiDmTc8LeP03GGq6r9rkVrO6DBkjBQJI/
 AkGCIlUJj5O5oJuq99n6O7ZMuKae0Jg1z31ehjaHZ/7KueyoTtoGwzQMg0ZjhIk1FiGP
 xVNw==
X-Gm-Message-State: AOAM532g4u+lbp5RZuk6GaKuSkF3z3yjXKoOLAAeGU+b4t+VSonvLUAs
 7mvsh/cW7J31mvHVGzsa6eM=
X-Google-Smtp-Source: ABdhPJyuRXpJ0JbnBdtC9I02MRrYTDpoopeUWo0kEKto7Olr+YuajOkJp7+5I391EoT2TC63zmg2MA==
X-Received: by 2002:a05:600c:282:: with SMTP id
 2mr13939863wmk.91.1638527660659; 
 Fri, 03 Dec 2021 02:34:20 -0800 (PST)
Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e])
 by smtp.gmail.com with ESMTPSA id m36sm2269650wms.25.2021.12.03.02.34.20
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 03 Dec 2021 02:34:20 -0800 (PST)
From: zimoun <zimon.toutoune@HIDDEN>
To: Danny Milosavljevic <dannym@HIDDEN>
Subject: Re: bug#34170: bitcoin-core bundles leveldb
References: <20190122133124.7ca032d7@HIDDEN>
Date: Fri, 03 Dec 2021 11:29:35 +0100
In-Reply-To: <20190122133124.7ca032d7@HIDDEN> (Danny Milosavljevic's
 message of "Tue, 22 Jan 2019 13:31:24 +0100")
Message-ID: <865ys6m168.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 34170
Cc: 34170 <at> debbugs.gnu.org, contact@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

This old bug#34170 [1] provides only the =E2=80=99Subject=E2=80=99 as eleme=
nts.
The package bitcore-core still provides =E2=80=99leveldb=E2=80=99:

--8<---------------cut here---------------start------------->8---
$ tar xf $(guix build -S bitcoin-core)
$ ls -1 bitcoin-0.21.2/src/leveldb
AUTHORS
benchmarks
cmake
CMakeLists.txt
CONTRIBUTING.md
db
doc
helpers
include
issues
LICENSE
NEWS
port
README.md
table
TODO
util
--8<---------------cut here---------------end--------------->8---

and I am not sure to get what is the issue.  Some explanations?

1: <http://issues.guix.gnu.org/issue/34170>


Cheers,
simon




Information forwarded to bug-guix@HIDDEN:
bug#34170; Package guix. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 22 Jan 2019 21:56:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 22 16:56:12 2019
Received: from localhost ([127.0.0.1]:41662 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gm41k-0002Ih-0V
	for submit <at> debbugs.gnu.org; Tue, 22 Jan 2019 16:56:12 -0500
Received: from eggs.gnu.org ([209.51.188.92]:54640)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dannym@HIDDEN>) id 1gm41i-0002IN-OB
 for submit <at> debbugs.gnu.org; Tue, 22 Jan 2019 16:56:11 -0500
Received: from lists.gnu.org ([209.51.188.17]:37337)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <dannym@HIDDEN>)
 id 1gm41b-0003Em-Rw
 for submit <at> debbugs.gnu.org; Tue, 22 Jan 2019 16:56:05 -0500
Received: from eggs.gnu.org ([209.51.188.92]:48922)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <dannym@HIDDEN>) id 1gm1rL-0002uG-1f
 for bug-guix@HIDDEN; Tue, 22 Jan 2019 14:37:19 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
 TVD_SPACE_RATIO,TVD_SPACE_RATIO_MINFP autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <dannym@HIDDEN>) id 1gm1rK-0004Zc-9x
 for bug-guix@HIDDEN; Tue, 22 Jan 2019 14:37:18 -0500
Received: from dd26836.kasserver.com ([85.13.145.193]:57190)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <dannym@HIDDEN>)
 id 1gm1rJ-0004U5-UI
 for bug-guix@HIDDEN; Tue, 22 Jan 2019 14:37:18 -0500
Received: from localhost (178.113.238.145.wireless.dyn.drei.com
 [178.113.238.145])
 by dd26836.kasserver.com (Postfix) with ESMTPSA id ADEC9336048F
 for <bug-guix@HIDDEN>; Tue, 22 Jan 2019 13:31:31 +0100 (CET)
Date: Tue, 22 Jan 2019 13:31:24 +0100
From: Danny Milosavljevic <dannym@HIDDEN>
To: <bug-guix@HIDDEN>
Subject: bitcoin-core bundles leveldb
Message-ID: <20190122133124.7ca032d7@HIDDEN>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/HO3porRQXaG/3pV9Q3zV9pU"; protocol="application/pgp-signature"
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 85.13.145.193
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--Sig_/HO3porRQXaG/3pV9Q3zV9pU
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable


--Sig_/HO3porRQXaG/3pV9Q3zV9pU
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlxHDRwACgkQ5xo1VCww
uqU4qQf/TF0NXXkLjk7McWCSIzVN7oFXQkyj1k5m7TfdL3Ztw72dPM9X4F8/9nC5
zt/sJrD4Qi1M2DOSTRKb4Bmfbr9WdtEC6yRU576UK0pijlHgO8M0rdaXnGTO/NC6
nXLssXWJYhtmIzZUsYW7W7a4B72pRSEhRbfPDNbASVBGzdJAUKn8lgQoEym7HSSR
UT2qcO/G267+YSQY9ZowqNy1hskTZHeaY0H3d/w4mkDmRj0I/O/50JhYJxNO/Xjw
xeH2I/RqNmq+1i783m91bUA+eylwm0ldOwUAdL0XcThd/Zy/lJ7OVm14Gj7dZGJ9
hRSQNrUKcVGwqvRdUFG2lwesSIm0wg==
=0Km+
-----END PGP SIGNATURE-----

--Sig_/HO3porRQXaG/3pV9Q3zV9pU--




Acknowledgement sent to Danny Milosavljevic <dannym@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-guix@HIDDEN. Full text available.
Report forwarded to bug-guix@HIDDEN:
bug#34170; Package guix. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 13 Jul 2022 15:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.