GNU bug report logs - #34200
[PATCH] gnu: Add stoken.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34200 in the body.
You can then email your comments to 34200 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ericbavier <at> centurylink.net
To: guix-patches <at> gnu.org
Cc: Eric Bavier <bavier <at> member.fsf.org>
Subject: [PATCH] gnu: Add stoken.
Date: Fri, 25 Jan 2019 13:31:27 -0600

From: Eric Bavier <bavier <at> member.fsf.org>

* gnu/packages/crypto.scm (stoken): New variable.
---
 gnu/packages/crypto.scm | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 2c63e53191..a41543289c 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -5,7 +5,7 @@
 ;;; Copyright © 2016 Lukas Gradl <lgradl <at> openmailbox>
 ;;; Copyright © 2016, 2017, 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2016, 2017 Nils Gillmann <ng0 <at> n0.is>
-;;; Copyright © 2016, 2017 Eric Bavier <bavier <at> member.fsf.org>
+;;; Copyright © 2016, 2017, 2019 Eric Bavier <bavier <at> member.fsf.org>
 ;;; Copyright © 2017 Pierre Langlois <pierre.langlois <at> gmx.com>
 ;;; Copyright © 2018 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2018 Arun Isaac <arunisaac <at> systemreboot.net>
@@ -902,3 +902,29 @@ Features:
 @end itemize\n")
       (home-page "https://github.com/bitcoin-core/secp256k1")
       (license license:unlicense))))
+
+(define-public stoken
+  (package
+    (name "stoken")
+    (version "0.92")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/stoken/"
+                                  "stoken-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0npgr6y85gzwksy8jkwa4yzvqwjprwnplx3yiw3ayk4f0ldlhaxa"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("nettle" ,nettle)
+       ("libxml2" ,libxml2)))
+    (home-page "https://stoken.sf.net")
+    (synopsis "Software Token for cryptographic authentication")
+    (description
+     "@code{stoken} is a tokencode generator compatible with RSA SecurID
+128-bit (AES) tokens.  This package contains a standalong command-line program
+that allows for importing token seeds, generating tokencodes, and various
+utility/testing functions.")
+    (license license:lgpl2.1+)))
--
2.20.1

Message #8 received at 34200 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: ericbavier <at> centurylink.net
Cc: 34200 <at> debbugs.gnu.org, Eric Bavier <bavier <at> member.fsf.org>
Subject: Re: [bug#34200] [PATCH] gnu: Add stoken.
Date: Sat, 26 Jan 2019 14:53:49 +0100

Hi Eric,

thanks for the patch!

> * gnu/packages/crypto.scm (stoken): New variable.
[…]
> +    (home-page "https://stoken.sf.net")

Sourceforge home pages don’t seem to support HTTPS.

> +    (synopsis "Software Token for cryptographic authentication")
> +    (description
> +     "@code{stoken} is a tokencode generator compatible with RSA SecurID
> +128-bit (AES) tokens.  This package contains a standalong command-line program
> +that allows for importing token seeds, generating tokencodes, and various
> +utility/testing functions.")
> +    (license license:lgpl2.1+)))

“standalong” should be “standalone”; I’d also separate the term
“tokencodes”.

Other than that it looks good to me!

--
Ricardo

Message #13 received at 34200-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Ricardo Wurmus <rekado <at> elephly.net>, 34200-done <at> debbugs.gnu.org
Subject: Re: [bug#34200] [PATCH] gnu: Add stoken.
Date: Sat, 26 Jan 2019 17:48:54 -0600

[Message part 1 (text/plain, inline)]

On Sat, 26 Jan 2019 14:53:49 +0100
Ricardo Wurmus <rekado <at> elephly.net> wrote:

> Hi Eric,
> 
> thanks for the patch!
> 
> > * gnu/packages/crypto.scm (stoken): New variable.  
> […]
> > +    (home-page "https://stoken.sf.net")  
> 
> Sourceforge home pages don’t seem to support HTTPS.

Hm, transcription error, I guess.

> 
> > +    (synopsis "Software Token for cryptographic authentication")
> > +    (description
> > +     "@code{stoken} is a tokencode generator compatible with RSA SecurID
> > +128-bit (AES) tokens.  This package contains a standalong command-line program
> > +that allows for importing token seeds, generating tokencodes, and various
> > +utility/testing functions.")
> > +    (license license:lgpl2.1+)))  
> 
> “standalong” should be “standalone”; I’d also separate the term
> “tokencodes”.

Done.

> 
> Other than that it looks good to me!

Thanks for the review, Ricardo!

Pushed with fixes to master in c2ab3b84398df0b26e6127ea0c336a39e8950d17.

`~Eric

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.