GNU bug report logs -
#34205
[PATCH] gnu: Add lhasa.
Previous Next
Reported by: Kei Kebreau <kkebreau <at> posteo.net>
Date: Sat, 26 Jan 2019 01:26:02 UTC
Severity: normal
Tags: patch
Done: Ricardo Wurmus <rekado <at> elephly.net>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34205 in the body.
You can then email your comments to 34205 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#34205
; Package
guix-patches
.
(Sat, 26 Jan 2019 01:26:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Kei Kebreau <kkebreau <at> posteo.net>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Sat, 26 Jan 2019 01:26:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/compression.scm (lhasa): New variable.
---
gnu/packages/compression.scm | 35 ++++++++++++++++++++++++++++++++++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index 327951fde..3fe4c74ec 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -12,7 +12,7 @@
;;; Copyright © 2016 Danny Milosavljevic <dannym <at> scratchpost.org>
;;; Copyright © 2016, 2017, 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
;;; Copyright © 2016 David Craven <david <at> craven.ch>
-;;; Copyright © 2016 Kei Kebreau <kkebreau <at> posteo.net>
+;;; Copyright © 2016, 2019 Kei Kebreau <kkebreau <at> posteo.net>
;;; Copyright © 2016, 2018 Marius Bakke <mbakke <at> fastmail.com>
;;; Copyright © 2017 Nils Gillmann <ng0 <at> n0.is>
;;; Copyright © 2017 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
@@ -434,6 +434,39 @@ than gzip and 15 % smaller output than bzip2.")
(license (list license:gpl2+ license:lgpl2.1+)) ; bits of both
(home-page "https://tukaani.org/xz/")))
+(define-public lhasa
+ (package
+ (name "lhasa")
+ (version "0.3.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/fragglet/lhasa/releases/download/v"
+ version "/lhasa-" version ".tar.gz"))
+ (sha256
+ (base32
+ "092zi9av18ma20c6h9448k0bapvx2plnp292741dvfd9hmgqxc1z"))))
+ (build-system gnu-build-system)
+ (arguments
+ '(#:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'set-up-test-environment
+ (lambda* (#:key inputs #:allow-other-keys)
+ (setenv "TZDIR" (string-append (assoc-ref inputs "tzdata")
+ "/share/zoneinfo"))
+ #t)))))
+ (native-inputs
+ `(("tzdata" ,tzdata)))
+ (home-page "http://fragglet.github.com/lhasa/")
+ (synopsis "LHA implementation")
+ (description "Lhasa is a replacement for the Unix LHA tool, for
+decompressing .lzh (LHA / LHarc) and .lzs (LArc) archives. The backend for the
+tool is a library, so that it can be reused for other purposes. Lhasa aims to
+be compatible with as many types of lzh/lzs archives as possible. It also aims
+to generate the same output as the (non-free) Unix LHA tool, so that it will
+act as a drop-in free replacement.")
+ (license license:isc)))
+
(define-public lzo
(package
(name "lzo")
--
2.20.1
Information forwarded
to
guix-patches <at> gnu.org
:
bug#34205
; Package
guix-patches
.
(Sat, 26 Jan 2019 12:11:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 34205 <at> debbugs.gnu.org (full text, mbox):
Hi Kei,
> * gnu/packages/compression.scm (lhasa): New variable.
this looks good to me.
A few minor suggestions:
> + (home-page "http://fragglet.github.com/lhasa/")
Please use HTTPS.
> + (synopsis "LHA implementation")
I’d prefer “Parse LHA archives” or something else that hints at what
“LHA” is.
> + (description "Lhasa is a replacement for the Unix LHA tool, for
> +decompressing .lzh (LHA / LHarc) and .lzs (LArc) archives. The backend for the
> +tool is a library, so that it can be reused for other purposes. Lhasa aims to
> +be compatible with as many types of lzh/lzs archives as possible. It also aims
> +to generate the same output as the (non-free) Unix LHA tool, so that it will
> +act as a drop-in free replacement.")
I’d say “free drop-in replacement”.
--
Ricardo
Information forwarded
to
guix-patches <at> gnu.org
:
bug#34205
; Package
guix-patches
.
(Sat, 26 Jan 2019 16:13:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 34205 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Thanks for the suggestions! I've attached a revised patch with the
suggested changes.
[0001-gnu-Add-lhasa.patch (text/plain, attachment)]
Reply sent
to
Ricardo Wurmus <rekado <at> elephly.net>
:
You have taken responsibility.
(Wed, 30 Jan 2019 20:26:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Kei Kebreau <kkebreau <at> posteo.net>
:
bug acknowledged by developer.
(Wed, 30 Jan 2019 20:26:04 GMT)
Full text and
rfc822 format available.
Message #16 received at 34205-done <at> debbugs.gnu.org (full text, mbox):
Kei Kebreau <kkebreau <at> posteo.net> writes:
> Thanks for the suggestions! I've attached a revised patch with the
> suggested changes.
>
> From a8ddb85540c9ee3d4b125f36652330fab565c65e Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kkebreau <at> posteo.net>
> Date: Fri, 25 Jan 2019 20:22:23 -0500
> Subject: [PATCH] gnu: Add lhasa.
>
> * gnu/packages/compression.scm (lhasa): New variable.
LGTM! I pushed it to “master” with commit 0dcea35d9.
Thanks!
--
Ricardo
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Thu, 28 Feb 2019 12:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 5 years and 31 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.