GNU bug report logs - #34232
[PATCH] gnu: rust: Package rust@1.29.2

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34232 in the body.
You can then email your comments to 34232 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Petkov <ivanppetkov <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: rust: Package rust <at> 1.29.2
Date: Sun, 27 Jan 2019 22:50:46 -0800

* gnu/packages/rust.scm (rust): renamed to rust-1.28
* gnu/packages/rust.scm (rust): Packaged rust <at> 1.29.2 by inheriting from
rust <at> 1.28.0 and only applying the necessary patches which were lacking
upstream
---
 gnu/packages/rust.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/rust.scm b/gnu/packages/rust.scm
index 501736d89..179689973 100644
--- a/gnu/packages/rust.scm
+++ b/gnu/packages/rust.scm
@@ -749,7 +749,7 @@ jemalloc = \"" jemalloc "/lib/libjemalloc_pic.a" "\"
                    (("fn thin_lto_works") "#[ignore]\nfn thin_lto_works"))
                  #t)))))))))
 
-(define-public rust
+(define-public rust-1.28
   (let ((base-rust
          (rust-bootstrapped-package rust-1.27 "1.28.0"
                                     "11k4rn77bca2rikykkk9fmprrgjswd4x4kaq7fia08vgkir82nhx"
@@ -782,3 +782,13 @@ jemalloc = \"" jemalloc "/lib/libjemalloc_pic.a" "\"
                  #t))
              ;; The thinlto test should pass with llvm 6.
              (delete 'disable-thinlto-test))))))))
+
+(define-public rust
+  (let ((base-rust
+         (rust-bootstrapped-package rust-1.28 "1.29.2"
+                                    "1jb787080z754caa2w3w1amsygs4qlzj9rs1vy64firfmabfg22h"
+                                    #:patches
+                                    '("rust-1.25-accept-more-detailed-gdb-lines.patch"
+                                      "rust-reproducible-builds.patch"))))
+    (package
+      (inherit base-rust))))
-- 
2.20.1

Message #8 received at 34232 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ivan Petkov <ivanppetkov <at> gmail.com>
Cc: 34232 <at> debbugs.gnu.org, Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Re: [bug#34232] [PATCH] gnu: rust: Package rust <at> 1.29.2
Date: Wed, 06 Feb 2019 23:06:02 +0100

Hello Ivan,

Ivan Petkov <ivanppetkov <at> gmail.com> skribis:

> * gnu/packages/rust.scm (rust): renamed to rust-1.28
> * gnu/packages/rust.scm (rust): Packaged rust <at> 1.29.2 by inheriting from
> rust <at> 1.28.0 and only applying the necessary patches which were lacking
> upstream

Thanks for your patch!  I’ll leave the last word to Danny but this LGTM.

Danny, WDYT?  Please apply if you think it’s good.

Ludo’.

Message #11 received at 34232 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Petkov <ivanppetkov <at> gmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 34232 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#34232] [PATCH] gnu: rust: Package rust <at> 1.29.2
Date: Wed, 13 Feb 2019 19:51:53 -0800

> Thanks for your patch!  I’ll leave the last word to Danny but this LGTM.
> 
> Danny, WDYT?  Please apply if you think it’s good.


Hey Danny,

Did you have any feedback on this?

FWIW I’ve also started working on packaging rust-1.30.1 but that one needs
some local patching and I haven’t quite finished fleshing all the changes
out.

Happy to merge the patches if you think that's better for doing one upgrade
of the rust compiler, but I'm also open to keeping them separate if that's
easier to review!

Thanks,
--Ivan

Message #16 received at 34232-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Ivan Petkov <ivanppetkov <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 34232-done <at> debbugs.gnu.org
Subject: Re: [bug#34232] [PATCH] gnu: rust: Package rust <at> 1.29.2
Date: Thu, 14 Feb 2019 17:57:33 +0100

[Message part 1 (text/plain, inline)]

Hi Ivan,

On Wed, 13 Feb 2019 19:51:53 -0800
Ivan Petkov <ivanppetkov <at> gmail.com> wrote:

> Did you have any feedback on this?

Yes, I've applied it to master.

Thanks!

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.