GNU bug report logs - #34245
perl mode aligns code with comments

Previous Next

Package: emacs;

Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>

Date: Tue, 29 Jan 2019 15:30:04 UTC

Severity: minor

Tags: confirmed, patch

Found in version 28.0.50

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34245 in the body.
You can then email your comments to 34245 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#34245; Package emacs. (Tue, 29 Jan 2019 15:30:04 GMT) Full text and rfc822 format available.
Acknowledgement sent to 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 29 Jan 2019 15:30:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: perl mode aligns code with comments
Date: Tue, 29 Jan 2019 22:56:21 +0800

In perl mode, a TAB on the second line below causes

my @genres = (         #["match", "BUT NOT"]
		       ["Rainbow.*Taiwan|Taiwan.*Rainbow"],

But wiser would be like perltidy does:

my @genres = (                      #["match", "BUT NOT"]
    ["Rainbow.*Taiwan|Taiwan.*Rainbow"],
Added tag(s) confirmed. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Thu, 13 Aug 2020 11:38:02 GMT) Full text and rfc822 format available.
bug Marked as found in versions 28.0.50. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Thu, 13 Aug 2020 11:38:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34245; Package emacs. (Thu, 20 Oct 2022 11:52:01 GMT) Full text and rfc822 format available.

Message #12 received at 34245 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 34245 <at> debbugs.gnu.org
Cc: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#34245: perl mode aligns code with comments
Date: Thu, 20 Oct 2022 08:51:32 -0300

[Message part 1 (text/plain, inline)]
severity 34245 minor
tags 34245 patch
quit


積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> In perl mode, a TAB on the second line below causes
>
> my @genres = (         #["match", "BUT NOT"]
>                ["Rainbow.*Taiwan|Taiwan.*Rainbow"],
>
> But wiser would be like perltidy does:
>
> my @genres = (                      #["match", "BUT NOT"]
>     ["Rainbow.*Taiwan|Taiwan.*Rainbow"],

I don't know why Debbugs marked this as a wishlist, it looks like a bug
to me.

Patch attached.


[0001-Fix-perl-mode-indentation-after-a-hanging-paren.patch (text/x-patch, attachment)]
Severity set to 'minor' from 'wishlist' Request was from Mauro Aranda <maurooaranda <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 20 Oct 2022 11:52:02 GMT) Full text and rfc822 format available.
Added tag(s) patch. Request was from Mauro Aranda <maurooaranda <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 20 Oct 2022 11:52:02 GMT) Full text and rfc822 format available.
Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Wed, 06 Sep 2023 22:16:02 GMT) Full text and rfc822 format available.
Notification sent to 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>:
bug acknowledged by developer. (Wed, 06 Sep 2023 22:16:02 GMT) Full text and rfc822 format available.

Message #21 received at 34245-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 34245-done <at> debbugs.gnu.org,
 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Subject: Re: bug#34245: perl mode aligns code with comments
Date: Wed, 6 Sep 2023 15:15:13 -0700

Version: 30.1

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> 積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:
>
>> In perl mode, a TAB on the second line below causes
>>
>> my @genres = (         #["match", "BUT NOT"]
>>                ["Rainbow.*Taiwan|Taiwan.*Rainbow"],
>>
>> But wiser would be like perltidy does:
>>
>> my @genres = (                      #["match", "BUT NOT"]
>>     ["Rainbow.*Taiwan|Taiwan.*Rainbow"],
>
> I don't know why Debbugs marked this as a wishlist, it looks like a bug
> to me.
>
> Patch attached.

Thanks, pushed to master as commit 2a8f458719a.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 05 Oct 2023 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 218 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.