GNU bug report logs - #34254
[PATCH] build: clean-go: Do not warn about *.go files in "test-tmp".

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34254 in the body.
You can then email your comments to 34254 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ericbavier <at> centurylink.net
To: guix-patches <at> gnu.org
Cc: Eric Bavier <bavier <at> member.fsf.org>
Subject: [PATCH] build: clean-go: Do not warn about *.go files in "test-tmp".
Date: Tue, 29 Jan 2019 23:08:58 -0600

From: Eric Bavier <bavier <at> member.fsf.org>

* Makefile.am (clean-go): Ignore "test-tmp" directory.
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 0590c51519..fec9800ce7 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -318,7 +318,7 @@ nobase_nodist_guileobject_DATA = $(GOBJECTS)
 # Handy way to remove the .go files without removing all the rest.
 clean-go:
 	-$(RM) -f $(GOBJECTS)
-	@find . -name '*.go' -print | \
+	@find . -path ./test-tmp -prune -o -name '*.go' -print | \
 	  if test -t 1; then \
 	    xargs -r echo -e "\033[31mwarning:\033[0m stray .go files:"; \
 	  else \
-- 
2.20.1

Message #8 received at 34254 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: ericbavier <at> centurylink.net
Cc: Eric Bavier <bavier <at> member.fsf.org>, 34254 <at> debbugs.gnu.org
Subject: Re: [bug#34254] [PATCH] build: clean-go: Do not warn about *.go files
 in "test-tmp".
Date: Wed, 06 Feb 2019 23:04:36 +0100

ericbavier <at> centurylink.net skribis:

> From: Eric Bavier <bavier <at> member.fsf.org>
>
> * Makefile.am (clean-go): Ignore "test-tmp" directory.

Neat, go for it!  This had been annoying me for a while actually…

Thanks,
Ludo’.

Message #13 received at 34254-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
Cc: 34254-done <at> debbugs.gnu.org
Subject: Re: [bug#34254] [PATCH] build: clean-go: Do not warn about *.go
 files in "test-tmp".
Date: Thu, 7 Feb 2019 21:22:56 -0600

[Message part 1 (text/plain, inline)]

On Wed, 06 Feb 2019 23:04:36 +0100
Ludovic Courtès <ludo <at> gnu.org> wrote:

> ericbavier <at> centurylink.net skribis:
> 
> > From: Eric Bavier <bavier <at> member.fsf.org>
> >
> > * Makefile.am (clean-go): Ignore "test-tmp" directory.  
> 
> Neat, go for it!  This had been annoying me for a while actually…
> 
> Thanks,
> Ludo’.

Pushed to master in 92becc3f15ce196a94274f80ee0b6594774856fa

`~Eric

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.