GNU bug report logs - #34258
[PATCH 1/2] gnu: Add python-discid.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34258 in the body.
You can then email your comments to 34258 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/2] gnu: Add python-discid.
Date: Wed, 30 Jan 2019 16:36:44 +0100

[Message part 1 (text/plain, inline)]

* gnu/packages/music.scm (python-discid): New variable.
---
 gnu/packages/music.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 4943b901e..5a07ad4ae 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -19,6 +19,7 @@
 ;;; Copyright © 2018 Pierre Neidhardt <mail <at> ambrevar.xyz>
 ;;; Copyright © 2018 Ludovic Courtès <ludo <at> gnu.org>
 ;;; Copyright © 2018 Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
+;;; Copyright © 2019 Gabriel Hondet <gabrielhondet <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4076,6 +4077,41 @@ it provides a submission URL for adding the disc ID to the database and gathers
 ISRCs and the MCN (=UPC/EAN) from disc.")
     (license license:lgpl2.1+)))
 
+(define-public python-discid
+  (package
+    (name "python-discid")
+    (version "1.1.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "discid" version))
+        (sha256
+          (base32
+            "1fgp67nhqlbvhhwrcxq5avil7alpzw4s4579hlyvxzbphdnbz8vq"))))
+    (build-system python-build-system)
+    (inputs
+     `(("libdiscid" ,libdiscid)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'set-libdiscid
+           ;; Set path of libdiscid
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((discid (assoc-ref inputs "libdiscid")))
+               (substitute* "discid/libdiscid.py"
+                 (("lib_name = (.*)$" all name)
+                  (string-append "lib_name = \"" discid
+                                 "/lib/libdiscid.so.0\"\n")))))))))
+    (home-page "https://python-discid.readthedocs.io/")
+    (synopsis "Python binding of Libdiscid")
+    (description "This package provides a python binding of Libdiscid by
+Musicbrainz.  The main purpose is the calculation of an identifier for audio
+discs @url{http://musicbrainz.org/doc/Disc%20ID, Disc ID} to use for the
+@url{http://musicbrainz.org/, MusicBrainz database.  Additionally the disc
+@acronym{MCN, Media Catalog Number} and track @acronym{ISRC, Internation
+Standard Recording Code} can be extracted.}")
+    (license license:lgpl3+)))
+
 (define-public libmusicbrainz
   (package
     (name "libmusicbrainz")
-- 
2.20.1

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 34258 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: 34258 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add python-isrcsubmit.
Date: Wed, 30 Jan 2019 16:40:55 +0100

[Message part 1 (text/plain, inline)]

* gnu/packages/music.scm (python-isrcsubmit): New variable.
---
 gnu/packages/music.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 5a07ad4ae..d88ae4d22 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2578,6 +2578,28 @@ MusicBrainz database.")
 (define-public python2-musicbrainzngs
   (package-with-python2 python-musicbrainzngs))
 
+(define-public python-isrcsubmit
+  (package
+    (name "python-isrcsubmit")
+    (version "2.0.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "isrcsubmit" version))
+        (sha256
+          (base32
+            "0jh4cni8qhri6dh83cmp0i0m0384vv0vznlygv49wj9xzh1d99qv"))))
+    (build-system python-build-system)
+    (propagated-inputs
+      `(("python-discid" ,python-discid)
+        ("python-musicbrainzngs" ,python-musicbrainzngs)))
+    (home-page "https://github.com/JonnyJD/musicbrainz-isrcsubmit")
+    (synopsis "Submit ISRCs from disc to MusicBrainz")
+    (description "@code{isrcsubmit} is a python script that allows to extract
+@acronym{ISRC, International Standard Recording Code} from audio CDs and
+submit them to @url{http://musicbrainz.org/, MusicBrainz}.")
+    (license license:gpl3)))
+
 (define-public python2-pyechonest
   (package
     (name "python2-pyechonest")
-- 
2.20.1

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 34258-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Gabriel Hondet <gabrielhondet <at> gmail.com>, 34258-done <at> debbugs.gnu.org
Subject: Re: [bug#34258] [PATCH 1/2] gnu: Add python-discid.
Date: Thu, 31 Jan 2019 22:06:47 +0100

[Message part 1 (text/plain, inline)]

Gabriel Hondet <gabrielhondet <at> gmail.com> writes:

> * gnu/packages/music.scm (python-discid): New variable.

[...]

> * gnu/packages/music.scm (python-isrcsubmit): New variable.

I fixed the indentation, made some editorialization of the descriptions
(note that the Guile TexInfo implementation does not have @acronym yet)
and pushed both patches as <84243592fe..07c82daad4>.

Thank you!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.