Package: guix-patches;
Reported by: Yoshinori Arai <kumagusu08 <at> gmail.com>
Date: Thu, 31 Jan 2019 06:44:02 UTC
Severity: normal
Tags: patch
Done: Leo Famulari <leo <at> famulari.name>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34262 in the body.
You can then email your comments to 34262 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
View this report as an mbox folder, status mbox, maintainer mbox
guix-patches <at> gnu.org:bug#34262; Package guix-patches.
(Thu, 31 Jan 2019 06:44:02 GMT) Full text and rfc822 format available.Yoshinori Arai <kumagusu08 <at> gmail.com>:guix-patches <at> gnu.org.
(Thu, 31 Jan 2019 06:44:02 GMT) Full text and rfc822 format available.Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
From: Yoshinori Arai <kumagusu08 <at> gmail.com> To: guix-patches <at> gnu.org Subject: [PATCH]Add: nkf Date: Thu, 31 Jan 2019 15:43:26 +0900
1 file changed, 38 insertions(+)
gnu/packages/textutils.scm | 38 ++++++++++++++++++++++++++++++++++++++
modified gnu/packages/textutils.scm
@@ -794,3 +794,41 @@ Chinese and Simplified Chinese, supporting character-level conversion,
phrase-level conversion, variant conversion, and regional idioms among
Mainland China, Taiwan, and Hong-Kong.")
(license license:asl2.0)))
+
+(define-public nkf
+ (let ((commit "08043eadf4abdddcf277842217e3c77a24740dc2")
+ (revision "1"))
+ (package
+ (name "nkf")
+ (version "2.1.5")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/nurse/nkf.git")
+ (commit commit)))
+ (file-name (string-append name version))
+ (sha256
+ (base32
+ "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; test for perl module
+ #:make-flags (list "CC=gcc" "CFLAGS=-O2 -Wall -pedantic"
+ (string-append "prefix=" %output))
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ (replace 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin"))
+ (man1 (string-append out "/share/man/man1"))
+ (man1j (string-append out "/share/man/ja/man1")))
+ (install-file "nkf" bin)
+ (install-file "nkf.1" man1)
+ (install-file "nkf.1j" man1j)
+ #t))))))
+ (home-page "https://ja.osdn.net/projects/nkf/")
+ (synopsis "Network Kanji Filter")
+ (description "Nkf is a yet another kanji code converter among networks, hosts and terminals. It converts input kanji code to designated kanji code such as ISO-2022-JP, Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.")
+ (license license:zlib))))
guix-patches <at> gnu.org:bug#34262; Package guix-patches.
(Thu, 31 Jan 2019 14:56:02 GMT) Full text and rfc822 format available.Message #8 received at 34262 <at> debbugs.gnu.org (full text, mbox):
From: Eric Bavier <ericbavier <at> centurylink.net> To: Yoshinori Arai <kumagusu08 <at> gmail.com> Cc: 34262 <at> debbugs.gnu.org Subject: Re: [bug#34262] [PATCH]Add: nkf Date: Thu, 31 Jan 2019 08:55:19 -0600
[Message part 1 (text/plain, inline)]
Thanks for the patch! Just a few nitpicks below: On Thu, 31 Jan 2019 15:43:26 +0900 Yoshinori Arai <kumagusu08 <at> gmail.com> wrote: > 1 file changed, 38 insertions(+) > gnu/packages/textutils.scm | 38 ++++++++++++++++++++++++++++++++++++++ > > modified gnu/packages/textutils.scm > @@ -794,3 +794,41 @@ Chinese and Simplified Chinese, supporting character-level conversion, > phrase-level conversion, variant conversion, and regional idioms among > Mainland China, Taiwan, and Hong-Kong.") > (license license:asl2.0))) > + > +(define-public nkf > + (let ((commit "08043eadf4abdddcf277842217e3c77a24740dc2") Could you add a comment about how this commit relates to the 2.1.5 release? I see the github page doesn't seem to make actual releases, or even tag. Would it make any sense to download the tarballs available at https://ja.asdn.net/projects/nkf instead? > + (revision "1")) > + (package > + (name "nkf") > + (version "2.1.5") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/nurse/nkf.git") > + (commit commit))) > + (file-name (string-append name version)) Rather than string-append use the 'git-file-name' procedure. > + (sha256 > + (base32 > + "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly")))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; test for perl module > + #:make-flags (list "CC=gcc" "CFLAGS=-O2 -Wall -pedantic" > + (string-append "prefix=" %output)) > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (replace 'install The Makefile's 'install' target seems like it might do what we want. Is that not the case? > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (man1 (string-append out "/share/man/man1")) > + (man1j (string-append out "/share/man/ja/man1"))) > + (install-file "nkf" bin) > + (install-file "nkf.1" man1) > + (install-file "nkf.1j" man1j) > + #t)))))) > + (home-page "https://ja.osdn.net/projects/nkf/") > + (synopsis "Network Kanji Filter") > + (description "Nkf is a yet another kanji code converter among networks, hosts and terminals. It converts input kanji code to designated kanji code such as ISO-2022-JP, Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.") > + (license license:zlib)))) 'is a yet' -> 'is yet' Use double-space after end-of-sentence period. Also, make sure to run 'guix lint knf' Could you send an updated patch? Thanks, `~Eric
[Message part 2 (application/pgp-signature, inline)]
guix-patches <at> gnu.org:bug#34262; Package guix-patches.
(Fri, 01 Feb 2019 04:04:02 GMT) Full text and rfc822 format available.Message #11 received at 34262 <at> debbugs.gnu.org (full text, mbox):
From: Yoshinori Arai <kumagusu08 <at> gmail.com> To: Eric Bavier <ericbavier <at> centurylink.net> Cc: 34262 <at> debbugs.gnu.org Subject: Re: [bug#34262] [PATCH]Add: nkf Date: Fri, 1 Feb 2019 13:03:05 +0900
On Thu, Jan 31, 2019 at 08:55:19AM -0600, Eric Bavier wrote:
> Thanks for the patch! Just a few nitpicks below:
>
> On Thu, 31 Jan 2019 15:43:26 +0900
> Yoshinori Arai <kumagusu08 <at> gmail.com> wrote:
>
> > 1 file changed, 38 insertions(+)
> > gnu/packages/textutils.scm | 38 ++++++++++++++++++++++++++++++++++++++
> >
> > modified gnu/packages/textutils.scm
> > @@ -794,3 +794,41 @@ Chinese and Simplified Chinese, supporting character-level conversion,
> > phrase-level conversion, variant conversion, and regional idioms among
> > Mainland China, Taiwan, and Hong-Kong.")
> > (license license:asl2.0)))
> > +
> > +(define-public nkf
> > + (let ((commit "08043eadf4abdddcf277842217e3c77a24740dc2")
>
> Could you add a comment about how this commit relates to the 2.1.5
> release? I see the github page doesn't seem to make actual releases,
> or even tag. Would it make any sense to download the tarballs
> available at https://ja.asdn.net/projects/nkf instead?
>
> > + (revision "1"))
> > + (package
> > + (name "nkf")
> > + (version "2.1.5")
> > + (source (origin
> > + (method git-fetch)
> > + (uri (git-reference
> > + (url "https://github.com/nurse/nkf.git")
> > + (commit commit)))
> > + (file-name (string-append name version))
>
> Rather than string-append use the 'git-file-name' procedure.
>
> > + (sha256
> > + (base32
> > + "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly"))))
> > + (build-system gnu-build-system)
> > + (arguments
> > + `(#:tests? #f ; test for perl module
> > + #:make-flags (list "CC=gcc" "CFLAGS=-O2 -Wall -pedantic"
> > + (string-append "prefix=" %output))
> > + #:phases
> > + (modify-phases %standard-phases
> > + (delete 'configure)
> > + (replace 'install
>
> The Makefile's 'install' target seems like it might do what we want.
> Is that not the case?
>
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (let* ((out (assoc-ref outputs "out"))
> > + (bin (string-append out "/bin"))
> > + (man1 (string-append out "/share/man/man1"))
> > + (man1j (string-append out "/share/man/ja/man1")))
> > + (install-file "nkf" bin)
> > + (install-file "nkf.1" man1)
> > + (install-file "nkf.1j" man1j)
> > + #t))))))
> > + (home-page "https://ja.osdn.net/projects/nkf/")
> > + (synopsis "Network Kanji Filter")
> > + (description "Nkf is a yet another kanji code converter among networks, hosts and terminals. It converts input kanji code to designated kanji code such as ISO-2022-JP, Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.")
> > + (license license:zlib))))
>
> 'is a yet' -> 'is yet'
>
> Use double-space after end-of-sentence period.
>
> Also, make sure to run 'guix lint knf'
>
> Could you send an updated patch?
>
> Thanks,
> `~Eric
Hello, I updated and made format patch.
From aab08237d2ece4a1f190522d1357b5b9e872ce57 Mon Sep 17 00:00:00 2001
From: Yoshinori Arai <kumagusu08 <at> gmail.com>
Date: Fri, 1 Feb 2019 12:55:46 +0900
Subject: [PATCH] Add nkf
---
gnu/packages/textutils.scm | 42 ++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index d2f84420c..34aae6361 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -794,3 +794,45 @@ Chinese and Simplified Chinese, supporting character-level conversion,
phrase-level conversion, variant conversion, and regional idioms among
Mainland China, Taiwan, and Hong-Kong.")
(license license:asl2.0)))
+
+(define-public nkf
+ (let ((commit "08043eadf4abdddcf277842217e3c77a24740dc2")
+ (revision "1"))
+ (package
+ (name "nkf")
+ ;;look at https://ja.osdn.net/projects/nkf/scm/git/nkf/
+ (version "2.1.5")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/nurse/nkf.git")
+ (commit commit)))
+ (file-name (string-append name version))
+ (sha256
+ (base32
+ "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; test for perl module
+ #:make-flags (list "CC=gcc" "CFLAGS=-O2 -Wall -pedantic"
+ (string-append "prefix=" %output))
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ ;; mkdir can't create directory
+ (replace 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin"))
+ (man1 (string-append out "/share/man/man1"))
+ (man1j (string-append out "/share/man/ja/man1")))
+ (install-file "nkf" bin)
+ (install-file "nkf.1" man1)
+ (install-file "nkf.1j" man1j)
+ #t))))))
+ (home-page "https://ja.osdn.net/projects/nkf/")
+ (synopsis "Network Kanji Filter")
+ (description "Nkf is yet another kanji code converter among networks,
+hosts and terminals. It converts input kanji code to designated kanji code
+such as ISO-2022-JP, Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.")
+ (license license:zlib))))
--
2.20.1
Leo Famulari <leo <at> famulari.name>:Yoshinori Arai <kumagusu08 <at> gmail.com>:Message #16 received at 34262-done <at> debbugs.gnu.org (full text, mbox):
From: Leo Famulari <leo <at> famulari.name> To: Yoshinori Arai <kumagusu08 <at> gmail.com> Cc: Eric Bavier <ericbavier <at> centurylink.net>, 34262-done <at> debbugs.gnu.org Subject: Re: [bug#34262] [PATCH]Add: nkf Date: Mon, 25 Feb 2019 23:17:51 -0500
[Message part 1 (text/plain, inline)]
> From aab08237d2ece4a1f190522d1357b5b9e872ce57 Mon Sep 17 00:00:00 2001
> From: Yoshinori Arai <kumagusu08 <at> gmail.com>
> Date: Fri, 1 Feb 2019 12:55:46 +0900
> Subject: [PATCH] Add nkf
>
> ---
> gnu/packages/textutils.scm | 42 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
Thank you!
I made the changes shown below and pushed as
933ac939d6d2de64c43e068e7c0ebfaaaf2dcdd8
diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index 2d3a090056..71f03b7568 100644
1 gnu: Add nkf.
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -800,14 +800,16 @@ Mainland China, Taiwan, and Hong-Kong.")
(revision "1"))
(package
(name "nkf")
- ;;look at https://ja.osdn.net/projects/nkf/scm/git/nkf/
+ ;; The commits corresponding to specific versions are published
+ ;; here:
+ ;; https://ja.osdn.net/projects/nkf/scm/git/nkf/
(version "2.1.5")
(source (origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/nurse/nkf.git")
(commit commit)))
- (file-name (string-append name version))
+ (file-name (git-file-name name version))
(sha256
(base32
"0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly"))))
@@ -815,21 +817,11 @@ Mainland China, Taiwan, and Hong-Kong.")
(arguments
`(#:tests? #f ; test for perl module
#:make-flags (list "CC=gcc" "CFLAGS=-O2 -Wall -pedantic"
- (string-append "prefix=" %output))
+ (string-append "prefix=" %output)
+ "MKDIR=mkdir -p")
#:phases
(modify-phases %standard-phases
- (delete 'configure)
- ;; mkdir can't create directory
- (replace 'install
- (lambda* (#:key outputs #:allow-other-keys)
- (let* ((out (assoc-ref outputs "out"))
- (bin (string-append out "/bin"))
- (man1 (string-append out "/share/man/man1"))
- (man1j (string-append out "/share/man/ja/man1")))
- (install-file "nkf" bin)
- (install-file "nkf.1" man1)
- (install-file "nkf.1j" man1j)
- #t))))))
+ (delete 'configure)))) ; No ./configure script
(home-page "https://ja.osdn.net/projects/nkf/")
(synopsis "Network Kanji Filter")
(description "Nkf is yet another kanji code converter among networks,
[signature.asc (application/pgp-signature, inline)]
Debbugs Internal Request <help-debbugs <at> gnu.org>
to internal_control <at> debbugs.gnu.org.
(Tue, 26 Mar 2019 11:24:08 GMT) Full text and rfc822 format available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.