X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 04 Feb 2019 15:35:03 +0000
Resent-Message-ID: <handler.34315.B.15492944882209 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 34315 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by submit <at> debbugs.gnu.org id=B.15492944882209
(code B ref -1); Mon, 04 Feb 2019 15:35:03 +0000
Received: (at submit) by debbugs.gnu.org; 4 Feb 2019 15:34:48 +0000
Received: from localhost ([127.0.0.1]:59596 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gqgGl-0000ZT-SU
for submit <at> debbugs.gnu.org; Mon, 04 Feb 2019 10:34:48 -0500
Received: from eggs.gnu.org ([209.51.188.92]:42094)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1gqcjy-0001OO-71
for submit <at> debbugs.gnu.org; Mon, 04 Feb 2019 06:48:42 -0500
Received: from lists.gnu.org ([209.51.188.17]:60198)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <thunk2@HIDDEN>) id 1gqcjs-0005eJ-U2
for submit <at> debbugs.gnu.org; Mon, 04 Feb 2019 06:48:36 -0500
Received: from eggs.gnu.org ([209.51.188.92]:56445)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <thunk2@HIDDEN>) id 1gqcjr-0007Tu-GT
for bug-gnu-emacs@HIDDEN; Mon, 04 Feb 2019 06:48:36 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_50,
FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=disabled
version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <thunk2@HIDDEN>) id 1gqcjo-0005aT-RH
for bug-gnu-emacs@HIDDEN; Mon, 04 Feb 2019 06:48:34 -0500
Received: from vsmx012.vodafonemail.xion.oxcs.net ([153.92.174.90]:45323)
by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <thunk2@HIDDEN>) id 1gqcjl-0005UH-2f
for bug-gnu-emacs@HIDDEN; Mon, 04 Feb 2019 06:48:30 -0500
Received: from vsmx004.vodafonemail.xion.oxcs.net (unknown [192.168.75.198])
by mta-8-out.mta.xion.oxcs.net (Postfix) with ESMTP id 623E8F34B23;
Mon, 4 Feb 2019 11:48:23 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.205.23.198])
by mta-8-out.mta.xion.oxcs.net (Postfix) with ESMTPA id D5B6819AD9A;
Mon, 4 Feb 2019 11:48:18 +0000 (UTC)
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="MUVMw9xUVK"
Content-Transfer-Encoding: 7bit
Message-ID: <23640.9851.562972.730234@HIDDEN>
Date: Mon, 4 Feb 2019 12:48:11 +0100
From: thunk2@HIDDEN (Thomas Plass)
X-VADE-STATUS: LEGIT
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no
timestamps) [generic]
X-Received-From: 153.92.174.90
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Spam-Score: 1.4 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: The attached patch contains a fix for what looks like a
clerical
error in icalendar--decode-isoduration(), test case: P1DT2H. But the real
point of this post is to propose a few improvements to handling timezones.
Content analysis details: (1.4 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.9 SPF_FAIL SPF: sender does not match SPF record (fail)
[SPF failed: Please see http://www.openspf.org/Why?s=mfrom;
id=thunk2%40arcor.de; ip=209.51.188.92; r=debbugs.gnu.org]
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (thunk2[at]arcor.de)
0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
in digit (thunk2[at]arcor.de)
0.2 FREEMAIL_REPLYTO_END_DIGIT Reply-To freemail username ends in
digit (thunk2[at]arcor.de)
X-Mailman-Approved-At: Mon, 04 Feb 2019 10:34:39 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.4 (/)
--MUVMw9xUVK
Content-Type: text/plain; charset=us-ascii
Content-Description: message body text
Content-Transfer-Encoding: 7bit
The attached patch contains a fix for what looks like a clerical error
in icalendar--decode-isoduration(), test case: P1DT2H.
But the real point of this post is to propose a few improvements to
handling timezones.
I use icalendar.el as a library for dealing with raw VCALENDAR data.
Also, I'm on Windows where the OS makes Emacs' timezone handling a
bit tricky. Meaning that, unless precautions are taken, datetime
conversions by icalendar.el sometimes are incorrect, in particular
around DST transitions.
Changes in the patch:
- add an optional argument to icalendar--decode-isodatetime() which
is passed to decode-time().
So, both encode-time() and decode-time() get to have their
respective timezones which makes datetime conversions predictable.
I know, I could do a (setenv "TZ" (icalendar--convert-tz-offset
...)) before I call icalendar--decode-isodatetime() but that +
restoring the environment variable afterwards looks clumsy.
- handle RDATE in icalendar--convert-tz-offset() in a rudimentary
fashion.
RDATE handling is required for those VTIMEZONEs that do not specify
RRULE, otherwise there will be no datetime conversions at all.
- identify the latest oberservance for DAYLIGHT and STANDARD
specifications within one VTIMEZONE, again supporting RDATE.
As is, icalendar.el handles multiple such specifications
indiscriminately, resulting in conversions that may be relative to
a date centuries in the past.
The relevance of this change is this: when a VCALENDAR does not
contain a VTIMEZONE section or e.g. the popular nonstandard
X-WR-TIMEZONE property, my application goes and fetches one from a
tzdata database such as tzurl.org. Standard tzurl.org responses
contain lots of historical records. Yes, tzurl.org also returns
"Outlook-style" VTIMEZONEs which icalendar.el is quite happy with
but that doesn't help me with complex VTIMEZONEs contained in
incoming VCALENDARs.
The patch is not a --git diff. Is that tolerable at all?
Best regards
Thomas
--MUVMw9xUVK
Content-Type: application/x-diff;
name="icalendar.el.patch"
Content-Disposition: attachment;
filename="icalendar.el.patch"
Content-Transfer-Encoding: base64
LS0tIGljYWxlbmRhci5lbC5vcmlnCTIwMTktMDEtMDcgMTk6NDQ6MDYuOTc1ODgxMjAwICswMTAw
CisrKyBpY2FsZW5kYXIuZWwJMjAxOS0wMS0zMSAxNDowNjozNy42MzI0MjI5MDAgKzAxMDAKQEAg
LTUyMyw5ICs1MjMsMTAgQEAKICAgKGxldCogKChvZmZzZXR0byAoY2FyIChjZGRyIChhc3NxICdU
Wk9GRlNFVFRPIGFsaXN0KSkpKQogCSAob2Zmc2V0ZnJvbSAoY2FyIChjZGRyIChhc3NxICdUWk9G
RlNFVEZST00gYWxpc3QpKSkpCiAJIChycnVsZS12YWx1ZSAoY2FyIChjZGRyIChhc3NxICdSUlVM
RSBhbGlzdCkpKSkKKyAgICAgICAgIChyZGF0ZS1wIChhbmQgKGFzc3EgJ1JEQVRFIGFsaXN0KSB0
KSkKIAkgKGR0c3RhcnQgKGNhciAoY2RkciAoYXNzcSAnRFRTVEFSVCBhbGlzdCkpKSkKLQkgKG5v
LWRzdCAoZXF1YWwgb2Zmc2V0dG8gb2Zmc2V0ZnJvbSkpKQotICAgIDs7IEZJWE1FOiBmb3Igbm93
IHdlIG9ubHkgaGFuZGxlIFJSVUxFIGFuZCBub3QgUkRBVEUgaGVyZS4KKwkgKG5vLWRzdCAob3Ig
cmRhdGUtcCAoZXF1YWwgb2Zmc2V0dG8gb2Zmc2V0ZnJvbSkpKSkKKyAgICA7OyBGSVhNRTogdGhl
IHByZXNlbmNlIG9mIGFuIFJEQVRFIGlzIGFzc3VtZWQgdG8gZGVub3RlIHRoZSBmaXJzdCBkYXkg
b2YgdGhlIHllYXIKICAgICAod2hlbiAoYW5kIG9mZnNldHRvIGR0c3RhcnQgKG9yIHJydWxlLXZh
bHVlIG5vLWRzdCkpCiAgICAgICAobGV0KiAoKHJydWxlIChpY2FsZW5kYXItLXNwbGl0LXZhbHVl
IHJydWxlLXZhbHVlKSkKIAkgICAgIChmcmVxIChjYWRyIChhc3NxICdGUkVRIHJydWxlKSkpCkBA
IC01NjksMTIgKzU3MCwxMyBAQAogCiAoZGVmdW4gaWNhbGVuZGFyLS1wYXJzZS12dGltZXpvbmUg
KGFsaXN0KQogICAiVHVybiBhIFZUSU1FWk9ORSBBTElTVCBpbnRvIGEgY29ucyAoSUQgLiBUWi1T
VFJJTkcpLgorQ29uc2lkZXIgb25seSB0aGUgbW9zdCByZWNlbnQgZGF0ZSBzcGVjaWZpY2F0aW9u
LgogUmV0dXJuIG5pbCBpZiB0aW1lem9uZSBjYW5ub3QgYmUgcGFyc2VkLiIKICAgKGxldCogKCh0
ei1pZCAoaWNhbGVuZGFyLS1jb252ZXJ0LXN0cmluZy1mb3ItaW1wb3J0CiAgICAgICAgICAgICAg
ICAgIChpY2FsZW5kYXItLWdldC1ldmVudC1wcm9wZXJ0eSBhbGlzdCAnVFpJRCkpKQotCSAoZGF5
bGlnaHQgKGNhZHIgKGNkYXIgKGljYWxlbmRhci0tZ2V0LWNoaWxkcmVuIGFsaXN0ICdEQVlMSUdI
VCkpKSkKKwkgKGRheWxpZ2h0IChjYWRyIChjZGFyIChpY2FsZW5kYXItLWdldC1tb3N0LXJlY2Vu
dC1vYnNlcnZhbmNlIGFsaXN0ICdEQVlMSUdIVCkpKSkKIAkgKGRheSAoYW5kIGRheWxpZ2h0IChp
Y2FsZW5kYXItLWNvbnZlcnQtdHotb2Zmc2V0IGRheWxpZ2h0IHQpKSkKLQkgKHN0YW5kYXJkIChj
YWRyIChjZGFyIChpY2FsZW5kYXItLWdldC1jaGlsZHJlbiBhbGlzdCAnU1RBTkRBUkQpKSkpCisJ
IChzdGFuZGFyZCAoY2FkciAoY2RhciAoaWNhbGVuZGFyLS1nZXQtbW9zdC1yZWNlbnQtb2JzZXJ2
YW5jZSBhbGlzdCAnU1RBTkRBUkQpKSkpCiAJIChzdGQgKGFuZCBzdGFuZGFyZCAoaWNhbGVuZGFy
LS1jb252ZXJ0LXR6LW9mZnNldCBzdGFuZGFyZCBuaWwpKSkpCiAgICAgKGlmIChhbmQgdHotaWQg
c3RkKQogCShjb25zIHR6LWlkCkBAIC01ODMsNiArNTg1LDI5IEBACiAJCQkgICIsIiAoY2RyIGRh
eSkgIiwiIChjZHIgc3RkKSkKIAkJKGNhciBzdGQpKSkpKSkKIAorKGRlZnVuIGljYWxlbmRhci0t
Z2V0LW1vc3QtcmVjZW50LW9ic2VydmFuY2UgKGFsaXN0IHN1Yi1jb21wKQorICAiUmV0dXJuIHRo
ZSBsYXRlc3Qgb2JzZXJ2YW5jZSBmb3IgU1VCLUNPTVAgREFZTElHSFQgb3IgU1RBTkRBUkQuCitB
TElTVCBpcyBhIFZUSU1FWk9ORSBwb3RlbnRpYWxseSBjb250YWluaW5nIGhpc3RvcmljYWwgcmVj
b3Jkcy4iCis7RklYTUU/OiAibW9zdCByZWNlbnQiIHNob3VsZCBiZSByZWxhdGl2ZSB0byBhIGdp
dmVuIGRhdGUKKyAgKGxldCAoKGNvbXBvbmVudHMgKGljYWxlbmRhci0tZ2V0LWNoaWxkcmVuIGFs
aXN0IHN1Yi1jb21wKSkpCisgICAgKGxpc3QKKyAgICAgKGNhcgorICAgICAgKHNvcnQgY29tcG9u
ZW50cworICAgICAgICAgICAgIycobGFtYmRhIChhIGIpCisgICAgICAgICAgICAgICAgKGxldCog
KChnZXQtcmVjZW50IChsYW1iZGEgKG4pCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgKGNhcgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocmV2ZXJz
ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHNvcnQKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVscSBuaWwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobWFwY2FyIChsYW1iZGEgKHApCisgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChhbmQg
KG1lbXEgKGNhciBwKSAnKERUU1RBUlQgUkRBVEUpKQorICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjYXIgKGNkZHIgcCkpKSkKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG4pKQor
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdzdHJpbmctbGVzc3ApKSkp
KQorICAgICAgICAgICAgICAgICAgICAgICAoYS1yZWNlbnQgKGZ1bmNhbGwgZ2V0LXJlY2VudCAo
Y2FyIChjZGRyIGEpKSkpCisgICAgICAgICAgICAgICAgICAgICAgIChiLXJlY2VudCAoZnVuY2Fs
bCBnZXQtcmVjZW50IChjYXIgKGNkZHIgYikpKSkpCisgICAgICAgICAgICAgICAgICAoc3RyaW5n
LWxlc3NwIGItcmVjZW50IGEtcmVjZW50KSkpKSkpKSkKKwogKGRlZnVuIGljYWxlbmRhci0tY29u
dmVydC1hbGwtdGltZXpvbmVzIChpY2FsZW5kYXIpCiAgICJDb252ZXJ0IGFsbCB0aW1lem9uZXMg
aW4gdGhlIElDQUxFTkRBUiBpbnRvIGFuIGFsaXN0LgogRWFjaCBlbGVtZW50IG9mIHRoZSBhbGlz
dCBpcyBhIGNvbnMgKElEIC4gVFotU1RSSU5HKSwKQEAgLTYwMiwxNSArNjI3LDE4IEBACiAJKGNk
ciAoYXNzb2MgaWQgem9uZS1tYXApKSkpKQogCiAoZGVmdW4gaWNhbGVuZGFyLS1kZWNvZGUtaXNv
ZGF0ZXRpbWUgKGlzb2RhdGV0aW1lc3RyaW5nICZvcHRpb25hbCBkYXktc2hpZnQKLSAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgem9uZSkKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc291
cmNlLXpvbmUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgcmVzdWx0LXpvbmUpCiAgICJSZXR1cm4gSVNPREFURVRJTUVTVFJJTkcgaW4gZm9y
bWF0IGxpa2UgYGRlY29kZS10aW1lJy4KIENvbnZlcnRzIGZyb20gSVNPLTg2MDEgdG8gRW1hY3Mg
cmVwcmVzZW50YXRpb24uICBJZgogSVNPREFURVRJTUVTVFJJTkcgc3BlY2lmaWVzIFVUQyB0aW1l
ICh0cmFpbGluZyBsZXR0ZXIgWikgdGhlCiBkZWNvZGVkIHRpbWUgaXMgZ2l2ZW4gaW4gdGhlIGxv
Y2FsIHRpbWUgem9uZSEgIElmIG9wdGlvbmFsCiBwYXJhbWV0ZXIgREFZLVNISUZUIGlzIG5vbi1u
aWwgdGhlIHJlc3VsdCBpcyBzaGlmdGVkIGJ5IERBWS1TSElGVAogZGF5cy4KLVpPTkUsIGlmIHBy
b3ZpZGVkLCBpcyB0aGUgdGltZXpvbmUsIGluIGFueSBmb3JtYXQgdW5kZXJzdG9vZCBieSBgZW5j
b2RlLXRpbWUnLgotCitTT1VSQ0UtWk9ORSwgaWYgcHJvdmlkZWQsIGlzIHRoZSB0aW1lem9uZSBm
b3IgZGVjb2RpbmcgdGhlIHRpbWUsCitpbiBhbnkgZm9ybWF0IHVuZGVyc3Rvb2QgYnkgYGVuY29k
ZS10aW1lJy4KK1JFU1VMVC1aT05FLCBpZiBwcm92aWRlZCwgaXMgdGhlIHRpbWV6b25lIGZvciBl
bmNvZGluZyB0aGUgcmVzdWx0CitpbiBhbnkgZm9ybWF0IHVuZGVyc3Rvb2QgYnkgYGRlY29kZS10
aW1lJy4KIEZJWE1FOiBtdWx0aXBsZSBjb21tYS1zZXBhcmF0ZWQgdmFsdWVzIHNob3VsZCBiZSBh
bGxvd2VkISIKICAgKGljYWxlbmRhci0tZG1zZyBpc29kYXRldGltZXN0cmluZykKICAgKGlmIGlz
b2RhdGV0aW1lc3RyaW5nCkBAIC02MzEsNyArNjU5LDggQEAKICAgICAgICAgKHdoZW4gKGFuZCAo
PiAobGVuZ3RoIGlzb2RhdGV0aW1lc3RyaW5nKSAxNSkKICAgICAgICAgICAgICAgICAgICA7OyBV
VEMgc3BlY2lmaWVyIHByZXNlbnQKICAgICAgICAgICAgICAgICAgICAoY2hhci1lcXVhbCA/WiAo
YXJlZiBpc29kYXRldGltZXN0cmluZyAxNSkpKQotICAgICAgICAgIChzZXRxIHpvbmUgdCkpCisg
ICAgICAgICAgKHNldHEgc291cmNlLXpvbmUgdAorICAgICAgICAgICAgICAgIHJlc3VsdC16b25l
IHQpKQogICAgICAgICA7OyBzaGlmdCBpZiBuZWNlc3NhcnkKICAgICAgICAgKGlmIGRheS1zaGlm
dAogICAgICAgICAgICAgKGxldCAoKG1keSAoY2FsZW5kYXItZ3JlZ29yaWFuLWZyb20tYWJzb2x1
dGUKQEAgLTY0Miw5ICs2NzEsOCBAQAogICAgICAgICAgICAgICAoc2V0cSBkYXkgICAobnRoIDEg
bWR5KSkKICAgICAgICAgICAgICAgKHNldHEgeWVhciAgKG50aCAyIG1keSkpKSkKICAgICAgICAg
OzsgY3JlYXRlIHRoZSBkZWNvZGVkIGRhdGUtdGltZQotICAgICAgICA7OyBGSVhNRSE/IQogICAg
ICAgICAoY29uZGl0aW9uLWNhc2UgbmlsCi0gICAgICAgICAgICAoZGVjb2RlLXRpbWUgKGVuY29k
ZS10aW1lIHNlY29uZCBtaW51dGUgaG91ciBkYXkgbW9udGggeWVhciB6b25lKSkKKyAgICAgICAg
ICAgIChkZWNvZGUtdGltZSAoZW5jb2RlLXRpbWUgc2Vjb25kIG1pbnV0ZSBob3VyIGRheSBtb250
aCB5ZWFyIHNvdXJjZS16b25lKSByZXN1bHQtem9uZSkKICAgICAgICAgICAoZXJyb3IKICAgICAg
ICAgICAgKG1lc3NhZ2UgIkNhbm5vdCBkZWNvZGUgXCIlc1wiIiBpc29kYXRldGltZXN0cmluZykK
ICAgICAgICAgICAgOzsgaG9wZSBmb3IgdGhlIGJlc3QuLi4KQEAgLTY5MCw5ICs3MTgsOSBAQAog
ICAgICAgICAgICAgICAoc2V0cSBkYXlzICgxLSBkYXlzKSkpKQogICAgICAgICAgICAoKG1hdGNo
LWJlZ2lubmluZyA0KSAgICAgICAgIDtkYXlzIGFuZCB0aW1lCiAgICAgICAgICAgICAoaWYgKG1h
dGNoLWJlZ2lubmluZyA1KQotICAgICAgICAgICAgICAgIChzZXRxIGRheXMgKCogNyAocmVhZCAo
c3Vic3RyaW5nIGlzb2R1cmF0aW9uc3RyaW5nCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgKG1hdGNoLWJlZ2lubmluZyA2KQotICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChtYXRjaC1lbmQgNikpKSkpKQorICAg
ICAgICAgICAgICAgIChzZXRxIGRheXMgKHJlYWQgKHN1YnN0cmluZyBpc29kdXJhdGlvbnN0cmlu
ZworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobWF0Y2gtYmVn
aW5uaW5nIDYpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICht
YXRjaC1lbmQgNikpKSkpCiAgICAgICAgICAgICAoaWYgKG1hdGNoLWJlZ2lubmluZyA3KQogICAg
ICAgICAgICAgICAgIChzZXRxIGhvdXJzIChyZWFkIChzdWJzdHJpbmcgaXNvZHVyYXRpb25zdHJp
bmcKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChtYXRjaC1i
ZWdpbm5pbmcgOCkK
--MUVMw9xUVK--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Thomas Plass <thunk2@HIDDEN> Subject: bug#34315: Acknowledgement ([PATCH] icalendar.el: DURATION fix + more robust timezone handling) Message-ID: <handler.34315.B.15492944882209.ack <at> debbugs.gnu.org> References: <23640.9851.562972.730234@HIDDEN> X-Gnu-PR-Message: ack 34315 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 34315 <at> debbugs.gnu.org Date: Mon, 04 Feb 2019 15:35:06 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 34315 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 34315: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34315 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 12 Feb 2019 18:58:01 +0000
Resent-Message-ID: <handler.34315.B34315.154999784821188 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.154999784821188
(code B ref 34315); Tue, 12 Feb 2019 18:58:01 +0000
Received: (at 34315) by debbugs.gnu.org; 12 Feb 2019 18:57:28 +0000
Received: from localhost ([127.0.0.1]:45216 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gtdFI-0005Vf-89
for submit <at> debbugs.gnu.org; Tue, 12 Feb 2019 13:57:28 -0500
Received: from mout.web.de ([212.227.15.14]:54497)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1gtdFF-0005VS-Tt
for 34315 <at> debbugs.gnu.org; Tue, 12 Feb 2019 13:57:26 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1549997839;
bh=Qyed8mldLUJMJkomG0NL4XYmSijvGpqoC5TcsMf5jUw=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=CuoDXE6bWuHYIPXEVSGr/a95yF6ayb25xox7dsf3wL97MGF3PXsNMzkTJdjQs2P0q
8Jk/VwtUFUwV5wLass/D4pKKAmYhhc1abBw59Mv8fjuzyPqKmz20z07kGqcwzemTGK
WU4aUkP/8kqUk1q/76OXKf2o6FP+J2eIA3FQxl8Y=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([217.226.71.100]) by smtp.web.de (mrweb002
[213.165.67.108]) with ESMTPSA (Nemesis) id 0LdEif-1hJvWJ3tir-00iQg3; Tue, 12
Feb 2019 19:57:19 +0100
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN>
Date: Tue, 12 Feb 2019 19:57:14 +0100
In-Reply-To: <23640.9851.562972.730234@HIDDEN> (Thomas Plass's message
of "Mon, 4 Feb 2019 12:48:11 +0100")
Message-ID: <875ztog7hx.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:we7ihuYoDNwcQnFK/PAMAHRN8euFCBoqrnvOR0Bv3Vty/qGyTYH
EKu9TTl+cY56rZNnX0C4GTGwpe2oXd5eq4T97gjD6zYVFExb8ZG9IQ2tjfdMEu+GlP4aDaq
2/6Dgzr16dHvLOTd7yqld8KOvWejf+k9gHdVC3RmO+3BcdgI2g3ghdzeELTketrGh4hQVck
ng276BQeqwLFGU1o813zA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:ifvr9MajV3I=:x1ItS9VfMM7nqO0811baQr
LRsOhqS/qgatNUCnClHisMGFTJncYrtWYxW6GZDg3oPtdBJ66vqr82geSaLYfWhqA95ln8RVI
jA4US59d0FQy3dX0OKjsBf9YVmoq0MkxlEYCKv1hKiMoP4Pw2gN/qWltDukkSbLDkCsyvgDPR
nnIyhbaueBWAOt9tg6hkt5B1bdnG4CEJVJTjWKc10OaRII8SvvJDg3FvGioHKUt4QGq8bsGJm
UjsMQGVpZng+ukuPkq1NfaR2JJlTFkgY7Nb61xfr1OhnF3bU9Zgp+H8TY6Xqs1NIe7u6PBBT0
ouIVMhrKJJJHCch74sFAOT6s9SyJPdEJKnXGzZnHhAP7SCb4m59zTWYLVaAkDoX01jVO/OCRD
F6wrrsGauo7Qw1FQ6RgrTpuf6ZXhNc+YxcTyMM2458sdVfCyB5nlkoDGwKdGje86KZBHaRFq/
Zm/5bNPjF25Xh0ebuf+Lmd0VN3VIo0zzI1Q1MMU+uar1MuCfwVBz74EYQ92uA1SaFMgTMPjNq
vbPOg3hIUXWL4i3Amoce1TQqGYp007GsCv4I8MEmDLQXAldg4BPj9v903BtqjN9SXO1zH3iYp
50XImM+WTDM+qVbEJvgUa/5hUsXrARWudOuNpT53edYJ9dl1MLNBs/CoYBObJ8/1C3mYcytZK
Qby/DDA1eKKJvAH/EMzrqBU+dq6PvJqlH15yEoH2ihFgyGG7lhXMFuNkM9Mvf4nyY0SzVO1GW
MGkqiJqK+AJOLL8y476vx/uuo+mt6Sp3iMk2AjsY/ekw//HFSann7Y+mR9pUtr5DklodE021d
gOt0GNqGOvjR8qTr7qfXQtvQqybrRd3a6LvIp/EfBbFrdaqi//lam66BHfm5Kciar8q58KaC1
DWnHr1ToGiznhn2HKGjKpArOcRJ1ZUZo/AI3A1veYCaHTdTZRyWWVZhm9ZEN2XmYPwiqAb4or
kdXK6kyrF+w==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Thanks for the patch. I'll have a look.
Ulf
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
In-Reply-To: <23640.9851.562972.730234@HIDDEN>
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 15 Feb 2019 17:18:01 +0000
Resent-Message-ID: <handler.34315.B34315.155025105229976 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.155025105229976
(code B ref 34315); Fri, 15 Feb 2019 17:18:01 +0000
Received: (at 34315) by debbugs.gnu.org; 15 Feb 2019 17:17:32 +0000
Received: from localhost ([127.0.0.1]:49761 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1guh7D-0007nQ-Nc
for submit <at> debbugs.gnu.org; Fri, 15 Feb 2019 12:17:31 -0500
Received: from mout.web.de ([217.72.192.78]:49483)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1guh7B-0007nA-P0
for 34315 <at> debbugs.gnu.org; Fri, 15 Feb 2019 12:17:30 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1550251043;
bh=DmTjZp4brBkGBzGUhwJVbmXAqV4M8V7GQwbvc4bVEc8=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date;
b=iz9oPHUaITEdHdtpyfAWQCQIPqfJVp+paHYDiboinSRM4G72KUMbEfoKppBmaRdtc
IUyVzJDSg6fQDhg8/Jl633R9VkuEfS1wVGGhxZl/ZQ7VHOyiWaF5BF3DNz4EVddASg
ktgCXlBWJrduU+7h+HbxLQXrDd8IsULXmLg0vg14=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([217.226.70.68]) by smtp.web.de (mrweb101
[213.165.67.124]) with ESMTPSA (Nemesis) id 0M41Bm-1hBXXc3v86-00rZHT; Fri, 15
Feb 2019 18:17:23 +0100
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
Date: Fri, 15 Feb 2019 18:17:19 +0100
Message-ID: <87wom1otsw.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:07D9Yzo17GaaHG8T4c+keK1pATYnXwyrz6BKJfqce3R5Ka6m3eH
xpgh5747AsP9ms/zh1carCHIl/KOrOGFQM77VPyIazubavuPRfzT9u2prEvqSHrv3v70hFj
ih37TbKW08egjHGHpEtMUjzE5nI+h8L4C68SmNP3+GrohSBJogeKcSDoDemjM2Lbc/18Z6D
j1crF7VRqqxqNBPZfX+Jg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:Ox/Jy3DQyFU=:UILobjdMsZkhCb/bdiAHRL
hfaWiQ+RrCKmnDNDUJeaDJBetqNUbJHzZYxnvY7kYEzgySewEdN2EjTVxq/wcslzArfrtr3iH
+49ESAByN0L6KAJdf2p5WZqIFSskn/ACRs5+y03fGzq0sQ/CmqfhgVUvb+UV3DZxgHBgHIjKX
51gn1b7ADmGL+LzyiE6ug47Bszrs5E8F2UKZJH6dN7ldpmYBiJz/+0hKP7lEwk0tIJuyztdvj
pIyblRVPCVDmDb7aegaVG6/LDpo2TW1RhfGw+E2ISxkD1D9oqmXiU/Lce+ZlXAj0sQE3+fDbY
DwUmrm0/ycUggffqHbuzE8FrtIcgIGQy5pXhKXlo7TVMB0mkRIdagXdQWQ+0KB/xGNW/4ZIKF
9YNygCLe26o8lhiLlu2Zhh5iM/oqsCkFZjGAXqfzUEbP1Njpt5GBcqdrBll8sUFDdfoEFX3Sq
dzIP/ykrPRkqHO3LQg+8xndQOAo+dLdOQun1mJ9Lhkmz1uDCskvvsFWsXBWsp1JyAAiTF6Fi9
lr1CM5P/lkbxFZjqFQpgy/ba8xV5cSlO9L/0CsjzwMu9tRV0+mpJb7NNuusvZ0eseH7dIbkda
ZxYhi8V4a3CZwqZt/OieKUn7tbCB4SB9kn6WOJM8L01tCW7vQE3Wp1H/oJzyP2H3NbKo6z+X2
OxEe1sX4Ba0S4WVFoxaN4S6CgSDvIEWDDIwrIgNT4gMczKo9yv2JKdHgaOqo4ZpGYYyxajYlz
gyCSS+B0YM4hpO8aFTg/BLzcJ6Q9/Drepc8s3wWygxDkSLaWLUb2Dg1YryENXjVQCVrz2xO0l
GG+tu+WYuKXxVI1mZQS4QMbrHIk9oRW22Rl2bF3lukRe9h8EMMaGCKTdN4eKvj7zOTgte04Is
rQUs1Rw5KvEQNRJ/xgzeBhu9+/kDRS36YGPMt9dN/V5jyKY/xwqg1Ah1EjsqzlMWtrbIyWryc
SvK8geVMpew==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Thomas,
the patch looks good so far. Could you please provide some testcases so
that I can add some unit tests?
Best,
ulf
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 18 Feb 2019 09:37:02 +0000
Resent-Message-ID: <handler.34315.B34315.155048261110440 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: 34315 <at> debbugs.gnu.org
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.155048261110440
(code B ref 34315); Mon, 18 Feb 2019 09:37:02 +0000
Received: (at 34315) by debbugs.gnu.org; 18 Feb 2019 09:36:51 +0000
Received: from localhost ([127.0.0.1]:52097 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gvfM2-0002iK-TE
for submit <at> debbugs.gnu.org; Mon, 18 Feb 2019 04:36:51 -0500
Received: from vsmx009.vodafonemail.xion.oxcs.net ([153.92.174.87]:39134)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1gvfM1-0002i5-1V
for 34315 <at> debbugs.gnu.org; Mon, 18 Feb 2019 04:36:50 -0500
Received: from vsmx001.vodafonemail.xion.oxcs.net (unknown [192.168.75.191])
by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTP id 8EA16C0152;
Mon, 18 Feb 2019 09:36:42 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.205.23.198])
by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTPA id E12D730008C;
Mon, 18 Feb 2019 09:36:35 +0000 (UTC)
Message-ID: <23658.31901.831381.517915@HIDDEN>
Date: Mon, 18 Feb 2019 10:36:29 +0100
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="XqqZEn2pcU"
Content-Transfer-Encoding: 7bit
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Friday, February 15 2019 18:17:19
(ID: <87wom1otsw.fsf@panama>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama>
X-VADE-STATUS: LEGIT
X-Spam-Score: -0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)
--XqqZEn2pcU
Content-Type: text/plain; charset=us-ascii
Content-Description: message body text
Content-Transfer-Encoding: 7bit
[specific Emacs behaviour/bug question at end, list subscribers please read on]
Ulf Jasper wrote at 18:17 on February 15, 2019:
: the patch looks good so far. Could you please provide some testcases
thanks. A set of iCalendar files is in the attached archive
along with a README and a slightly cleaner version of the patch.
However, for unit testing, you'd need to not only consider the
data but the OS, too. What follows is not only meant as a reply
to your request but is also a question for the Emacs maintainers.
The date-time that prompted me to look at this in detail is Sat,
Nov 3 2018 20:15 Europe/Berlin local time, the OS is Windows (7).
I made tests with two pre-built binaries, the official GNU 26.1:
(emacs-version)
"GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
of 2018-05-30"
and an older "SourceForge" 25.3 build.
I don't know what makes Sat, Nov 3 2018 (and the weekdays preceding
it) so peculiar, but my hunch is its proximity to the DST transition
that occured on the Sunday six days earlier, the "fifth week" of Oct.
The decode/encode combo in the forms below is essentially the
guts of icalendar--decode-isodatetime(), old and patched. The
zone rule for Europe/Berlin is the current standard one, also
computed by icalendar--convert-tz-offset().
The point of these examples is to see how time zone rules
missing/supplied/in environment affect date-time conversions.
Here's code for a same-zone scenario, note the two TZ setenv()s:
(let ((Europe/Berlin "STD-01:00DST-02:00,M3.5.0/02:00:00,M10.5.0/03:00:00"))
;; force Windows behaviour, usually no TZ set
(setenv "TZ")
(print (decode-time (encode-time 0 15 20 3 11 2018 )))
(print (decode-time (encode-time 0 15 20 3 11 2018 Europe/Berlin) ))
(print (decode-time (encode-time 0 15 20 3 11 2018 Europe/Berlin) Europe/Berlin))
;; force Unixoid/POSIX? behaviour
(setenv "TZ" Europe/Berlin)
(print (decode-time (encode-time 0 15 20 3 11 2018 )))
(print (decode-time (encode-time 0 15 20 3 11 2018 Europe/Berlin) ))
(print (decode-time (encode-time 0 15 20 3 11 2018 Europe/Berlin) Europe/Berlin))
nil)
Official Windows-26.1 evals to (comments by me):
(0 15 20 3 11 2018 6 nil 3600) ; correct, no-brainer
(0 15 19 3 11 2018 6 nil 3600) ; wrong: 19:15?!
(0 15 20 3 11 2018 6 t 7200) ; "less" wrong: DST is on?!
(0 15 20 3 11 2018 6 t 7200) ; "less" wrong: DST is on?!
(0 15 20 3 11 2018 6 t 7200) ; "less" wrong: DST is on?!
(0 15 20 3 11 2018 6 t 7200) ; "less" wrong: DST is on?!
SourceForge 25.3 performs slightly better:
(0 15 20 3 11 2018 6 nil 3600) ; correct
(0 15 19 3 11 2018 6 nil 3600) ; wrong: 19:15?!
(0 15 20 3 11 2018 6 t 7200) ; "less" wrong: DST is on?!
(0 15 20 3 11 2018 6 nil 3600) ; correct
(0 15 20 3 11 2018 6 nil 3600) ; correct
(0 15 20 3 11 2018 6 nil 3600) ; correct
Never mind the DST weirdness, I can live with this behaviour as
producing the desired 20:15 is possible in a predictable fashion.
But it get's even weirder.
Consider the following different-zone conversion.
America/Creston is UTC-7, adding UTC+1 for Europe/Berlin makes an
8 hour difference. So, Berlin 20:15 is Creston 12:15, see also
https://www.timeanddate.com/worldclock/converter.html?iso=20181103T191500&p1=37&p2=2274
Let's check:
(let ((Europe/Berlin "STD-01:00DST-02:00,M3.5.0/02:00:00,M10.5.0/03:00:00")
(America/Creston "STD+07:00"))
;; force Windows behaviour
(setenv "TZ")
(print (decode-time (encode-time 0 15 12 3 11 2018)))
(print (decode-time (encode-time 0 15 12 3 11 2018 America/Creston)))
(print (decode-time (encode-time 0 15 12 3 11 2018 America/Creston) Europe/Berlin))
;; force Unixoid/POSIX? behaviour
(setenv "TZ" Europe/Berlin)
(print (decode-time (encode-time 0 15 12 3 11 2018)))
(print (decode-time (encode-time 0 15 12 3 11 2018 America/Creston)))
(print (decode-time (encode-time 0 15 12 3 11 2018 America/Creston) Europe/Berlin))
nil)
Eval says (Official Windows-26.1):
(0 15 12 3 11 2018 6 nil 3600) ; correct (no conversion possible)
(0 15 20 3 11 2018 6 nil 3600) ; correct 20:15 with "their-zone" conversion only
(0 15 21 3 11 2018 6 t 7200) ; wrong: 21:15 with "their zone" + "my zone" conversion
(0 15 12 3 11 2018 6 nil 3600) ; correct (TZ in env applicable for decoding only)
(0 15 21 3 11 2018 6 t 7200) ; wrong time 21:15 + wrong DST=on
(0 15 21 3 11 2018 6 t 7200) ; wrong time 21:15 + wrong DST=on
SourceForge 25.3 is slightly different:
(0 15 12 3 11 2018 6 t 7200)
(0 15 20 3 11 2018 6 nil 3600)
(0 15 21 3 11 2018 6 t 7200)
(0 15 12 3 11 2018 6 nil 3600)
(0 15 21 3 11 2018 6 t 7200)
(0 15 21 3 11 2018 6 t 7200)
Things are fine again for dates following (Nov 4 etc.), ie.
when October's "fifth week" comes to an end.
If I remember correctly, Arch Linux pre-built 26.1 is always correct.
So, getting the desired 20:15 is dependent on - what? Is it possible
to drive decode-time/encode-time to always convert between time zones
correctly and if so, how? Is this a bug in Emacs or am I just
uninformed?
Thomas
--XqqZEn2pcU
Content-Type: application/zip;
name="icalendar019-patch+testcases.zip"
Content-Disposition: attachment;
filename="icalendar019-patch+testcases.zip"
Content-Transfer-Encoding: base64
UEsDBBQAAAAIAFlTUk5PC+3glwEAAL8DAAAGABwAUkVBRE1FVVQJAANZempc9U9pXHV4CwABBCAC
AAAEAQIDAK2ST2vbQBDF7wZ/hyGnBCxZcikkPdWNVDC0SVC3f/BFbKRRtGS9I3ZHDumn78gockp7
KLinXWZn5/3eY1RrAmw3d1CRY21cAA2d5qqFhjyYSlt0tfYxWkji9Aq0q6UjIAM1YK7HZ2AMDI2x
GOL57JvafM63tze59FVsSIaO07EGbtGjcfAkB3hkb3Av5cbTDlrm7t1yyT97b2PyDzJrPoMI8t5T
h+UH9Na4aJWkl2mavFFyeZskpaNSqi+k5aQemyrIdwBHMBUXEGgoqO0mE/lGKFyF4eA2U1/UulDL
TOU32WJKZJzhosB6UKihG3A8P8OP6HsRTW6fWiO5SZ7G7U0w9xaB6bcM/8nPX82Uh1DKF4TJ28R0
DP387LZnS/QowM8Wzy5OVpUdYfKDkUm3ol3nsUUXzB5fiRtX2b427gGOnyTninwdRo71Dodyee1l
aegVSbo6wf8fro9Q/0H3aKYssrXKT8phXJQ+IByGLWS7GIri66cDKre9e1y9116a4xrhXLW00wHu
rA7hAtLL6CPeD/RX89kvUEsDBBQAAAAIAJygUU66RsY8tAEAANgDAABGABwARXVyb3BlX0Jlcmxp
bi0yMDE4MTEwM1QyMDE1MDBfaW4tY2FsZW5kYXJfVlRJTUVaT05FX3R6dXJsX3N0YW5kYXJkLmlj
c1VUCQADV7BpXMRDaVx1eAsAAQQgAgAABAECAwCtk0FvozAQhe/+FVavDcGGRt24ysGA0yIBztom
Kr0g2tButBQqAof2168NW9rk0l3t3sbPD79PM4PHrsOEbH0asSSgAmyZkCFPiDNHYCN4EAbkuaj7
ogLe6FRhzO54woC603esb5uX0vbKttrXWkpFRH503Qux7e6tb6t50z7Zb01d7uvHxmr6rmqan/bx
V7dWFPpWxH2qTPLx5Zga0CwKr2+UTuDrtWRqLXhMzhFGaJIU14IzCAmNGfGZVCBQUlGhCF5eIuQ6
S2Uc2iNEGjGyFuz7KmNURNmVl8U8UTcrV1c6bmVhmQLdk4/sEUW/ZxoVnKI4pyj4M8oxCUbOQiH3
CxKMTlGmbHP4mMTvybAtSxTwIyol2aSebup76JWZ1eqoscRB+BvGyFW6WGiOQOlH/8SYTmPPR4d1
4si19FBUZb0r2nyizId9yA9dYfTdfP9wGPHijYlYIuxcKnyBLgwLk74IN8M67IquhCbBwthC7gx2
+2cjELyAqfLP8Qx+yoNTHiwOsC07APu2Lnfw/hX+5V7O4Bkf9TN46F6rEsg0jqnI/hXJAAH4f5CG
RRgHP5TTf/wLUEsDBBQAAAAIAKSgUU45F0TB2wIAACUKAABIABwARXVyb3BlX0Jlcmxpbi0yMDE4
MTEwM1QyMDE1MDBfaW4tY2FsZW5kYXJfVlRJTUVaT05FX3R6dXJsX2hpc3RvcmljYWwuaWNzVVQJ
AANjsGlc2EFpXHV4CwABBCACAAAEAQIDAK2WTXOiQBCG7/wK7olxPkAYUh5QxoQqPlwYU2sulqtu
YpXBFOJh8+u3R1ZEBndNbQ5W4UNXv+80PT0z4A9+5DwN3YBHnptoTzxJ/ThyyB3Sxkns+Z7zNs/2
8402KCOFH/LnOOKaeIZ3fJ9v31fdwSrfrDNAkyRwXovi3el2i499vrnb5i/dj222Wmc/t93z6O+d
wB92gnjoCql4/rJU89xp4D88Csgcj0YpF6MkDp0bhBGqkIgBkAOI3JA7Q54KzROpcBPhYGZjRAkT
MgJikmQScGeU8G/9KXeTYHo/mIZxJB77FJ5Art/B6USDWpy0SyuQTxbIa1ohTSu4bqXuhPUwIpZA
9B9OMGpaqbT/bgWZlNjXmbEZRQbCAqHSjOcKrtAW6S/4ILiHDIoEoXXlS9RCBu5VH+9IbaBmkxqo
9N6g9OzzH6kBsVShJlCiUHCGDYWCM9SrPuaRSme2EsuAoia1UZmBVLX+8o7D0HGyJLhR6lZqIfg1
FwSlZlhdJsFYFqpBKWQ0FApLb4k1MZaFalDpTPFgWEBNtdRAqUJZmxqUmhFFDRIwoqjZBKiyYpsC
VTzYBoIdo1ATYplCe60erFYPdqsaA6rUl6E2Dwy3eWCkTY3RthXDfmrxwMy6h08MCKVpab1pw3rX
wjY0ibrh2qmFoJPqfhqb6JIfev3AMsy2ul+gFuqd6v6JTa0M0IubGuYRVib3BQqNjy/Mc/nndJj/
Odz5E4+ENgzcNHXGkwGcz0fhe3nc98/OaIcgbMMgoAIeTMjvCUh6TeCkujnMyohOI2IGaDHfrLLl
PJ9VLmeHK8Xsdb0rtvka3t+tF7vSYDiWIgxhaG8shzu44ekw8ceHu8VyXqx0qdHBuIPorV6s3yRw
sKlPxPAG3+o1Rb1S1Oc7PV8Vmr7Ps9VS//FLv/JyA+kWm/1ynb3oJ7uQarHNlzstnYShm0z/15Y0
pelfZ+vQEmULHB6rS+FvUEsDBBQAAAAIAM9oUU7aDZvU9QAAAMABAAA6ABwARXVyb3BlX0Jlcmxp
bi0yMDE4MTEwM1QyMDE1MDBfbm9faW4tY2FsZW5kYXJfVlRJTUVaT05FLmljc1VUCQADRU5pXI89
aVx1eAsAAQQgAgAABAECAwCl0U1rgzAYB/B7PkWOG5gusS3bcosaRsA3kmi7XSRUD4IvQ+v3X1LX
Mtrjbg9/wu95ScA/RErLkMU8jZgEJZdKZCn1NxjkMotERHszLKYDR3SQSIuEf2Upp3yZxu/mJWim
rh1AsCq85KkGYcyUonkRxCIEkbYu9TF5IwRvtS32GNtUaSb1Q17YdqtcrTK6e1ENY2XTk+maoTZT
VV4H2rSneWWT3LHvmPivmuzwzrXjKpQi126x2pwb6FRECMJbD57b3gWU7D04jPCPDm+6B6/7AniZ
Cz4VOkTkGZp5XvqmBqpIEiY//8s7HMBH3h3x97yX8vZfP1BLAwQUAAAACAC4oFFOLWu1jZcBAAAN
BAAAUAAcAEFtZXJpY2FfQ3Jlc3Rvbi0yMDE4MTEwM1QxMjE1MDBfaW4tY2FsZW5kYXJfVlRJTUVa
T05FX3R6dXJsX2hpc3RvcmljYWxfUkRBVEUuaWNzVVQJAAOLsGlcQ0ZpXHV4CwABBCACAAAEAQID
AKWT306DMBTG7/sUfQAZPYgbq/Gig86Q8C+lLOoNwQ2VZGOGsQt9els2t8li1MhV+fqd/k75DhN+
60d05rKARx4TaMZF6scRtQYEJSL2fI+uinpbLNFk55R+yB/iiCP5oPbYqmyqeWG6Tblp17USMxHQ
l7Z9pabZvm+b5WDdPJvv67qs6qe12fffGYHvGkHsMqmp/e0dM5VM9+ap0+PpNOVyKuKQGmRkD4l9
EGWsJUKUELGQ0zCVyJOqVkgKjmMTICBJ9yDhMcnPVPUFjqwf0B3nBOwcwckpeAxDIGfgnvoHsNMH
f3fjMThkSKwz8Bf1C1i/HOPdx81nPJLIDVia0iSbqLQ+Edd6AG56iVGLgANALiVYcKUInlTH/s6a
Hecp33uMnievamNeLMt6UTT5ode8G7T8pVIlunqZd7cdVPPNrtkw0bAxAWskwSa27ounrvCTbuoW
RVtiTTIADHJ5gdtqVWKwKFzhTLrG6AKfcPGBi4sNbsoW4W1Tlwv8+IZ/P/hpFoZM3P+XrckI/5Hd
Bb0Ltlsefv4PUEsDBBQAAAAIALSgUU7NmN5dZwEAABMDAABIABwAQW1lcmljYV9DcmVzdG9uLTIw
MTgxMTAzVDEyMTUwMF9pbi1jYWxlbmRhcl9WVElNRVpPTkVfdHp1cmxfc3RhbmRhcmQuaWNzVVQJ
AAODsGlcMkVpXHV4CwABBCACAAAEAQIDAKWTyW6DMBCG734KP0AcbJIojaseCDgVEpvARG0uiAba
ohKowByap68NKak4dfHJnu3/Zkbesnvbo3vTcJhnGSHYszCyfY/qcwyC0Ldsi57SqktLsB0iue2y
g+8xwA/SZ5zypjimmtnkragraYxDh74K8U41TZy7ppzXzYt2rqu8qJ5rVHeirOs3bZr3gBzbRI5v
GlypT92DdsQNxWhJFX+3ixjfhb5LEV5jPJq4Pxo8w2XUjTiwuMwMOSUb6SCYcNwfIDu+1lSPa3OX
ZtmeeRyYjhFFNIi3kvGr2K1q/27CSXVMbgjBC050spIKFpdlfxYaX6eZXGLQJCYpKnRMy7zK0iYZ
WZN+zEkrUmXP5sWxHSDdQIlsMNHXnCzxUvGwyAztoJ9xloocKgVECMKLGRTFKYdEp2QFY26i9Qx+
04OjHkxb2OQCwK6p8gw+fcDfrzuKXdcIH//LoAgA/CNDv/Bhwf11/AKfUEsDBBQAAAAIALGgT045
r7dvegcAAEIWAAASABwAaWNhbGVuZGFyLmVsLnBhdGNoVVQJAAN+DWdcuQxnXHV4CwABBOgDAwAE
AQIDAKVYbXPaSBL+bP2KDlt3FoGhJBzenKpLfDbOUuXEu4Cvbl37YQdpANVJIzwjnPL++uuekZDA
ioMTVcXGot/76bcwxiAKeCxkyFVHxJ0znweiv1yMFuJssFyK3oD+DcNB1+u9G/SCJfeCRU/0Trqe
P2Jel/k98EfnXu/cG3R872w46vU9D1qe73lOq9Xak37A1Bud++86o7NRv+/7O6aPH4H1umftEbTo
l+/Bx48OALixyN6C66bLpRZZloIbcIU/whB/cq0f4HR+f3t9PRvP57fA40hnTXwcOIGcZ6nS5AWu
6+nt5wM+pbaxYI883ooaxun07mZc4WhB8bgq5JlgG6SU4Y786mJekEOWawgznXGV1Ui/ms/mF9N5
RT5DepmyUCO5eNjyGHaxKB00hGTD+/dwPfnv5/E5LFMFMv0KXwWkMn6CNRoVC8jNRwNlmoG1bi2U
6DitiiLk3TnzktLc/VJrthawUUILGaDeJSrKdUQa0MNtIkJAIaFA7cJQLyOFGkP+ROT04klw5diA
fl0LaaO5U78LHZlYSZS1nOKbJyMHjqEBdwdIxvQmjrKcqyLBpsawLpV4oNyUabmejn+3xOSzAWt/
1Pa7iNaB1/bPDFodTKxYbiVUlG240qggixLxdyrREJtYsrIx3yoJHP4zn3we399+GcPFzWQ2h0ii
mxyCVGpwJ1fQgfk9m82nky+fmpilS3wfhULZrFLAkhQDqEQgJMURw6o3IoiWaEUWpbLjwFRkpEpG
MUQY48KWgEvCwAIzRlaGnUa14rK/WRTuBQ4tehQqYzpTkVwxBBiLkk2qMgeePVW+lciYeETr2Eal
G5TwZOFNRTi5KjCOCIij1TorAh+EVBsHYoJ1FIcKQZELuLr442by6de5heKxUihgzAaMpQst1CMn
uNbJBCvTgrAUXhMVjJcFaUmWFb4hZIk4fJVv2Ai+XF1Mr3a+HSXlZd/2ZIKRGVrfSuEv+rYjQzBZ
ITbbSyvFggaFknTXQNi8siUzPGv3sWKGvXZ3aCrm5AQrrtFukC+K4tYs/yIhJOXENEnzl1XotJ6X
2Que24oDvV2gO8nGdKxGXhFUPTFWDH5f4aDOObv7N7u8/fwbFGgAeplHD6swL1W9V78b7Gkyi3iM
hYm+ZzySWCiwRv2pImupSlMVaqy01nvTMT+cQ6NSvw3Q63Qbh1SUSqBp0aMA0w5W+Ema8iYHqEix
RskhrGSZ6e+haed+0bJdep0PL4pwMcdcjQUNpeDKfMPnl1M35ski5BhWWDT3v6y2XTIhb0k7DllD
X/tU7fkuLdl7LDE16PiBsHs0R86X8I2Z1YUvm2N9qZFltoNEJA92/m+acOoWc98My+aPC7cayrVi
c7CjvOaRr+A8zYfCSgmEqHpZrct32MA6RtzGUMVLaT1/WcziSDGL5rfkuAdmw86yQnYzf5xW3Xgv
GiTqZsVcrdaiHfSXlgrIwpIqsv1ncnlxM6a2kg/+vGJxbI95sAYRi4TsyZcjW82m79QuCG3Tafte
t43bdqvf7bf9vNWapkrrTBoA9miygSGqi6Za41yIzSoULNIptR0yHD0r/7Chg3+mG1ozsLlh/2Z6
HS0zu4r+yENW/QT4dbpVgWAk5ceF4Pa6jTNmTYFyWExmt1Sc1O1tsCmDOCsSnkEc/U/AX3nAKDin
mL887RrMCYLsbNj3fGrn44QHGhXZTTmzexrAZOnUaMm3OUTM3fwSbBoyxaOYoo/tFnEL901ChwPW
gtBSIUrs1MiRFqc0gsxX5NwbUghF9hxaAnkiSBrOPDb7dXJtBpxMJaPNkSTY0NBbk2dUtHgqqR1C
gO44jIZhm1ZN3PcecVcN28RCAgr0t8kmLp+K+G0lbrQ4JVMj8S+8HiqBZE5rdns3vRwfIdgMbxMF
ik7xTdtpvUJfazqe3d3Mj9VmmAttNkLfUXeAk/x0SpAx2uCxgsM34UwLSgjF2JwnurIZYB9Jv4rw
jd3XqxWb6BU8K9GmJVs+/8Y2izO/PcBe0Ru2h/nVbZ/K+eX+iya7XGXrGvHg95o1J4A5CwmyBYBV
fhnW3Qs0tNbogj02P9yjWiVqLCZdxa2b8+Fa+mAAbc7r1uE3lZ4ANYtCpdqhcj4a4w3ICQASR4HW
XD1VgoOvy4a374ldzpLwiYZQnhucMCtcArlk1A0YX+g03uIyZzLwrkv/8dHHU3I/A1U/6ArBzxJT
4APKbj6LuaWj8zmn61q6A68CM+sMWot2YU59CnIZ2OKkf/PhTcVpnDlhRA2DBVwLs0jt9Xq3Am1w
K2UFWhAvJJFErwGhbPZ9vF3JUGOzabgHzf9n5FUS33zW1HcKhFKp2oskrmaY65XAuW0PZGsD/Nn4
h/6z0fhGfVUjvMYr17QGivECqTqdjk30yKNED/wB/noh0TjXfWY+7GePaHAVzYI1W4hVJM158a5Z
6ja85hCjZO4LpxvtkLfXfD6rq1a8hQG4iBfsAHhB5CVIAdgqM7TyNvL6ef/Mkn6NJcdKwQpD/m8s
eVV3vu/Jq7aGOid+REBp/xEpG9T0WusjFcFRTr7GxBovh03n/1BLAQIeAxQAAAAIAFlTUk5PC+3g
lwEAAL8DAAAGABgAAAAAAAEAAAD4gQAAAABSRUFETUVVVAUAA1l6alx1eAsAAQQgAgAABAECAwBQ
SwECHgMUAAAACACcoFFOukbGPLQBAADYAwAARgAYAAAAAAABAAAA+IHXAQAARXVyb3BlX0Jlcmxp
bi0yMDE4MTEwM1QyMDE1MDBfaW4tY2FsZW5kYXJfVlRJTUVaT05FX3R6dXJsX3N0YW5kYXJkLmlj
c1VUBQADV7BpXHV4CwABBCACAAAEAQIDAFBLAQIeAxQAAAAIAKSgUU45F0TB2wIAACUKAABIABgA
AAAAAAEAAAD4gQsEAABFdXJvcGVfQmVybGluLTIwMTgxMTAzVDIwMTUwMF9pbi1jYWxlbmRhcl9W
VElNRVpPTkVfdHp1cmxfaGlzdG9yaWNhbC5pY3NVVAUAA2OwaVx1eAsAAQQgAgAABAECAwBQSwEC
HgMUAAAACADPaFFO2g2b1PUAAADAAQAAOgAYAAAAAAABAAAA+IFoBwAARXVyb3BlX0Jlcmxpbi0y
MDE4MTEwM1QyMDE1MDBfbm9faW4tY2FsZW5kYXJfVlRJTUVaT05FLmljc1VUBQADRU5pXHV4CwAB
BCACAAAEAQIDAFBLAQIeAxQAAAAIALigUU4ta7WNlwEAAA0EAABQABgAAAAAAAEAAAD4gdEIAABB
bWVyaWNhX0NyZXN0b24tMjAxODExMDNUMTIxNTAwX2luLWNhbGVuZGFyX1ZUSU1FWk9ORV90enVy
bF9oaXN0b3JpY2FsX1JEQVRFLmljc1VUBQADi7BpXHV4CwABBCACAAAEAQIDAFBLAQIeAxQAAAAI
ALSgUU7NmN5dZwEAABMDAABIABgAAAAAAAEAAAD4gfIKAABBbWVyaWNhX0NyZXN0b24tMjAxODEx
MDNUMTIxNTAwX2luLWNhbGVuZGFyX1ZUSU1FWk9ORV90enVybF9zdGFuZGFyZC5pY3NVVAUAA4Ow
aVx1eAsAAQQgAgAABAECAwBQSwECHgMUAAAACACxoE9OOa+3b3oHAABCFgAAEgAYAAAAAAABAAAA
tIHbDAAAaWNhbGVuZGFyLmVsLnBhdGNoVVQFAAN+DWdcdXgLAAEE6AMDAAQBAgMAUEsFBgAAAAAH
AAcAYgMAAKEUAAAAAA==
--XqqZEn2pcU--
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 18 Feb 2019 16:00:02 +0000
Resent-Message-ID: <handler.34315.B34315.155050555323171 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Thomas Plass <thunk2@HIDDEN>
Cc: ulf.jasper@HIDDEN, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.155050555323171
(code B ref 34315); Mon, 18 Feb 2019 16:00:02 +0000
Received: (at 34315) by debbugs.gnu.org; 18 Feb 2019 15:59:13 +0000
Received: from localhost ([127.0.0.1]:53103 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gvlK4-00061f-Nb
for submit <at> debbugs.gnu.org; Mon, 18 Feb 2019 10:59:13 -0500
Received: from eggs.gnu.org ([209.51.188.92]:44765)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1gvlK3-00061T-DE
for 34315 <at> debbugs.gnu.org; Mon, 18 Feb 2019 10:59:11 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45976)
by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
id 1gvlJw-0001Bk-JC; Mon, 18 Feb 2019 10:59:04 -0500
Received: from [176.228.60.248] (port=1854 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
(Exim 4.82) (envelope-from <eliz@HIDDEN>)
id 1gvlJw-0003PZ-4b; Mon, 18 Feb 2019 10:59:04 -0500
Date: Mon, 18 Feb 2019 17:59:09 +0200
Message-Id: <83y36djdf6.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <23658.31901.831381.517915@HIDDEN> (thunk2@HIDDEN)
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <23658.31901.831381.517915@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
> Date: Mon, 18 Feb 2019 10:36:29 +0100
> From: thunk2@HIDDEN (Thomas Plass)
> Cc: 34315 <at> debbugs.gnu.org
>
> I don't know what makes Sat, Nov 3 2018 (and the weekdays preceding
> it) so peculiar, but my hunch is its proximity to the DST transition
> that occured on the Sunday six days earlier, the "fifth week" of Oct.
>
> The decode/encode combo in the forms below is essentially the
> guts of icalendar--decode-isodatetime(), old and patched. The
> zone rule for Europe/Berlin is the current standard one, also
> computed by icalendar--convert-tz-offset().
>
> The point of these examples is to see how time zone rules
> missing/supplied/in environment affect date-time conversions.
>
> Here's code for a same-zone scenario, note the two TZ setenv()s:
>
> (let ((Europe/Berlin "STD-01:00DST-02:00,M3.5.0/02:00:00,M10.5.0/03:00:00"))
You cannot expect MS-Windows to support Posix DST rules such as above
in the C runtime functions like mktime, localtime, etc. Windows
support for DST rules in C runtime is very rudimentary, and is limited
to the likes of EST-5DST, without any specification of when the DST
transitions happen (the transition dates are hard-coded in the Windows
C runtime).
I think this factoid goes a long way towards explaining why you get
wrong results for the timezone offset around the DST transition date.
To make myself clear: modern Windows systems do have database of DST
transition rules, and they do apply these rules both for setting the
system clock and in APIs such as GetTimeZoneInformation. But the
rules are not in Posix format (although the information is of course
equivalent), and these capabilities are not propagated to C runtime
functions which Emacs uses.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 18 Feb 2019 19:16:02 +0000
Resent-Message-ID: <handler.34315.B34315.15505173409053 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 34315 <at> debbugs.gnu.org
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.15505173409053
(code B ref 34315); Mon, 18 Feb 2019 19:16:02 +0000
Received: (at 34315) by debbugs.gnu.org; 18 Feb 2019 19:15:40 +0000
Received: from localhost ([127.0.0.1]:53208 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gvoOC-0002Lw-03
for submit <at> debbugs.gnu.org; Mon, 18 Feb 2019 14:15:40 -0500
Received: from vsmx011.vodafonemail.xion.oxcs.net ([153.92.174.89]:35650)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1gvoO9-0002Lc-Am
for 34315 <at> debbugs.gnu.org; Mon, 18 Feb 2019 14:15:38 -0500
Received: from vsmx003.vodafonemail.xion.oxcs.net (unknown [192.168.75.197])
by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTP id CE7A93E0119;
Mon, 18 Feb 2019 19:15:31 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.205.23.198])
by mta-7-out.mta.xion.oxcs.net (Postfix) with ESMTPA id BF7C2300158;
Mon, 18 Feb 2019 19:15:26 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <23659.1095.418799.313991@HIDDEN>
Date: Mon, 18 Feb 2019 20:15:19 +0100
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Monday, February 18 2019 17:59:09
(ID: <83y36djdf6.fsf@HIDDEN>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <23658.31901.831381.517915@HIDDEN>
<83y36djdf6.fsf@HIDDEN>
X-VADE-STATUS: LEGIT
X-Spam-Score: -0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)
Eli Zaretskii wrote at 17:59 on February 18, 2019:
: these capabilities are not propagated to C runtime
: functions which Emacs uses.
I take it then, Windows pre-built users have no way to work around
this in Elisp?
What about the C source? Is there any way for a total C-dummy like me
to tweak/hard wire a rule for my local zone into the source? Could
you point me at the file(s)/place(s) in the Git that I'd need to look
at?
It'll be daunting to do this on Windows. The last time I built an
emacs must have been jwz's lemacs under SunOS back in '93...
Thomas
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 18 Feb 2019 19:31:02 +0000
Resent-Message-ID: <handler.34315.B34315.155051823911780 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.155051823911780
(code B ref 34315); Mon, 18 Feb 2019 19:31:02 +0000
Received: (at 34315) by debbugs.gnu.org; 18 Feb 2019 19:30:39 +0000
Received: from localhost ([127.0.0.1]:53213 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gvoch-00033v-A8
for submit <at> debbugs.gnu.org; Mon, 18 Feb 2019 14:30:39 -0500
Received: from eggs.gnu.org ([209.51.188.92]:44102)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1gvoce-00033X-OQ
for 34315 <at> debbugs.gnu.org; Mon, 18 Feb 2019 14:30:37 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e]:50112)
by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
id 1gvocX-000068-Nk; Mon, 18 Feb 2019 14:30:29 -0500
Received: from [176.228.60.248] (port=3520 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
(Exim 4.82) (envelope-from <eliz@HIDDEN>)
id 1gvocW-0003bw-10; Mon, 18 Feb 2019 14:30:29 -0500
Date: Mon, 18 Feb 2019 21:30:33 +0200
Message-Id: <83ef84ki7a.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <23659.1095.418799.313991@HIDDEN> (thunk2@HIDDEN)
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <23658.31901.831381.517915@HIDDEN>
<83y36djdf6.fsf@HIDDEN> <23659.1095.418799.313991@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
> Date: Mon, 18 Feb 2019 20:15:19 +0100
> From: thunk2@HIDDEN (Thomas Plass)
> Cc: 34315 <at> debbugs.gnu.org
>
> Eli Zaretskii wrote at 17:59 on February 18, 2019:
> : these capabilities are not propagated to C runtime
> : functions which Emacs uses.
>
> I take it then, Windows pre-built users have no way to work around
> this in Elisp?
Not in Lisp, no.
> What about the C source? Is there any way for a total C-dummy like me
> to tweak/hard wire a rule for my local zone into the source? Could
> you point me at the file(s)/place(s) in the Git that I'd need to look
> at?
I don't understand what kind of C-level change do you have in mind.
AFAIU, any change to support this stuff would involve writing (or
importing from a free source) a parser for such DST rules, and then
using APIs like SetDynamicTimeZoneInformation to make the parsed rule
in effect. It would probably also mean replacing localtime and its
ilk with versions that actually access the DST data set by the above
APIs. Is that what you had in mind?
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 18 Feb 2019 20:04:02 +0000
Resent-Message-ID: <handler.34315.B34315.155052021616986 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 34315 <at> debbugs.gnu.org
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.155052021616986
(code B ref 34315); Mon, 18 Feb 2019 20:04:02 +0000
Received: (at 34315) by debbugs.gnu.org; 18 Feb 2019 20:03:36 +0000
Received: from localhost ([127.0.0.1]:53223 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gvp8Z-0004Pu-Ve
for submit <at> debbugs.gnu.org; Mon, 18 Feb 2019 15:03:36 -0500
Received: from vsmx011.vodafonemail.xion.oxcs.net ([153.92.174.89]:25244)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1gvp8X-0004Pa-Py
for 34315 <at> debbugs.gnu.org; Mon, 18 Feb 2019 15:03:34 -0500
Received: from vsmx003.vodafonemail.xion.oxcs.net (unknown [192.168.75.197])
by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTP id 2FE973E02E6;
Mon, 18 Feb 2019 20:03:28 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.205.23.198])
by mta-7-out.mta.xion.oxcs.net (Postfix) with ESMTPA id DE186300158;
Mon, 18 Feb 2019 20:03:22 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <23659.3971.287290.530810@HIDDEN>
Date: Mon, 18 Feb 2019 21:03:15 +0100
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Monday, February 18 2019 21:30:33
(ID: <83ef84ki7a.fsf@HIDDEN>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <23658.31901.831381.517915@HIDDEN>
<83y36djdf6.fsf@HIDDEN> <23659.1095.418799.313991@HIDDEN>
<83ef84ki7a.fsf@HIDDEN>
X-VADE-STATUS: LEGIT
X-Spam-Score: -0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)
Eli Zaretskii wrote at 21:30 on February 18, 2019:
:
: I don't understand what kind of C-level change do you have in mind.
To be frank, I have no idea whatsoever. If this is something that
hasn't bothered any maintainer enough to fix it, then it's probably no
use for a non-C+non-Windows-API guy like me to try.
All I could do is to lobby?
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 18 Feb 2019 20:17:01 +0000
Resent-Message-ID: <handler.34315.B34315.155052101619112 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.155052101619112
(code B ref 34315); Mon, 18 Feb 2019 20:17:01 +0000
Received: (at 34315) by debbugs.gnu.org; 18 Feb 2019 20:16:56 +0000
Received: from localhost ([127.0.0.1]:53238 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gvpLU-0004yC-04
for submit <at> debbugs.gnu.org; Mon, 18 Feb 2019 15:16:56 -0500
Received: from eggs.gnu.org ([209.51.188.92]:52106)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1gvpLS-0004xt-QK
for 34315 <at> debbugs.gnu.org; Mon, 18 Feb 2019 15:16:55 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e]:50632)
by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
id 1gvpLG-0002tY-Lj; Mon, 18 Feb 2019 15:16:44 -0500
Received: from [176.228.60.248] (port=2496 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
(Exim 4.82) (envelope-from <eliz@HIDDEN>)
id 1gvpLF-0007D6-Pf; Mon, 18 Feb 2019 15:16:42 -0500
Date: Mon, 18 Feb 2019 22:16:48 +0200
Message-Id: <83bm38kg27.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <23659.3971.287290.530810@HIDDEN> (thunk2@HIDDEN)
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <23658.31901.831381.517915@HIDDEN>
<83y36djdf6.fsf@HIDDEN> <23659.1095.418799.313991@HIDDEN>
<83ef84ki7a.fsf@HIDDEN> <23659.3971.287290.530810@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
> Date: Mon, 18 Feb 2019 21:03:15 +0100
> From: thunk2@HIDDEN (Thomas Plass)
> Cc: 34315 <at> debbugs.gnu.org
>
> All I could do is to lobby?
You could also file a wishlist bug report. Maybe someone will be
interested enough to do something like that, who knows.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 10 Aug 2020 11:49:02 +0000
Resent-Message-ID: <handler.34315.B34315.15970601053095 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: 34315 <at> debbugs.gnu.org, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.15970601053095
(code B ref 34315); Mon, 10 Aug 2020 11:49:02 +0000
Received: (at 34315) by debbugs.gnu.org; 10 Aug 2020 11:48:25 +0000
Received: from localhost ([127.0.0.1]:34720 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k56Hw-0000nq-Ru
for submit <at> debbugs.gnu.org; Mon, 10 Aug 2020 07:48:25 -0400
Received: from quimby.gnus.org ([95.216.78.240]:46774)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1k56Hw-0000nc-22
for 34315 <at> debbugs.gnu.org; Mon, 10 Aug 2020 07:48:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=0zq/fGCZUml68TU+i+YordW5l+n2i7J/8KYJgp87hcQ=; b=W4Fehs9VVzUNmz7DA8Y5bo81dH
lzb6414sQYlXLQH7kluAVlaItAagnzfXlFFFk21dHpPlaQ7xVnOC6TXhDDchsSbPjIriPxoSFroLq
tAhMYX6J/SmrMAEEfGIWDoenqNx2G5JLy0QLrvtdzBJ6nSQmxzYEopHQY0Fh2rUyu8i0=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1k56Hn-0003VC-1z; Mon, 10 Aug 2020 13:48:17 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama>
Date: Mon, 10 Aug 2020 13:48:13 +0200
In-Reply-To: <87wom1otsw.fsf@panama> (Ulf Jasper's message of "Fri, 15 Feb
2019 18:17:19 +0100")
Message-ID: <87zh7267sy.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Ulf Jasper <ulf.jasper@HIDDEN> writes: > Thomas,
> > the patch
looks good so far. Could you please provide some testcases so > that I can
add some unit tests? This was over a year ago.
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Ulf Jasper <ulf.jasper@HIDDEN> writes:
> Thomas,
>
> the patch looks good so far. Could you please provide some testcases so
> that I can add some unit tests?
This was over a year ago.
As far as I understand it, the patch itself is good and fixes a real
problem in icalendar date parsing? But then the thread turned towards
questions about daylight savings time handling in Windows, and the patch
itself wasn't applied?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 10 Aug 2020 16:09:01 +0000
Resent-Message-ID: <handler.34315.B34315.15970757293461 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
Cc: 34315 <at> debbugs.gnu.org, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.15970757293461
(code B ref 34315); Mon, 10 Aug 2020 16:09:01 +0000
Received: (at 34315) by debbugs.gnu.org; 10 Aug 2020 16:08:49 +0000
Received: from localhost ([127.0.0.1]:37301 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k5ALx-0000tl-7c
for submit <at> debbugs.gnu.org; Mon, 10 Aug 2020 12:08:49 -0400
Received: from mout.web.de ([212.227.17.11]:33135)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1k5ALt-0000tV-0I
for 34315 <at> debbugs.gnu.org; Mon, 10 Aug 2020 12:08:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1597075718;
bh=83Gg0dX9RsCi+FdkWXRWA/dYodKylcjaMNtUeyLDgOQ=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=WjFyw1qYpc68nKHA7yUYPqywjNxBu3bkoXccLxlHsuERTW0LBiaDOoIN8bPssRXf0
ryhT8WIa9arN9mQ/zcQN7bv8JADLwwQc72kEH8E1leufetQQVzWJeevBJbfVPQgz9B
iDC2dEvuE1XLJKe+ExnOUrGFZHaf9JCqm6Az5nHE=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.158.235.225]) by smtp.web.de (mrweb102
[213.165.67.124]) with ESMTPSA (Nemesis) id 0MUF4Q-1kEPmG0iB8-00R06B; Mon, 10
Aug 2020 18:08:38 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
Date: Mon, 10 Aug 2020 18:08:34 +0200
In-Reply-To: <87zh7267sy.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Mon,
10 Aug 2020 13:48:13 +0200")
Message-ID: <87pn7yo54t.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:+4OqIzCGFmBaUuXDMFMjx5RD3l0Mw+AlTw1l4YR/C+s8bMXl+WS
bJ8og7r8LeQ7/OlXbU0bRLlSsS5KiAbKsKgQfUulaPButy/wWZu+2NE8EAU6POxU9CUhLVt
GXCeu6EFb70B1NGugf61l8u/sgaPNvOtfg/XXxiVq2B8FS3FmH9HuuEcIM36BTPAVGxNgKh
uuq7wvG5jB1e1W9g/iw5g==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:wQmlIAhCu7g=:V1vMcxyf1wUCe6rLoayzFK
4nwc4nG3MLc1uH9X1Ql0k3wIletuwAc/8s9F0gP1894xpYGnow+H6VIouYqfRxBBs4sBdS41h
rnVFrq6Lw/VPUI5/PxjSg/eYZ/vj/OtlNb9aSMq2MjWmt0TLBZ2TZAXTyGJRsfnvaizvsfsIA
I8HQhofQ1t176K9kWBgXlfrVbE049WzkzHUy3fPJGlwvDx9JS4n7SnoTLVPVFkeaTj5tZSmMS
xhKDeksG8XiJMRGqwSpUhsYvFfkMCwAqxtdpbP1s/Mi2CvmDCRfcUXmsMrmW2Bjvq9SlRDrKf
IcsOJ5nrzJVv1LmHICbUxZiZb3SkNGnoM6B5MeHT/5h4b0JWpYCWBKvTCYfQVp8l8t1bzZf/1
09W1NaWMxx7mcU3EQ3wxDbMKSMnyQ6ytRZyRfjtcqalujnod4e3Ru4q19fWoqO4ZxfIEJEYzb
6jz50vjy55/Ic2I8gMTXpjQ7zFRx6vs0pzAGHwUJ3AfrCm7mDaAmcfV2q9drCbNki2ujXjW2y
k8ZwKvTuHBlbVnhRd/tVWuMxR3dqsGtBKtwOHulqb+ddu2f9DA1yZQHeG24uDa+UZw6oX1YTf
Hua9DzgWaUWrjIphC1f4I0qNYF6eM35IfhKvFzac2Kn8JqfixBEHQ04+FPVEMq0uIYQSBIbfz
Ez3nDaXCWgDyBjusIO+6sxyoZ8iyeqYeBGIW2mRXSLS6HHoEIffWSFUH7f90twPqY+dAWjH6h
sWBOBzJ/PPJNw+S5azqJeMRPlEXZsEX6Qawl46IunJpYhjQDPUYtozXhTUL/TqvlUhWBUPKDL
9I/grBlioNPQQYdE0xfpDXzSP2ehGsGDRSpnF5vnGrc84L29RxVj6zRfKeQdG5cJ2ZcCtiNMp
FXzb2MsQQezrkwm0VTEqjqWTAnN1Yge/Ji5yB+nmB6YYPmczF691aZtL6p/33gmzgrlB/iaU+
nRdkUdRkyIua/oH9eRviCbMsatBX+MjoOJ5FEFiMIfE5iYVb8guF1vZ1gSViW7nab1zC77g3/
HBdLBWixzLqo8RuW/uQ0sBBGUOXdg0DhUYmUi1mjcBe82Ll9JefQxmwGbyW70U+t39FrKOIlI
WPe7b/oVx3W2AwXO/1L3QPiY1mcfJcGaZLGg4jS+bknTzd74i2k0oQag0rP4k9IY50AcuT/5a
ln6P5uypPhdB1xV6FPVco8ZHnZdTSktRmLJFc04yRkgVrHcPDbq/O3Q1H0k4Qa/69mZ/ZamcL
lVf714Se69ijM63O3
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
It seems that I lost track of this issue. Sorry.
Am 10.08.2020 um 13:48 (+0200) schrieb Lars Ingebrigtsen:
> As far as I understand it, the patch itself is good and fixes a real
> problem in icalendar date parsing?
IIRC the patch looked good insofar as it appeared to address only the
observed problem and to be properly documented and formatted although I
was not able to reproduce the problem.
> But then the thread turned towards questions about daylight savings
> time handling in Windows, and the patch itself wasn't applied?
Right, the patch was not applied.
Eli pointed out that the root cause lies in the dst handling in
ms-windows (and not in newsticker). That makes the patch more of a
work-around than a fix.
I admit that I am not very much inclined to check and apply the patch as
I do not have a ms-windows box to run tests on.
Eli, what do you think?
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 10 Aug 2020 16:46:02 +0000
Resent-Message-ID: <handler.34315.B34315.15970779279199 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: larsi@HIDDEN, 34315 <at> debbugs.gnu.org, thunk2@HIDDEN
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.15970779279199
(code B ref 34315); Mon, 10 Aug 2020 16:46:02 +0000
Received: (at 34315) by debbugs.gnu.org; 10 Aug 2020 16:45:27 +0000
Received: from localhost ([127.0.0.1]:37354 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k5AvP-0002Nz-B2
for submit <at> debbugs.gnu.org; Mon, 10 Aug 2020 12:45:27 -0400
Received: from eggs.gnu.org ([209.51.188.92]:56680)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1k5AvL-0002F2-6r
for 34315 <at> debbugs.gnu.org; Mon, 10 Aug 2020 12:45:25 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:53810)
by eggs.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <eliz@HIDDEN>)
id 1k5AvE-000829-1E; Mon, 10 Aug 2020 12:45:16 -0400
Received: from [176.228.60.248] (port=4561 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
(Exim 4.82) (envelope-from <eliz@HIDDEN>)
id 1k5AvD-0002Mk-AP; Mon, 10 Aug 2020 12:45:15 -0400
Date: Mon, 10 Aug 2020 19:45:01 +0300
Message-Id: <83o8ni4fhu.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87pn7yo54t.fsf@panama> (message from Ulf Jasper on Mon, 10 Aug
2020 18:08:34 +0200)
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN> <87pn7yo54t.fsf@panama>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Ulf Jasper <ulf.jasper@HIDDEN>
> Cc: thunk2@HIDDEN (Thomas Plass), 34315 <at> debbugs.gnu.org
> Date: Mon, 10 Aug 2020 18:08:34 +0200
>
> IIRC the patch looked good insofar as it appeared to address only the
> observed problem and to be properly documented and formatted although I
> was not able to reproduce the problem.
>
> > But then the thread turned towards questions about daylight savings
> > time handling in Windows, and the patch itself wasn't applied?
>
> Right, the patch was not applied.
>
> Eli pointed out that the root cause lies in the dst handling in
> ms-windows (and not in newsticker). That makes the patch more of a
> work-around than a fix.
>
> I admit that I am not very much inclined to check and apply the patch as
> I do not have a ms-windows box to run tests on.
>
> Eli, what do you think?
My comments were not about the patch (which I admit I don't really
understand, as I don't use icalendar), but about the attempts to see
what happens with time under different TZ settings.
As for the patch, I've looked at it again now, and I don't think it's
specific to MS-Windows, is it? If so, and if you think it's good,
feel free to install.
Thanks.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 10 Aug 2020 17:05:02 +0000
Resent-Message-ID: <handler.34315.B34315.159707907526713 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: Ulf Jasper <ulf.jasper@HIDDEN>, larsi@HIDDEN, 34315 <at> debbugs.gnu.org
Reply-To: Thomas Plass <thomas.plass@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.159707907526713
(code B ref 34315); Mon, 10 Aug 2020 17:05:02 +0000
Received: (at 34315) by debbugs.gnu.org; 10 Aug 2020 17:04:35 +0000
Received: from localhost ([127.0.0.1]:37406 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k5BDu-0006wn-SD
for submit <at> debbugs.gnu.org; Mon, 10 Aug 2020 13:04:35 -0400
Received: from mx009.vodafonemail.xion.oxcs.net ([153.92.174.39]:14800)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1k5BDs-0006wY-0K
for 34315 <at> debbugs.gnu.org; Mon, 10 Aug 2020 13:04:33 -0400
Received: from vsmx002.vodafonemail.xion.oxcs.net (unknown [192.168.75.192])
by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTP id 9B24B605259;
Mon, 10 Aug 2020 17:04:26 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.205.18.233])
by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 02F9460524B;
Mon, 10 Aug 2020 17:04:17 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24369.32256.954408.774614@HIDDEN>
Date: Mon, 10 Aug 2020 19:04:00 +0200
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Monday, August 10 2020 19:45:01
(ID: <83o8ni4fhu.fsf@HIDDEN>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
X-VADE-STATUS: LEGIT
X-Spam-Score: -1.0 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.0 (---)
Eli Zaretskii wrote at 19:45 on August 10, 2020:
:
: As for the patch, I've looked at it again now, and I don't think it's
: specific to MS-Windows, is it?
Exactly, the patch has nothing to do with MS-Windows' DST handling
(though incidentally, it was developed while dealing with that issue).
It fixes general issues with icalendar.el's handling of timezones as
commonly used in ical data and the standard tzurl.org repo. It is
also completely backwards-compatible as far as I can make out.
Here's the README for the testcases I provided to Ulf along with the patch:
This ZIP contains a patch for icalendar.el 0.19 and a set of iCalendar test files.
VTIMEZONE sections contained therein were retrieved from http://tzurl.org.
- Europe_Berlin-20181103T201500_no_in-calendar_VTIMEZONE.ics
no VTIMEZONE, so no TZID references for DTSTART/DTEND, contains
non-standard property X-WR-TIMEZONE which is invisible to icalendar.el
- Europe_Berlin-20181103T201500_in-calendar_VTIMEZONE_tzurl_standard.ics
standard VTIMEZONE ("Outlook-style")
- Europe_Berlin-20181103T201500_in-calendar_VTIMEZONE_tzurl_historical.ics
comprehensive VTIMEZONE including historical records
- America_Creston-20181103T121500_in-calendar_VTIMEZONE_tzurl_standard.ics
standard ("Outlook-style") VTIMEZONE
- America_Creston-20181103T121500_in-calendar_VTIMEZONE_tzurl_historical_RDATE.ics
comprehensive VTIMEZONE including historical records which use RDATE, not RRULE
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 11 Aug 2020 11:02:01 +0000
Resent-Message-ID: <handler.34315.B34315.159714368621587 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: Thomas Plass <thomas.plass@HIDDEN>, Ulf Jasper <ulf.jasper@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.159714368621587
(code B ref 34315); Tue, 11 Aug 2020 11:02:01 +0000
Received: (at 34315) by debbugs.gnu.org; 11 Aug 2020 11:01:26 +0000
Received: from localhost ([127.0.0.1]:38783 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k5S22-0005c7-Cl
for submit <at> debbugs.gnu.org; Tue, 11 Aug 2020 07:01:26 -0400
Received: from quimby.gnus.org ([95.216.78.240]:58904)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1k5S1z-0005bt-Hb
for 34315 <at> debbugs.gnu.org; Tue, 11 Aug 2020 07:01:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=qmp84nCS/LZViCKyijFg7vYn7esYIjWGRyZikVQZHIs=; b=IdLk/QWGl+oXy9zBAJ853aktFU
+0oIT+n3SC1zlguNRqLlY8HdiQX/dgfMn0jPRSMYD0C3N7jWsY7ekNMTtQTBrm9ScNOLgkzDCDRzt
eRmQVgBeuS3OiVj+wWld4WR1mVAd9HRUKLsFaZJNgyUjqsKTTxUmmgFBIWPJYAyBsUgM=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1k5S1m-0002bV-H8; Tue, 11 Aug 2020 13:01:16 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN>
Date: Tue, 11 Aug 2020 13:01:08 +0200
In-Reply-To: <24369.32256.954408.774614@HIDDEN> (Thomas Plass's message
of "Mon, 10 Aug 2020 19:04:00 +0200")
Message-ID: <87y2mlxx8r.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: thunk2@HIDDEN (Thomas Plass) writes: > It fixes general
issues with icalendar.el's handling of timezones as > commonly used in ical
data and the standard tzurl.org repo. It is > also completely
backwards-compatible as far as I can make o [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
thunk2@HIDDEN (Thomas Plass) writes:
> It fixes general issues with icalendar.el's handling of timezones as
> commonly used in ical data and the standard tzurl.org repo. It is
> also completely backwards-compatible as far as I can make out.
>
> Here's the README for the testcases I provided to Ulf along with the patch:
Can you respin the patch and add the test cases to
test/lisp/calendar/icalendar-tests.el? The icalendar test files should
go to a new test/data/icalendar directory, I guess.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 11 Aug 2020 15:15:01 +0000
Resent-Message-ID: <handler.34315.B34315.159715889226962 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Thomas Plass <thomas.plass@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.159715889226962
(code B ref 34315); Tue, 11 Aug 2020 15:15:01 +0000
Received: (at 34315) by debbugs.gnu.org; 11 Aug 2020 15:14:52 +0000
Received: from localhost ([127.0.0.1]:41426 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k5VzH-00070n-OS
for submit <at> debbugs.gnu.org; Tue, 11 Aug 2020 11:14:51 -0400
Received: from mout.web.de ([212.227.15.4]:57255)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1k5VzD-00070W-0a
for 34315 <at> debbugs.gnu.org; Tue, 11 Aug 2020 11:14:51 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1597158880;
bh=UgxclSttCuF4fZnaPf94p/n0HSsvrBKRlRowEWJd8/c=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=lfXY5uomzpSqlZhvQFNZlBoWJXj47V5VzccbpLlSbkr6Vcbj6b/WTCVLJ+HYjelCO
nbbl/9ozBQuZ5Z8WQelYwuBViZ1LdXoUfzUhQ5X7YDZQYoQ20noxcZLHk8mPyikuHv
RW4kave/hPgleLg+NK42yv25x6gFvAVIoCmhSDWw=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.158.235.225]) by smtp.web.de (mrweb004
[213.165.67.108]) with ESMTPSA (Nemesis) id 0MQL8O-1kHeVo0Z3c-00To2p; Tue, 11
Aug 2020 17:14:40 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
Date: Tue, 11 Aug 2020 17:14:36 +0200
In-Reply-To: <87y2mlxx8r.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Tue,
11 Aug 2020 13:01:08 +0200")
Message-ID: <87d03x43kz.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:vxTfy3s9hbKD1C2cdJ/sQe3D520mPQhVh6AzedV6QdNM1DyiESG
M9j69kpCfnLqVWSjfrJAoyxAZqINrSTfEh7FCD01oIKQwalV0gkIG/D227UNSQLCmHgbfKJ
VDAHw/q0TYwQ316vg9r1iqwXpDso4r9JkkcmdeCdvEhmCLWyg+VRBi0XEcdJqRZBC2Ssx4q
X456MGWPCPvfPLSD5DwVw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:2RwpGpRe2mo=:BsqWwv0F67SSpEOyqMxmX+
bXSDeAPn8cfcGkgdlrQd7Q5FKt7mJittjDxDgboECb6gDvrIcdWkCmo8rxSvyhuJHV04271WJ
tbQqpxlms+aTPx070wVl3xfBjdEOnnzdU0kugqx+liRPiNt928fVCz/QUTLxbMzh5+49jCRZ3
vapew5p3pX8VLpHl1uAhGpoPo0eF+wYLi5THsvW4G3rQc4+klrxBUnmI5f40Jy5E/bop9sMjI
NcAewghLWjULB63PMC1VP6uRongrO55aQRwSyiLjcoPh3usp7bOUpUKel2syEivtfXDnxK2wE
4XCHPEhghtU3axnh+24JDEF2CDlr6oxbon62vPhqh789SyhV4i14kX0ZMujcHyk1Y+T9F2IR8
/knkdTa5usSUowIc07CL5EeZusTcEdOC2DGDhg4JoKd4T77S4CoZLXt3f2vrPSxSNLQlIAlSg
8Ul5q8Miee9vZzvxAp+e4Zfj0t4amvNEP0YvXjA6dm9r+NomfjobJhYQ+4UYvDe+fu+CxDHFM
BTxQM7WCP4o4GdNaEvJdYddZoq+7QlA75u9JWRASYB0JnbsfOaGSoPzm6aQLLNBmao8uM+S3O
pm5R7SsEwug1gwVnVU8mHX+/vbJJvmoN4WcPVaIrvANbZCndHsyoCqxb4Mqu+fzIE6b8JQjXI
ODAHMeiTTs/1pAaOsTE7AcAS2l88bBprOawM51nsxJ3wK31nRVstp8rRueC+4CjdB36DMpBpv
qFuC12T68xU1GsfB87AtAiOfTp5vEXhzadKKVTO2osmbJVsh9QU07LE326Nw4ozsWbybvGsGS
8VqmcwPRGtoT5Ovr67hW+J2+CzHYPNM7agY84t5AdzkD8ir+OiEdyKlgoGglY1yUfK2imDAl9
iKyIAjI02cDYXfcUnxu+Ws+9ECRn9oZ3ZU2Ht51UF7QhsOeQgunUPpX0UgjIdSVNiy6nECsOW
i1iRbSb5UgXEbWiirarX2xcIZ7B5sA3OPVi5+5h+I9OhbeL1Qc5AdL9lMHkIMwS3dgQLDMivP
gjKuk/tWEMh696Iea5Bjtx8d2e7Y7D0Tu3nLAPBiNAg+61/5W28pLLOt0j99Osk2lZiVP0ugQ
c07C5yqayqOYFfMO6qzRqEAcgWfhFGOnwR6R9uLPC4QCKQizEmL33LSRNQc2G7HkzhVOhz52X
M9dHTQZE4RoZk0j/Xhz1mEQ8NRjb3vid9VONoSCGI6WwBvaoUsXItWRdpLZe6Sp+Wiq03E0b4
cgDVB5Q82IPc7EXuAvLMvsrfjULjOUncTwg63hg==
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Am 11.08.2020 um 13:01 (+0200) schrieb Lars Ingebrigtsen:
> thunk2@HIDDEN (Thomas Plass) writes:
>
>> It fixes general issues with icalendar.el's handling of timezones as
>> commonly used in ical data and the standard tzurl.org repo. It is
>> also completely backwards-compatible as far as I can make out.
>>
>> Here's the README for the testcases I provided to Ulf along with the patch:
>
> Can you respin the patch and add the test cases to
> test/lisp/calendar/icalendar-tests.el? The icalendar test files should
> go to a new test/data/icalendar directory, I guess.
IIRC icalendar-tests.el does not make use of the testdata directory.
Thomas, could you please provide the expected results for the test files,
one for each ics file? Thanks!
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 11 Aug 2020 15:20:02 +0000
Resent-Message-ID: <handler.34315.B34315.15971591763436 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Thomas Plass <thomas.plass@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.15971591763436
(code B ref 34315); Tue, 11 Aug 2020 15:20:02 +0000
Received: (at 34315) by debbugs.gnu.org; 11 Aug 2020 15:19:36 +0000
Received: from localhost ([127.0.0.1]:41434 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k5W3r-0000tL-Jq
for submit <at> debbugs.gnu.org; Tue, 11 Aug 2020 11:19:35 -0400
Received: from quimby.gnus.org ([95.216.78.240]:33658)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1k5W3q-0000t9-07
for 34315 <at> debbugs.gnu.org; Tue, 11 Aug 2020 11:19:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=8l5Gg9uQW8bAW+L8NjzcMaTtF6WYEUlRXg4zmvlFRWo=; b=GBlT7MuOdYXAVBXucfYV/mINyg
jH7NnxF0NH246RsIMT/A3+bVc9U9GrFYwgQX71vuwmKT7g7a1qPOEgHOL6Qw//FGqv8+IkDx8PvP/
Q/xYX9a0YPi//3Ost1R72g0CeV2xaoH02JrZCpOhlCuYAMX9/tRo5o8d/sb25rygxXXo=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1k5W3f-0005Ym-2q; Tue, 11 Aug 2020 17:19:27 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama>
Date: Tue, 11 Aug 2020 17:19:21 +0200
In-Reply-To: <87d03x43kz.fsf@panama> (Ulf Jasper's message of "Tue, 11 Aug
2020 17:14:36 +0200")
Message-ID: <87bljhtdl2.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Ulf Jasper <ulf.jasper@HIDDEN> writes: > IIRC
icalendar-tests.el
does not make use of the testdata directory. No, but I think it should. :-)
At least when adding new tests -- it's easier to be sure that we're really
testing the right thing when we've not stringified the icalendar data into
a Lisp string...
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Ulf Jasper <ulf.jasper@HIDDEN> writes:
> IIRC icalendar-tests.el does not make use of the testdata directory.
No, but I think it should. :-) At least when adding new tests -- it's
easier to be sure that we're really testing the right thing when we've
not stringified the icalendar data into a Lisp string...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 11 Aug 2020 15:46:02 +0000
Resent-Message-ID: <handler.34315.B34315.159716072215741 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Thomas Plass <thomas.plass@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.159716072215741
(code B ref 34315); Tue, 11 Aug 2020 15:46:02 +0000
Received: (at 34315) by debbugs.gnu.org; 11 Aug 2020 15:45:22 +0000
Received: from localhost ([127.0.0.1]:41492 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k5WSo-00045Y-DT
for submit <at> debbugs.gnu.org; Tue, 11 Aug 2020 11:45:22 -0400
Received: from mout.web.de ([212.227.17.12]:41169)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1k5WSl-0003w1-0q
for 34315 <at> debbugs.gnu.org; Tue, 11 Aug 2020 11:45:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1597160712;
bh=p4Tik7m81Vamd5jrDe7WMYNAn/2YsccaXn31e5wSafo=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=le9+xR21fs4xRMVLBaWpDvrbV0GZvXKrTwBfGfUh/XG24Uut/WzjmOsXbsjf7aU1K
ju6UyehABWRRFalZh7EorVGuktqEwxqQmvAWA7DlQGk0hu46CGue3lOuQAeRmh/RnB
bGOM81rKsaNzEQTP+TYzVRJ4xMH2uWucQgEcgvk8=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.158.235.225]) by smtp.web.de (mrweb101
[213.165.67.124]) with ESMTPSA (Nemesis) id 0MVtxM-1kC8C80kFU-00X4mC; Tue, 11
Aug 2020 17:45:12 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <87bljhtdl2.fsf@HIDDEN>
Date: Tue, 11 Aug 2020 17:45:10 +0200
In-Reply-To: <87bljhtdl2.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Tue,
11 Aug 2020 17:19:21 +0200")
Message-ID: <878sel4261.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:Uc5vdSSOIiZwjZ7o3XS6d/fvuwqthwc7IjuvYaMM8v7lIH5SJZz
pZeHDcry31f2P+nIJdRfv5mhUF2tsS7uZDGzYLLafX2EG/lx2KquIYr45d+DYdIqJs1oalB
j/iz6QZ+x12T26Qqrpawwt2H9t+xGVIkM8t0IByCBZvCE85ATI/3bdYEYcAN8s5/ux7tuF9
2qdp3fqAozisIIIhTD4gw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:IBphVoiHU3w=:X2ZH39mjtQWfrr5qfOxRnO
Ft8dj65FmBnUzqVRWA5eI64P+OZH7kHZcfKkmt1+dJG5eAn0aBpkSl03wwKQxzu9gvPHm8U32
5cI7tBQGwoDiFZmZAgMDUCOVwZFTdCaIe/RzPDDdOJrhmMvIP0Pe1f5u/AurRuUJK8EqVoJxp
MzDwiMDUjmfhH4mKbRk/rAd2ovU0WVl8CpN6mb2/wv5zyWRFo4qBaYZyREpsCd/3Al0Ho/mNf
Yc0ig/p+TdI4OxpW0bT61L7ZbkZUGtTpS4js1lTgznD5+voD6APr7lm1n1VNUtSjMDF/tovHE
edqek/kH6quaUjuAgePQfbw0aAbckkXqEqtc0sc4Amb8fdix5e+ygGeLnG5EVwZAGIyvLDkFO
zRchwMB1WYUz6RHnVJrtCELnvn314cSP2wus054Oa3YoEZWeeIslvrbjXkc9pattQT8Bgx7dX
np+R0zd2HXCWPWJhhsw8Ugpz91e2ujUCGPy0YEd8hiRxBgmrykOOLSkloOQiuTGNpZjhteaz+
jeNlVaE8IiLNirsnz/rFUC0kpdPMdY4erdTLY/nk7GUzDpiqL5rLU7o+53eKzBgTSaRvnB4lV
i1Z0+l6+sr+q0FWrqR++L+08gIxeklWKemeBnACbVoGeH1zKiYp2EgAmTT+ZQJ2jKJwSfZxMF
Yq21WW6R6Yht2MGhPbGHcKt0W5DtT366sTJwCgK9WZReUsnWNMTWCMyJe4bw5Xxr6NrlgbtH2
Ns1SQ2W2iKr62uDvK69jTuh25gTytg5um82w215oo1zEVei5Lw3IvqEfA50qExaVC+vJddGrI
O9hsjNC2RcpDnsVvxenvHqqK4qRKJCbskAZHFdNzQOnrnmTYo4mQYhhEYcUCrcNjfqOh5i11H
7nhI2Z7YTjge0YCQqc5VJuJwXeuiHjQ70WwerNigNB/KZPIBK9O6Z6n9uPI3IWG1J7aHT77gi
X2GZIsMsMNQq0Ur+viVaWtETP6H80yNJHG6CRWHaaLAFo2uxT0EtqSdpZQvmObrf3NgDE0hW4
ijB5+TViunDxxPWFFjN79FRn/pKJB1hHB6c7HRIFWn7Lfkg/v2HQR7MsYxpiB2tBCt+ByduFV
E1q73NTpV3MsQXgKayVN99fgeXPATJaNsmKIOS0MlbZytdMjdwNaDKxIryhp7h3Zja/9rXMps
jOmzjhig/sdKZKkgCGJPYzAZvBWBtxtoRMrfrNpZx0IXXP8O6sGSxU3IITufK6StBPxUm4mw/
DtF9mruDdds7Ea9Mh+5bBsALnJz0luG9920oxmA==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Am 11.08.2020 um 17:19 (+0200) schrieb Lars Ingebrigtsen:
> Ulf Jasper <ulf.jasper@HIDDEN> writes:
>
>> IIRC icalendar-tests.el does not make use of the testdata directory.
>
> No, but I think it should. :-) At least when adding new tests -- it's
> easier to be sure that we're really testing the right thing when we've
> not stringified the icalendar data into a Lisp string...
Agree. icalendar-tests are hard to read. sigh.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 12 Aug 2020 13:09:01 +0000
Resent-Message-ID: <handler.34315.B34315.15972377368488 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Thomas Plass <thunk2@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.15972377368488
(code B ref 34315); Wed, 12 Aug 2020 13:09:01 +0000
Received: (at 34315) by debbugs.gnu.org; 12 Aug 2020 13:08:56 +0000
Received: from localhost ([127.0.0.1]:43264 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k5qUy-0002Cp-0u
for submit <at> debbugs.gnu.org; Wed, 12 Aug 2020 09:08:56 -0400
Received: from vsmx009.vodafonemail.xion.oxcs.net ([153.92.174.87]:54014)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1k5qUw-0002Cc-9M
for 34315 <at> debbugs.gnu.org; Wed, 12 Aug 2020 09:08:54 -0400
Received: from vsmx001.vodafonemail.xion.oxcs.net (unknown [192.168.75.191])
by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTP id 5556D159EB9A;
Wed, 12 Aug 2020 13:08:48 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.205.18.233])
by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 7CF00159EB98;
Wed, 12 Aug 2020 13:08:37 +0000 (UTC)
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="HQeW33IGhA"
Content-Transfer-Encoding: 7bit
Message-ID: <24371.59842.984273.402129@HIDDEN>
Date: Wed, 12 Aug 2020 15:08:18 +0200
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Tuesday, August 11 2020 17:14:36
(ID: <87d03x43kz.fsf@panama>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama>
X-VADE-STATUS: LEGIT
X-Spam-Score: -0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)
--HQeW33IGhA
Content-Type: text/plain; charset=us-ascii
Content-Description: message body text
Content-Transfer-Encoding: 7bit
Attached is an updated ZIP containing the respun patch and the
unmodified samples. The patch is against
https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/calendar/icalendar.el
blob: d76c11050312b4a04ac1cbda436b3c08fc6f2cc5
Hopefully, this is OK as it is.
I also extended the README in the ZIP to clarify what the patch is about:
The aim of the patch is to support robust date-time conversions based
on the VTIMEZONE sections in the iCalendar data. VTIMEZONE specifies
the source timezone while the target timezone is supplied externally
(by the OS, environment, user, etc).
Assuming a target timezone of Europe/Berlin, the local start time of
all events defined in the sample files is November 3, 2018 20:15h
(20181103T201500).
Aside: the clerical (?) error in `icalendar--decode-isoduration' is
also part of the patch but has nothing to do with conversions.
Ulf Jasper wrote at 17:14 on August 11, 2020:
: Am 11.08.2020 um 13:01 (+0200) schrieb Lars Ingebrigtsen:
:
: Thomas, could you please provide the expected results for the test files,
: one for each ics file? Thanks!
Well, the expected result depends on:
- The local timezone of the person running the code. Where I'm
sitting, it is November 3, 2018 20:15h for all samples.
Europe_Berlin-20181103T201500_no_in-calendar_VTIMEZONE.ics contains
no VTIMEZONE and thus has a somewhat undefined result. The user
agent is assumed to do the right thing based on OS/environment/user/AI.
Note: this particular date+time is carefully chosen as it is
subject to DST adjustments. Under MS-Windows, it exercises
Emacs' buggy DST handling. But this fact is just incidental
and not addressed by the patch.
- Expectations as to how the conversion result is to be rendered. In
my case rendering of the iCal data is done by a MIME handler I
cooked up for VM. This is mainly used for rendering incoming
meeting requests necessitating accurate date calculations.
Technical note: The concept of "target zone" is implemented by an
additional optional argument to `icalendar--decode-isodatetime'. My
VM plugin's function for getting the event dates (inspired by
`icalendar--convert-ical-to-diary') says:
(icalendar--decode-isodatetime dtstart nil dtstart-zone local-zone)
where there is a lot of apparatus for computing 'dtstart-zone and
'local-zone. If you'd like to know more, I can send the code.
--HQeW33IGhA
Content-Type: application/zip;
name="icalendar-patch+testcases_20200812.zip"
Content-Disposition: attachment;
filename="icalendar-patch+testcases_20200812.zip"
Content-Transfer-Encoding: base64
UEsDBBQAAAAIAK5wDFE5BcI0tAIAAN8FAAAGABwAUkVBRE1FVVQJAAMI2zNfCNszX3V4CwABBCAC
AAAEAQIDAK1UTU/bQBC9R8p/GHGCyvFHQiji1JTkgNQCCu6HqCprvR7HK9a71u46EH59Z53gQOFQ
iV5sa3Z25r3nN5NWwsLtxTVwrRwTygKDhjleQakNCM4kqoKZEOWvD7+BqYLOLTrQJYjz3SE4tA5K
IdGGw8H39OLr4vbqckF53AlNJXe1sQBXoUGh4J5eYNAZgWsKl0bXUDnXnEWRe2yNDLVZUa3hAEaw
aI1uMPuMRgo1GsfJaZLEk5Q+pnGcKZ1R9Aln1ncPBbd0HUBp6IMBWO0D6e3FnNqXhEJxtB3XeXqT
zpZpNE8Xl/Og12NXQ42sY75DAY2HY9wGfo5+LEc92/tKkGqkplBrYUUuEZx+oeA/8XmTTNaJkj1B
6Ln1mPaiHx5ctU5qfUeANxIPjt7dlRzitPFE+r5c143BCpUVa3zWXCgu20KoFewvkc5cm8LucMxq
9OHs3JBp9DMkyfgd/F+x3oP6D333ZLLlfJYu3qXDziitReiKBeQuB8vlty8d1LRCYKL2A0bDsptF
chV5ybZNo40Do/OWBq5gDkdO1Oi9ukZju1nLmcViONCqu/7GMIrtyX56qQ4L4Xlqg1yUAomjz7S6
NZzMTJ0etUKP33ubThwzK9oF/QnB9BiloJHGB4dGMSk3w8Fhvunyr24CQJoOo1WNygVeBEMhx4+6
YZ9Z29ZeNfaqNMmxdXC0dXDQFZTaC0suMNtUSttipq2iSCEsu62zo2xZ3RDyblF5rJd6jXWOBiYB
eDvQ4yyZVoT3r/HYonNVq+7Gn5ih3xgWCIdppWtm4Voya48gGY9m7Yp8NY59tl+XfqNZWmkr4ULL
1kwpVoUr1frtFnGKRlgzbkP/5QxiJIVtoicbRi93B9kNcqnzMyg+nnBCN40nyTg/ZvEx4wnPC3Y8
OcknPD4t+Uk55nwKw8EfUEsDBBQAAAAIAJygUU66RsY8tAEAANgDAABGABwARXVyb3BlX0Jlcmxp
bi0yMDE4MTEwM1QyMDE1MDBfaW4tY2FsZW5kYXJfVlRJTUVaT05FX3R6dXJsX3N0YW5kYXJkLmlj
c1VUCQADV7BpXMRDaVx1eAsAAQQgAgAABAECAwCtk0FvozAQhe/+FVavDcGGRt24ysGA0yIBztom
Kr0g2tButBQqAof2168NW9rk0l3t3sbPD79PM4PHrsOEbH0asSSgAmyZkCFPiDNHYCN4EAbkuaj7
ogLe6FRhzO54woC603esb5uX0vbKttrXWkpFRH503Qux7e6tb6t50z7Zb01d7uvHxmr6rmqan/bx
V7dWFPpWxH2qTPLx5Zga0CwKr2+UTuDrtWRqLXhMzhFGaJIU14IzCAmNGfGZVCBQUlGhCF5eIuQ6
S2Uc2iNEGjGyFuz7KmNURNmVl8U8UTcrV1c6bmVhmQLdk4/sEUW/ZxoVnKI4pyj4M8oxCUbOQiH3
CxKMTlGmbHP4mMTvybAtSxTwIyol2aSebup76JWZ1eqoscRB+BvGyFW6WGiOQOlH/8SYTmPPR4d1
4si19FBUZb0r2nyizId9yA9dYfTdfP9wGPHijYlYIuxcKnyBLgwLk74IN8M67IquhCbBwthC7gx2
+2cjELyAqfLP8Qx+yoNTHiwOsC07APu2Lnfw/hX+5V7O4Bkf9TN46F6rEsg0jqnI/hXJAAH4f5CG
RRgHP5TTf/wLUEsDBBQAAAAIAKSgUU45F0TB2wIAACUKAABIABwARXVyb3BlX0Jlcmxpbi0yMDE4
MTEwM1QyMDE1MDBfaW4tY2FsZW5kYXJfVlRJTUVaT05FX3R6dXJsX2hpc3RvcmljYWwuaWNzVVQJ
AANjsGlc2EFpXHV4CwABBCACAAAEAQIDAK2WTXOiQBCG7/wK7olxPkAYUh5QxoQqPlwYU2sulqtu
YpXBFOJh8+u3R1ZEBndNbQ5W4UNXv+80PT0z4A9+5DwN3YBHnptoTzxJ/ThyyB3Sxkns+Z7zNs/2
8402KCOFH/LnOOKaeIZ3fJ9v31fdwSrfrDNAkyRwXovi3el2i499vrnb5i/dj222Wmc/t93z6O+d
wB92gnjoCql4/rJU89xp4D88Csgcj0YpF6MkDp0bhBGqkIgBkAOI3JA7Q54KzROpcBPhYGZjRAkT
MgJikmQScGeU8G/9KXeTYHo/mIZxJB77FJ5Art/B6USDWpy0SyuQTxbIa1ohTSu4bqXuhPUwIpZA
9B9OMGpaqbT/bgWZlNjXmbEZRQbCAqHSjOcKrtAW6S/4ILiHDIoEoXXlS9RCBu5VH+9IbaBmkxqo
9N6g9OzzH6kBsVShJlCiUHCGDYWCM9SrPuaRSme2EsuAoia1UZmBVLX+8o7D0HGyJLhR6lZqIfg1
FwSlZlhdJsFYFqpBKWQ0FApLb4k1MZaFalDpTPFgWEBNtdRAqUJZmxqUmhFFDRIwoqjZBKiyYpsC
VTzYBoIdo1ATYplCe60erFYPdqsaA6rUl6E2Dwy3eWCkTY3RthXDfmrxwMy6h08MCKVpab1pw3rX
wjY0ibrh2qmFoJPqfhqb6JIfev3AMsy2ul+gFuqd6v6JTa0M0IubGuYRVib3BQqNjy/Mc/nndJj/
Odz5E4+ENgzcNHXGkwGcz0fhe3nc98/OaIcgbMMgoAIeTMjvCUh6TeCkujnMyohOI2IGaDHfrLLl
PJ9VLmeHK8Xsdb0rtvka3t+tF7vSYDiWIgxhaG8shzu44ekw8ceHu8VyXqx0qdHBuIPorV6s3yRw
sKlPxPAG3+o1Rb1S1Oc7PV8Vmr7Ps9VS//FLv/JyA+kWm/1ynb3oJ7uQarHNlzstnYShm0z/15Y0
pelfZ+vQEmULHB6rS+FvUEsDBBQAAAAIAM9oUU7aDZvU9QAAAMABAAA6ABwARXVyb3BlX0Jlcmxp
bi0yMDE4MTEwM1QyMDE1MDBfbm9faW4tY2FsZW5kYXJfVlRJTUVaT05FLmljc1VUCQADRU5pXI89
aVx1eAsAAQQgAgAABAECAwCl0U1rgzAYB/B7PkWOG5gusS3bcosaRsA3kmi7XSRUD4IvQ+v3X1LX
Mtrjbg9/wu95ScA/RErLkMU8jZgEJZdKZCn1NxjkMotERHszLKYDR3SQSIuEf2Upp3yZxu/mJWim
rh1AsCq85KkGYcyUonkRxCIEkbYu9TF5IwRvtS32GNtUaSb1Q17YdqtcrTK6e1ENY2XTk+maoTZT
VV4H2rSneWWT3LHvmPivmuzwzrXjKpQi126x2pwb6FRECMJbD57b3gWU7D04jPCPDm+6B6/7AniZ
Cz4VOkTkGZp5XvqmBqpIEiY//8s7HMBH3h3x97yX8vZfP1BLAwQUAAAACAC4oFFOLWu1jZcBAAAN
BAAAUAAcAEFtZXJpY2FfQ3Jlc3Rvbi0yMDE4MTEwM1QxMjE1MDBfaW4tY2FsZW5kYXJfVlRJTUVa
T05FX3R6dXJsX2hpc3RvcmljYWxfUkRBVEUuaWNzVVQJAAOLsGlcQ0ZpXHV4CwABBCACAAAEAQID
AKWT306DMBTG7/sUfQAZPYgbq/Gig86Q8C+lLOoNwQ2VZGOGsQt9els2t8li1MhV+fqd/k75DhN+
60d05rKARx4TaMZF6scRtQYEJSL2fI+uinpbLNFk55R+yB/iiCP5oPbYqmyqeWG6Tblp17USMxHQ
l7Z9pabZvm+b5WDdPJvv67qs6qe12fffGYHvGkHsMqmp/e0dM5VM9+ap0+PpNOVyKuKQGmRkD4l9
EGWsJUKUELGQ0zCVyJOqVkgKjmMTICBJ9yDhMcnPVPUFjqwf0B3nBOwcwckpeAxDIGfgnvoHsNMH
f3fjMThkSKwz8Bf1C1i/HOPdx81nPJLIDVia0iSbqLQ+Edd6AG56iVGLgANALiVYcKUInlTH/s6a
Hecp33uMnievamNeLMt6UTT5ode8G7T8pVIlunqZd7cdVPPNrtkw0bAxAWskwSa27ounrvCTbuoW
RVtiTTIADHJ5gdtqVWKwKFzhTLrG6AKfcPGBi4sNbsoW4W1Tlwv8+IZ/P/hpFoZM3P+XrckI/5Hd
Bb0Ltlsefv4PUEsDBBQAAAAIALSgUU7NmN5dZwEAABMDAABIABwAQW1lcmljYV9DcmVzdG9uLTIw
MTgxMTAzVDEyMTUwMF9pbi1jYWxlbmRhcl9WVElNRVpPTkVfdHp1cmxfc3RhbmRhcmQuaWNzVVQJ
AAODsGlcMkVpXHV4CwABBCACAAAEAQIDAKWTyW6DMBCG734KP0AcbJIojaseCDgVEpvARG0uiAba
ohKowByap68NKak4dfHJnu3/Zkbesnvbo3vTcJhnGSHYszCyfY/qcwyC0Ldsi57SqktLsB0iue2y
g+8xwA/SZ5zypjimmtnkragraYxDh74K8U41TZy7ppzXzYt2rqu8qJ5rVHeirOs3bZr3gBzbRI5v
GlypT92DdsQNxWhJFX+3ixjfhb5LEV5jPJq4Pxo8w2XUjTiwuMwMOSUb6SCYcNwfIDu+1lSPa3OX
ZtmeeRyYjhFFNIi3kvGr2K1q/27CSXVMbgjBC050spIKFpdlfxYaX6eZXGLQJCYpKnRMy7zK0iYZ
WZN+zEkrUmXP5sWxHSDdQIlsMNHXnCzxUvGwyAztoJ9xloocKgVECMKLGRTFKYdEp2QFY26i9Qx+
04OjHkxb2OQCwK6p8gw+fcDfrzuKXdcIH//LoAgA/CNDv/Bhwf11/AKfUEsDBBQAAAAIAEVtDFHJ
gToofQcAAAkWAAASABwAaWNhbGVuZGFyLmVsLnBhdGNoVVQJAAOS1TNfdNUzX3V4CwABBOgDAwAE
AQIDAKVYbXPaxhb+bP2KEzq9FoVlEJiXJDNNfG3cMOPEvYDv3Hr6oYu0gKbSCu8KZ9xf33N2V0jG
qoNzNRnHFuf9POcNxhjEIU+EjLjqiKQTjYZhEHQH3X7QW57x7hkPg3AZ8bP+cNkPu+NVOFz1wnBw
0uv2uqw7ZkEPgv47/Nfvd8aD0dlwOOx2oYWfdr1Wq/VE+gFTf/Su2+0E3WD89m1vz/TxI7BBMGi/
hRb9F3Th40cPAPxE5D+B72erlRZ5noEfcoU/ogh/cq3v4XRxd3N1NZ8sFjfAk1jnTXw8OAHHs1JZ
+gLX1ezm8wGfUrtEsAee7EQN42x2ez2pcLSgeHwV8VywLVLKaE9+eb4oyCF3GqJc51zlNdIvF/PF
+WxRkc+QXmYs0kgu7nc8gX0sSgcNIdnw/j1cTf/3efIOVpkCmX2FrwIymTzCBo1KBDjz0UCZ5WCt
2wglOl6rogh59868pNS5X2rNNwK2SmghQ9S7QkVOR6wBPdylIgIUEgnULgz1KlaoMeKPRE4vHgVX
ng3o142QNpp79fvQkYmVRFnLKb4uGQ44hgb8PSAZ09skzh1XRYJNjWFdKXFPuSnTcjWb/McSk88G
rMOgjYBuDYa9dtA3aPUwsWK1k1BRtuVKo4I8TsVfmURDbGLJysZipyRw+O9i+nlyd/NlAufX0/kC
YolucggzqcGfXkIHFndsvphNv/zSxCxd4Ps4EspmlQKWZhhAJUIhKY4YVr0VYbxCK/I4kx0PZiIn
VTJOIMYYF7aEXBIGlpgxsjLqNKoVl//F4uhJ4NCiB6FypnMVyzVDgLE43WYq9+DZU+Vbi5yJB7SO
bVW2RQmPFt5UhNPLAuOIgCReb/Ii8GFEtXEgJtzESaQQFE7A5flv19NfPi0sFI+VQgFjNmAsW2qh
HjjBtU4mWJkWhKXwmqhgvCxIS7K88A0hS8TRq3zDRvDl8nx2ufftKCkv+/ZEJhiZkfWtFP6ib3sy
BJMVYrO9slIsaFAoSfcNhM0rWzKjQXuIFTMatXtjUzEnJ1hxjXaDfFEUt2b5FwkhKSemSZq/rEKv
9bzMXvDcVhzo3RLdSbemYzVcRVD1JFgx+HmFgzrn/Pbf7OLm869QoAHopYseVqErVf2kfrfY02Qe
8wQLE33PeSyxUGCD+jNF1lKVZirSWGmt96ZjfngHjUr9NkBvsl0SUVEqgabFDwJMO1jjb9KUNzlA
RYo1Sg5hJctcfwtNe/eLlu3Taze8KMLFHPM1FjSUgivzDZ8fTv2Ep7gZYFhh2Xz6YbXtkgmuJe05
ZA197VO155u0ZO+xxNSgk3vC7tEcji/lWzOrC1+2x/pSI8tsB6lI7+383zbh1C/mvhmWze8XbjWU
a8X2YEd5zSNfwXnqhsJaCYSoelmtz/fYwDpG3CZQxUtpPX9ZzPJIMcvmP8nxD8yGvWWF7KZ7vFbd
eC8aJOpmxVyt1qId9BeWCsjCkiq2/Wd6cX49obbiBr+rWBzbEx5uQCQiJXvccmSr2fSd2gWhbTvt
27N2MIDWMBi3A9dqTVOldSYLAXs02cAQ1UVTrXEuwmYVCRbrjNoOGY6elX/Y0MG/si2tGdjcsH8z
vYlXuV1Fv+chq/4P8Otsp0LBSMr3C8HtdZfkzJoC5bCYzm+oOKnb22BTBnFWpDyHJP5TwB8uYBSc
U8yfS7sGc4IgOxsPuwG180nKQ42K7Kac2z0NYLryarS4bQ4Rc7u4AJuGXPE4oehju0Xcwl2T0OGB
tSCyVIgSOzUc0pKMRpD5iJx7QwqhyJ5HSyBPBUnDmcfmn6ZXZsDJTDLaHEmCDQ29NXlGRcvHktoj
BOiOx2gYtmnVxH3vAXfVqE0sJKBAf5ts4vKxiN9O4kaLUzIzEv/A66ESSOa15je3s4vJEYLN8DZR
oOgUn7S91iv0tWaT+e314lhthrnQZiP0DXUHOHGnU4qM8RaPFRy+KWdaUEIoxuY80ZXNAPtI9lVE
b+y+Xq3YVK/hWYk2Ldnq+SemWQx7Z+0R9opB0B67q9s+lfPL/5kmu1znmxrxEAyaNSeAOQsJsgWA
lbsM6+4FGlobdMEemx/uUK0SNRaTruLWdXy4lt4bQJvzunX4SaUnQM2iUKl2qJyPxngDcgKAxFGg
NVePleDg67LhPfXELmdp9EhDyOUGJ8wal0AuGXUDxpc6S3a4zJkM9Ef0xcdwSN9/VDOANoRmMhls
FcVtDnMKyRNCg6I3H95Qq7cGOHpmW4ZdA/EVpjONJeoGBJTZuvGClJhZc3izE7OUU8WzwPZjc35U
31ZC6u4IoF0/iqmVsJBrYVYsduLiUcE7+JVag6qF9sh5DcNBpzbMvlAqU/tLPqW0rQWOYHvrWn74
vfGj/r3RqC2VkyKgn/BWNQVOsV8iQQcfm6+x+aJqFPQP8lXFHfVC8ANmfilPpYIGN8o83LClWMfS
XAlnzTKbhtfcU0+yXODuGe+g+XzkVq34CUbgI5CwkPEQcJVEzu+UmT2uG7x+bD+zZFhjybFSsFCQ
/x92tao73/bkVcO/zonvEVDaf0TKRjUt0/pIVXmUk68xscbLcdP7G1BLAQIeAxQAAAAIAK5wDFE5
BcI0tAIAAN8FAAAGABgAAAAAAAEAAAD4gQAAAABSRUFETUVVVAUAAwjbM191eAsAAQQgAgAABAEC
AwBQSwECHgMUAAAACACcoFFOukbGPLQBAADYAwAARgAYAAAAAAABAAAA+IH0AgAARXVyb3BlX0Jl
cmxpbi0yMDE4MTEwM1QyMDE1MDBfaW4tY2FsZW5kYXJfVlRJTUVaT05FX3R6dXJsX3N0YW5kYXJk
Lmljc1VUBQADV7BpXHV4CwABBCACAAAEAQIDAFBLAQIeAxQAAAAIAKSgUU45F0TB2wIAACUKAABI
ABgAAAAAAAEAAAD4gSgFAABFdXJvcGVfQmVybGluLTIwMTgxMTAzVDIwMTUwMF9pbi1jYWxlbmRh
cl9WVElNRVpPTkVfdHp1cmxfaGlzdG9yaWNhbC5pY3NVVAUAA2OwaVx1eAsAAQQgAgAABAECAwBQ
SwECHgMUAAAACADPaFFO2g2b1PUAAADAAQAAOgAYAAAAAAABAAAA+IGFCAAARXVyb3BlX0Jlcmxp
bi0yMDE4MTEwM1QyMDE1MDBfbm9faW4tY2FsZW5kYXJfVlRJTUVaT05FLmljc1VUBQADRU5pXHV4
CwABBCACAAAEAQIDAFBLAQIeAxQAAAAIALigUU4ta7WNlwEAAA0EAABQABgAAAAAAAEAAAD4ge4J
AABBbWVyaWNhX0NyZXN0b24tMjAxODExMDNUMTIxNTAwX2luLWNhbGVuZGFyX1ZUSU1FWk9ORV90
enVybF9oaXN0b3JpY2FsX1JEQVRFLmljc1VUBQADi7BpXHV4CwABBCACAAAEAQIDAFBLAQIeAxQA
AAAIALSgUU7NmN5dZwEAABMDAABIABgAAAAAAAEAAAD4gQ8MAABBbWVyaWNhX0NyZXN0b24tMjAx
ODExMDNUMTIxNTAwX2luLWNhbGVuZGFyX1ZUSU1FWk9ORV90enVybF9zdGFuZGFyZC5pY3NVVAUA
A4OwaVx1eAsAAQQgAgAABAECAwBQSwECHgMUAAAACABFbQxRyYE6KH0HAAAJFgAAEgAYAAAAAAAB
AAAAtIH4DQAAaWNhbGVuZGFyLmVsLnBhdGNoVVQFAAOS1TNfdXgLAAEE6AMDAAQBAgMAUEsFBgAA
AAAHAAcAYgMAAMEVAAAAAA==
--HQeW33IGhA--
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 12 Aug 2020 13:13:01 +0000
Resent-Message-ID: <handler.34315.B34315.15972379628930 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: Ulf Jasper <ulf.jasper@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.15972379628930
(code B ref 34315); Wed, 12 Aug 2020 13:13:01 +0000
Received: (at 34315) by debbugs.gnu.org; 12 Aug 2020 13:12:42 +0000
Received: from localhost ([127.0.0.1]:43297 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k5qYc-0002Jy-FI
for submit <at> debbugs.gnu.org; Wed, 12 Aug 2020 09:12:42 -0400
Received: from quimby.gnus.org ([95.216.78.240]:45150)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1k5qYa-0002Jl-RC
for 34315 <at> debbugs.gnu.org; Wed, 12 Aug 2020 09:12:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=ViljQ9/M3gQrZ2h74obprmkiPrVSkYCASRIIBGuI/PE=; b=rI0deQPb87HeDMQuv2+DCN0uxy
04gD903KPqOpj579Phr+Mt2n8Gy5jJqlZHCDVfOnap6I7+rhak5EHeTFADJBhof9wgi0oL5O/bPv/
Ep1y4ZVoNe7IYk7ADEvmnva7wTqIROF1QHj8dFTfMf11dF7w8qinxi1JfYG9lW4FjkU0=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1k5qYP-00011M-6x; Wed, 12 Aug 2020 15:12:34 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
Date: Wed, 12 Aug 2020 15:12:27 +0200
In-Reply-To: <24371.59842.984273.402129@HIDDEN> (Thomas Plass's message
of "Wed, 12 Aug 2020 15:08:18 +0200")
Message-ID: <87y2mkknyc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: thunk2@HIDDEN (Thomas Plass) writes: > Attached is an
updated
ZIP containing the respun patch and the > unmodified samples. The patch is
against >
https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/calendar/icalendar.el
> blob: d76c11 [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
thunk2@HIDDEN (Thomas Plass) writes:
> Attached is an updated ZIP containing the respun patch and the
> unmodified samples. The patch is against
> https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/calendar/icalendar.el
> blob: d76c11050312b4a04ac1cbda436b3c08fc6f2cc5
>
> Hopefully, this is OK as it is.
It would be better to add the test cases in the test/data directory and
add the tests as code to icalendar-tests.el...
> : Thomas, could you please provide the expected results for the test files,
> : one for each ics file? Thanks!
>
> Well, the expected result depends on:
>
> - The local timezone of the person running the code. Where I'm
> sitting, it is November 3, 2018 20:15h for all samples.
(etc)
This is why the test cases should bind the time zone to whatever it is
it's testing -- that way we can easily ensure that the code continues to
work.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 12 Aug 2020 13:31:01 +0000
Resent-Message-ID: <handler.34315.B34315.159723904021431 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Ulf Jasper <ulf.jasper@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.159723904021431
(code B ref 34315); Wed, 12 Aug 2020 13:31:01 +0000
Received: (at 34315) by debbugs.gnu.org; 12 Aug 2020 13:30:40 +0000
Received: from localhost ([127.0.0.1]:43346 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k5qq0-0005ZM-IW
for submit <at> debbugs.gnu.org; Wed, 12 Aug 2020 09:30:40 -0400
Received: from mx009.vodafonemail.xion.oxcs.net ([153.92.174.39]:50674)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1k5qpy-0005Su-Lk
for 34315 <at> debbugs.gnu.org; Wed, 12 Aug 2020 09:30:39 -0400
Received: from vsmx002.vodafonemail.xion.oxcs.net (unknown [192.168.75.192])
by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTP id 1B3FC605212;
Wed, 12 Aug 2020 13:30:33 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.205.18.233])
by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 9419C60523D;
Wed, 12 Aug 2020 13:30:24 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24371.61149.995030.284670@HIDDEN>
Date: Wed, 12 Aug 2020 15:30:05 +0200
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Wednesday, August 12 2020 15:12:27
(ID: <87y2mkknyc.fsf@HIDDEN>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN>
X-VADE-STATUS: LEGIT
X-Spam-Score: -1.8 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.8 (--)
Lars Ingebrigtsen wrote at 15:12 on August 12, 2020:
:
: It would be better to add the test cases in the test/data directory and
: add the tests as code to icalendar-tests.el...
Certainly. But apparently I'm too stupid to find that file and the
test/data dir. Can someone send it to me? As I have no commit
privileges and also am unable to build Emacs, I haven't checked out
the git. So if the maintainer(s) could assist or extend the tests,
I'd be grateful.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 12 Aug 2020 15:07:02 +0000
Resent-Message-ID: <handler.34315.B34315.15972447846285 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.15972447846285
(code B ref 34315); Wed, 12 Aug 2020 15:07:02 +0000
Received: (at 34315) by debbugs.gnu.org; 12 Aug 2020 15:06:24 +0000
Received: from localhost ([127.0.0.1]:45177 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1k5sKe-0001dJ-9C
for submit <at> debbugs.gnu.org; Wed, 12 Aug 2020 11:06:24 -0400
Received: from mout.web.de ([212.227.17.11]:42509)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1k5sKc-0001d6-94
for 34315 <at> debbugs.gnu.org; Wed, 12 Aug 2020 11:06:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1597244775;
bh=Be9KDYyukmpA6aJZlTVfZbZGDOY342zCnMeGSJsoSP4=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=KWaAmzVAtaIugdTB12ybkvhIySpUNxk8DYNV0k4Det+nNnuX4dVclov7ava0lPjV9
goXogmC9qKXF6q04nG6aSNBGTug3lPhhJTlbe75fPo95RUVTY8QU2ak+my4UCKzPAI
47Orxdw+4Ok45yTlgXvBljk9gX5xAjHTBYW4UI1o=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.158.235.225]) by smtp.web.de (mrweb106
[213.165.67.124]) with ESMTPSA (Nemesis) id 1M8kAN-1k1lbC1Lyz-004lfB; Wed, 12
Aug 2020 17:06:15 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
Date: Wed, 12 Aug 2020 17:06:10 +0200
In-Reply-To: <24371.61149.995030.284670@HIDDEN> (Thomas Plass's message
of "Wed, 12 Aug 2020 15:30:05 +0200")
Message-ID: <87364rq4yl.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:yZPhDfO80kObyRDluUChA6oUaEOxIdFHBrp0tTSkJIJ40jQYazN
MS6BwM+c4RAoKyzRpG7cmpLbMyL6YAnHuuhQM1N2s1w99P7btw/SV5AjOBmwnZAOfLgX1C4
Nv39IG4vvNGQj8q2KHPo8FakaAtCMbg4yPLaAc1ip+N6OEA+8Mq1IbCehDHADDPzgP9xt5a
eb06E538KbwRUypRezzUA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:T9ukhmBoAic=:v5fFkN23sbLqJu9NStHa6E
fz6zdTZUz/l5NqdXZtfMzdMOf06SO3tU0Ju8D2yqQd4N2NlYb+M/Wan3c4LH+bXbD4Csx0QD7
x2Jdn6h0eh4pT3DFCRn5zn/+WGAmWyXIY3sAh8oBbafCr/8UCijr9nQwAM3Ukp1Mfz/TvWGxM
wiGhJ+tr4AmB8/j/ac7BQl605fIhXe5kinein8bLdp6h3aLJChatm6D+sDy72NWmL+v3zaY9W
3tiM3DUm+Zl5y1IF/mFT5VNwJdHFetu9fWu2trPvAgFh3gaaIDhEuzzr0ycp6TRQGMTCStJBS
2nDU0MaC9tdVWPys02mIs/RphqvJ22jTM/400NztJoN+fVzX8Q8nGFoRIdc4migK+T1QJNTvZ
PeuNEx67moP6BoCW3nL22bcFjKfHY/GOWl2xn+WiWVPocpw+YovQzMbH22axxNyWiwwn9Yidm
C7stTpXN0G6pDPrHXSo2xv7yg0M/UPyhA4vt8bCEM/jegKm8R0TD6faYu+bFKa9vFFOG4TO2E
vQhaZrutmrvw0gwyS2+H2Bi9mdvpA9yAgNv773qLwkY7XqsMgQimHlzNv2k+Q0FljmMS+kt9N
sDBSrrg6A6osWujQMqhTJF1SNsQOlWC1MN1ruWhjXPQtsQ/GuiSz7j8f0CBuEpfqp86iO61E4
eUCak2gNqtqzGf4nQ8Yx9CLTbJprd5gHutYlB83qb4xGCiNiAS+suTE3MlWuZuzMrk6EzMYyg
YwpIOl3+Nu8AFYFzPzTvwfgjBcMlwbfeTRQgQK7VLmkU8pBpQRbKVBkp6dpLKtqAXxgCqqdy1
bdf5jNDBx3u64CIqRgoonRQmTOeHU7hbnIIbDlbCPB5j8ep7QxRBcSltGnvEqHYV3HgaBts9d
rafd95ohMvasV5rcTFAug97FcWOCBigLG4KIss+YaJOV00+zDZfCGX+Go+OgExdsz0MrsMh3d
JGpLQdmLBgpCTPDUq4UQQgLMlSetx04nMlQ7+6pn1ZK9h6dmusqhhBBsCbMeRonfTFnAZlPYV
Dx920QK/JuNJOf9fFSnyQIb/qRWt7ISwpm963ViFjmBROyj9P4ZR2ifUE6EMs23t3fi6PFKwz
t6tNWqEc7+zFGVauxTX08mZ+hmTKwWcyRmA8LfLX91jubQ1KUc6mJwRsD8zIb6idWL+DH9R6G
y2WNKOSWJbRkEN/mXTZclq64MLwEobar5/eB+4X4rfP8c+CG70JEumP8DV9WtTya/c3COJeBt
ggypU2pDaEZN93KmZ/qgbkDtzSB2FXvD2ZkeUrA==
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Am 12.08.2020 um 15:30 (+0200) schrieb Thomas Plass:
> Lars Ingebrigtsen wrote at 15:12 on August 12, 2020:
> :
> : It would be better to add the test cases in the test/data directory an=
d
> : add the tests as code to icalendar-tests.el...
>
> Certainly. But apparently I'm too stupid to find that file and the
> test/data dir. Can someone send it to me? As I have no commit
> privileges and also am unable to build Emacs, I haven't checked out
> the git. So if the maintainer(s) could assist or extend the tests,
> I'd be grateful.
Don't worry. I shall write or enhance the tests for the
icalendar-functions that you changed. I shall also write tests that
check import of the ics files that you supplied.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 02 Sep 2020 18:07:01 +0000
Resent-Message-ID: <handler.34315.B34315.159906996121245 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.159906996121245
(code B ref 34315); Wed, 02 Sep 2020 18:07:01 +0000
Received: (at 34315) by debbugs.gnu.org; 2 Sep 2020 18:06:01 +0000
Received: from localhost ([127.0.0.1]:60653 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kDX8z-0005WY-HE
for submit <at> debbugs.gnu.org; Wed, 02 Sep 2020 14:06:01 -0400
Received: from mout.web.de ([217.72.192.78]:42285)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1kDX8w-0005WF-NQ
for 34315 <at> debbugs.gnu.org; Wed, 02 Sep 2020 14:05:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1599069951;
bh=VWlQwZq111vUDLIYLO6n9Nk2RTnApMuDPjCKfhWPljs=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=MjNKfZX5zZdNA3FtWZ41qLa1wrHtZEWEUGFPxZ74J+h3Utzfyi1XxCqvodIrHO674
PZJ9ws/W7RtvWGWkgZbTqS/PXk0Jbs+VQ9OkmPm9YwCo0DZR3I0mO9sl3o6ab/nltD
dEKUlgjWIUXznd4gwsWnmiThAFNVKwFcN4E/XD7E=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.158.235.225]) by smtp.web.de (mrweb103
[213.165.67.124]) with ESMTPSA (Nemesis) id 0MXYWA-1k7QRF2MD8-00WSvD; Wed, 02
Sep 2020 20:05:51 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama>
Date: Wed, 02 Sep 2020 20:05:47 +0200
In-Reply-To: <87364rq4yl.fsf@panama> (Ulf Jasper's message of "Wed, 12 Aug
2020 17:06:10 +0200")
Message-ID: <87imcwf404.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:eLWTA+PsAnkOxMijqwWU4BRm4f87dr/myJIIFNECOk7d8CZ7LjG
e1eBWlFKtQgXNGFBKbmLKlCuAe6zkNIIYRQmK5R41J+AJ7FPs5ZWjw+bsMvFw+w9TrH1mFd
POkw7uIBzNadWd/HCjDAJOfD0PuXwogXl1I/M/YfCAG7mg1H4Nwr7fO0Q4U729s9EkOvDuh
oyLk8lfBiPr4L0cPjPsdA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:0MJl1VpSZqk=:AM33g++XKXGS6deTJenUno
dZpiOOs77A7PF5b+XGWkFFXPKjw41Dy5+0VGHa+/TGSBRLblmd0ulRUl/i8vA03KdH411PWiV
IXwqLGUFz3Xmwtka2B97xHpOOUrr6Nr0mncq7vEt7u902L7LB8p0NSVieE9dLWD5j2yxNDFRN
ot6j+QyXkuOrwyokSTCECJ5fd4BqoPJx1YGrFwNZ9Z0dqQf3dmQttLTP7G5MRNg4LOd8ekqJh
jRbzttKNt0seHALcaRCny9W4ulsJ++9H7L9aoGld/RrgpC1kquBeQKa1InqEgBbGlAcE7HtUG
BBgdCa+38ClK2UgYJRwmiS6PTNgyOIaeM7oSVKkTq2Ah6Ndkp9DeFOJH+nDNxmxIZDKTdqxdr
/ufSFhcSMVFvkJyREbC14XPUyfP6yIE2iV+j345ID6NobjA3BPKo7IW9p1GooXyUnXSxziWxX
wAd9LKf8yx9XRJlQy0oKR0qFXU+k7XdX2JHZQYOI/WId+2tvDHRb6d0GxAxfzcZ/K9Fl46IEX
TYDTj+lKVGzYILb2w/PFtG5zwxVn4lpjUkzym4gPve98Sy/ifcxPYMzjek0b1JwX8GyhHius0
e5B+YZRxz3fd52KVdBLxp/AMQTVoimbyRJRIkzcJF41j8D6Yu9jTObWlHRXcWl2jn/V3hQW7/
XGIMi/RiGEBrT+1PTrFEdjws8BVJJR2Nakg4LDrhhTSUWgo7NklzlPzeEDwcYo9w1Bob3xtyy
UMSzqQs8DWcEVBW9CHTeq+gxYnAuw+hv6x4Hlr4VtTjY9eAFoQ9K0N9zzm5oUmujyaKH46izN
SfXrcZpHB/lbXVin8ikqUdj5RqFbSI+g0VpDmW45DbI7+lN7kmVnc7gZfdY4zIjiyUCIfaDJ0
BcfToTBKjunAAKorG/cP0A8682n4/lzxMyVCi4PUrSfQ/Vz3ITZw+fYF4fp+SgxEFS7hFoRaB
waCJyTYAX/20rh4r/I9JH06yqdfD5whuVBnGzY6h1YzpcNVBQ6PTMFvOVBJs0i4lJU76f6Os0
1UY+uG5+WLX6aqKxJrWemPaLPnY2IQFDPULakRnVhQjx5YGDtyaMuiuzyv8p8S7QdjZioaCtb
ENkVKVsZL9I/YWSmfTeJAoylYjhaWdk41PMxmbuuDGdvuJ3dTKDAMnxrw1Dec7Snpvt2sASWl
Iydfl0m7cPiWiQLQ3rXo9ANQLHO3iDbHAxGoMRrL4jJCAz599FHnaicdcGF2F2c42TKBQYxwC
OVqrn9g80Jhh/5qIYSvmJo1pOimHN7KrVUVCJHg==
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Just pushed two commits containing 1) unit tests and 2) your patch and
more tests.
I had to make a small change in the patched version of
`icalendar--decode-isodatetime' regarding input data in utc zone.
Please have a look.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 03 Sep 2020 08:39:01 +0000
Resent-Message-ID: <handler.34315.B34315.159912233116313 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.159912233116313
(code B ref 34315); Thu, 03 Sep 2020 08:39:01 +0000
Received: (at 34315) by debbugs.gnu.org; 3 Sep 2020 08:38:51 +0000
Received: from localhost ([127.0.0.1]:33400 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kDklf-0004F3-3G
for submit <at> debbugs.gnu.org; Thu, 03 Sep 2020 04:38:51 -0400
Received: from vsmx009.vodafonemail.xion.oxcs.net ([153.92.174.87]:23229)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1kDklc-0004En-0U
for 34315 <at> debbugs.gnu.org; Thu, 03 Sep 2020 04:38:49 -0400
Received: from vsmx001.vodafonemail.xion.oxcs.net (unknown [192.168.75.191])
by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTP id 2D5CE159DBC3;
Thu, 3 Sep 2020 08:38:42 +0000 (UTC)
Received: from agame7.arcor.de (unknown [88.76.253.199])
by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTPA id B7557159DD73;
Thu, 3 Sep 2020 08:38:33 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24400.43911.666145.400179@HIDDEN>
Date: Thu, 3 Sep 2020 10:38:31 +0200
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Wednesday, September 2 2020 20:05:47
(ID: <87imcwf404.fsf@panama>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
X-VADE-STATUS: LEGIT
X-Spam-Score: -0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)
Thanks, approved. Defaulting to local time when decoding seems
reasonable.
Ulf Jasper wrote at 20:05 on September 2, 2020:
: I had to make a small change in the patched version of
: `icalendar--decode-isodatetime' regarding input data in utc zone.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
In-Reply-To: <23640.9851.562972.730234@HIDDEN>
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 03 Sep 2020 14:29:02 +0000
Resent-Message-ID: <handler.34315.B34315.15991433323562 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.15991433323562
(code B ref 34315); Thu, 03 Sep 2020 14:29:02 +0000
Received: (at 34315) by debbugs.gnu.org; 3 Sep 2020 14:28:52 +0000
Received: from localhost ([127.0.0.1]:35890 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kDqEN-0000vO-Oq
for submit <at> debbugs.gnu.org; Thu, 03 Sep 2020 10:28:51 -0400
Received: from mout.web.de ([212.227.15.14]:50583)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1kDqEJ-0000v6-V2
for 34315 <at> debbugs.gnu.org; Thu, 03 Sep 2020 10:28:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1599143321;
bh=RK/qjLiYsF0PofI+pALvxCTIk/ZEnx4/QS/j7vvkGKo=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date;
b=eRMO9RhOtjRJww9+AIwKUh6yVzn0f9QfZxZoVtvV+2LKcBvzwQhP22qOu5RDqHK49
+2B04FqAH53tx9hXNfu9JMIpEPE/8m8kCFYYUI+r7aZLcvrnbKjJ9kcjACflN4Ntku
oIvVnGFMTQDMXK6sdOh8KjFxdGj9Bh1i/xUlDtWw=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.158.235.225]) by smtp.web.de (mrweb004
[213.165.67.108]) with ESMTPSA (Nemesis) id 0MFvnC-1kJpyp1Rig-00Ez6F; Thu, 03
Sep 2020 16:28:41 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN>
Date: Thu, 03 Sep 2020 16:28:37 +0200
Message-ID: <874kof2aui.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:39qE0AUOC3iablVmLuGxjGIHx0IgnLB8MqPs5BQtaqwlQ0hUm5i
aG1zYQN92arkMehT75NvjHrwg9/ga8iqOgvnpGCB+tAUS/SDjL9rihopdmLvdMVUjYYxr4t
JPmspA8oPiO/Teo+VA0zDDXkGCg/WPNffL/tn4jn1/DgBOleWhkuUUQWros0JBBn/OtwSyy
rA/hFlJWXuBlVobxtRtGg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:ntDImCBcXoY=:WeqZsr2YBfIHzDVC5t9S9J
iKBrXV73DjMrOCn7S6QtSBe9CviS+YnIRnnwHodvLg7S0Q8oXfoq4Gb47uC+3cSrqnLG0CCX3
75373Y58DbfR4bJdlApILgolcqtH+7w41fSF2vBl3SkV6x2H2gTkWHOfyi84EEcnCNSc4Buqz
gVxoUYF50v9EaZyqVPd8Cz7RbSyA45lQYO1qM1UQaN6N+1Y1Wimt4eqKpXyqUCBp9puDlnyaI
FXvN0mai1E5kvxHyxajiGiVFoEoIf+cVjQS31E5YAT6k/hHrPk3aDhnh2XbpN3UVWpc8P56Bl
CzdU4aZ5DpggH2RTMdsog7GSTlN8IuDWCyn0nXfX5rbBWuv6+maldCt1mEOXtMze4g+vOK2qy
RwJ7AkB0Exqoo3KN8AJg0MlhuzBKipca9fi2q4jluaUqhb+tZZ2zshIZIHX7QDt/7ynd8VFi7
duRJUht7Z7bL5NxHLWxzC0SMxZwRZQ0bWEm4bR2FkIdMdHhU0oGf8+6P7sun9XvDsKvfbNyzU
vJfeZ5GO8a8pFL6ltuhbGgfPCx9oLmgX+NmmDZxnfoL4+/pUErQjkHdMixX8lASOdwKJxeOql
0zQ6Gr4/JOSyprQKYVq1waBWqv2+bhQlwdhnt855zLYMruRqdrglP270e5sI95qLHlHzveMwU
OK5OJFkSK1SUJc3VIWBGOO9B8T5XCeoSqXS+SGOkMnJ24kWQ6f8YetEsaukglDDP9PTC7jbnR
H2h5vDDMyVBozaSYWPubsX3EMQ7beH+VOiufbq63EblbATdY8lMhcaupbMFw656vTVqSc9FTH
YguCIdIimErtyar/fIsF22FzYXCzsoMuga8fckkyQQPmfJTAzfWyL8F2wijVgDUuywcIFbQwz
wPOEHY0MlMV6Yfm1yvQsNQtI6JVg3PDmQoa8AJxs3velKAhPzEMS6tGlf1H4k5JLmFKqyyA3P
BgZXqhRlQfN7XkGJUkASRsjgQEs74Z8cF3Vjr9VlezbFpOaD1c7+Z8DVa8Ag8DS8FOaoYUyGQ
8XLwqOIrTKwHvL5GGzgRfpsnJ12gKjhS22DyhLTUHAKX7wTcb3PEbS3P4qaP1Vo2xS7zgRgBV
TwG/M+ThofZNfdXhfz8Zd+8WgBI0rpona4Z3RiPodLSxRtGjUJAEkymnzKd2cpPmCwxhJpLBw
H3gMC5hpaZwL5MJH7lH3/RD2I/NmPZTqkWTn1Aus3yL5rAbD6oMg3vm/qnCRiYEIyk5oxalGO
xYTJ/+jkh3MOUu0VHN61yX9J338enOPuAUF8Hcw==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Thomas,
after committing your changes I learned that your contribution counts as
a non-trivial change that is sufficiently large to make a copyright
assignment necessary.
So, would you please assign the copyright for your contribution(s) to
the FSF?
In order to do this, please ask on emacs-devel@HIDDEN, and we will send
you the necessary form together with the instructions to fill and email
it, in order to start this legal paperwork.
I should have asked you to assign copyright before I incorporated your
changes. My mistake. Sorry!
All the best,
Ulf
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 12 Sep 2020 08:02:01 +0000
Resent-Message-ID: <handler.34315.B34315.15998977208203 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.15998977208203
(code B ref 34315); Sat, 12 Sep 2020 08:02:01 +0000
Received: (at 34315) by debbugs.gnu.org; 12 Sep 2020 08:02:00 +0000
Received: from localhost ([127.0.0.1]:46169 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kH0Tw-00028F-89
for submit <at> debbugs.gnu.org; Sat, 12 Sep 2020 04:02:00 -0400
Received: from vsmx012.vodafonemail.xion.oxcs.net ([153.92.174.90]:18883)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1kH0Tu-00027y-Ce
for 34315 <at> debbugs.gnu.org; Sat, 12 Sep 2020 04:01:59 -0400
Received: from vsmx004.vodafonemail.xion.oxcs.net (unknown [192.168.75.198])
by mta-8-out.mta.xion.oxcs.net (Postfix) with ESMTP id 08739F35652;
Sat, 12 Sep 2020 08:01:52 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.205.16.79])
by mta-8-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 7F62019ADB2;
Sat, 12 Sep 2020 08:01:43 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24412.32869.172878.106922@HIDDEN>
Date: Sat, 12 Sep 2020 10:01:41 +0200
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Thursday, September 3 2020 16:28:37
(ID: <874kof2aui.fsf@panama>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
X-VADE-STATUS: LEGIT
X-Spam-Score: -0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)
In case anyone is waiting:
Ulf Jasper wrote at 16:28 on September 3, 2020:
:
: So, would you please assign the copyright for your contribution(s) to
: the FSF?
Seven days ago I returned the signed agreement to assign@HIDDEN
cc'ing the FSF copyright clerk. No reply since. Presumably, the
assignment ("GNU EMACS") is in effect.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 12 Sep 2020 08:13:01 +0000
Resent-Message-ID: <handler.34315.B34315.15998983289123 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: ulf.jasper@HIDDEN, larsi@HIDDEN, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.15998983289123
(code B ref 34315); Sat, 12 Sep 2020 08:13:01 +0000
Received: (at 34315) by debbugs.gnu.org; 12 Sep 2020 08:12:08 +0000
Received: from localhost ([127.0.0.1]:46188 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kH0dk-0002N5-BQ
for submit <at> debbugs.gnu.org; Sat, 12 Sep 2020 04:12:08 -0400
Received: from eggs.gnu.org ([209.51.188.92]:38400)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1kH0di-0002Mf-LB
for 34315 <at> debbugs.gnu.org; Sat, 12 Sep 2020 04:12:06 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:59708)
by eggs.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <eliz@HIDDEN>)
id 1kH0da-0008VC-N8; Sat, 12 Sep 2020 04:11:58 -0400
Received: from [176.228.60.248] (port=3102 helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
(Exim 4.82) (envelope-from <eliz@HIDDEN>)
id 1kH0da-0000Yb-3Y; Sat, 12 Sep 2020 04:11:58 -0400
Date: Sat, 12 Sep 2020 11:11:57 +0300
Message-Id: <83h7s3e7n6.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <24412.32869.172878.106922@HIDDEN> (thunk2@HIDDEN)
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN>
<874kof2aui.fsf@panama> <24412.32869.172878.106922@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Sat, 12 Sep 2020 10:01:41 +0200
> From: thunk2@HIDDEN (Thomas Plass)
> Cc: Lars Ingebrigtsen <larsi@HIDDEN>,
> Eli Zaretskii <eliz@HIDDEN>,
> 34315 <at> debbugs.gnu.org
>
> In case anyone is waiting:
>
> Ulf Jasper wrote at 16:28 on September 3, 2020:
> :
> : So, would you please assign the copyright for your contribution(s) to
> : the FSF?
>
> Seven days ago I returned the signed agreement to assign@HIDDEN
> cc'ing the FSF copyright clerk. No reply since. Presumably, the
> assignment ("GNU EMACS") is in effect.
Not yet, AFAICT. if you get no responses in another week, please ping
them and CC me.
Thanks.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Richard Stallman <rms@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 13 Sep 2020 04:08:02 +0000
Resent-Message-ID: <handler.34315.B34315.159997005326445 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Thomas Plass <thunk2@HIDDEN>
Cc: ulf.jasper@HIDDEN, larsi@HIDDEN, 34315 <at> debbugs.gnu.org
Reply-To: rms@HIDDEN
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.159997005326445
(code B ref 34315); Sun, 13 Sep 2020 04:08:02 +0000
Received: (at 34315) by debbugs.gnu.org; 13 Sep 2020 04:07:33 +0000
Received: from localhost ([127.0.0.1]:49301 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kHJIa-0006sT-OF
for submit <at> debbugs.gnu.org; Sun, 13 Sep 2020 00:07:32 -0400
Received: from eggs.gnu.org ([209.51.188.92]:43094)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <rms@HIDDEN>) id 1kHJIY-0006sG-O7
for 34315 <at> debbugs.gnu.org; Sun, 13 Sep 2020 00:07:32 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:51625)
by eggs.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <rms@HIDDEN>)
id 1kHJIR-000142-9c; Sun, 13 Sep 2020 00:07:23 -0400
Received: from rms by fencepost.gnu.org with local (Exim 4.82)
(envelope-from <rms@HIDDEN>)
id 1kHJIP-0006nv-S1; Sun, 13 Sep 2020 00:07:22 -0400
Content-Type: text/plain; charset=Utf-8
From: Richard Stallman <rms@HIDDEN>
In-Reply-To: <24412.32869.172878.106922@HIDDEN> (thunk2@HIDDEN)
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24412.32869.172878.106922@HIDDEN>
Message-Id: <E1kHJIP-0006nv-S1@HIDDEN>
Date: Sun, 13 Sep 2020 00:07:21 -0400
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> Seven days ago I returned the signed agreement to assign@HIDDEN
> cc'ing the FSF copyright clerk. No reply since. Presumably, the
> assignment ("GNU EMACS") is in effect.
It ought to be, but we should wait for confirmation.
--
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 29 Sep 2020 10:06:01 +0000
Resent-Message-ID: <handler.34315.B34315.16013739281427 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.16013739281427
(code B ref 34315); Tue, 29 Sep 2020 10:06:01 +0000
Received: (at 34315) by debbugs.gnu.org; 29 Sep 2020 10:05:28 +0000
Received: from localhost ([127.0.0.1]:54969 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kNCVk-0000Mw-Et
for submit <at> debbugs.gnu.org; Tue, 29 Sep 2020 06:05:28 -0400
Received: from vsmx009.vodafonemail.xion.oxcs.net ([153.92.174.87]:41980)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1kNCVg-0000Mf-7I
for 34315 <at> debbugs.gnu.org; Tue, 29 Sep 2020 06:05:27 -0400
Received: from vsmx001.vodafonemail.xion.oxcs.net (unknown [192.168.75.191])
by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTP id 54216159E4A9;
Tue, 29 Sep 2020 10:05:18 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.200.173.137])
by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 9116E159E812;
Tue, 29 Sep 2020 10:05:07 +0000 (UTC)
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="+r4RaW0PXo"
Content-Transfer-Encoding: 7bit
Message-ID: <24435.1743.473339.944597@HIDDEN>
Date: Tue, 29 Sep 2020 12:05:03 +0200
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Thursday, September 3 2020 16:28:37
(ID: <874kof2aui.fsf@panama>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
X-VADE-STATUS: LEGIT
X-Spam-Score: -0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)
--+r4RaW0PXo
Content-Type: text/plain; charset=us-ascii
Content-Description: message body text
Content-Transfer-Encoding: 7bit
Two pieces of news:
- as of yesterday, my assignment/disclaimer process with the FSF has
been completed
- in celebration, I'd like to submit yet another patch that extends
icalendar.el's timezone handling, this one intended to support
regions that at some point in the past made a permanent switch from
a DST/STD scheme to STD-only/DST-only. Cases in point are China
and Turkey,
cf. https://en.wikipedia.org/wiki/Daylight_saving_time_in_Asia.
Ulf, would you care to review the code and the included test cases?
Ulf Jasper wrote at 16:28 on September 3, 2020:
:
: So, would you please assign the copyright for your contribution(s) to
: the FSF?
--+r4RaW0PXo
Content-Type: application/zip;
name="icalendar-patch2+testcases_20200924.zip"
Content-Disposition: attachment;
filename="icalendar-patch2+testcases_20200924.zip"
Content-Transfer-Encoding: base64
UEsDBBQAAAAIAH2bOFEZ4V7XswcAAOQcAAAbABwAaWNhbGVuZGFyLmVsLjIwMjAwOTI0LnBhdGNo
VVQJAAMe12xfHtdsX3V4CwABBOgDAwAEAQIDAM1ZW3PaVhB+Nr9iR32wKD4EYWwHPJ3EMTjx1E5a
IG2dtwM6GE2EhCXhjDP58d09F92MuLjTTnmwhbS75zu7e77dFYwx8KbcF4HLo6bwmy6ftM/OOq/P
RNs9a3e64uR42nW7/LXDu9NZW3Q63elZtyMO2q12i7W6rH0MTrvXafec42brxDl12setFjTwaavW
aDQK1jOlDjjdXrvTc5zm2UnrdffUSZXevgV24nSPOqfQoP8np/D2bQ0OwHaTOOFRAvaUR/jHdfEv
j+MHOOyPR+OL4Ri478VJHT9SPgiZG6N4GEHk8kSwJdjiYcV9CGezWCRJqC9mUbhQWvQ5P4er679u
Bz1I5gKWkYhFMBUoCjyAYf9iPAAvBlx4tRAuoBFXBGEipPTMi3BFlz+RON14EjyqMTJrf5uLAAEH
brZ8uiOCGK18wR65vxKgkCMgqYm6vkh+BtuWMmCnPmUsXvpeorVyFkj1QKnOIvFALsu8dTUc/K6E
6zm5ydMiDJJ5UfTd3e2nj+MP66RpkyXZ/sVdKkmimSe/CXDD4DCBaRhFYpr4TzBHT+Bm/vx1NIa5
iEQTFWxvJn1hIkfOsuMk8oL7X0BuxLobXAxv7qw6aLwpJnsaBnGKD79MeWK+ypjyrwI4BHwhl9KO
xQVxJcwMqz8aW2CNxn2rXlBDOOMvR/Dp6mo0GMvIu66KO8XXDzEWkHhoFGAUHuVVveBRYHBJTAYl
Lq5rU1x4JGZZPrTq8IbVwWogEpbDYceriXJDJuvAcSZg9ayNwsdwkgUPoY0Rk0o9Cd3kGRTTTYYY
kapwlITKH2fj83zO3ouEfRPiK5pnwWoxEVEes8os1lY5tNYWKe8ODCzH2ixioiEXdshP+JE45KUW
KkNsaZBSnpxqjSMexD4yjSWD7l3qLcM3FMcoxEsx9WZPKnE4AVeKaDr4gdn8o9ls1sm0F4A6jDrL
ku8YRrLSlCoSrzkW0hkWc/BIwLk0K/fB49z66Hsfvye1Rrrd/XiokbrqBUzUODDK27gok9yNjfLy
W/mIhPdkJFJ5GScZZIqVMpyal9Ibz5gpe1LBTUXVPdmpoLyGn4qr78BQOYUqjspEiKU2KyieSmXW
MFWaiaWELHFVWaz8cbZIvJCvKow+Y6xt8CRnbREqs1bjQHKV4q1GylsbmSuLxssIrKi/D4/lNF9O
Z6A3aaPZB616YtXrClBBWy2daa6JEfVn5pRLg4aEMBiypTww5xesWyt72rT00nhRCgpYLYsUD3Q4
bC9IWBIyHQ6UUuVDloFRviDTPeuVpS5yETRUzU6BdbSuqv4Vch0K9g5yKiN0VhTCmseVf0Tw8t+r
URa0etu1FOZ9tdoGfoo8EB6mXQTD4eebAcY20v27auqTHkQiWUWBzE3FQUD0zmHp86mYh74rImNO
Mzlk3xSRPyfwSuLemVM3cKlyxAbu1AC1V9RYU8PhScxWAeRYbcmjGGs0hfV7GGAtV8MTnQxrTE7h
8Mf4+nbw5dPHAVzcXGNRxOQN8TY5AuzrPjSx9rDReHj98X29qQa3M+fouIOD22vn6KRrBjdEQmu6
pj5P6RCXGXYRosuwEmNcWDiJRfTIaeySqOAQ57uP/YthPx3u4sRVtTgznjOIEKm2seQ703FNxQLP
z2a9tBVCQY9suXRUZKjVreKkoBrCNPpqEiUldUXHWXeM1pFF+1T3sm8kK0VSzXqxbuSXLvF/ihUH
28Q0OSqzcRHfu58n1RVojZLxSEXdosKq6qo0zeQIrQFoM/IspWtvL2ql7ewSf0azOcNsx5Aulnsu
kWLbV+/QlnvbVNIhS+tK16Qe/h+6xmD7B66p2Faap8XU2bJQ0ZnbujPFfew+EigcLUtLlYxtDGJ6
bqtat+yglntz1WYpoWo+MJ3YRkZoKFbJc0IFbW+gSsXgYDJCTs/WMKtw1Njh85zGDCvi6PM7dvnp
9jfAaenm+v2HMdBNTbey395sg96L+X5qJq6wY0pIXKgryzDBTXho4InKSsK9gGraHPcRRrRrrNA4
oLlxEzuXczm6vemBRQ4A5QAL4nm48l2Y4NgpEJ73KECWqXu8CkBl07me+vbVpHYAtXXU+WNIRUL4
OC8STJ45DwcofET+JLWYOl/5PnCFnsOmAFI+pchguQ2S+Nkxn849341w5VIc02JFt2tZWpom1o7D
iOZYY7jY3P50aPt8MXE55gdM1rxSMRMUQVCegVQjqHgFs/aY7Ciq8O4qTEfAf6CqvbOG1lvwpXxR
bPay3HUva2xJal+IxYM6pMs68qB56az58MXG1QrZO+1l9ZuvrZ9gD83DEoluXNbmaW4gIdEYBfl8
ydDzzWYmO5qZVBQYk6wZnH+pVha3tIvGs4zY0IxN/kP4k5fCr6+Zkp+X3jQSZk/1rH419qlfxU2m
1expwdRgsrUSEfuqKlNRyrIShJAC13v0XPo1qEJ6dHfLspolwWCtW0bhEieLJzntYbEzvzwF7isz
XtYahGTm+egfKhNy2aZ8nyNpsgGGA9Xr2JTgclFax17ruy31s1KBmwo+25Idy6pGTv+Wph6t4Ypa
Y117YgYvPNnMjJb5Sqfmy0slJRuHTErXzOvLi5sBBUHPm7oeYhEd8OkcsPouKN30D2wqS2SI1s6l
R7W/AVBLAwQUAAAACAAUmThREEMho0YEAAA+EwAAQQAcAEFzaWFfSXN0YW5idWxfMjAyMDA5MjRU
MTIwMDAwX2luLWNhbGVuZGFyX1ZUSU1FWk9ORV90enVybF9vcmcuaWNzVVQJAAOY0mxfiWJsX3V4
CwABBCACAAAEAQIDAM2YTW/bOBCG7wb8H3RvHZMUJZIq9qDYSleAPwJZDra9GG7j7Rpw7YXjHLa/
fmdENbE447RBL+2pfkLM+86QHFK8Lt6Xs+xulE+K2Tiv+r3baj4ux9nX9f5xvev37opqUc5nmboS
/d61H1yX0+LjfFb0e/VHGJo/bNfD8uG03n963CFbVpPsn9Pp32w4PH17PO6uDscvw2+H/Wa7//sw
DIb/NZiUo8FkPspr1An+6hUXdY7mxhh8fnOzKOqbaj7N3giZJIl6pvW8YWmSIpvl0yIrp3W/N64h
QlVn0lohpJC1aP71e9U4rwuKoRRnmj/00OqdeVAYpXVQFOcOHOgI6iDEnINx/mFSvv+zJg5atTP9
uKO/6BpIRcIZ4DHEjpWlWAotYooVjE4p1iKRzOiEldRCpLFgsFTcaAVOGJwAVhSnIuVGGwFxKLZC
S5q8doDp6EQAdhRDqRR1kiphZEIxlopiI6BUtIJGAqaxjQJsKI4heQgiAwwzGUNNVIBBkJkGw1fQ
GHZBGMtOg0197MCJNbB8HMUWsKHY+cUWYIcrNqFY+ixDrFhJF/tlH2LIUVHfMPWsk5SXNGzyzvJO
HOOkmSoqqbCN0eQBK8YJbm3GCWDNSybMNABOeSfGO4kDbL1kiJ1PPsCy7T4hljxWrKSMffIh1jxO
eCepT77F2J+f+/EPToiY9OeXzoeUPx94jCVStF0oiZVj2jNgpplrPnbCYo2zQiUhBsgy7VkyBy60
Z9aJ5rPUhpe0bJYatjrTcxLBSiaSxSlfqpQvlcHYmmnPrEHDxzYxDNfBysP2jMu9ht3XxVBB5qg1
UMGYa88wC3S0TWDSqBNozw0OTgRozw73QIgt4IRiB1gTDO3ZYQMIMS4fR7FiJSGCw+RDrFknLuGd
QKm42MYXNsTW77QQO1/vDsYfMDpMB9sz4LCw2J4ZJ9ieGSfYnnlJWBCksNieeSfGO9EBtl4yxM4n
H2C8tKKTEEvvJMSKlZSxTz7EuuPkVRdi2nD1WcOFX+cN10DK3I2LxxZPx5RsUiuZUwOwYg4qwLEw
cfeyHx4mF3PTr8rN+ctx2FK6+FWHGdWPO/pxV5+vLY8tLijaLi2eIMwdEpaTpJ3Oxp3u/4vr5qUP
KWie3EcDi/Fe0dlCr6o5/cC7eIFoLl70xL2Im6uU4S9HorNCfvqD+MJ159mhxDOXaQRd/IuaF1dl
c5dz5POI4K4+/jp7+GhfQoq7YgbFH03yxSK7XV5PytGT0Dt8HPmj854BIthL4SySbTse1xD45ZHt
FCzbl5bV9yGrINhqux98Xu82+/v1cfVkddW8wKwOxy9X288PrbnpLabrYFeZGma62dLjYjGqytvm
EeZ+fdpEGH4g3EDpt9F3zWh3AInotP26iaTKhIiW9ehN/DY60+73ouhJPlo/RMfN6fG439xHn/6L
fvpZaLGcTvPqw+9gpZn6dqab/z8/lv0PUEsDBBQAAAAIAAdzN1HwPkEYGwIAAF8GAABBABwAQXNp
YV9TaGFuZ2hhaV8yMDIwMDkxNlQwNzAwMDBfaW4tY2FsZW5kYXJfVlRJTUVaT05FX3R6dXJsX29y
Zy5pY3NVVAkAA24+a195PGtfdXgLAAEEIAIAAAQBAgMAzZVLb5tAFIX3SPyH2Sc2d3gYhqoLDOMU
iYcFY6vJBtGYxkgOrmy8aH59ZrDjB0zTLmtv8Mfhnqt7huspfQgTd+l7EU0CL1OVeZYGYeC+ls2h
3KjKkmZ5mCauPgZVmR7FLIzpU5pQVWFPXOrt61LL12Xzsi5rwRZZ5K7b9perae3bYbcZb3cv2tu2
qerm51bryb+PotAfRanvMeHTu3t0zJknmgtE8XQ2yymbZWns3oEDlmlcKEs7BoIkXkxdP2eqEjD+
fMZcTACLL4PuoypZ4DE6xHwQV47HDgLvMQofvjFJB9DzJ9f+wY2/CTCR+P8JYzCwNcQ6YEOinoAl
U9tgyjCfnMySSLHDa4PJQO9hUVsfYodje4gJx5MB5uPqGuxjzPHFUmRyyeAvp4IMMvnkTJgie53p
hkUscp2JHGMsjsoAW9xUgidADBhiWyQ7xI5czTPRHVkmBEszIdiQZUIwlmVCJFHxARJZVJhj6yaT
Swbi19VmOK0KuqQJH7cfeXnuzhdT/q6fh/9FbI+vNy+8q4vinbd9NAkYL/y50jkqF6dVVHxIil6x
om5Gz+Wmalblrji3WnQrquAralw/70/NxXNeXywG3WbYBLPrhOZ+Fs67LbUq2wqJ8iMgIzy5Rx+e
aLPlFqitXysEtguAFsy/c+7RlbeqIHS2R+Ue7ar2sGuqFfrxG/3z3swXcexlj/9DK130p6S768u/
yTtQSwMEFAAAAAgAmXI3UQnm3RhlAgAA2QkAAE8AHABBc2lhX1NoYW5naGFpXzIwMjAwOTE2VDA3
MDAwMF9pbi1jYWxlbmRhcl9WVElNRVpPTkVfbXVsdGlfREFZTElHSFRfU1RBTkRBUkQuaWNzVVQJ
AAOiPWtfoj1rX3V4CwABBCACAAAEAQIDAO2WXW+iQBSG70n4D3PfjszgBx+bvaAwtSQCBsZm2xtC
ESuJgpFxm/33e0BR264bL7pcrVd6Znzf9zmMZ7xjY9c3H21rwnzHCmVpGgaO65jrpNglK1l6ZGHk
Br6p9ogswa6o3mmOQzYOQtfyZclj/CFwzOnsbuJGD7J0txfkrseeA5/JEn8GOavKEyVaJsXrMsll
6QeeuDaeBLbFa/EPq3uJiFt1IqdW8C2PmXbEZcnhUA+5SY0BpYRQTppXvSm4v48Yvw8Dz7whxnmN
B1DR6wpAngnvjRzraeKOH/jJyHlnpI/IkAwuGemfjIzW6CR8HREYGfSi0VcSaWRA1S6INCDqd0Gk
AxG5iugfUOpA2clJNIBy1MVzM4BI64AIpAZ02AERfNG43LqvJKJA1MW0ACPjcuuuIqo/nU3qP49u
JlJlxu1PQ/tYvxC3WTvF1WBYXx7X5FNccm1c9sh8aIw9saJofw2dfL/VBN/fXS+mStTDWdD2Jg4H
4b/v1Pc7Z4ebLG63xB/E4rzAabLKinmyjY9R4/VuJfK4fcBxS9TL0+oQ1ZuCGzUIVTVOB2TQ5GKR
HbrTptnzRGSoNsPEwHR0i9oEaFWCIRL5OkNEMwlB0Pcb/RadJZElhI5h0FsulqhJtFllqA2FkmKO
2mCo2r3gtFxvyiIrRHWL0kUPRJZCbCpTUUSWLmF1vSty8au3ztNtWZUL0YOaIoZKuVjkaYb7o6GS
g8RWYODEosSnBRA7psMvO4HFMsPZTzDDNQnOK/y2LYtXRczxRlHpsN9XZSmaeZ4VPv1vRt2M5sdw
OPvN+9NfOBCUpd9QSwMEFAAAAAgABps4Ue7nl1mpAgAANQUAAAYAHABSRUFETUVVVAkAAzvWbF9w
J2tfdXgLAAEEIAIAAAQBAgMApVNda9swFH0P5D9cGIMGIjt1v1ifFuKyBbauJGawvhjFvo5FbcnT
lZNmv35XitNS6Fv1Yixd3XPuOUdZrQgelw9QGO2k0gQSOumKGipjQRWyQV1KG2EDUpd8SOjAVKAW
wwk4JDceVapBisaj8SirceiAz45L6G0XZ6DmTg1CKR0Kp1qkgGVxqwzju1pyP7nhIqOx5H+EntCD
lvLQqG3tgORO6S34y6A0VHJneusryEkPVIYjprOQxO25pDNKO5AWYVErLcMwWW+f8DCFouLK2rmO
buMYdbRXT6rDUsnI2G3s/+J0QM6PyLlvnyudz0nJT/kDmq7Bz8kN5Svs+k2jitxUeUD6WOcjRS/r
UsPvbPnz7vHX/d00iNKhbWWLPBbtVXDMmhbSdRavs9Tr7D+F1LDB8QifO4tErCeL4fYG9vJAt74x
nJ1PgBiaLUnnf34sv33PgjzrbH6fzlcpUL8RhWk7tkM7mgJKBhvy4m3gGcGvIRoWi95a1MUbi1fp
PLsjOJPEBa633trNAdy/3jZejaEHRtsoxMHPH685KttaqsAn7Cy9w5u+mRypJ5PXSL5LfmCLVYWF
UztsDsyc2RFPU4YMmQGZhQocvUBekk3voMSikdaXGc03veoW//bKMvk0Y4xVBsGcxTq8A5ab83aU
VQTC+WmEPJkls9mX8+tsdjPjxR6L07vIX5zNgx456xGpgqaB2o4ZSHaZSX2gcds3TuUnjfKTPu/A
JJPwJMK0iqj3M3fGulB1CrPDouZMtL1W7hC1qrCGTOUi3ovdVWyqShUoLq6vYtX6y4JxhDPi9eCF
pGClBYMJ3HG+QlyEIrG3Rm9jV4ouTs6vLi6SN9OfcjBMn1xm58mHZHV1r5+Sr9JyPKIS4SyrTcth
fWgk0QSSS7HGTni08eg/UEsBAh4DFAAAAAgAfZs4URnhXtezBwAA5BwAABsAGAAAAAAAAQAAALSB
AAAAAGljYWxlbmRhci5lbC4yMDIwMDkyNC5wYXRjaFVUBQADHtdsX3V4CwABBOgDAwAEAQIDAFBL
AQIeAxQAAAAIABSZOFEQQyGjRgQAAD4TAABBABgAAAAAAAEAAAD4gQgIAABBc2lhX0lzdGFuYnVs
XzIwMjAwOTI0VDEyMDAwMF9pbi1jYWxlbmRhcl9WVElNRVpPTkVfdHp1cmxfb3JnLmljc1VUBQAD
mNJsX3V4CwABBCACAAAEAQIDAFBLAQIeAxQAAAAIAAdzN1HwPkEYGwIAAF8GAABBABgAAAAAAAEA
AAD4gckMAABBc2lhX1NoYW5naGFpXzIwMjAwOTE2VDA3MDAwMF9pbi1jYWxlbmRhcl9WVElNRVpP
TkVfdHp1cmxfb3JnLmljc1VUBQADbj5rX3V4CwABBCACAAAEAQIDAFBLAQIeAxQAAAAIAJlyN1EJ
5t0YZQIAANkJAABPABgAAAAAAAEAAAD4gV8PAABBc2lhX1NoYW5naGFpXzIwMjAwOTE2VDA3MDAw
MF9pbi1jYWxlbmRhcl9WVElNRVpPTkVfbXVsdGlfREFZTElHSFRfU1RBTkRBUkQuaWNzVVQFAAOi
PWtfdXgLAAEEIAIAAAQBAgMAUEsBAh4DFAAAAAgABps4Ue7nl1mpAgAANQUAAAYAGAAAAAAAAQAA
APiBTRIAAFJFQURNRVVUBQADO9ZsX3V4CwABBCACAAAEAQIDAFBLBQYAAAAABQAFAFACAAA2FQAA
AAA=
--+r4RaW0PXo--
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 01:47:01 +0000
Resent-Message-ID: <handler.34315.B34315.160151677723199 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: Ulf Jasper <ulf.jasper@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.160151677723199
(code B ref 34315); Thu, 01 Oct 2020 01:47:01 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 01:46:17 +0000
Received: from localhost ([127.0.0.1]:33466 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kNnfh-000623-Ef
for submit <at> debbugs.gnu.org; Wed, 30 Sep 2020 21:46:17 -0400
Received: from quimby.gnus.org ([95.216.78.240]:52730)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1kNnff-00061q-LQ
for 34315 <at> debbugs.gnu.org; Wed, 30 Sep 2020 21:46:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=BmeWzZEfLLT4cx+DbfSstVi/qkXC2LuTQxGeLfy79ZQ=; b=JyDjVS1410t2ZwKiVjZGjeG3aA
SO3/EIoxGUsib498FJWew6hsoBqq1L9PQTfiyFdZFA8xOv7OSOMAOX3YQxJNr0j6s0XD42NmnxkVq
XzoJjyYxmf1b7thkAXhlxgCjtSIWs00mB1cS2TNJ4so/86z5qroo5GRLf3amARVr4QU8=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1kNnfU-0000Q7-SG; Thu, 01 Oct 2020 03:46:04 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEWcMhiqUBnRaR/m
mDZaKBL83mL+9IL////OESbrAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QKAQEpMNBQSYAAAAG0SURB
VDjLlZPBkcMgDEXFhgKATAoAJgUExneS0MCOx+lg038Jq4/Adja57D94bD2QZPQhGrLKWhe6bJAg
x+wunAEKFkO8zCuOxszyiYESsG1JMYdMxfSglWiUHRvwurJCFgH0RBy91oI0DYQOHKpnH6V0bjVG
ad+LN5AykSGJYO20iBqg4xYYmhs4L29qwJym/4JdqmlJ0yeQXPRZQOSjXUHy3MrXumMDF8PATG9g
Nm2Qh55KdcAHx6ASRXwEgDi1eLJtyprXXe4BxR0OLgWMv5Cuh1lXAZqni7PF8lIrXWq98TyIR8QB
cUuporuPVBgUXZtbqMd5h6Xi+8cuzsDQNeCt1BfdvGPQC2jUZqvQAF4XJUa0rbN1h9V1s7O1Zg9q
AfHYYnqNI6kAC6ruod4Zdggo1Jw6Gr4ilWvtajRmtN4B2z5I8aEruVdcEKm8GDSsYkumBtzukg0B
vNy+fgVXgFQvsP3HuJDQ6kRH9GLQx/P58wPC4DzPbM0Fj2k5Px7f8ykDFAbnOMDyfEougOWTHNVj
7reu94p3tFvG3fz7g2wCZeSEDAYmU7kGEn8ojhmi3Rn8AnCwxQRK+Y+kAAAAJXRFWHRkYXRlOmNy
ZWF0ZQAyMDIwLTEwLTAxVDAxOjQxOjQ4KzAwOjAw8rtNgQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAy
MC0xMC0wMVQwMTo0MTo0OCswMDowMIPm9T0AAAAASUVORK5CYII=
X-Now-Playing: Hood's _The Lost You_: "You Can't Breathe Memories"
Date: Thu, 01 Oct 2020 03:45:59 +0200
In-Reply-To: <24435.1743.473339.944597@HIDDEN> (Thomas Plass's message
of "Tue, 29 Sep 2020 12:05:03 +0200")
Message-ID: <874knewwfc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: thunk2@HIDDEN (Thomas Plass) writes: > - in celebration,
I'd like to submit yet another patch that extends > icalendar.el's timezone
handling, this one intended to support > regions that at some point in the
past made a permanent switch [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
thunk2@HIDDEN (Thomas Plass) writes:
> - in celebration, I'd like to submit yet another patch that extends
> icalendar.el's timezone handling, this one intended to support
> regions that at some point in the past made a permanent switch from
> a DST/STD scheme to STD-only/DST-only. Cases in point are China
> and Turkey,
> cf. https://en.wikipedia.org/wiki/Daylight_saving_time_in_Asia.
>
> Ulf, would you care to review the code and the included test cases?
Thanks for the code. It was in slightly inconvenient format -- we
prefer just simple patches, so I've reformatted it as such below.
However, the code makes two tests fail:
2 unexpected results:
FAILED icalendar--convert-tz-offset
FAILED icalendar--parse-vtimezone
I haven't actually looked at the failing cases, though.
In addition, the test cases included aren't actually used? Could you
propose some code to use them? (It should go in
test/lisp/calendar/icalendar-tests.el.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=icalendar.patch
Content-Transfer-Encoding: 8bit
diff --git a/lisp/calendar/icalendar.el b/lisp/calendar/icalendar.el
index dab277487e..e4760db3e4 100644
--- a/lisp/calendar/icalendar.el
+++ b/lisp/calendar/icalendar.el
@@ -519,46 +519,56 @@ icalendar--convert-tz-offset
(dtstart (car (cddr (assq 'DTSTART alist))))
(no-dst (or rdate-p (equal offsetto offsetfrom))))
;; FIXME: the presence of an RDATE is assumed to denote the first day of the year
- (when (and offsetto dtstart (or rrule-value no-dst))
- (let* ((rrule (icalendar--split-value rrule-value))
- (freq (cadr (assq 'FREQ rrule)))
- (bymonth (cadr (assq 'BYMONTH rrule)))
- (byday (cadr (assq 'BYDAY rrule))))
- ;; FIXME: we don't correctly handle WKST here.
- (if (or no-dst (and (string= freq "YEARLY") bymonth))
- (cons
- (concat
- ;; Fake a name.
- (if dst-p "DST" "STD")
- ;; For TZ, OFFSET is added to the local time. So,
- ;; invert the values.
- (if (eq (aref offsetto 0) ?-) "+" "-")
- (substring offsetto 1 3)
- ":"
- (substring offsetto 3 5))
- ;; The start time.
- (let* ((day (if no-dst
- 1
- (icalendar--get-weekday-number (substring byday -2))))
- (week (if no-dst
- "1"
- (if (eq day -1)
- byday
- (substring byday 0 -2)))))
- ;; "Translate" the iCalendar way to specify the last
- ;; (sun|mon|...)day in month to the tzset way.
- (if (string= week "-1") ; last day as iCalendar calls it
+ (if (and offsetto dtstart (or rrule-value no-dst))
+ (let* ((rrule (icalendar--split-value rrule-value))
+ (freq (cadr (assq 'FREQ rrule)))
+ (bymonth (cadr (assq 'BYMONTH rrule)))
+ (byday (cadr (assq 'BYDAY rrule))))
+ ;; FIXME: we don't correctly handle WKST here.
+ (if (or no-dst (and (string= freq "YEARLY") bymonth))
+ (cons
+ (concat
+ ;; Fake a name.
+ (if dst-p "DST" "STD")
+ ;; For TZ, OFFSET is added to the local time. So,
+ ;; invert the values.
+ (if (eq (aref offsetto 0) ?-) "+" "-")
+ (substring offsetto 1 3)
+ ":"
+ (substring offsetto 3 5))
+ ;; The start time.
+ (let* ((day (if no-dst
+ 1
+ (icalendar--get-weekday-number (substring byday -2))))
+ (week (if no-dst
+ "1"
+ (if (eq day -1)
+ byday
+ (substring byday 0 -2)))))
+ ;; "Translate" the iCalendar way to specify the last
+ ;; (sun|mon|...)day in month to the tzset way.
+ (if (string= week "-1") ; last day as iCalendar calls it
(setq week "5")) ; last day as tzset calls it
(when no-dst (setq bymonth "1"))
(concat "M" bymonth "." week "." (if (eq day -1) "0"
(int-to-string day))
- ;; Start time.
- "/"
- (substring dtstart -6 -4)
- ":"
- (substring dtstart -4 -2)
- ":"
- (substring dtstart -2)))))))))
+ ;; Start time.
+ "/"
+ (substring dtstart -6 -4)
+ ":"
+ (substring dtstart -4 -2)
+ ":"
+ (substring dtstart -2))))))
+ ;; neither RRULE nor RDATE present: return the offset and a placeholder
+ (cons
+ (concat
+ ;; Fake a name.
+ (if dst-p "DST" "STD")
+ (if (eq (aref offsetto 0) ?-) "+" "-")
+ (substring offsetto 1 3)
+ ":"
+ (substring offsetto 3 5))
+ dtstart))))
(defun icalendar--parse-vtimezone (alist)
"Turn a VTIMEZONE ALIST into a cons (ID . TZ-STRING).
@@ -571,34 +581,59 @@ icalendar--parse-vtimezone
(standard (cadr (cdar (icalendar--get-most-recent-observance alist 'STANDARD))))
(std (and standard (icalendar--convert-tz-offset standard nil))))
(if (and tz-id std)
- (cons tz-id
- (if day
- (concat (car std) (car day)
- "," (cdr day) "," (cdr std))
- (car std))))))
+ (cons tz-id
+ (if (and (not (assq 'RRULE daylight))
+ (not (assq 'RRULE standard)))
+ (let ((daylight-rdate (and (assq 'RDATE daylight)
+ (icalendar--get-most-recent-observance-from-sub-comp
+ daylight
+ '(RDATE))))
+ (standard-rdate (and (assq 'RDATE standard)
+ (icalendar--get-most-recent-observance-from-sub-comp
+ standard
+ '(RDATE)))))
+ (if (and daylight-rdate
+ standard-rdate
+ (string-greaterp daylight-rdate standard-rdate))
+ (car day)
+ (car std)))
+ (if day
+ (concat (car std) (car day)
+ "," (cdr day) "," (cdr std))
+ (car std)))))))
(defun icalendar--get-most-recent-observance (alist sub-comp)
- "Return the latest observance for SUB-COMP DAYLIGHT or STANDARD.
+ "Return the latest observance of all SUB-COMPs DAYLIGHT or STANDARD.
ALIST is a VTIMEZONE potentially containing historical records."
-;FIXME?: "most recent" should be relative to a given date
+;FIXME: "most recent" should be relative to a given date and
+; avoid selecting a SUB-COMP valid for dates in the future.
(let ((components (icalendar--get-children alist sub-comp)))
(list
(car
(sort components
#'(lambda (a b)
- (let* ((get-recent (lambda (n)
- (car
- (sort
- (delq nil
- (mapcar (lambda (p)
- (and (memq (car p) '(DTSTART RDATE))
- (car (cddr p))))
- n))
- 'string-greaterp))))
- (a-recent (funcall get-recent (car (cddr a))))
- (b-recent (funcall get-recent (car (cddr b)))))
+ (let* ((a-recent (icalendar--get-most-recent-observance-from-sub-comp
+ (car (cddr a))
+ '(DTSTART RDATE)))
+ (b-recent (icalendar--get-most-recent-observance-from-sub-comp
+ (car (cddr b))
+ '(DTSTART RDATE))))
(string-greaterp a-recent b-recent))))))))
+(defun icalendar--get-most-recent-observance-from-sub-comp (alist sym-list)
+ "Return the latest observance for ALIST DAYLIGHT or STANDARD.
+ALIST is an individual DAYLIGHT or STANDARD.
+SYM-LIST is a list of property names DTSTART and/or RDATE
+for filtering ALIST."
+ (car
+ (sort
+ (delq nil
+ (mapcar (lambda (p)
+ (when (memq (car p) sym-list)
+ (car (cddr p))))
+ alist))
+ 'string-greaterp)))
+
(defun icalendar--convert-all-timezones (icalendar)
"Convert all timezones in the ICALENDAR into an alist.
Each element of the alist is a cons (ID . TZ-STRING),
diff --git a/test/lisp/calendar/icalendar-resources/Asia_Istanbul_20200924T120000_in-calendar_VTIMEZONE_tzurl_org.ics b/test/lisp/calendar/icalendar-resources/Asia_Istanbul_20200924T120000_in-calendar_VTIMEZONE_tzurl_org.ics
new file mode 100644
index 0000000000..6425909be6
--- /dev/null
+++ b/test/lisp/calendar/icalendar-resources/Asia_Istanbul_20200924T120000_in-calendar_VTIMEZONE_tzurl_org.ics
@@ -0,0 +1,219 @@
+BEGIN:VCALENDAR
+PRODID:manual
+VERSION:2.0
+BEGIN:VTIMEZONE
+TZID:Asia/Istanbul
+TZURL:http://tzurl.org/zoneinfo/Asia/Istanbul
+X-LIC-LOCATION:Asia/Istanbul
+BEGIN:STANDARD
+TZOFFSETFROM:+015552
+TZOFFSETTO:+015656
+TZNAME:IMT
+DTSTART:18800101T000000
+RDATE:18800101T000000
+END:STANDARD
+BEGIN:STANDARD
+TZOFFSETFROM:+015656
+TZOFFSETTO:+0200
+TZNAME:EET
+DTSTART:19101001T000000
+RDATE:19101001T000000
+END:STANDARD
+BEGIN:DAYLIGHT
+TZOFFSETFROM:+0200
+TZOFFSETTO:+0300
+TZNAME:EEST
+DTSTART:19160501T000000
+RDATE:19160501T000000
+RDATE:19200328T000000
+RDATE:19210403T000000
+RDATE:19220326T000000
+RDATE:19240513T000000
+RDATE:19250501T000000
+RDATE:19400630T000000
+RDATE:19401201T000000
+RDATE:19420401T000000
+RDATE:19450402T000000
+RDATE:19460601T000000
+RDATE:19470420T000000
+RDATE:19480418T000000
+RDATE:19490410T000000
+RDATE:19500419T000000
+RDATE:19510422T000000
+RDATE:19620715T000000
+RDATE:19640515T000000
+RDATE:19700503T000000
+RDATE:19710502T000000
+RDATE:19720507T000000
+RDATE:19730603T010000
+RDATE:19740331T020000
+RDATE:19750330T000000
+RDATE:19760601T000000
+RDATE:19770403T000000
+RDATE:19780402T000000
+RDATE:19860330T010000
+RDATE:19870329T010000
+RDATE:19880327T010000
+RDATE:19890326T010000
+RDATE:19900325T010000
+RDATE:19910331T010000
+RDATE:19920329T010000
+RDATE:19930328T010000
+RDATE:19940320T010000
+RDATE:19950326T010000
+RDATE:19960331T010000
+RDATE:19970330T010000
+RDATE:19980329T010000
+RDATE:19990328T010000
+RDATE:20000326T010000
+RDATE:20010325T010000
+RDATE:20020331T010000
+RDATE:20030330T010000
+RDATE:20040328T010000
+RDATE:20050327T010000
+RDATE:20060326T010000
+RDATE:20070325T030000
+RDATE:20080330T030000
+RDATE:20090329T030000
+RDATE:20100328T030000
+RDATE:20110328T030000
+RDATE:20120325T030000
+RDATE:20130331T030000
+RDATE:20140331T030000
+RDATE:20150329T030000
+RDATE:20160327T030000
+END:DAYLIGHT
+BEGIN:STANDARD
+TZOFFSETFROM:+0300
+TZOFFSETTO:+0200
+TZNAME:EET
+DTSTART:19161001T000000
+RDATE:19161001T000000
+RDATE:19201025T000000
+RDATE:19211003T000000
+RDATE:19221008T000000
+RDATE:19241001T000000
+RDATE:19251001T000000
+RDATE:19401005T000000
+RDATE:19410921T000000
+RDATE:19421101T000000
+RDATE:19451008T000000
+RDATE:19461001T000000
+RDATE:19471005T000000
+RDATE:19481003T000000
+RDATE:19491002T000000
+RDATE:19501008T000000
+RDATE:19511008T000000
+RDATE:19621008T000000
+RDATE:19641001T000000
+RDATE:19701004T000000
+RDATE:19711003T000000
+RDATE:19721008T000000
+RDATE:19731104T030000
+RDATE:19741103T050000
+RDATE:19751026T000000
+RDATE:19761031T000000
+RDATE:19771016T000000
+RDATE:19850928T000000
+RDATE:19860928T020000
+RDATE:19870927T020000
+RDATE:19880925T020000
+RDATE:19890924T020000
+RDATE:19900930T020000
+RDATE:19910929T020000
+RDATE:19920927T020000
+RDATE:19930926T020000
+RDATE:19940925T020000
+RDATE:19950924T020000
+RDATE:19961027T020000
+RDATE:19971026T020000
+RDATE:19981025T020000
+RDATE:19991031T020000
+RDATE:20001029T020000
+RDATE:20011028T020000
+RDATE:20021027T020000
+RDATE:20031026T020000
+RDATE:20041031T020000
+RDATE:20051030T020000
+RDATE:20061029T020000
+RDATE:20071028T040000
+RDATE:20081026T040000
+RDATE:20091025T040000
+RDATE:20101031T040000
+RDATE:20111030T040000
+RDATE:20121028T040000
+RDATE:20131027T040000
+RDATE:20141026T040000
+END:STANDARD
+BEGIN:DAYLIGHT
+TZOFFSETFROM:+0300
+TZOFFSETTO:+0400
+TZNAME:+04
+DTSTART:19781015T000000
+RDATE:19781015T000000
+RDATE:19800406T030000
+RDATE:19810329T030000
+RDATE:19820328T030000
+RDATE:19830731T000000
+END:DAYLIGHT
+BEGIN:DAYLIGHT
+TZOFFSETFROM:+0400
+TZOFFSETTO:+0400
+TZNAME:+04
+DTSTART:19790401T030000
+RDATE:19790401T030000
+END:DAYLIGHT
+BEGIN:STANDARD
+TZOFFSETFROM:+0400
+TZOFFSETTO:+0300
+TZNAME:+03
+DTSTART:19791015T000000
+RDATE:19791015T000000
+RDATE:19801013T000000
+RDATE:19811012T000000
+RDATE:19821011T000000
+RDATE:19831002T000000
+END:STANDARD
+BEGIN:DAYLIGHT
+TZOFFSETFROM:+0300
+TZOFFSETTO:+0300
+TZNAME:EEST
+DTSTART:19850420T000000
+RDATE:19850420T000000
+RDATE:20151025T040000
+END:DAYLIGHT
+BEGIN:STANDARD
+TZOFFSETFROM:+0200
+TZOFFSETTO:+0200
+TZNAME:EET
+DTSTART:20070101T000000
+RDATE:20070101T000000
+RDATE:20110327T030000
+RDATE:20140330T030000
+END:STANDARD
+BEGIN:STANDARD
+TZOFFSETFROM:+0300
+TZOFFSETTO:+0200
+DTSTART:20151108T040000
+RDATE:20151108T040000
+END:STANDARD
+BEGIN:STANDARD
+TZOFFSETFROM:+0300
+TZOFFSETTO:+0300
+TZNAME:+03
+DTSTART:20160907T000000
+RDATE:20160907T000000
+END:STANDARD
+END:VTIMEZONE
+BEGIN:VEVENT
+CLASS:PUBLIC
+DTSTART;TZID=Asia/Istanbul:20200924T120000
+DTEND;TZID=Asia/Istanbul:20200924T130000
+UID:Asia_Istanbul_20200924T120000_in-calendar_VTIMEZONE_tzurl_org.ics
+DTSTAMP:20190127T140400
+DESCRIPTION:date 2020-09-24, Istanbul local time 12:00 UTC+3, in-calendar
+ VTIMEZONE as returned by http://tzurl.org/zoneinfo/Asia/Istanbul
+SUMMARY:date 2020-09-24, Istanbul local time 12:00 UTC+3, in-calendar
+ VTIMEZONE as returned by http://tzurl.org/zoneinfo/Asia/Istanbul
+END:VEVENT
+END:VCALENDAR
diff --git a/test/lisp/calendar/icalendar-resources/Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_multi_DAYLIGHT_STANDARD.ics b/test/lisp/calendar/icalendar-resources/Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_multi_DAYLIGHT_STANDARD.ics
new file mode 100644
index 0000000000..26dd3cbfb8
--- /dev/null
+++ b/test/lisp/calendar/icalendar-resources/Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_multi_DAYLIGHT_STANDARD.ics
@@ -0,0 +1,116 @@
+BEGIN:VCALENDAR
+PRODID:manual
+VERSION:2.0
+CALSCALE:GREGORIAN
+METHOD:PUBLISH
+BEGIN:VTIMEZONE
+TZID:Asia/Shanghai
+X-LIC-LOCATION:Asia/Shanghai
+BEGIN:STANDARD
+TZNAME:CST
+DTSTART:19411001T000000
+TZOFFSETFROM:+0900
+TZOFFSETTO:+0800
+END:STANDARD
+BEGIN:DAYLIGHT
+TZNAME:CDT
+DTSTART:19860504T000000
+TZOFFSETFROM:+0800
+TZOFFSETTO:+0900
+END:DAYLIGHT
+BEGIN:STANDARD
+TZNAME:CST
+DTSTART:19860914T000000
+TZOFFSETFROM:+0900
+TZOFFSETTO:+0800
+END:STANDARD
+BEGIN:DAYLIGHT
+TZNAME:CDT
+DTSTART:19870412T000000
+TZOFFSETFROM:+0800
+TZOFFSETTO:+0900
+END:DAYLIGHT
+BEGIN:STANDARD
+TZNAME:CST
+DTSTART:19870913T000000
+TZOFFSETFROM:+0900
+TZOFFSETTO:+0800
+END:STANDARD
+BEGIN:DAYLIGHT
+TZNAME:CDT
+DTSTART:19880410T000000
+TZOFFSETFROM:+0800
+TZOFFSETFROM:+0800
+TZOFFSETTO:+0900
+END:DAYLIGHT
+BEGIN:STANDARD
+TZNAME:CST
+DTSTART:19880911T000000
+TZOFFSETFROM:+0900
+TZOFFSETTO:+0800
+END:STANDARD
+BEGIN:DAYLIGHT
+TZNAME:CDT
+DTSTART:19890416T000000
+TZOFFSETFROM:+0800
+TZOFFSETTO:+0900
+END:DAYLIGHT
+BEGIN:STANDARD
+TZNAME:CST
+DTSTART:19890917T000000
+TZOFFSETFROM:+0900
+TZOFFSETTO:+0800
+END:STANDARD
+BEGIN:DAYLIGHT
+TZNAME:CDT
+DTSTART:19900415T000000
+TZOFFSETFROM:+0800
+TZOFFSETTO:+0900
+END:DAYLIGHT
+BEGIN:STANDARD
+TZNAME:CST
+DTSTART:19900916T000000
+TZOFFSETFROM:+0900
+TZOFFSETTO:+0800
+END:STANDARD
+BEGIN:DAYLIGHT
+TZNAME:CDT
+DTSTART:19910414T000000
+TZOFFSETFROM:+0800
+TZOFFSETTO:+0900
+END:DAYLIGHT
+BEGIN:STANDARD
+TZNAME:CST
+DTSTART:19910915T000000
+TZOFFSETFROM:+0900
+TZOFFSETTO:+0800
+END:STANDARD
+END:VTIMEZONE
+BEGIN:VTIMEZONE
+TZID:Etc/UTC
+X-LIC-LOCATION:Etc/UTC
+BEGIN:STANDARD
+TZNAME:UTC
+DTSTART:19700101T000000
+TZOFFSETFROM:+0000
+TZOFFSETTO:+0000
+END:STANDARD
+END:VTIMEZONE
+BEGIN:VEVENT
+CLASS:PUBLIC
+DTSTART;TZID=Asia/Shanghai:20200916T070000
+DTEND;TZID=Asia/Shanghai:20200916T080000
+UID:Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_multi_DAYLIGHT_STANDARD.ics
+DTSTAMP:20190127T140400
+DESCRIPTION:date 2020-09-16, Shanghai local time 07:00 UTC+8, in-calendar
+ VTIMEZONE with multiple DAYLIGHT and STANDARD sub-components, cf.
+ https://techcommunity.microsoft.com/t5/office-365/import-ics-to-office-365
+ -calendar-but-the-event-time-is-wrong/td-p/215332
+SUMMARY:date 2020-09-16, Shanghai local time 07:00 UTC+8, in-calendar
+ VTIMEZONE with multiple DAYLIGHT and STANDARD sub-components, cf.
+ https://techcommunity.microsoft.com/t5/office-365/import-ics-to-office-365
+ -calendar-but-the-event-time-is-wrong/td-p/215332
+END:VEVENT
+END:VCALENDAR
+
+
diff --git a/test/lisp/calendar/icalendar-resources/Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_tzurl_org.ics b/test/lisp/calendar/icalendar-resources/Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_tzurl_org.ics
new file mode 100644
index 0000000000..ccd39bd114
--- /dev/null
+++ b/test/lisp/calendar/icalendar-resources/Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_tzurl_org.ics
@@ -0,0 +1,65 @@
+BEGIN:VCALENDAR
+PRODID:manual
+VERSION:2.0
+BEGIN:VTIMEZONE
+TZID:Asia/Shanghai
+TZURL:http://tzurl.org/zoneinfo/Asia/Shanghai
+X-LIC-LOCATION:Asia/Shanghai
+BEGIN:STANDARD
+TZOFFSETFROM:+080543
+TZOFFSETTO:+0800
+TZNAME:CST
+DTSTART:19010101T000000
+RDATE:19010101T000000
+END:STANDARD
+BEGIN:DAYLIGHT
+TZOFFSETFROM:+0800
+TZOFFSETTO:+0900
+TZNAME:CDT
+DTSTART:19400601T000000
+RDATE:19400601T000000
+RDATE:19410315T000000
+RDATE:19420131T000000
+RDATE:19460515T000000
+RDATE:19470415T000000
+RDATE:19480501T000000
+RDATE:19490501T000000
+RDATE:19860504T020000
+RDATE:19870412T020000
+RDATE:19880417T020000
+RDATE:19890416T020000
+RDATE:19900415T020000
+RDATE:19910414T020000
+END:DAYLIGHT
+BEGIN:STANDARD
+TZOFFSETFROM:+0900
+TZOFFSETTO:+0800
+TZNAME:CST
+DTSTART:19401012T235959
+RDATE:19401012T235959
+RDATE:19411101T235959
+RDATE:19450901T235959
+RDATE:19460930T235959
+RDATE:19471031T235959
+RDATE:19480930T235959
+RDATE:19490528T000000
+RDATE:19860914T020000
+RDATE:19870913T020000
+RDATE:19880911T020000
+RDATE:19890917T020000
+RDATE:19900916T020000
+RDATE:19910915T020000
+END:STANDARD
+END:VTIMEZONE
+BEGIN:VEVENT
+CLASS:PUBLIC
+DTSTART;TZID=Asia/Shanghai:20200916T070000
+DTEND;TZID=Asia/Shanghai:20200916T080000
+UID:Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_tzurl_org.ics
+DTSTAMP:20190127T140400
+DESCRIPTION:date 2020-09-16, Shanghai local time 07:00 UTC+8, in-calendar
+ VTIMEZONE as returned by http://tzurl.org/zoneinfo/Asia/Shanghai
+SUMMARY:date 2020-09-16, Shanghai local time 07:00 UTC+8, in-calendar
+ VTIMEZONE as returned by http://tzurl.org/zoneinfo/Asia/Shanghai
+END:VEVENT
+END:VCALENDAR
--=-=-=--
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 01:51:01 +0000
Resent-Message-ID: <handler.34315.B34315.160151704923631 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.160151704923631
(code B ref 34315); Thu, 01 Oct 2020 01:51:01 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 01:50:49 +0000
Received: from localhost ([127.0.0.1]:33485 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kNnk9-000695-Jz
for submit <at> debbugs.gnu.org; Wed, 30 Sep 2020 21:50:49 -0400
Received: from quimby.gnus.org ([95.216.78.240]:52760)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1kNnk7-00068r-6O
for 34315 <at> debbugs.gnu.org; Wed, 30 Sep 2020 21:50:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=d/1st5vIPeGwqB8gDaoVo6gk+lk4O+1ja3WZCHwawtU=; b=Qa+QuTM/WziNOnQD6t3+d9Ie3y
kUoy3Z2hWCe22vE5V7eAa460RYKwKEUJIK2RGrKFwwgYNrWKzeJ8LK+D/9nXZ7w+3p3FPv6WIeUTp
UYN8lDN1yeelYlINiPvx3Cdz8tly9m8qsK1a7pbZMYTSgA/Nrby6bi8JUD/QVZTUX41w=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1kNnjy-0000Rc-2O; Thu, 01 Oct 2020 03:50:40 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEWcMhiqUBnRaR/m
mDZaKBL83mL+9IL////OESbrAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QKAQEpMNBQSYAAAAG0SURB
VDjLlZPBkcMgDEXFhgKATAoAJgUExneS0MCOx+lg038Jq4/Adja57D94bD2QZPQhGrLKWhe6bJAg
x+wunAEKFkO8zCuOxszyiYESsG1JMYdMxfSglWiUHRvwurJCFgH0RBy91oI0DYQOHKpnH6V0bjVG
ad+LN5AykSGJYO20iBqg4xYYmhs4L29qwJym/4JdqmlJ0yeQXPRZQOSjXUHy3MrXumMDF8PATG9g
Nm2Qh55KdcAHx6ASRXwEgDi1eLJtyprXXe4BxR0OLgWMv5Cuh1lXAZqni7PF8lIrXWq98TyIR8QB
cUuporuPVBgUXZtbqMd5h6Xi+8cuzsDQNeCt1BfdvGPQC2jUZqvQAF4XJUa0rbN1h9V1s7O1Zg9q
AfHYYnqNI6kAC6ruod4Zdggo1Jw6Gr4ilWvtajRmtN4B2z5I8aEruVdcEKm8GDSsYkumBtzukg0B
vNy+fgVXgFQvsP3HuJDQ6kRH9GLQx/P58wPC4DzPbM0Fj2k5Px7f8ykDFAbnOMDyfEougOWTHNVj
7reu94p3tFvG3fz7g2wCZeSEDAYmU7kGEn8ojhmi3Rn8AnCwxQRK+Y+kAAAAJXRFWHRkYXRlOmNy
ZWF0ZQAyMDIwLTEwLTAxVDAxOjQxOjQ4KzAwOjAw8rtNgQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAy
MC0xMC0wMVQwMTo0MTo0OCswMDowMIPm9T0AAAAASUVORK5CYII=
X-Now-Playing: Hood's _The Lost You_: "By Island Lake (excerpt)"
Date: Thu, 01 Oct 2020 03:50:36 +0200
In-Reply-To: <874knewwfc.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Thu,
01 Oct 2020 03:45:59 +0200")
Message-ID: <87tuvevhn7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Oops, the example files didn't survive sending like this --
the CRLF was translated into two newlines? + VTIMEZONE as returned by
http://tzurl.org/zoneinfo/Asia/Shanghai +END:VEVENT
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Oops, the example files didn't survive sending like this -- the CRLF was
translated into two newlines?
+ VTIMEZONE as returned by http://tzurl.org/zoneinfo/Asia/Shanghai
+END:VEVENT
+END:VCALENDAR
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 13:40:01 +0000
Resent-Message-ID: <handler.34315.B34315.16015595566236 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Ulf Jasper <ulf.jasper@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.16015595566236
(code B ref 34315); Thu, 01 Oct 2020 13:40:01 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 13:39:16 +0000
Received: from localhost ([127.0.0.1]:34849 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kNynj-0001cW-WA
for submit <at> debbugs.gnu.org; Thu, 01 Oct 2020 09:39:16 -0400
Received: from vsmx011.vodafonemail.xion.oxcs.net ([153.92.174.89]:31476)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1kNyni-0001cI-PW
for 34315 <at> debbugs.gnu.org; Thu, 01 Oct 2020 09:39:15 -0400
Received: from vsmx003.vodafonemail.xion.oxcs.net (unknown [192.168.75.197])
by mta-5-out.mta.xion.oxcs.net (Postfix) with ESMTP id 2B91259D2D0;
Thu, 1 Oct 2020 13:39:09 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.200.173.137])
by mta-7-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 56A08539ACD;
Thu, 1 Oct 2020 13:38:56 +0000 (UTC)
Message-ID: <24437.56299.111042.412318@HIDDEN>
Date: Thu, 1 Oct 2020 16:38:51 +0300
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Thursday, October 1 2020 03:45:59
(ID: <874knewwfc.fsf@HIDDEN>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
X-VADE-STATUS: LEGIT
X-Spam-Score: -0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)
Lars Ingebrigtsen wrote at 03:45 on October 1, 2020:
:
: However, the code makes two tests fail:
Like with the previous patch, I hoped to get away with offloading the
testing part to the maintainer... But the failures prompted me to get
familiar with the test setup for the two culprits.
: 2 unexpected results:
: FAILED icalendar--convert-tz-offset
: FAILED icalendar--parse-vtimezone
My latest patch requires some test definitions to be modified as well
as existing commented out code to be commented in.
Background: In light of the way an abandonment of daylight saving time
is expressed in VTIMEZONE, my patch will always make sure that - when
no recurrence rules RRULE are specified - the (most recent) UTC offset
of the most recent DAYLIGHT or STANDARD is returned. This offset is
what counts, IMHO. Computing and using a TZ spec - even a default one
- seems inappropriate for theses cases.
: In addition, the test cases included aren't actually used?
Implicitly, they are when my patch to icalendar-tests.el (below, not a
--git, sorry) is applied. The raw ICS data seem rather large for
incorporation into the Lisp code.
But I'd rather let Ulf have the final say about the patches and how
the data is to be tested.
----------------------------------------------------------------------
diff -Naur icalendar-tests.el.bce7de769e0c024b26729c45c2c27c7f3749c499 icalendar-tests.el
--- icalendar-tests.el.bce7de769e0c024b26729c45c2c27c7f3749c499 2020-10-01 12:59:40.051753100 +0200
+++ icalendar-tests.el 2020-10-01 14:04:42.106937900 +0200
@@ -248,7 +248,7 @@
(setq result (icalendar--parse-vtimezone vtimezone))
(should (string= "Kolkata, Chennai, Mumbai, New Delhi" (car result)))
(message (cdr result))
- (should (string= "STD-05:30DST-05:30,M1.1.1/00:00:00,M1.1.1/00:00:00"
+ (should (string= "STD-05:30"
(cdr result)))
;; FIXME: add testcase that covers changes for fix of bug#34315
@@ -557,28 +557,29 @@
(RRULE nil "FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU"))
t)))
- ;; testcase: dtstart is mandatory
- (should (null (icalendar--convert-tz-offset
+ ;; testcase: dtstart is mandatory but if not set return at least the offset
+ (should (equal '("DST-02:00")
+ (icalendar--convert-tz-offset
'((TZOFFSETFROM nil "+0100")
(TZOFFSETTO nil "+0200")
(RRULE nil "FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU"))
t)))
- ;; FIXME: rrule and rdate are NOT mandatory! Must fix code
- ;; before activating these testcases
- ;; ;; testcase: no rrule and no rdate => no result
- ;; (should (null (icalendar--convert-tz-offset
- ;; '((TZOFFSETFROM nil "+0100")
- ;; (TZOFFSETTO nil "+0200")
- ;; (DTSTART nil "19700329T020000"))
- ;; t)))
- ;; ;; testcase: no rrule with rdate => no result
- ;; (should (null (icalendar--convert-tz-offset
- ;; '((TZOFFSETFROM nil "+0100")
- ;; (TZOFFSETTO nil "+0200")
- ;; (DTSTART nil "18840101T000000")
- ;; (RDATE nil "18840101T000000"))
- ;; t)))
+ ;; rrule and rdate are NOT mandatory: return the offset and a placeholder
+ (should (equal '("DST-02:00" . "19700329T020000")
+ (icalendar--convert-tz-offset
+ '((TZOFFSETFROM nil "+0100")
+ (TZOFFSETTO nil "+0200")
+ (DTSTART nil "19700329T020000"))
+ t)))
+ ;; ;; testcase: no rrule with rdate => return offset and a default TZ spec
+ (should (equal '("DST-02:00" . "M1.1.1/00:00:00")
+ (icalendar--convert-tz-offset
+ '((TZOFFSETFROM nil "+0100")
+ (TZOFFSETTO nil "+0200")
+ (DTSTART nil "18840101T000000")
+ (RDATE nil "18840101T000000"))
+ t)))
)
;; restore time-zone even if something went terribly wrong
(setenv "TZ" tz))))
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
In-Reply-To: <23640.9851.562972.730234@HIDDEN>
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 16:20:02 +0000
Resent-Message-ID: <handler.34315.B34315.160156918524850 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Jan Tatarik <jan.tatarik@HIDDEN>, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.160156918524850
(code B ref 34315); Thu, 01 Oct 2020 16:20:02 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 16:19:45 +0000
Received: from localhost ([127.0.0.1]:38064 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kO1J2-0006Sj-9x
for submit <at> debbugs.gnu.org; Thu, 01 Oct 2020 12:19:45 -0400
Received: from mout.web.de ([212.227.17.12]:40811)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1kO1Iz-0006SV-Tl
for 34315 <at> debbugs.gnu.org; Thu, 01 Oct 2020 12:19:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1601569173;
bh=1vC1MjpGRHf2sBG9oVMYeGCklv0/LbOiuYsjrAlP3iM=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date;
b=FYMEfUSlKpgAq3VRNiRISXQxzMFqksQSVaAFmXrU/TCFwKXwu1vwJb0s8jgZ5kJBP
0Z1pBcQcFUw0ypvawV6n/b03U/leHvMwxXUgZxgQFk4ZjV5Z7btKjc9mjJ2wiyU41B
iUOjbIjoaT1bwK8Ed1oNGU1hwbeYJY24Pbx2j9uo=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.187.48.89]) by smtp.web.de (mrweb103
[213.165.67.124]) with ESMTPSA (Nemesis) id 0Md4pC-1k5wUJ16Xq-00ICKn; Thu, 01
Oct 2020 18:19:33 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN>
Date: Thu, 01 Oct 2020 18:19:29 +0200
Message-ID: <87d021vrzi.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:+6nUcDKS2zwN4srFFYs81ObF9/SIT1njSe9yeS7RXJYXwlnrz9a
ASUewUlViq8P9jkz7skuJyapOq3uLrKEE5H9FLvGTYoINdmOFhfCoqPFScWlxNwDND6eP+S
hVIzM4bHdirt5/PJW7xbRmAYAWTvC60zytxWERdMIYLQ9x+T5/eIqrQ1fFEq0EjxFndCoyc
cBMtwHcsJ03wT/7Gi17TQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:A6c3b9FU1/M=:kMdBlwM1M2Y0lm996rtNbm
FbsiF32XnoiWw2Sl7yTRwMPBUWsLED2FIJvD3jf3WYIXiDjveZ84XRjGSvuNCnfnFquJiY80B
Pc2q7UkMIu/9jwqGqylbkbTDcNo19TMa3wYXDizxM/DSxegLGDTigMcKqWZ/UZu6bWJAO38Ji
VAhAUTM8pVfPpHeP3ydK2IinsI6k1aL2jpP/a9Gx88MvfzNA5p70vTzcDN0vqmwf+q0vPhCQL
AywAIoxKxRd4SzSbq/briEhPWykn/1GrQwYuEYN4jJ0S//X7IcPN2UfgJDoEIR0bJH3Dtfyi5
Zo9GVmEYX1cAcPg8qhvB6/QYOiNEEKh7yk8qCX9/7grWLOpFg2Lz9wDd5VnaVD3+L/W9s9UEd
ZrfSHUE4uvB6m5ofR707crMU9pw5HrzpTjOQjGEGkK1/iWeFJTLljhmrzkHYsxA+aV/AaNoqQ
fCoQtg+LGO/105qzDqeUcxwaht7+J1nLXwMRZxiNoLDMJZ8YQgKuuXK0AMU/usf92V9nc0n+P
HHaoW2wghbCzi8sfBY4hvt+O0W+yYpp0M1gAGDgNrRyznDABhoMeRntJVpE62sPK83hXnp/1S
54dWXOcrPJj2dOKdu8wqYzMaAPF4bC9zRlbB2EYpueNcHBGKkGnf25xaZtDwvylVpPgyiANTM
iJ4iSzm8OC5veqNMZVLzd6ujwN1/DTPoLRBBpQTDUWHkmJIkjWx0rCz6EsffG6uP6K43TcZoA
ocNQjcaTZ5VDrDwkTgIGbU9YJCsDiEIQhxnH9uERwve8W4fHyljXiDa/2FsMRwcZJOix3JD42
QnUoNSD9z0pjJ1VqUjt9OqJrfO0tCVe02C7QSUMef2egfnjEbzG690Iylcp4jWE5x4YHwilpa
nvbfDIR8UEzt6HdK2045S+y58oFBanA0sBKXjWeL9zkjweLv0MzA15837Vs4aRVvKBw2inDmx
46uwCoMNNDrrlNtodPlPhPEcpqP4TSsgFziZo33ImGpZ3lDp5BS/AfYdZNXRDMFUFsCuvWj/z
fxVFLwYC0ewsQr5Rx6Lk5i9N8/gKP9Cb0anD+gE24DGLI9DNY4MYddW/fPgq/pkdg6cC2p0sR
2Iu3saw73vE6BFy0iOySJ7Yue0Bb6m2eZZiVDSe2RvYaKTNE83fuzzBloJz9RR77p4IXBMlJQ
o6zqOB+QpmyxyIEdK4qWaUOJ4wwTWgc+EjNclg+/9+uXAPDEpoVWH/KXQzWDLxX8N2DnvyZBi
SoxFqx2PtDzxwwLuKywh7xmFKLBuU9xF8eWRnGg==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Am 01.10.2020 um 16:38 (+0300) schrieb Thomas Plass:
> But I'd rather let Ulf have the final say about the patches and how
> the data is to be tested.
I agree with Lars here. (Thank you, Lars, for your investigation!)
When patching icalendar.el (or any other file) one must make sure that
the corresponding unit tests do not fail. If necessary the unit tests
need to be adjusted. If possible one should add unit tests so that all
code changes get covered. (And so on -- the usual ideas behind unit
tests.)
It looks like your patch of 'icalendar-tests.el' does not contain
the samples from the ics files. Could you please add these?
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 16:24:01 +0000
Resent-Message-ID: <handler.34315.B34315.160156938325236 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.160156938325236
(code B ref 34315); Thu, 01 Oct 2020 16:24:01 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 16:23:03 +0000
Received: from localhost ([127.0.0.1]:38076 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kO1MF-0006Yx-5x
for submit <at> debbugs.gnu.org; Thu, 01 Oct 2020 12:23:03 -0400
Received: from quimby.gnus.org ([95.216.78.240]:60820)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1kO1ME-0006YH-Az
for 34315 <at> debbugs.gnu.org; Thu, 01 Oct 2020 12:23:02 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=y/a5YQ/Rg8+ftM4dEfoOHjTuiIUrMynSIIHpuwDKeOA=; b=K9qDYkm9nLHDQzdbm0YQwgPRZz
CDvKgHKqlMwz1KX7WKqOqmHQIWybP4lmCisVK4i5nb9wm7eliITeo82GeIb44bjAxuPFSXAfTP9Dq
sO6AgVWe8OLlszF/2hbewKZyKXm2+IaWbonjq2BSB8OB2hOfgkMSCobjzyIRZ5pY/NWc=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1kO1M5-0000RE-Ma; Thu, 01 Oct 2020 18:22:56 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN> <87d021vrzi.fsf@panama>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEVKPyqHd1abjXHC
uaPv6tz////fpjJBAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QKAQ8WHLDIIlUAAAGjSURBVDjLdZIL
loMgDEVhZhYg2AVocAFKsoCpyf7XNA/QI3ba9FQgN7x81LnLvA8wP2AX4uUO+BWCBYfQxVd6eHwH
2nnwXdg7+wi+PoHwCcRbFGz4V9UEQKH12Et9rd8rnjPaHuIhxbJvG/GyKz1sn+Iu41DBYvvvJquo
GmKEbeFWblKbnj/r01SfD+CHWGvQu1Hn7zylCYlY5UHLWgHybUcJA6qJoXjOkWB2gSJ1HfUNHpOt
rZB7teLEP766iWaAeb7fCJEqmInSXSSmlAkAz+6tFvVEADEmzq8gQytSUr4BZGBmoo3NLjAUkAAy
ZSz9jYgEzMrEie0NkJzwBvrWIJFYDFdULjCgORYWUbYsHfBj01EzznJKYegR5SRDUQato1wf0NfI
5azIAavAzyOxjglnFVgBWsCIqpNlwlmar+6cx8CgkXML1QaQvAyOiy2QZtVTy4UyHmFNpVC9tFxM
TYK4Ogyt1FyOGoBKS6rVDZBTi0QHZUx2mjsk0DaSlJaPJI4PUIbRRNri8Nn3gXbu6g2xm2kdif3z
N4ezN1ZKfg9Q+R/7LIx5Xi7N5AAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMC0wMVQxNToyMjoy
OCswMDowMGrgvqYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTAtMDFUMTU6MjI6MjgrMDA6MDAb
vQYaAAAAAElFTkSuQmCC
X-Now-Playing: Mutamassik's _Definitive Works_: "High Alert A'ala Teta
(Interlude for Granma)"
Date: Thu, 01 Oct 2020 18:22:52 +0200
In-Reply-To: <87d021vrzi.fsf@panama> (Ulf Jasper's message of "Thu, 01 Oct
2020 18:19:29 +0200")
Message-ID: <877ds9rk4j.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Ulf Jasper <ulf.jasper@HIDDEN> writes: > It looks like your
patch of 'icalendar-tests.el' does not contain > the samples from the ics
files. Could you please add these? I think putting the sample .ics files
in a separate icalendar-resources directory is the way forward...
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Ulf Jasper <ulf.jasper@HIDDEN> writes:
> It looks like your patch of 'icalendar-tests.el' does not contain
> the samples from the ics files. Could you please add these?
I think putting the sample .ics files in a separate icalendar-resources
directory is the way forward...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 16:56:01 +0000
Resent-Message-ID: <handler.34315.B34315.160157131028469 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.160157131028469
(code B ref 34315); Thu, 01 Oct 2020 16:56:01 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 16:55:10 +0000
Received: from localhost ([127.0.0.1]:38128 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kO1rI-0007P6-Rr
for submit <at> debbugs.gnu.org; Thu, 01 Oct 2020 12:55:09 -0400
Received: from mout.web.de ([212.227.15.4]:55703)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1kO1rF-0007OP-Gm
for 34315 <at> debbugs.gnu.org; Thu, 01 Oct 2020 12:55:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1601571298;
bh=N2uzgDENvdVmTVqfwIpMZ35958EA+LCLmx+CVpODteI=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=aRAorS8HTRZQyUh5YSznl7weA/FYL9uShImWUe+BK5gITFMtzFvQbiAdjnr7pvzQl
2pZtzidLxi6x5xRBqU4+rDMr0Fg0SJx8tlRwX/Q3OMfm2d3YVq85pK5nGWaC8+xr9z
OVsfPoTCdj3W/Mjcw8Sf+69uEsFeoFsnBXK3pbBk=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.187.48.89]) by smtp.web.de (mrweb005
[213.165.67.108]) with ESMTPSA (Nemesis) id 1M5Qq9-1kNCuS3hMT-001BI4; Thu, 01
Oct 2020 18:54:57 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN> <87d021vrzi.fsf@panama>
<877ds9rk4j.fsf@HIDDEN>
Date: Thu, 01 Oct 2020 18:54:56 +0200
In-Reply-To: <877ds9rk4j.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Thu,
01 Oct 2020 18:22:52 +0200")
Message-ID: <878scpvqcf.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:QYJ7IGv33IbsKbKxB3z2+natiygU05MAtA8zRhn1c1iUM7OV/WW
R8TeTffjoPoPpSLRZfHmx3Ag4TpKFGsIpI6iF8SCKrKPfcAgKQyhpCY7ufFWevY2A3i+zXu
kxurafWwExTxE0rW0HZrw4i6IKtQLG9jw4mfvAclrpXsUZUsDXRF/enuiqB3B8Q84Tka8wh
v5cKxWZ+yeebaxNRgdrYA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:9qXRJE8Iujc=:6MgCYhAiTiTb08n9ATpQI/
TX92ZoCYx1MQBvws/SmKznmU7Csd6dtOdK5IJydxXCtAdhO+sGqZVhYf6SWTzGrMN3FVyEo8u
lSVyXeon7Bav4IxavNgAaX45yt5mDbQemGxvi8Otx0bPxlSge8+eeSnxGW+whbBeByMxKhtrj
vWvYOQ27oZJ/0k8G2hzvWVi8UT/yUewQJBZ3K/22wXSc1WPblEP/NUGHttlxf39IDRWQvfwT/
VN8GEJRBsGryBJkFkKkKlnBk2SqADDRsguuSBlDWCetdqUz2WqJ/6aC5ihaOpcEMJ5vCrIV0b
V89EB86dolJr7ZwoNpevlA75cORLSppE7AZg9Pd2MsiEUAjqpNNDKkoJ79/SjIOclNz5iuesq
hFTy5PmGqvmvXfEGQ332U15TILp0yZYRgiQ7lXdggU44vS9ASV+cRe7xKnKheE8fOh1KUDRNd
xsaubDnpDeLdCcGqN3hn5BmIz0MzwVHDz0zRH8e+jpz9W/cWTgaT4xB4Ev3R3rigzgm39tlBh
XRvOsPL2LmHOLUsUw/JjXRXa/mD5MPc45Zx52ZqjOOFkAL8NQ1SF5D/IuxUTX4ItTVSYCKnsq
n+rYOdoRbckMhWNKY5AM6gcNRoSxpTNCVjZoz7mF0k27Qn16nJspqcs6rThCYq0dDOwYU11fL
ZT9BSfNSjXqKpc/U0sJ/ZRhVoZAhwU071fBU8aw6v/mVFKWbYbFoj7BZ9kWALTBiaww3FXqmV
7Xn8zUgAqMpyrXxxsj0pRqPsLSPiavCwDOFdlqmlBb2+/KNS3YrwvoxOWkKXN/H4WRqkDuKaW
MxRT/eCNWS0pHwf/SEulbCLxufnwwLG55xOfMSb3EbzChp8VeHquc2BklAPTXeT4x9aCfnpGM
aR94j5SIM2/0CZEZYy56KSt9661QtBwjCOoCx29VFDa2fZ4WFy0yzCFoGbx3EnCVKAQr9N5/f
O9wMKHlMAmA2degL8XjeyH94lz6tjA9N1vyk0oG1sB632YTAyc34hb0rFk847+h8P4Wusk5JW
+csVej6o6qgYzcHJXHmvXRFIW1dg7NFVqNOJlm9xaoN7HKzPuPH4AOm975uxE8tuhb5U7cX4E
5d63jhyTzHmZ+XZqCP3g9PBskJmFLm137Eh4pJLGraSdrRMJyXzkMx42EQZvidicvP1KTNZyG
9NPcYgeCMRZMxk3XEVvon7AKJXqWALzPl7yD1yyWWuFON0rgCU/5E1DkT/oVoW/yk+zQ/nNW6
e7mezf/MPbVH4j+MF8/FZqW4PKDOo/H1M62QS1w==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Am 01.10.2020 um 18:22 (+0200) schrieb Lars Ingebrigtsen:
> Ulf Jasper <ulf.jasper@HIDDEN> writes:
>
>> It looks like your patch of 'icalendar-tests.el' does not contain
>> the samples from the ics files. Could you please add these?
>
> I think putting the sample .ics files in a separate icalendar-resources
> directory is the way forward...
Currently there is no way to use ics files in icalendar-tests. In the
past we've extracted the relevant handful of lines from such a file and
constructed a testcase from such files. ics files might be useful for
the "real world tests" though.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 17:00:01 +0000
Resent-Message-ID: <handler.34315.B34315.160157155728962 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.160157155728962
(code B ref 34315); Thu, 01 Oct 2020 17:00:01 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 16:59:17 +0000
Received: from localhost ([127.0.0.1]:38136 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kO1vJ-0007X4-51
for submit <at> debbugs.gnu.org; Thu, 01 Oct 2020 12:59:17 -0400
Received: from quimby.gnus.org ([95.216.78.240]:32914)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1kO1vH-0007Wp-Gh
for 34315 <at> debbugs.gnu.org; Thu, 01 Oct 2020 12:59:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=7D7SE38SuT/pFeJXQXZkAYV1/s+hQIPPQFATymG/XfU=; b=hbXdGKVUr1wTZ57/JzbHvUThS3
RxmW9ClmGjJGPz7CVt4DLz0K5j6TpCmgFLMTrCvLTvPLM+rDNHl83SkMfeCMUACwTXi8656pFntOk
VY3DZfbLoBxSafMbGY+dAOsz3gkFBykfBNHA5okMvG4a6qOyVnV4hqv/trr5tCHunNzg=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1kO1v8-0000jg-QS; Thu, 01 Oct 2020 18:59:09 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <87wom1otsw.fsf@panama>
<87zh7267sy.fsf@HIDDEN> <87pn7yo54t.fsf@panama>
<83o8ni4fhu.fsf@HIDDEN> <24369.32256.954408.774614@HIDDEN>
<87y2mlxx8r.fsf@HIDDEN> <87d03x43kz.fsf@panama>
<24371.59842.984273.402129@HIDDEN> <87y2mkknyc.fsf@HIDDEN>
<24371.61149.995030.284670@HIDDEN> <87364rq4yl.fsf@panama>
<87imcwf404.fsf@panama> <24400.43911.666145.400179@HIDDEN>
<874kof2aui.fsf@panama> <24435.1743.473339.944597@HIDDEN>
<874knewwfc.fsf@HIDDEN> <24437.56299.111042.412318@HIDDEN>
<87d021vrzi.fsf@panama> <877ds9rk4j.fsf@HIDDEN>
<878scpvqcf.fsf@panama>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEWeojOusVi0sqPW
1NH29vFsaWH///9lFNI9AAAAAWJLR0QGYWa4fQAAAAd0SU1FB+QKARA6Ge7pWTkAAAGkSURBVDjL
nZJNetwgDIYhTffgpPtYwD6DNAcYUC9g1/e/SiX8h/NMs6gMLHiRvk8YY9bwMq0PfETbdW2YH8wX
4Lw33gm6gg9jRuu10hdwk/oOvKrYC9Dj/vZpXiT1/aIxeP8iU4YZeqDSw9jC2UuGdX70IwyDM54u
dtWSXbt5v4Az7NtzYP0/gFjrXa0CK+jUzWcHehHzWK+8XbIVUHfAzvpDPQBn2sHDu0M+FsIDMG7A
Om2wKqAGdvL6YeIG1gzmx2jdqOYQueIJxAiV0fy82T+y3wFGBFx+LW95RoBAJ6gAsCyLrNOUU+5A
ntKSFg6BC0BqMg1wniFhZALmQJPUPjWmScyrqZxjxbq5oprCEokJZcDhqjmsQIRBjmKmE0gnNSDi
PSNjPTNIwSQH7zmEHuj4PSsoMdS6/hLTrlJLiel7mWJl3DKUI5WZOUFhLryLU/tY2uJ7UtCCjFSJ
CrRAggOgANLOMItfCIyFNiBNyBWAdJElQ5oNsmSM4qqdkR2orFxfQ0Uy518WT/P+3GoPEsBzELDE
p6CPr6DiHvwdeBb1P8BfcTXhhZ9aEUQAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTAtMDFUMTY6
NTg6MjUrMDA6MDCI5DbiAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTEwLTAxVDE2OjU4OjI1KzAw
OjAw+bmOXgAAAABJRU5ErkJggg==
X-Now-Playing: Static's _Re: Talking About Memories_: "One After 808"
Date: Thu, 01 Oct 2020 18:59:05 +0200
In-Reply-To: <878scpvqcf.fsf@panama> (Ulf Jasper's message of "Thu, 01 Oct
2020 18:54:56 +0200")
Message-ID: <87lfgpq3vq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Ulf Jasper <ulf.jasper@HIDDEN> writes: > Currently there is
no way to use ics files in icalendar-tests. In the > past we've extracted
the relevant handful of lines from such a file and > constructed a testcase
from such files. ics files mi [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Ulf Jasper <ulf.jasper@HIDDEN> writes:
> Currently there is no way to use ics files in icalendar-tests. In the
> past we've extracted the relevant handful of lines from such a file and
> constructed a testcase from such files. ics files might be useful for
> the "real world tests" though.
Why can't ics files be used from icalendar-tests?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 18:41:02 +0000
Resent-Message-ID: <handler.34315.B34315.160157764231109 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.160157764231109
(code B ref 34315); Thu, 01 Oct 2020 18:41:02 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 18:40:42 +0000
Received: from localhost ([127.0.0.1]:38305 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kO3VQ-00085f-4n
for submit <at> debbugs.gnu.org; Thu, 01 Oct 2020 14:40:41 -0400
Received: from mout.web.de ([212.227.15.3]:49301)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1kO3VM-00085Q-9s
for 34315 <at> debbugs.gnu.org; Thu, 01 Oct 2020 14:40:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1601577629;
bh=1hZ8mtHw8HSCpR1y9YMqYyPlorgkgsBiktgL6l7kwr4=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=CecqweiYnduRviLIsy80iAmxId3dmY3j9Nn//hYBw1X4fioIQrdKFdUfbmbWlv4U2
3BX0WxmPQrDsE+OMutA+hLiLqqH3qQi5q0xIvpLp9Z7Ypa6HJK9IuJ0GxoCkaWzKQe
a3WSzDVhMevzB+O2u3MrQ9X/7w/EaLJ0pfOy6IMM=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.187.48.89]) by smtp.web.de (mrweb003
[213.165.67.108]) with ESMTPSA (Nemesis) id 0Mhljf-1k1rod43gx-00MrpW; Thu, 01
Oct 2020 20:40:29 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN> <87d021vrzi.fsf@panama>
<877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
<87lfgpq3vq.fsf@HIDDEN>
Date: Thu, 01 Oct 2020 20:40:23 +0200
In-Reply-To: <87lfgpq3vq.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Thu,
01 Oct 2020 18:59:05 +0200")
Message-ID: <874kndvlgo.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:XYYiffWICgzgnZOiYgmN4ZEJEi4S/dj/iHRTKBgLM97tCVzNtzy
Z1+KhO0DsUNWefQbynW6ye9CWUB4tUOcVx5FPz/UJVqIgufepW8M/e113k3rfFld2zcxkAl
B/DxaI0+aPcL30hg7YVPkhvvabMKbzQ1WKzk+RX7nz8XilIgBzYFD6jIqZjpEtkpGlfB9wI
Mn9fHoKEj3qJW0PYOFr2g==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:0y2lPMhyr0I=:ccMRWyYcWDFlfz2GSrzIxT
QyA5AJEeQCNHLeXaqKaFLQ2pY142q/l9uRGoFSHkr++230G/WNNi/o10dM/9e2W6ZuJTIyohS
eOH2nWpCWwr/eM7Ho3dMCSw6rDtByuBQIi2QvyiuKcxGrOwaE4a9OLpAOQXSJM8l0ktLNi2+8
9IKlZ+kpw51uEOcjeBmMQjbG1/ntuNGQnBLXjpZLZpfLpdcKgX3sa2pDSb91+NSCK3q+pukh9
HeXk7Cka1kik9SYug3DCh/bTGWXuK5uzGJF4XCh/B7ZnmJHdR//nOuz9oOT5QFAaLfJbo+EvY
1aFiFVZOhL1CcRWgdQvMO0R173ST7YCyV0fBuKDDvETEKdC0IVxv1e4li3Hk2Kb+93ExzBGae
G3FCmv+XR/gXHnZjoktgJJJn7MzRg5z1xk75andfvYXh168/WzDE+OUpS+cM4QBld19Xfzx9p
+zwOwqOVxDUTVrCWIriqxjnPemvtm9PodxPgg7dIN22j5jmgotOfPlylN4Dp/mj68DsABWOSp
EW1pcLrLMy+29LYVS7CV+3QrvouOABkgmOPYZrlhg/ruxpN3ZCXSm5yiTUUmW2+9I6ncJRvlq
Km/nJMcqGumv/9Z7kYBmiitgvoTuKvaHN63F2SuSGdpHC5ay3mrKTYhWoPf6dWbwW13Vxw7sb
3FaYjdWBqpgHpN+Yh41ksURrGSYv9ETLPd5tM6IuHed/m6y9cazF0YcM07V4Efg1RZJSr6KC9
Kz4s/UjanMAv9CZyTGCP7ko9lkaZ5uiaL8ZYF9TyuVbEw+ZP8fRNMU//C/DnRKgCa2hvtYTxq
e0Y9iCxM2jFtz7rC6/TxNJqrm19KJdKMct8bz8YiETFCig10aR1wZhFODeIFrkMx2EgVCh195
SdcAdKSgkfwLHr6GYeYb8/bDML8yazqvElO6CHxpx/LXg29LEDnODlUxeidfntwLk5j3EyJJD
WXVdNwyBjb8nhbgYlcKRpalbCCQ2qKAf5SZnlIiQKvEg7FxkpkDjczBzaflemDzFx1kARRhJt
2UPKvm7ftx/bVubjyUXhDA6puyGlsSZBl9QgO58ePudUSB7REL5Px5MUaxRNgeJKeOl98KDCu
2KhNkasLwfDbyIPoUoDQZbObFX5MN9mcl3ENEATLZ+dmi9nKNBqFhFEErX8/NoJV2NAzdy5C3
eBoGvZSgTzEZ7jGGTW8xrimabuppd/hkrumwJH7f0187QJoBhYRFtaun7h7GpMTCt8YcH6rJC
ovYxwiry4GnfcJgEyI2WxzR1AyStgGmG49OBx6g==
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Am 01.10.2020 um 18:59 (+0200) schrieb Lars Ingebrigtsen:
> Why can't ics files be used from icalendar-tests?
Because it has not been implemented.
Right now 'icalendar-tests.el' contains input data together with the
corresponding expected results. When we move input data into separate
files, we should do the same for the expected results. For each ics
file there should be a corresponding expected-result file. That's not a
big deal. It just has not been done yet.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 18:49:01 +0000
Resent-Message-ID: <handler.34315.B34315.16015780897522 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.16015780897522
(code B ref 34315); Thu, 01 Oct 2020 18:49:01 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 18:48:09 +0000
Received: from localhost ([127.0.0.1]:38313 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kO3ce-0001xG-O9
for submit <at> debbugs.gnu.org; Thu, 01 Oct 2020 14:48:09 -0400
Received: from quimby.gnus.org ([95.216.78.240]:34270)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1kO3cQ-0001wa-Sb
for 34315 <at> debbugs.gnu.org; Thu, 01 Oct 2020 14:48:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=5ISri7sOx+UDbRJYVSm1U/RrIZDRXc0t1lVgyGxwc+Y=; b=Rxz58NIvd4VHDyXRyDaqIHBeu3
jOecYQkcYPqcP4hKhKA6rnXXytbz1VV/npNnSoMPTrwytnqKkIyPiOKKD3MRKyVvB2JnoDwL8Mzfs
kH4DzEgT4w/SvvmZgJEKWo3Js8fuC3QmPH/nSRXbE2LU8KFSxfeCL2j5fVUMqLYb+8iw=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1kO3cD-0002BM-4c; Thu, 01 Oct 2020 20:47:48 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <87pn7yo54t.fsf@panama>
<83o8ni4fhu.fsf@HIDDEN> <24369.32256.954408.774614@HIDDEN>
<87y2mlxx8r.fsf@HIDDEN> <87d03x43kz.fsf@panama>
<24371.59842.984273.402129@HIDDEN> <87y2mkknyc.fsf@HIDDEN>
<24371.61149.995030.284670@HIDDEN> <87364rq4yl.fsf@panama>
<87imcwf404.fsf@panama> <24400.43911.666145.400179@HIDDEN>
<874kof2aui.fsf@panama> <24435.1743.473339.944597@HIDDEN>
<874knewwfc.fsf@HIDDEN> <24437.56299.111042.412318@HIDDEN>
<87d021vrzi.fsf@panama> <877ds9rk4j.fsf@HIDDEN>
<878scpvqcf.fsf@panama> <87lfgpq3vq.fsf@HIDDEN>
<874kndvlgo.fsf@panama>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj
SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEWXbEaac0////9M
TvLDAAAAAWJLR0QCZgt8ZAAAAAd0SU1FB+QKARIEM3cTX/wAAAEoSURBVCjPTZJNrsYgCEUxgblf
AvvBpM41KfvfyrtXO3gd9VQ4/FiJ/YZKurVMifEQujZJccvuIq4tl8TEB+lltguwUkXKZpXYgGD1
sLEXwbRr4H1JH6kIA7yAeQA550SEEEUbwMSvIIY1u7IXoO3pQQFgMsdjDpzoEVjxEd1woQ6Stuia
bXjEZI5uA9gFr1MUNd+Ch0XlCjA7Ic48D0ZviDztPO1C4zx+gXVg++W1nQ7af4BAjmAcYHMUIGec
Ez+CVUpzGHeg46z8Cp5txpUjrCSXcak22cHahCBAgFTsvWpf2wUKZGkkNzrHhgAACfa2PpgQIAf3
hjBuBzmAen/fRrM/3wnC8G/EcrtXkj4JbOAKVp+I2p+gHcEW72L4G2oWij7OeSBAzh9gyF5AZeCr
OQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0xMC0wMVQxODowNDo1MCswMDowMEGUUCAAAAAldEVY
dGRhdGU6bW9kaWZ5ADIwMjAtMTAtMDFUMTg6MDQ6NTArMDA6MDAwyeicAAAAAElFTkSuQmCC
X-Now-Playing: Nanang Tatang's _Muki_: "Last Train Out"
Date: Thu, 01 Oct 2020 20:47:39 +0200
In-Reply-To: <874kndvlgo.fsf@panama> (Ulf Jasper's message of "Thu, 01 Oct
2020 20:40:23 +0200")
Message-ID: <87362x3hro.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Ulf Jasper <ulf.jasper@HIDDEN> writes: > Am 01.10.2020 um
18:59 (+0200) schrieb Lars Ingebrigtsen: > >> Why can't ics files be used
from icalendar-tests? > > Because it has not been implemented. > > Right now
'icalendar-tests.el' contains [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Ulf Jasper <ulf.jasper@HIDDEN> writes:
> Am 01.10.2020 um 18:59 (+0200) schrieb Lars Ingebrigtsen:
>
>> Why can't ics files be used from icalendar-tests?
>
> Because it has not been implemented.
>
> Right now 'icalendar-tests.el' contains input data together with the
> corresponding expected results. When we move input data into separate
> files, we should do the same for the expected results. For each ics
> file there should be a corresponding expected-result file. That's not a
> big deal. It just has not been done yet.
Oh, OK, I thought you meant there was something somehow fundamentally
precluding putting the ics data into files.
But surely not all the tests are transforms in this way. Reading an ics
file and having a test that says "what's the meeting time in this file?"
should be a fine test, right?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 18:50:01 +0000
Resent-Message-ID: <handler.34315.B34315.16015781747652 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Jan Tatarik <jan.tatarik@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Thomas Plass <thunk2@HIDDEN>
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.16015781747652
(code B ref 34315); Thu, 01 Oct 2020 18:50:01 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 18:49:34 +0000
Received: from localhost ([127.0.0.1]:38317 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kO3e2-0001zL-Cb
for submit <at> debbugs.gnu.org; Thu, 01 Oct 2020 14:49:34 -0400
Received: from vsmx012.vodafonemail.xion.oxcs.net ([153.92.174.90]:50874)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1kO3dz-0001z7-7L
for 34315 <at> debbugs.gnu.org; Thu, 01 Oct 2020 14:49:33 -0400
Received: from vsmx004.vodafonemail.xion.oxcs.net (unknown [192.168.75.198])
by mta-8-out.mta.xion.oxcs.net (Postfix) with ESMTP id 254BAF3534F;
Thu, 1 Oct 2020 18:49:25 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.200.173.137])
by mta-8-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 67AC419AE5F;
Thu, 1 Oct 2020 18:49:12 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24438.9378.994810.275603@HIDDEN>
Date: Thu, 1 Oct 2020 21:49:06 +0300
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Thursday, October 1 2020 18:54:56
(ID: <878scpvqcf.fsf@panama>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN> <87d021vrzi.fsf@panama>
<877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
X-VADE-STATUS: LEGIT
X-Spam-Score: -0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)
I'd like to get some guidance from people involved on the following proposal:
Ulf Jasper wrote at 18:54 on October 1, 2020:
: Currently there is no way to use ics files in icalendar-tests.
Would it be acceptable to:
- create a directory root/test/lisp/calendar/icalendar-resources
- extend icalendar-tests.el with the following:
(defvar icalendar-resources-directory "icalendar-resources"
"Name of directory containing ICS files.
This directory is relative to icalendar-tests.el.")
(defun icalendar-tests--get-ical-from-file (ics-file &optional component)
"Return iCalendar data structures from ICS-FILE.
Optional symbol COMPONENT names a top-level component like 'VTIMEZONE."
(let (ical)
(if (file-exists-p ics-file)
(save-excursion
(with-temp-buffer
(insert-file-contents ics-file)
(goto-char (point-min))
(setq ical (car (icalendar--read-element nil nil)))
(if component
(setq res (car (icalendar--get-children ical component)))
(setq res ical))))
(error "Can't find ICS file %s" ics-file))))
Which could be used thusly in the definition of 'icalendar--parse-vtimezone:
(ert-deftest icalendar--parse-vtimezone ()
"Test method for `icalendar--parse-vtimezone'."
(let (vtimezone result)
(setq vtimezone (icalendar-tests--get-ical-from-file
(concat (file-name-as-directory icalendar-resources-directory)
"Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_tzurl_org.ics")
'VTIMEZONE))
(setq result (icalendar--parse-vtimezone vtimezone))
(should (string= "Asia/Shanghai" (car result)))
(message (cdr result))
(should (string= "STD-08:00"
(cdr result)))
...
))
I have no idea how the test code is run, in particular how
(concat (file-name-as-directory icalendar-resources-directory)
"Asia_Shanghai_20200916T070000_in-calendar_VTIMEZONE_tzurl_org.ics")
could be made to resolve.
Also, I cannot alter the git.
Please advise.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: thunk2@HIDDEN (Thomas Plass)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 18:55:02 +0000
Resent-Message-ID: <handler.34315.B34315.16015784618065 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: Ulf Jasper <ulf.jasper@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Jan Tatarik <jan.tatarik@HIDDEN>, 34315 <at> debbugs.gnu.org
Reply-To: Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.16015784618065
(code B ref 34315); Thu, 01 Oct 2020 18:55:02 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 18:54:21 +0000
Received: from localhost ([127.0.0.1]:38321 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kO3ie-000261-VK
for submit <at> debbugs.gnu.org; Thu, 01 Oct 2020 14:54:21 -0400
Received: from mx009.vodafonemail.xion.oxcs.net ([153.92.174.39]:14416)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <thunk2@HIDDEN>) id 1kO3id-00025o-MM
for 34315 <at> debbugs.gnu.org; Thu, 01 Oct 2020 14:54:20 -0400
Received: from vsmx002.vodafonemail.xion.oxcs.net (unknown [192.168.75.192])
by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTP id 1739F605707;
Thu, 1 Oct 2020 18:54:14 +0000 (UTC)
Received: from agame7.arcor.de (unknown [2.200.173.137])
by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 6DDFF605453;
Thu, 1 Oct 2020 18:54:01 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24438.9667.925336.969882@HIDDEN>
Date: Thu, 1 Oct 2020 21:53:55 +0300
From: thunk2@HIDDEN (Thomas Plass)
In-Reply-To: Your message of Thursday, October 1 2020 21:49:06
(ID: <24438.9378.994810.275603@HIDDEN>).
References: <23640.9851.562972.730234@HIDDEN> <875ztog7hx.fsf@panama>
<87wom1otsw.fsf@panama> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN> <87d021vrzi.fsf@panama>
<877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
<24438.9378.994810.275603@HIDDEN>
X-VADE-STATUS: LEGIT
X-Spam-Score: -1.8 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.8 (--)
Cleaned up version:
(defun icalendar-tests--get-ical-from-file (ics-file &optional component)
"Return iCalendar data structures from ICS-FILE.
Optional symbol COMPONENT names a top-level component like 'VTIMEZONE."
(let (ical)
(if (file-exists-p ics-file)
(save-excursion
(with-temp-buffer
(insert-file-contents ics-file)
(goto-char (point-min))
(setq ical (car (icalendar--read-element nil nil)))
(if component
(car (icalendar--get-children ical component))
ical)))
(error "Can't find ICS file %s" ics-file))))
Thomas Plass wrote at 21:49 on October 1, 2020:
:
: - extend icalendar-tests.el with the following:
:
: (defvar icalendar-resources-directory "icalendar-resources"
: "Name of directory containing ICS files.
: This directory is relative to icalendar-tests.el.")
:
: (defun icalendar-tests--get-ical-from-file (ics-file &optional component)
: "Return iCalendar data structures from ICS-FILE.
: Optional symbol COMPONENT names a top-level component like 'VTIMEZONE."
: (let (ical)
: (if (file-exists-p ics-file)
: (save-excursion
: (with-temp-buffer
: (insert-file-contents ics-file)
: (goto-char (point-min))
: (setq ical (car (icalendar--read-element nil nil)))
: (if component
: (setq res (car (icalendar--get-children ical component)))
: (setq res ical))))
: (error "Can't find ICS file %s" ics-file))))
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 19:02:02 +0000
Resent-Message-ID: <handler.34315.B34315.16015788678778 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.16015788678778
(code B ref 34315); Thu, 01 Oct 2020 19:02:02 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 19:01:07 +0000
Received: from localhost ([127.0.0.1]:38334 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kO3pD-0002HW-5G
for submit <at> debbugs.gnu.org; Thu, 01 Oct 2020 15:01:07 -0400
Received: from mout.web.de ([212.227.15.3]:52467)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1kO3pB-0002Gn-LW
for 34315 <at> debbugs.gnu.org; Thu, 01 Oct 2020 15:01:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1601578858;
bh=m1018dfEnlHwo1hImzBDMKQdbJRFBsK7R53uUhaofro=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=SYttVjnJlv33MYUYEXTnsxE1lG77+Brg1BUAlqOqs2H6B6u5REVjEkwf+6gwiw7L4
wT+AvdnA2pG3wtt4ZNURdEhEz0GEVZD259vEWs6a7xQWpO0ENMmYQne6RGpv0W6LE1
tlK43jfFL6x+TZJ7r46glEN2mAJRohCjsrn8a6Hw=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.187.48.89]) by smtp.web.de (mrweb001
[213.165.67.108]) with ESMTPSA (Nemesis) id 0MEVU9-1kDKJH1GfJ-00FhRd; Thu, 01
Oct 2020 21:00:58 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN> <87d021vrzi.fsf@panama>
<877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
<87lfgpq3vq.fsf@HIDDEN> <874kndvlgo.fsf@panama>
<87362x3hro.fsf@HIDDEN>
Date: Thu, 01 Oct 2020 21:00:57 +0200
In-Reply-To: <87362x3hro.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Thu,
01 Oct 2020 20:47:39 +0200")
Message-ID: <87sgaxu5xy.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:wnF8rNP586wVb/NuAsOq1gZtj0ddQW+AChD5O9MCWWBlJxfA/sJ
YT3ncm3p3AWhnT7adktftbpSD8+wOVnbxFzWUxwPoXkHrxfRU1/pxT/Gzgkz+VN+8svx4XU
uPfi6w/y/PEj2K97866n2iyAnGvkILhwlcGkc0pso1ka3OgBYMty2mlp/ovM4rPkQqaQgW+
ZOWEbJKBqmC+a6AJcOeqg==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:J2Syj3l+By0=:NsCH8dbMw/WSDji9Zh90OJ
pfg0zY2zl7dwBdGyh2hjRMxMRi+gstXOs5hG+IrQXxVMf2viCWuWBDDjQZrxN2Gmk2wslPo/X
pwLZa9Vuk+1x9IOpmsY3I9p5Gey4YHQ/cZKSpEij83ittd+3BbH7tsc5PtuPx3pjbrKkH7P41
2mhiE6rF3m0rc8QGgTFwBw6Ee62AXVFkRU5Ho3fYJFoLDIHZVqbeqbp3emqJeiEZA0O3LEOkK
GhcQ7Og5zRl1seiI7O162QjHpLoxaFVeMNJAzlDznNSIEpDc6K2ugXYKET3bOl2XqJAtpyzTO
vthx0YHmtKq7VUOMZxGM26lXyBQVoQh164p/C6fmcKsVQa7LoJwfINbhaxzvDNh0/LE0ETZhJ
aS4n1TzS7XX9L8ie2QHDkvWzDqH4qfKpultBETxBlmjl+ib0/Ysp1PZLnRGodnctfUh0desMJ
rAj1mKXvtPnzPioM9aPrDSYb+mkNgkQOYckCfTmqFRpH7rtx9jRY4+55LP4UlcrxUiWKFosQG
CyYESFnnYZKTW99noZKwxsl8YcBmDxn3bCodQFVFjPuK7t5Rpt+pXe8tosJ1EMGEBvjDM+LxK
cjLQAf0QYGpPBIM+wPaDaYG5n94aCMz5x9rMaSWyP2K7WR0811T3EOzWKtWBU3jcn5wLtJwUd
e48mHXTbD8fI4H6U4cqsuZaMlwewrYoJVWCW+EiLF2I0eSU5OtxMndzsQb9J39nUHvO/0YJxx
1tzR4aMMrns3WbA8mtad1vI0AMPVh1nBwf5lxISF48OYchOAv7uwaKJ6QR2gPc+d2XOo3k8f7
L7VWljmxwhGeEurW6JHiH9BjDOX0jHDbJ9c/BO/tv51aEBHzmPaVvIsE+c0US66I4cv4Pyobf
ml4HO6OLDyALnOcYRw4imBz3bUYV0VZoeZil2RGTyt5620XKjcnJM3j/2GJV0gXqjCS3Zq1yz
fshEu0BgaHaKtMA7KigtAxK7lGypY6EECPWoPljPebCTfAOAfaajf30GDOMsmNfAuDGsOzbPt
T89Ho8Pbn4LfI6sEVD2ZaM8zPk93pPPebHcLKjqKxHe2/JwBs6q/AYU7ov76ysSa4HSzo/Z3u
WB9bxbc11p6TSAyGmHx5j5yejo1pdEFcjuYgIcombVVm+OCAN0k3LmWQO2Pek3gEQFNO+ZIMs
HStuK24XrsmTfkzI39UHNO5TUmv3KOqYoS3w8iQk5/iJMyrwE2AbXIsI5I4zu0+ThP7nYp7au
Smass8qzvNYUQUtuh+ymL6giZJxLW0437ZUhXeQ==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Am 01.10.2020 um 20:47 (+0200) schrieb Lars Ingebrigtsen:
> But surely not all the tests are transforms in this way. Reading an ics
> file and having a test that says "what's the meeting time in this file?"
> should be a fine test, right?
Basically icalendar.el just does transformations from ics to Emacs diary
and vice versa. Correspondingly icalendar-tests consist of import and
export tests plus tests of lower-level functions. The file based
approach would apply to the im-/export tests only.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Oct 2020 19:15:02 +0000
Resent-Message-ID: <handler.34315.B34315.160157969410128 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: thunk2@HIDDEN (Thomas Plass)
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Jan Tatarik <jan.tatarik@HIDDEN>, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.160157969410128
(code B ref 34315); Thu, 01 Oct 2020 19:15:02 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2020 19:14:54 +0000
Received: from localhost ([127.0.0.1]:38377 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kO42X-0002dI-MO
for submit <at> debbugs.gnu.org; Thu, 01 Oct 2020 15:14:53 -0400
Received: from mout.web.de ([212.227.17.12]:34571)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1kO42W-0002cw-Bi
for 34315 <at> debbugs.gnu.org; Thu, 01 Oct 2020 15:14:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1601579684;
bh=3SdXiQcaMgDWfwgY2dp9BwMvk2jzQ7uqTp6HJM79uIk=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=KbeHlt3uENtvMUWqSRUUCtpZ6iNfH6VFQXLS4R0JhDr1BpwWcC6gUtc3lE934bAKY
ZF+nIVJ88fchkDduhBSd0AniIZlT7RK7kafWD+u33y5+ze8aG6m/hbXcKixz4oQoFD
hvd3kSs0hY+a3wHAjkqNOp7NYtXxgANFlq6776sQ=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.187.48.89]) by smtp.web.de (mrweb101
[213.165.67.124]) with ESMTPSA (Nemesis) id 0LlWKh-1kw1kB38dD-00bIwG; Thu, 01
Oct 2020 21:14:44 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <87zh7267sy.fsf@HIDDEN>
<87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN> <87d021vrzi.fsf@panama>
<877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
<24438.9378.994810.275603@HIDDEN>
Date: Thu, 01 Oct 2020 21:14:43 +0200
In-Reply-To: <24438.9378.994810.275603@HIDDEN> (Thomas Plass's message
of "Thu, 1 Oct 2020 21:49:06 +0300")
Message-ID: <87o8llu5b0.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:Cxt1gbDqfDr/GgXqLOI/cYnJPpNo5YxsOqVjP6W8vbExHKO77aR
3dpLdHlUWi0SPE/3NH0A9EZDfybIrux9Pp3lFIeiAnXFh0THGrQqMSbnJlTbBi2LK+Cv3eg
gwP1XyZhBW1KEDl+YKUl+bM52LBQr1KMfqwD4pLeqVg+EwS+e9klCYj2BGnzPwo6PL1XOah
HcLA5XaLPHt73H1h8wjwA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:zc3x4ETfn1k=:V5lIFsLprEeuDBrEnNdBZj
K+dqFcc4B2jAsmaMdL8qIa3fDKzwKL7O/rW8GOlEBob38N7UWhp8H6PfMZxDtlWY0Z8K4gSeT
ZsIw+vpfRN1kv0C0qxLIPEsAh8mYfu36Lngvm0/EMr6n/8kJqHLn7JLw2XA9Lm/r7Xp7Ytxd7
+YKuHQt+lksLo5jq0rKKVajaay7JwWLqkfCLINETmnCXlwQsBezFD9oK2SZ55z1BPOgou9Xti
ZN7/cEstjy0BInkYlxcrt8JqcNrshhc0mL5b2VzWve0/AfvkpKO2OClOIE5lJY0knctbfaYiI
antyOg6D5LFwNAZmOA5JA+Vzrp4pBIUXf2n/IhrLTn6YxDpKJOxMcu207iccQebnaJNb7OkK5
iQUYzc6wn1EA4Gtb5O5YodmgptxA9RVYTqm8xqddkRbAvLwRnxwKT85hmzefg2CXNdBGlylcZ
VGV0zjUwlQ42eVOGG2jl8N3FAs777r89Kp8Jy1X4mTFzdsycORejCPHpVOikBcz/2fC+OvtXw
JWJ6BsHmB3gPQO0UH5jvzCJsio8BqvcDdXsm1TBF8eghi7M/bT2QCr9n1wC5K1qmfklZecGVw
/mMyZP7qU29tcREP6pFhR3d1KouMtOrOa1f2QZf2A7dh80X6Frw+HvVehlWs+bdmx+8ar13/L
pCIA7zkE6xvy0P9gr77prqpOtN38BpW2/xgOCZAm3tXKITV2Qjx6BPREXEReEAqX2MelRoAJq
jtXyn6tDuTCF7i2TkJ9bsN+Y9Qph2xXdF/Ei6bJHSU5tGgYEke+5PHbtcM/A0sTOH3R/5f8O4
raOiXxPVaHCnyOF4vwFzjKQHF7PgfOlmCGQ0S9sw4NEEjqagatDbTQOb9gDPT/FAk1e6Vh1V9
pX7k7fsp8JIamSPsgQjFUX/oDvy52Db5CdnGgxplZOrC67OPS4ylOV5J/3bd236s2N4wf9DCq
RX5/IzN8Kj2gLsiHrV4T68PJtx0TSCnq7GkQbg8bldNIVrTNXWwgRPVJtOtTTbsnisR9qZVYD
PctDmDhd6zQV7ea0Ob8ipwKtPqIyo1vJeeS9CAgD1V1g622rWbkp5Ndw5KXN2bfOClOjuSJEu
XmJy5DTPKecXHopBHIL77kZGpAvDy8FWf/TPSqsTpP5wY6FWua88fKy0+wm0GlB/1mXaphB56
27J+CRkv4S6lNDLnlRgSgyua3jzbtDLHYEttpU9h0AWHqTn7Uh7NKUOQSsxJU5kXTlrqX+Z5A
i7uv+InCfanF4J9NLUdDzHLl2eVoapOHHlLaVAg==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Am 01.10.2020 um 21:49 (+0300) schrieb Thomas Plass:
> I'd like to get some guidance from people involved on the following
> proposal:
That is close to what I have in mind. When we out-source test input
data, we should do the same with the corresponding expected results. A
unit test case would look something like this.
- read input data from ics file
- read expected result from corresponding file
- perform action under test on input data
- compare result with previously read expected result
I could write the necessary helper functions and then, for a start,
apply this scheme to the "real world" tests in icalendar-tests.el.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 10 Oct 2020 20:07:02 +0000
Resent-Message-ID: <handler.34315.B34315.160236039229502 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.160236039229502
(code B ref 34315); Sat, 10 Oct 2020 20:07:02 +0000
Received: (at 34315) by debbugs.gnu.org; 10 Oct 2020 20:06:32 +0000
Received: from localhost ([127.0.0.1]:38623 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kRL8M-0007fi-T5
for submit <at> debbugs.gnu.org; Sat, 10 Oct 2020 16:06:32 -0400
Received: from quimby.gnus.org ([95.216.78.240]:52906)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1kRL8K-0007fU-87
for 34315 <at> debbugs.gnu.org; Sat, 10 Oct 2020 16:06:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=zExU+JGax/Hqd5jzmcJOvMEIUTSSvY09a3OjthzDB/4=; b=rcy5CDJV46jDKJt7AWE6VNCptX
IQfBQRYiP2HMIxi8wC22Kbz0IlG0P45dnsqJ9bIhP3ATeE4ulP1PJ4LO2c8OFrFugc304Mr1gtHyf
i94TZhnSFP7sqAxIrTdMg4tDk8A8oZ8ksjSKxJHs3WH6/4K/4+kc0BYxracyTglC/BLM=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1kRL8B-00063I-Lm; Sat, 10 Oct 2020 22:06:18 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <87pn7yo54t.fsf@panama>
<83o8ni4fhu.fsf@HIDDEN> <24369.32256.954408.774614@HIDDEN>
<87y2mlxx8r.fsf@HIDDEN> <87d03x43kz.fsf@panama>
<24371.59842.984273.402129@HIDDEN> <87y2mkknyc.fsf@HIDDEN>
<24371.61149.995030.284670@HIDDEN> <87364rq4yl.fsf@panama>
<87imcwf404.fsf@panama> <24400.43911.666145.400179@HIDDEN>
<874kof2aui.fsf@panama> <24435.1743.473339.944597@HIDDEN>
<874knewwfc.fsf@HIDDEN> <24437.56299.111042.412318@HIDDEN>
<87d021vrzi.fsf@panama> <877ds9rk4j.fsf@HIDDEN>
<878scpvqcf.fsf@panama> <24438.9378.994810.275603@HIDDEN>
<87o8llu5b0.fsf@panama>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAHlBMVEV2cHKUjYyEfoCh
m5lYUlJBPDwZFhaCe32FgH3///8F2ZJAAAAAAWJLR0QJ8dml7AAAAAd0SU1FB+QKChMuMFeyL1gA
AAGqSURBVDjLtdIxr5swEADgqwR4jeOXxxwW1lj07UbPZk4lzPwqYXd1o0j+B/3dPTsJHGnWekDg
z3enOwPf+It15Ht4Cbj+PxxXEEbi8/QjfzQNgSHtTT/T+75tmjVV5Tk/+BzRxguBd/+J2OP5JsRI
wTF7TcATHAn0k/91uEfQVPzDe98zvt9HAApiQPjCLDECozXEhDDvWLy0AASExH3vAksRFPgpgce9
Z/ieQSXBGu0CcgEWMz7BGQEoCPnxAPgXpgUwXf8ofhjHwtoVPhfQunwJ72dt7DTDvcgKf2bj3eQA
Ao0QOEM3eOftM0gcrkbQN1hSCcEHP9sJgdUUug7v21ucOzAW1lTiBvdhkRpY4gGjotDJjpc51R1g
AckL7xJYvYngsi7dOFrrjVFrhBBSvhk3am291mpTg5+uZzxWYOeaRnSyfvuCOoLZQic4lHmwg6LQ
4USgwKYj2wK2x8N1TjddKSDFE7Crg1iHaswAlxvgffzeIbShmhWBvHZOsSZWLkMgV7vzmmGE28wK
UyGMrIXSafX0MwTvVARtbgAPOPU4XQXFaHIbEP4C9tKtFFmXn98AAAAldEVYdGRhdGU6Y3JlYXRl
ADIwMjAtMTAtMTBUMTk6NDY6NDgrMDA6MDD+pT4xAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTEw
LTEwVDE5OjQ2OjQ4KzAwOjAwj/iGjQAAAABJRU5ErkJggg==
X-Now-Playing: David Sylvian's _Sleepwalkers_: "Exit-Delete"
Date: Sat, 10 Oct 2020 22:06:14 +0200
In-Reply-To: <87o8llu5b0.fsf@panama> (Ulf Jasper's message of "Thu, 01 Oct
2020 21:14:43 +0200")
Message-ID: <87h7r13ky1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Ulf Jasper <ulf.jasper@HIDDEN> writes: > - read input data
from ics file > - read expected result from corresponding file > - perform
action under test on input data > - compare result with previously read
expected result > > I could write [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Ulf Jasper <ulf.jasper@HIDDEN> writes:
> - read input data from ics file
> - read expected result from corresponding file
> - perform action under test on input data
> - compare result with previously read expected result
>
> I could write the necessary helper functions and then, for a start,
> apply this scheme to the "real world" tests in icalendar-tests.el.
Sounds like a good plan to me.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 22 Oct 2020 15:51:02 +0000
Resent-Message-ID: <handler.34315.B34315.160338184922082 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>, Thomas Plass <thunk2@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.160338184922082
(code B ref 34315); Thu, 22 Oct 2020 15:51:02 +0000
Received: (at 34315) by debbugs.gnu.org; 22 Oct 2020 15:50:49 +0000
Received: from localhost ([127.0.0.1]:53598 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kVcrY-0005k6-PO
for submit <at> debbugs.gnu.org; Thu, 22 Oct 2020 11:50:48 -0400
Received: from mout.web.de ([212.227.15.3]:57253)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1kVcrX-0005js-8k
for 34315 <at> debbugs.gnu.org; Thu, 22 Oct 2020 11:50:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1603381838;
bh=dvWUN2ys2FH8pwKHP3Fe5u/Bi0G5HKLhfUD8mhUH48k=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=H3DE0ShIt9h6WNLMU6JCkvHZrJ43hjBLLzOPIRnIPrM/aA0Xa/VRewJEXUP3ZSHDP
8j/TcKOtFye9kyq8FfQwDRm2iDXcy/0Livom7k+LKfoTeG7Ks2qma5zzJxqIQ4+uyj
jJEfD4of6pl8NZpt1YzLhOVATrwjj5MG16o/VtNc=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([87.187.56.96]) by smtp.web.de (mrweb001
[213.165.67.108]) with ESMTPSA (Nemesis) id 0M8hhT-1k9qkn0KEV-00wEtz; Thu, 22
Oct 2020 17:50:38 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN> <87d021vrzi.fsf@panama>
<877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
<24438.9378.994810.275603@HIDDEN> <87o8llu5b0.fsf@panama>
<87h7r13ky1.fsf@HIDDEN>
Date: Thu, 22 Oct 2020 17:50:34 +0200
In-Reply-To: <87h7r13ky1.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Sat,
10 Oct 2020 22:06:14 +0200")
Message-ID: <87zh4exnsl.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:Cni1Djokw1mCxmbjcaOphS1LNlXgsuutdGZxFftRh8dWbmz86Oz
xV47VVcxqSx3gauwGInY7c7GyEXvXVrnrmSiRWLj7gHBmGdaOxDE53RIclGoBSZ+j8Nv11m
dOZXmcKlGIYVjW9pk9BSMHQJO3oyi1W+TTu/J3hG8WcTlqvTXmB7n9PStCz8Vk9ZphkoYJy
Npr9I3c+eMDw6jmO+H9tQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:RO3TXkO14qw=:4Z4OClfi0+L9nxG6GHgVYQ
hWq8eilHlVHPyhcFe5K7A6cB2s5T1eaBeLA2hdVflrqdtvCdHsUaBLaiwCsYnQe9CWukL9Nq4
ZBLQ74C8Bc5yzE4fy/9GNc/GBL9nDmJj0142JGolw7nI+qYrpHrne0groBnWh3zBVwY2HYB4m
LYcg+GmKp2cCMhpfjUKpK9dFZp7F78xG79roL3nb18fTp3n3wYvQdC7+11/PbMj/dzVs5QxZ9
/1RSPSR60AInH0MSD/VuEW60hkobpTIWj9oYoUiI618aiwp7cCKPejvkjTTA33tvO0TzjqThI
bDk0bBZKcaxQpalwnZmR5aoh7BAg1jz7TPhXrOsvfO498uvFDHiWSja6S1Mbnp30smLx0GVgy
UnG2CbD7dmYbPEgTIHHUA6E0Y4p5ExG114UI9Pq6Ko4PCyv0iLqnwb7JcBtAQCxPKUU45z2qS
lB2fILddUr/zRH0UUPIMMkNzhj6tzrCoNwsuHqztcZiVlvCgll/sXyxp6qQ1yX6ksm5kSm/3i
IhK6H1+awy3LD7CMiLEZDyHOloLD6x8cZKlYjRRb74EQCuFbKHXtD4fp6RdjyvEoCCxc7KcdM
CWS7whcfbOf7YBvc5ixKR1Jw3uLcylmtBtSgJLg8IjcC82lgkgD6KzK5uj950Uiq0i85TpZDd
88YYuClaheSU6wdnmlZgkxwGFr6QWWyYbNqEFEM2Gk5/wzmwIFuCmyhkPqyn0mp8QYeWb+6wg
R/r1OwyKvjGBM1Jh5rq9H2ZAE0cQ0ZFKGHfd0dyd6YxqiotxBk1qom7aDq1xQYrQzjVtxfkWk
UettuONFyJuKdpCdthw1QtVKYjQg3Eu3Z5KEdIlaA/vUribJR2BgR8Q1GjRsa/IXvMKMC/G7t
G+l3rnEboN+Q5P83/xyA==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Sorry for the long delays on my side.
I moved the test data out of icalendar-tests.el into separate files.
The first step is done.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 11 May 2021 14:12:01 +0000
Resent-Message-ID: <handler.34315.B34315.162074226623833 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, Thomas Plass <thunk2@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.162074226623833
(code B ref 34315); Tue, 11 May 2021 14:12:01 +0000
Received: (at 34315) by debbugs.gnu.org; 11 May 2021 14:11:06 +0000
Received: from localhost ([127.0.0.1]:36988 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lgT6B-0006Bx-5j
for submit <at> debbugs.gnu.org; Tue, 11 May 2021 10:11:06 -0400
Received: from quimby.gnus.org ([95.216.78.240]:47762)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1lgT69-0006Bj-Hm
for 34315 <at> debbugs.gnu.org; Tue, 11 May 2021 10:10:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=tTyixTJsNfy+6iQmb7qEdNpkKsoDgAunPL+VMdyRMcE=; b=epqte+Ok+xivdnqSYFXz0ptw25
cPJXI7pOB+NGLItHSAq2eKkM/l+Zyz0Z9aM3Hfj68ndhb62cVrGcBLorSGHHF5o3bYrwMt2P6P69P
KfLaN80/YNkXeULjjZJXbCU4tWunDLUcsG3+e/LeVbpgILiBWDcU/wyaN0VDy12hKDV8=;
Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1lgT5z-0005uv-Qr; Tue, 11 May 2021 16:10:50 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN> <87d021vrzi.fsf@panama>
<877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
<24438.9378.994810.275603@HIDDEN> <87o8llu5b0.fsf@panama>
<87h7r13ky1.fsf@HIDDEN> <87zh4exnsl.fsf@panama>
X-Now-Playing: Floating Points with Pharoah Sanders and the London Symphony
Orchestra's _Promises_: "Movement 3"
Date: Tue, 11 May 2021 16:10:47 +0200
In-Reply-To: <87zh4exnsl.fsf@panama> (Ulf Jasper's message of "Thu, 22 Oct
2020 17:50:34 +0200")
Message-ID: <871radmkd4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Ulf Jasper <ulf.jasper@HIDDEN> writes: > Sorry for the long
delays on my side. > > I moved the test data out of icalendar-tests.el into
separate files. > The first step is done. Looks good.
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Ulf Jasper <ulf.jasper@HIDDEN> writes:
> Sorry for the long delays on my side.
>
> I moved the test data out of icalendar-tests.el into separate files.
> The first step is done.
Looks good.
Re-skimming this thread, it seems to me that the reported problem hasn't
been fixed? (But I may be completely wrong about that.) If that's the
case, has there been any progress on integrating Thomas' patch?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 29 Jul 2021 14:56:01 +0000
Resent-Message-ID: <handler.34315.B34315.162757053832388 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, Thomas Plass <thunk2@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.162757053832388
(code B ref 34315); Thu, 29 Jul 2021 14:56:01 +0000
Received: (at 34315) by debbugs.gnu.org; 29 Jul 2021 14:55:38 +0000
Received: from localhost ([127.0.0.1]:57966 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1m97Ri-0008QK-6m
for submit <at> debbugs.gnu.org; Thu, 29 Jul 2021 10:55:38 -0400
Received: from mout.web.de ([212.227.17.11]:55233)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1m97Rg-0008Q7-Ry
for 34315 <at> debbugs.gnu.org; Thu, 29 Jul 2021 10:55:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
s=dbaedf251592; t=1627570525;
bh=aLOD3InOhu2syhRqmGMf9ggq42u0w+DIHuKBi8EnPOs=;
h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To;
b=fH5vHQQFpZxcmWVrb+Jp/n/4iFTCMhwa3B0stHZbivGbyBAkWP0lzcX6iAm7dvZQU
/J6HjztCob+TpjlNMRZbFPZiCwA6Jelln7C9n5jvZSIh9DFTZWZJOTT7gNunUGe1ke
fNaBu3augsDTGxIqRi/R+0rzJgO4cdVxBCRwFyZ4=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from udesktop ([79.213.248.214]) by smtp.web.de (mrweb102
[213.165.67.124]) with ESMTPSA (Nemesis) id 0Lhev7-1mvhk53e4n-00mqiE; Thu, 29
Jul 2021 16:55:24 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN> <87d021vrzi.fsf@panama>
<877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
<24438.9378.994810.275603@HIDDEN> <87o8llu5b0.fsf@panama>
<87h7r13ky1.fsf@HIDDEN> <87zh4exnsl.fsf@panama>
<871radmkd4.fsf@HIDDEN>
Date: Thu, 29 Jul 2021 16:55:18 +0200
In-Reply-To: <871radmkd4.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Tue,
11 May 2021 16:10:47 +0200")
Message-ID: <87im0tkw4p.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:5aRpmLYRgOXD35EV2sFq42XIppezJlSqXAQhlESVihYTBb3SUFb
GOl20mCEHwCDP9F4mOI4wXVXnQ86Bpr3tZjyP+WbaAiora6TkfEe3UboYExV8cwnP0maIFW
GVvlQHlQUx04uPFF/fZx/yKxd8ieOEiozu09FtvwUU4jyhaMVHMKalbkKYfbVzY/kjFPXhP
MT9UGb8n/y9Mpn5FIi7VQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:+flhekZmOHE=:RgRJI0T2u9u24FM8wyYCqH
eg9ejfkgysaIV+sNDqAoJKcXdHeP6qKXbhtQrL73mEB6+QK96z44WE3BWSbstYi46dnULvpG4
GYK1TULJsdUAIKffBLMXMYA5PHlWZsHLY0wlK/HKY34blon2BdrpCLEiC59iMDjfYBv3IDF/d
0g57NADd2uL/W0gCMYHEnaZrtpjR2QAPqEAsbbR1yk18sQ8Yv7q/J83BF1dbP6JcWJojbvE7m
OnJqk3y75saCZwYbpckTChU0IOKsdXnWXNNRWbhMYOg2mgJaqbJ6rZWEamWDYSnNuttGJN2C8
oo6B7LrS/EhNhjcEYPv/xUivaEWet+f5eNnK3gzIc8TC6wiObc1RBqPVLDc0EYMPHXQTZU6nX
EJ1hm0dcEXxJwHiK15DVRKo/43VnHXZiBXzqc7TjT1m9HqUAZ+ey8H1yAjm5HCAU4qzzWGZPb
8mn21jWDbJxTS6YE50Jq1j0nW9c2QhDaYdq7GbmYDZgNuIcsJlOKNesvzKGvj+gOvM3tJ2qwC
sWO5jS6MlAwh2qbHehEiboVyVgl/uYEK8NqrLSL6bSu+5muJR798NzGxjKIAxfnpsbXCLDg+8
7ou5+65P7VgrwII4ULBBKlMqw+sxsFZW5z2ocCvXh2W9zauvjt1CFFeb+parZyVOS371tMnTs
FKjoSbCxWLCbMZPaawt80OAt2mZFU15WjrJYwTeFjHGRsTAt2/LAc2QkUM3ZW2yX4cGsS8CKB
LDqgr6+UHu+7XQrRuBQQkjO1rCiOZPh0maVenvx94dJp79SAb9v4IXYIT2S2GjpZ9isZssz/G
4YiX5p/e8iMJnP3n5tepmYuZPA6zqdEJjjTo0Opq+aoS6ZRk5b90Z/QG1hIHgJeslzqEgBUXm
0ECsVztVqgu3xajgMRw4HBcj9PJeZxAefV73twFwKcnLlaskDYcGvpspiG2gPj0Ws5T3oekB2
GTwkcqHcHbh0EKvniOb7YJIL/0dEVdrYIxzeOatXPXY5l02Pt8abQxxTMzg2KswvVvFr6SOaX
4rVwvVrUUf7DlnXLLNdToHsfEVdy5wY6/C5Q40d9KicjXZjk2SgrC8TG6psJfc33otiGn6r5F
RrJI1Ar+1yKlQ44lDd/KlBLUi3E9ZdLwUS3
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Am 11.05.2021 um 16:10 (+0200) schrieb Lars Ingebrigtsen:
> Ulf Jasper <ulf.jasper@HIDDEN> writes:
>> I moved the test data out of icalendar-tests.el into separate files.
>> The first step is done.
>
> Looks good.
>
> Re-skimming this thread, it seems to me that the reported problem hasn't
> been fixed? (But I may be completely wrong about that.) If that's the
> case, has there been any progress on integrating Thomas' patch?
IIRC the next step would be to add test files, i.e. ics files holding
input files and diary files holding expected output data. But maybe I
am mistaken.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 30 Jul 2021 11:38:01 +0000
Resent-Message-ID: <handler.34315.B34315.162764506819547 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, Thomas Plass <thunk2@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.162764506819547
(code B ref 34315); Fri, 30 Jul 2021 11:38:01 +0000
Received: (at 34315) by debbugs.gnu.org; 30 Jul 2021 11:37:48 +0000
Received: from localhost ([127.0.0.1]:59162 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1m9Qpo-00055C-5k
for submit <at> debbugs.gnu.org; Fri, 30 Jul 2021 07:37:48 -0400
Received: from quimby.gnus.org ([95.216.78.240]:41192)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1m9Qpm-00054z-Kt
for 34315 <at> debbugs.gnu.org; Fri, 30 Jul 2021 07:37:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=g6YGFbhiGxOijYAIHlZ/lgmA6ctsPFQvdtmFksLsBIg=; b=avOOmj7+2Iqp0OOmJdNDPcTpYy
mGmPYh9oAEzDi2/poA6eWZ/EvAtqKkByvQTj3sFkMjVP9KjBWt4D86TsmCXl+V+RcZUnk+sq5g7NE
/Ghqzuwe8oFrLAtNZvk5ahkJ6Keh7ykRX1iQsQtSjLK0imax2kcdWt5CQbDcQfg1Udjs=;
Received: from 2.149.45.105.tmi.telenormobil.no ([2.149.45.105] helo=elva)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1m9Qpc-0006vW-70; Fri, 30 Jul 2021 13:37:38 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <23640.9851.562972.730234@HIDDEN> <87d03x43kz.fsf@panama>
<24371.59842.984273.402129@HIDDEN> <87y2mkknyc.fsf@HIDDEN>
<24371.61149.995030.284670@HIDDEN> <87364rq4yl.fsf@panama>
<87imcwf404.fsf@panama> <24400.43911.666145.400179@HIDDEN>
<874kof2aui.fsf@panama> <24435.1743.473339.944597@HIDDEN>
<874knewwfc.fsf@HIDDEN> <24437.56299.111042.412318@HIDDEN>
<87d021vrzi.fsf@panama> <877ds9rk4j.fsf@HIDDEN>
<878scpvqcf.fsf@panama> <24438.9378.994810.275603@HIDDEN>
<87o8llu5b0.fsf@panama> <87h7r13ky1.fsf@HIDDEN>
<87zh4exnsl.fsf@panama> <871radmkd4.fsf@HIDDEN>
<87im0tkw4p.fsf@panama>
Date: Fri, 30 Jul 2021 13:37:29 +0200
In-Reply-To: <87im0tkw4p.fsf@panama> (Ulf Jasper's message of "Thu, 29 Jul
2021 16:55:18 +0200")
Message-ID: <87k0l8oww6.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Ulf Jasper <ulf.jasper@HIDDEN> writes: >> Re-skimming this
thread, it seems to me that the reported problem hasn't >> been fixed? (But
I may be completely wrong about that.) If that's the >> case, has there been
any progress on integrating [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
0.0 TVD_RCVD_IP Message was received from an IP address
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Ulf Jasper <ulf.jasper@HIDDEN> writes:
>> Re-skimming this thread, it seems to me that the reported problem hasn't
>> been fixed? (But I may be completely wrong about that.) If that's the
>> case, has there been any progress on integrating Thomas' patch?
>
> IIRC the next step would be to add test files, i.e. ics files holding
> input files and diary files holding expected output data. But maybe I
> am mistaken.
That's also my understanding.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 01 Oct 2023 02:13:02 +0000
Resent-Message-ID: <handler.34315.B34315.169612635720543 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Ulf Jasper <ulf.jasper@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Thomas Plass <thunk2@HIDDEN>, 34315 <at> debbugs.gnu.org, Jan Tatarik <jan.tatarik@HIDDEN>
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.169612635720543
(code B ref 34315); Sun, 01 Oct 2023 02:13:02 +0000
Received: (at 34315) by debbugs.gnu.org; 1 Oct 2023 02:12:37 +0000
Received: from localhost ([127.0.0.1]:60231 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qmlwi-0005LH-Np
for submit <at> debbugs.gnu.org; Sat, 30 Sep 2023 22:12:36 -0400
Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:47393)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stefankangas@HIDDEN>) id 1qmlwg-0005Kz-8S
for 34315 <at> debbugs.gnu.org; Sat, 30 Sep 2023 22:12:35 -0400
Received: by mail-lf1-x12a.google.com with SMTP id
2adb3069b0e04-50308217223so23529984e87.3
for <34315 <at> debbugs.gnu.org>; Sat, 30 Sep 2023 19:12:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1696126332; x=1696731132; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=OF3ieZoyezNXuQbfmwV7cciBayU7lmAIDbS2XTAyu8g=;
b=DuoGx/LrpIRi/RgJMsRK6tTO4g3ahsFR2m4gYkhpj4AiKWuebwhZUgiBhWnhZzr2c0
lPs2i2ueWmldhUwUSUeTzzrarDJCg/fjj7uxxJw6jv+rJI95cKDZpx1+ehwOWrvEY4tT
uMk8gogNyq5WD+oh9QXH5bisjzMKEOhxh9GJneXcjGECTOrFnerZIB+QFOK9HC6/3q9O
XACmHCdoBPzrZFY+trC7moEaI8J9g/eZDQPi1YwGxRc75cyLtKtqgT9o3GrL4ZI3EVQL
NXRZxE+s55AE81g6rAIrP+tPcU7lG+2S3pR5MDLO93YLKWYCLpskAwjA3WBUn7KAgIG8
/u2g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1696126332; x=1696731132;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=OF3ieZoyezNXuQbfmwV7cciBayU7lmAIDbS2XTAyu8g=;
b=ApZFkMHZTJ8K6Y6NvmI6bN2Ofy8YxHGVkn6KYhkFyBv45JYmYCjtAqsGDQA6Ku3OWk
+5aNnU0FU7etwP/M9aP93xJZEfGCU/ZIg0leiXuGre9vRoP8wFSlxr0K1SOlAU7cBZpg
TLH4ywt3lpLtoMgJn6hYjR+iu9YCuu/tQ5Mb5NFVXevrYBBKxkcwlgu2pCUGAS0sqLis
xKtgQHwS3cR3rAPIPUPgN2yVKjtkc1UT5qsZQqPwkJ7y5h9pt1PUCABfwBjpDCHKC/XT
RN15jUfcYIlAcMyVPie30/Eyv8koZx6umMf6hIL92Fub16EOq/q+t0IHFdtOPRXAdm0I
qlNw==
X-Gm-Message-State: AOJu0Yw31PAmOipRjjnTDnAvDp8kEe3/Ocm9RZ8vyLKGfykOe61LKmpV
/pFWlG0XuNaCNadiqTfgPvAQAUwa/Cpz4DoBeQE=
X-Google-Smtp-Source: AGHT+IFwFHnlvWWgqbZf4wh/x3etWUiBSii76ej+SfX889NP8liF3UYs5jm7woQW84eGqfgD2ttaDL+nc8izUhON/gw=
X-Received: by 2002:a05:6512:23a7:b0:500:b53f:fbc2 with SMTP id
c39-20020a05651223a700b00500b53ffbc2mr8374317lfv.26.1696126332420; Sat, 30
Sep 2023 19:12:12 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Sat, 30 Sep 2023 19:12:12 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87h7r13ky1.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Sat,
10 Oct 2020 22:06:14 +0200")
References: <23640.9851.562972.730234@HIDDEN> <83o8ni4fhu.fsf@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN>
<874kof2aui.fsf@panama> <24435.1743.473339.944597@HIDDEN>
<874knewwfc.fsf@HIDDEN> <24437.56299.111042.412318@HIDDEN>
<87d021vrzi.fsf@panama> <877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
<24438.9378.994810.275603@HIDDEN> <87o8llu5b0.fsf@panama>
<87h7r13ky1.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sat, 30 Sep 2023 19:12:12 -0700
Message-ID: <CADwFkmn2wSJMFZAxw+Ec_rYK-Z_+KtkGm67r5YXyLEZ9uauc6A@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Lars Ingebrigtsen <larsi@HIDDEN> writes:
> Ulf Jasper <ulf.jasper@HIDDEN> writes:
>
>> - read input data from ics file
>> - read expected result from corresponding file
>> - perform action under test on input data
>> - compare result with previously read expected result
>>
>> I could write the necessary helper functions and then, for a start,
>> apply this scheme to the "real world" tests in icalendar-tests.el.
>
> Sounds like a good plan to me.
The last update here was 2 years ago.
Ulf, did you get any further with this?
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 12 Oct 2023 14:51:01 +0000
Resent-Message-ID: <handler.34315.B34315.169712222520828 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Thomas Plass <thunk2@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Jan Tatarik <jan.tatarik@HIDDEN>, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.169712222520828
(code B ref 34315); Thu, 12 Oct 2023 14:51:01 +0000
Received: (at 34315) by debbugs.gnu.org; 12 Oct 2023 14:50:25 +0000
Received: from localhost ([127.0.0.1]:44068 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qqx16-0005Ps-Rr
for submit <at> debbugs.gnu.org; Thu, 12 Oct 2023 10:50:25 -0400
Received: from mout.web.de ([212.227.17.12]:60169)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1qqx13-0005PX-J4
for 34315 <at> debbugs.gnu.org; Thu, 12 Oct 2023 10:50:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273;
t=1697122188; x=1697726988; i=ulf.jasper@HIDDEN;
bh=OpcPFiKSjmSc1wXaan64wWpt31oejrA3VgEUeAC6PRQ=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
b=vJ249jPuUjn3BzMQqBWV9jvdLgcTQVYELPijdtRxeQpx4jsZYZfhOXAh06Y27Awdg/8qJgnp/4U
d+PETbwiloK7VptnS9yP3Oy1MMwTlj3nw+xHubUJpLfDvBJT4l05QhwHEIn05pySVxHQCT22VHzL8
GyeRaB6tGOwq5CyFjXjG2uNc3UC21sxle9Cc9JXqDcdA0SC4EANvY3q1Ix6rnpcm6TkKfYyzqqRP1
DetsoZeqpUjYFkJqK7/qTIs1enq7oKdOUXVq6xN1Lwuh0KninrI1WsUI7DQTcVMPZ78WUfvUXE7oH
J4opBROPOzWZdobZclLxrjh6uSy+As0Eqsdw==
X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6
Received: from arzi ([87.187.62.190]) by smtp.web.de (mrweb106
[213.165.67.124]) with ESMTPSA (Nemesis) id 1MRW2R-1rEPBB389V-00NSbl; Thu, 12
Oct 2023 16:49:48 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
In-Reply-To: <CADwFkmn2wSJMFZAxw+Ec_rYK-Z_+KtkGm67r5YXyLEZ9uauc6A@HIDDEN>
(Stefan Kangas's message of "Sat, 30 Sep 2023 19:12:12 -0700")
References: <23640.9851.562972.730234@HIDDEN>
<24369.32256.954408.774614@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN> <874kof2aui.fsf@panama>
<24435.1743.473339.944597@HIDDEN> <874knewwfc.fsf@HIDDEN>
<24437.56299.111042.412318@HIDDEN> <87d021vrzi.fsf@panama>
<877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
<24438.9378.994810.275603@HIDDEN> <87o8llu5b0.fsf@panama>
<87h7r13ky1.fsf@HIDDEN>
<CADwFkmn2wSJMFZAxw+Ec_rYK-Z_+KtkGm67r5YXyLEZ9uauc6A@HIDDEN>
Date: Thu, 12 Oct 2023 16:49:43 +0200
Message-ID: <87o7h3q4jc.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:0VQ11HV9VzYILwXarqhiGNaLX+j9jpgCRQ33ZA+vq+8sUVLoHH2
i/9S6QnzESSsB44TmHqV3riE+VfzLEIh+sDKHlCammCAeAhqWyXhYw6VZwbvdvpP+GjyuTP
ot8lZvNaaWkemigqxkGAvIIVK8UlNrLmGCMT2GW43zbQHoXtq1dIAd6jhntCQL42rYLzcNk
1A9Uceuuj3uUndrDkEK+w==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:wlW8j2GoHm8=;ydAjQHUjoFwiVbg2JKgZazeNUdW
RTySMMTUpxRpXs0chnNb0DvgyhL9KBPzLKL3vR0I2Cx0JRJohCiLK63wceyCRshD2FiOmFJ4F
OZkrqBhUt3CrPq7x1iooo753JxCV/5PkgK8pz/Yx+TZifENGJxJ/B1GCEdTOIfk5Trg8EVTAf
56cUgJH9Z5WbDhwW8Fxf43jBX3N0TH9yUgPBy726f96XCJUpoYS825mOIbe7zz7vSlfB17tOx
oAVO4xRBmhplhIq8xhTJTrhaWsK8vEvXEcmK8arnTgiUuC4Pem2mx+obf4Ri8wc8AdPNPgDPO
M4LmCyD/C7k2u4Y0zYYQYTSf+/r/X10cgw6FwNaFTyY0ZjTaXZrhu3aZZSv3dPqBYBw+R7Epk
EmZaontBn07sS/bPEvww7iIXK/TCvDV9uBKaVEDzh7GMiMjHbcqvYFHo+vElkQipaasO8QBXC
9vWzhGAbB32OMN2vagJWWxf2blCm3nKATBxqxlscyHsv2wresu6H7fQMZ3BcaZlXiESWLz0Qs
QC5p2V92vW3gIqWt2tyL70VgeN75m+yomB8f4Fi00a6jS26OTgzCbabv5TVDSQKOSAvy5FWx4
sLJAtgAjrOXESaDr9kLxoyHf2iFlYUrkc5rkGBO62+eQO2osh5Om+iWcR+0Vz4Kn4AErrkJ4a
RwVtzyMcWo45SB/MKbK5UUjd+AdsBNvecF9n4W0xI4ahOHhvw4ae5x7/F43hA9eJyxwf9N9Lq
TmtBj9/Uvcg11/dCS+3RZ/h5exEfbm84wYoNSRzXIa4Rir+MfNZbxgp6znPYxeWCCb6KnQ6qC
M41LvAaozLyKhmj/xfa3DKE33us+qf4mI7O7kBw8DC8BxrmnKzztOrVHc6zzIaMh4hKwaknBg
tg21thSKeoJmctnFYKuOXdjeRDpnjQ0HsZOHCu02SXkYUfB62/C2uTqGhEILg8hri9S4L3EE+
voX39g==
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Am 30.09.2023 um 19:12 (-0700) schrieb Stefan Kangas:
> The last update here was 2 years ago.
>
> Ulf, did you get any further with this?
Sorry, I lost track of this bug. I also lost track of icalendar.el
itself. I stopped using it some years ago. I think it is time to step
back from maintaining icalendar.el.
Best,
ulf
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 15 Oct 2023 14:29:01 +0000
Resent-Message-ID: <handler.34315.B34315.169738013431051 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Thomas Plass <thunk2@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Jan Tatarik <jan.tatarik@HIDDEN>, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.169738013431051
(code B ref 34315); Sun, 15 Oct 2023 14:29:01 +0000
Received: (at 34315) by debbugs.gnu.org; 15 Oct 2023 14:28:54 +0000
Received: from localhost ([127.0.0.1]:53890 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qs26w-00084l-DA
for submit <at> debbugs.gnu.org; Sun, 15 Oct 2023 10:28:54 -0400
Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:54613)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stefankangas@HIDDEN>) id 1qs26t-00084V-ML
for 34315 <at> debbugs.gnu.org; Sun, 15 Oct 2023 10:28:52 -0400
Received: by mail-lj1-x232.google.com with SMTP id
38308e7fff4ca-2c514cbbe7eso13713321fa.1
for <34315 <at> debbugs.gnu.org>; Sun, 15 Oct 2023 07:28:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1697380101; x=1697984901; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=1S5By1itfmQBDw8B3MgMYbV/2zNQP5UCpPRC4njzaF0=;
b=BRxwlLu260SbO/u0Bs2hcn4QgWDtWzfWQIe29HomnlYGwoSY/3utdhVqWoj5UeZNr8
ebK7tUZ++vzxN72vBJZWoq6IKv+lE6bDaVBuQlpH/HwTq+IvRVWmsKlsHqW2ViYJ0wi6
2xe2jYhbrW72JdftHR2S2MdFe6AJZcmYeQEIf+FxmFx9qr10GUzd32l05C38Cb/9aUtU
4hqGYZGPHZuLg6+cMDxGPMrrd1lrM5hsXijBFWgXYoTgpOV7GcWykSU1gM8yJ2nOxevy
dLQptj8AwBGi5HfOdUzJdb8EoYsoWIpZTxmHWH5VHeSJWOuUtAn1vH5Te8PWH149cxFQ
jm0A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1697380101; x=1697984901;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=1S5By1itfmQBDw8B3MgMYbV/2zNQP5UCpPRC4njzaF0=;
b=VQAsDaawCqCRv+NHFU3zn9LlO2wxbM7wjr9eAxBE/2TKVMiKmH+nmJbfv4Ludwx+7T
EaCe6nZzysgi03l6FpJ1jrhCFZbJ1jVz83j6LSxC0zlozBXq+dsABxYy/+WAhXraNuNk
IrQTFdufb+0KZHavvBCRIBcYSYnbbKSJPeqwrhgZ3NA8GodvJjsczueU6AgS4kjByk4T
STwnU9Wpxf80oCzKjMzP4P9gWZSwRZj5ZGsRE6s6p/19Tbcc2GGcNEZod9YiAILvAJCi
tRdYqtkWVNtFqb1nGReMXwe+VGY9OPM73hcVGnJRyhPQ9nQ+OjlaaefqLs9gHsswllwl
UOLg==
X-Gm-Message-State: AOJu0YwJRSwXWQjInJlyFcf0nvTdEyje1Oh6uNhaX3gEsUuO2E10lbdu
Y+zPNTOt8KuqpFgKggfYoc7t3ThUmF5JE8PusQg=
X-Google-Smtp-Source: AGHT+IEBbJkyssrDH8sYcW4Gl2JbvXKN6woEgbU6/vTd0d0aTeBq3R9mYNLx+5nc5fgkxdnQcfmiXp6qUplslsDvEJ4=
X-Received: by 2002:a2e:6a0d:0:b0:2bc:b0ae:a9e5 with SMTP id
f13-20020a2e6a0d000000b002bcb0aea9e5mr27207348ljc.42.1697380101188; Sun, 15
Oct 2023 07:28:21 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Sun, 15 Oct 2023 07:28:20 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87o7h3q4jc.fsf@panama>
References: <23640.9851.562972.730234@HIDDEN> <87y2mlxx8r.fsf@HIDDEN>
<87d03x43kz.fsf@panama> <24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN>
<874kof2aui.fsf@panama> <24435.1743.473339.944597@HIDDEN>
<874knewwfc.fsf@HIDDEN> <24437.56299.111042.412318@HIDDEN>
<87d021vrzi.fsf@panama> <877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
<24438.9378.994810.275603@HIDDEN> <87o8llu5b0.fsf@panama>
<87h7r13ky1.fsf@HIDDEN>
<CADwFkmn2wSJMFZAxw+Ec_rYK-Z_+KtkGm67r5YXyLEZ9uauc6A@HIDDEN>
<87o7h3q4jc.fsf@panama>
MIME-Version: 1.0
Date: Sun, 15 Oct 2023 07:28:20 -0700
Message-ID: <CADwFkmmen5KPpM8-dHbEjXjr5nTBkMWr6asvXzWOMwG6ZdU6tA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Ulf Jasper <ulf.jasper@HIDDEN> writes:
> Am 30.09.2023 um 19:12 (-0700) schrieb Stefan Kangas:
>
>> The last update here was 2 years ago.
>>
>> Ulf, did you get any further with this?
>
> Sorry, I lost track of this bug. I also lost track of icalendar.el
> itself. I stopped using it some years ago. I think it is time to step
> back from maintaining icalendar.el.
Noted. Feel free to update the Maintainer header to reflect that
decision (or let me know, and I'll do it for you).
Thanks for all your work on icalendar.el over the years.
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Ulf Jasper <ulf.jasper@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 19 Oct 2023 14:12:01 +0000
Resent-Message-ID: <handler.34315.B34315.169772470323474 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Thomas Plass <thunk2@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Jan Tatarik <jan.tatarik@HIDDEN>, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.169772470323474
(code B ref 34315); Thu, 19 Oct 2023 14:12:01 +0000
Received: (at 34315) by debbugs.gnu.org; 19 Oct 2023 14:11:43 +0000
Received: from localhost ([127.0.0.1]:37372 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qtTkV-00066X-ID
for submit <at> debbugs.gnu.org; Thu, 19 Oct 2023 10:11:43 -0400
Received: from mout.web.de ([212.227.17.12]:59769)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ulf.jasper@HIDDEN>) id 1qtTkS-00066J-Lk
for 34315 <at> debbugs.gnu.org; Thu, 19 Oct 2023 10:11:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273;
t=1697724666; x=1698329466; i=ulf.jasper@HIDDEN;
bh=zRTvs4jT/WPX+WyGoMaxgoMdx7sl1G1rBNlPfaEqs00=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
Date;
b=gfZkLI58HQ7lctlfJib05mCZcD8ht6dcCP2MLcNWN1ZKZjctyP+/au/qk4dtVoeD
HWGr7o+iHpQi5U3m5Tid+11ozJkKwnUghparlyBv2lO1vYZusXw9LxpXo8Sd6Zc57
elQ6RTxW5SDI80c1FBF926XfqNvnGC/S8d5k7GkzBCSppu0zBsiNmQWQczA94wHzU
DuWjhsRsQCrEdp2e+dvwI3gletBO1ieWUUQr/72eT8+0QdkS4L206RufpwEWuQ7un
tcdBwtGyjTlxDXO0j8QkmUV/YMW21QQOXiI3kXWsofa9IRziFshHnXpkqjkXa5rV/
bRKJ4ldcyChdaOTavw==
X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6
Received: from arzi ([87.187.62.190]) by smtp.web.de (mrweb105
[213.165.67.124]) with ESMTPSA (Nemesis) id 1MbkSC-1rWf2a29Z0-00dAsQ; Thu, 19
Oct 2023 16:11:06 +0200
From: Ulf Jasper <ulf.jasper@HIDDEN>
In-Reply-To: <CADwFkmmen5KPpM8-dHbEjXjr5nTBkMWr6asvXzWOMwG6ZdU6tA@HIDDEN>
(Stefan Kangas's message of "Sun, 15 Oct 2023 07:28:20 -0700")
References: <23640.9851.562972.730234@HIDDEN> <87d03x43kz.fsf@panama>
<24371.59842.984273.402129@HIDDEN> <87y2mkknyc.fsf@HIDDEN>
<24371.61149.995030.284670@HIDDEN> <87364rq4yl.fsf@panama>
<87imcwf404.fsf@panama> <24400.43911.666145.400179@HIDDEN>
<874kof2aui.fsf@panama> <24435.1743.473339.944597@HIDDEN>
<874knewwfc.fsf@HIDDEN> <24437.56299.111042.412318@HIDDEN>
<87d021vrzi.fsf@panama> <877ds9rk4j.fsf@HIDDEN>
<878scpvqcf.fsf@panama> <24438.9378.994810.275603@HIDDEN>
<87o8llu5b0.fsf@panama> <87h7r13ky1.fsf@HIDDEN>
<CADwFkmn2wSJMFZAxw+Ec_rYK-Z_+KtkGm67r5YXyLEZ9uauc6A@HIDDEN>
<87o7h3q4jc.fsf@panama>
<CADwFkmmen5KPpM8-dHbEjXjr5nTBkMWr6asvXzWOMwG6ZdU6tA@HIDDEN>
Date: Thu, 19 Oct 2023 16:11:02 +0200
Message-ID: <87ttqm7le1.fsf@panama>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:hHtMwK84c4Ru0M3x1kM7uRlYkot/PertC0TG5L8IjcMAwexxdFj
4dsqVkaLxgyaQbXh8qVYIIQvzD5adjBafJ/MAKTPthQr9n64KeejTNyfUHfS/7gP7y71TlL
PXbZOxNjOShvX0er/kxW9QgHjUEnGCkJCfJhN9cuyuNuG79z/AFW2o9jlesbTyUPXjnmsjD
deCowp6JpAORbM17X5gAQ==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:ENISudbN8tY=;HCsEvA0c767Q58a3xcsS9p5wSSo
FI9unMZFtJz4vHSSHebPl2FmylUHCZ00gWb0JkglttOdJomuoB8XamkiTfPdsbd/3ih2C12Hw
dTsrz1mhSz4AXDg7pPb/PXzY0nk1+b/WPE4oRvugWPADlijdqMna8xLx+4YC3gSnRywnWRwJR
Hv0vJGCp6QR0RFAAGHihoPjrJimtRmKx2cSjaZuiAp36qJc54XV98nzuwb6nZPdbF/Ak11JiR
2tSW6/L6d9bCaCI6RhupNoIycfDlNMpA76zSx2zXwwx9+Gg+64Qzj5jUuRG1amsPy1iDC5NXP
12C5dQeNSOdoj8CiOYZH1dICFA6HJjf5ZFHjFFUxu93HxFxO3c2H3nM/cYZ35KP0jrMAOT36R
Gfw6AJ52DYXxU/KQ2+aXvS1KdFPmB6gwECycDt4EVAjIdebJ1OyR+1WjTfH/yxHo3b394FhPX
qBIkEvOJnZEVI71EJIH0u2gekBZb/PCSGaAOSPXqbryEU4m+pb+jmEiRTfXLygKZxhn1zfvyr
9ktmaQvxKZfHEvBLTsOd0lhIUVwTzkkeGPn8d4pLtcF4UujH9NJrpquROLMRa2eErIOrZMk/X
rWQwx1nrrXo9XNFnGiSR6Q1ggRha6PkQFd2xui7V5UgbxXUcxkBosu4rMVLs5WiPi4dtuddpi
kfwDD4GJTX7TIvRisGhApxCZ8KdJWZexVlIeBfDmzp0npOov9us5Xgy3NzH92QO2uTWkcReOw
leKLkKrIATYk6iNkB9Lkz8hPHxH7HxbCDyDVJvQjWKVgD9Ta1A1xapLBtrdkaZDq0Kfm2B6WZ
LphDeTRDr6CshLFxSK0A+iLovWsvi+Oxxp9ax91tjueRkabAh4Geyl/t3CzBVHUQQhnziHXH9
suFAoEWGD1hg+0zbhBBOSB41/DzWv5kAZuh84s2fLHX76SU/YOAhHMsryf4vA+NqJ8/EkaW3p
rXcLLxgllRBagoqV/UrKajYlj18=
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Am 15.10.2023 um 07:28 (-0700) schrieb Stefan Kangas:
> Ulf Jasper <ulf.jasper@HIDDEN> writes:
>
>> Am 30.09.2023 um 19:12 (-0700) schrieb Stefan Kangas:
>>
>>> The last update here was 2 years ago.
>>>
>>> Ulf, did you get any further with this?
>>
>> Sorry, I lost track of this bug. I also lost track of icalendar.el
>> itself. I stopped using it some years ago. I think it is time to step
>> back from maintaining icalendar.el.
>
> Noted. Feel free to update the Maintainer header to reflect that
> decision (or let me know, and I'll do it for you).
Removed myself from MAINTAINERS (for icalendar). There is no maintainer
header in the el-files, BTW.
Best,
ulf
X-Loop: help-debbugs@HIDDEN
Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 24 Dec 2023 14:04:01 +0000
Resent-Message-ID: <handler.34315.B34315.17034265865974 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 34315
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Ulf Jasper <ulf.jasper@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Thomas Plass <thunk2@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Jan Tatarik <jan.tatarik@HIDDEN>, 34315 <at> debbugs.gnu.org
Received: via spool by 34315-submit <at> debbugs.gnu.org id=B34315.17034265865974
(code B ref 34315); Sun, 24 Dec 2023 14:04:01 +0000
Received: (at 34315) by debbugs.gnu.org; 24 Dec 2023 14:03:06 +0000
Received: from localhost ([127.0.0.1]:51818 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rHP4I-0001YA-5W
for submit <at> debbugs.gnu.org; Sun, 24 Dec 2023 09:03:06 -0500
Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:53488)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stefankangas@HIDDEN>) id 1rHP4B-0001Xc-II
for 34315 <at> debbugs.gnu.org; Sun, 24 Dec 2023 09:03:00 -0500
Received: by mail-ed1-x529.google.com with SMTP id
4fb4d7f45d1cf-55436c4a65eso2170392a12.2
for <34315 <at> debbugs.gnu.org>; Sun, 24 Dec 2023 06:02:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1703426564; x=1704031364; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=A7fQ+5MIJuUhYptTMcl8eGnx1OgsXIyXXpttX0KGF34=;
b=KlUcTBRt2M9ArZvPt2aDUF6Be78hp/cHh7rHuVcJMe7Jefy0n3xFBv96cqEJNjVHBD
NuSBhQl6lQGbupdnEoxFaH0EQM3I1pNWGDVLeoBBPM/JN48TFcbDNdPvGoPgZXhdxgNa
gfoyyOsXMKkcBb6DXXR2xUcaxNzHz5OrYPUoP5UI2EqJ/z/V3bIYY0++ciNChP014tUH
9l2qHNi5iH/UEp+h3tnPPcisBhrlrjF8dvwFx0+pACqoEB0sUN0TM71nU5s1j+1GxpMM
fDRKY+uzzTV8Ym7euIqnRhGl9HemXOKfzlLd2MVGYPpfdmssc/mlDO1V3tNTqaWLTzLO
ojog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1703426564; x=1704031364;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=A7fQ+5MIJuUhYptTMcl8eGnx1OgsXIyXXpttX0KGF34=;
b=gJOR/23ifOABp+Yw5DBbCXkXxafh9gHQYY8IehJbdXAjxYwhuKuwWHV+kSw8xPNJA6
PCwS1Oydr5rHIMGKYnlUx61vcI9OebE+fMwn5YVnzW/MH9z4AFD2zxQgZ7u7p554kTEX
tTu6PgH1zlo2VEuAGRnQMwVApxKcUj/RAV9jiklYAO1H48r9xKtdrgigfCimllAHeIfW
pezH34mY+rPxwICq3tJ2tqfYEuqchek2dKlLi2f8bE/Xvp3N8PvJp0ysPy8ciW26CG8n
XOv5wsAZIm/QwiycZS8LcugeK3OvNQuzqPAicnTxr2MdEUN1E9B9cty72ogY7I3+spFm
/5jw==
X-Gm-Message-State: AOJu0YyhU60FBfROexa2jETEbA6cbopBM3R6Gss784CHl+eFuSAVCRzy
6HQoKPsOUlDqDcjhE+8DKi/EnzqZMFKyVj/CXp4=
X-Google-Smtp-Source: AGHT+IEqylKfv7tH6xoimbWtHlanFBUd+R2pDy/pygG0ZiqfJWja+wt8d7cfe4vEqC32Ymxb2GVl8xkwsa3m41xTFj4=
X-Received: by 2002:a50:aa94:0:b0:554:347a:4f58 with SMTP id
q20-20020a50aa94000000b00554347a4f58mr2993332edc.66.1703426563727; Sun, 24
Dec 2023 06:02:43 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Sun, 24 Dec 2023 06:02:43 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87ttqm7le1.fsf@panama>
References: <23640.9851.562972.730234@HIDDEN>
<24371.59842.984273.402129@HIDDEN>
<87y2mkknyc.fsf@HIDDEN> <24371.61149.995030.284670@HIDDEN>
<87364rq4yl.fsf@panama> <87imcwf404.fsf@panama>
<24400.43911.666145.400179@HIDDEN>
<874kof2aui.fsf@panama> <24435.1743.473339.944597@HIDDEN>
<874knewwfc.fsf@HIDDEN> <24437.56299.111042.412318@HIDDEN>
<87d021vrzi.fsf@panama> <877ds9rk4j.fsf@HIDDEN> <878scpvqcf.fsf@panama>
<24438.9378.994810.275603@HIDDEN> <87o8llu5b0.fsf@panama>
<87h7r13ky1.fsf@HIDDEN>
<CADwFkmn2wSJMFZAxw+Ec_rYK-Z_+KtkGm67r5YXyLEZ9uauc6A@HIDDEN>
<87o7h3q4jc.fsf@panama>
<CADwFkmmen5KPpM8-dHbEjXjr5nTBkMWr6asvXzWOMwG6ZdU6tA@HIDDEN>
<87ttqm7le1.fsf@panama>
MIME-Version: 1.0
Date: Sun, 24 Dec 2023 06:02:43 -0800
Message-ID: <CADwFkm=dJAFCn3r8iGnKiFpWWkrhRJHHe3UJ3DQRN4-sK09hfg@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Ulf Jasper <ulf.jasper@HIDDEN> writes:
> Am 15.10.2023 um 07:28 (-0700) schrieb Stefan Kangas:
>> Ulf Jasper <ulf.jasper@HIDDEN> writes:
>>
>>> Sorry, I lost track of this bug. I also lost track of icalendar.el
>>> itself. I stopped using it some years ago. I think it is time to step
>>> back from maintaining icalendar.el.
>>
>> Noted. Feel free to update the Maintainer header to reflect that
>> decision (or let me know, and I'll do it for you).
>
> Removed myself from MAINTAINERS (for icalendar). There is no maintainer
> header in the el-files, BTW.
According to our conventions, the maintainer of a file without any
explicit "Maintainer" is whoever is marked as "Author". I'm not
necessarily a fan of this convention, myself. I'd prefer being
explicit.
However, this being the case, I think the correct thing to do in this
case is to add a header that points to emacs-devel.
So I did that.
Thanks.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.