GNU bug report logs - #34325
Add xmagnify, a tiny screen magnifier for X11

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34325 in the body.
You can then email your comments to 34325 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Miloradovsky <andrew <at> interpretmath.pw>
To: guix-patches <at> gnu.org
Subject: Add xmagnify, a tiny screen magnifier for X11
Date: Tue, 5 Feb 2019 00:20:54 +0000

[Message part 1 (text/plain, inline)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Sorry, I wasn't able to thoroughly test it or lint, because I couldn't
make Guix install it from the checked out tree, but it works on my machine.

Neither the instructions from here worked for that

- - https://www.gnu.org/software/guix/manual/en/html_node/Contributing.html

Nor from here

- -
https://www.gnu.org/software/guix/blog/2018/a-packaging-tutorial-for-guix/

Could only install it via `guix package -f ~/path/to/file.scm -i
package-name`.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEkYid79R7hu2s1S0QNVwlkcVwbIsFAlxY1rAACgkQNVwlkcVw
bItzOw//fAYH+Wux2vt7prJtlKlAlc4OifTV4vrnzKZBtKYx1DzlCANTPriJc23L
KIAoCAs772WlVjuwFrRTZyr+QF34JeOptmBDxSpzmysKWAKsbI2BqlOlEHDcECva
0EMIRAAne3YdcHV3FsVvZQiw5z3cKu1H7UD+Bn6nDbtrgWnb9kmzVAeRPC+AAwdJ
7NtC5i5zwmPRJGqsLmDjol2/bqF1lIK0GGUWB7BfetzSUbfVsKCO4IiBj8FZrIu8
PiLzBI4T91ubIFQNUTxiYy4vMmNKGwibg4pW6iJHfgMK/He+HETxyiRKml5rOSiW
WNQH2nTPBt5r4AmfUILMrrpoFOdjihieHM6g2bwcsXceSaJCi2mrrp8qL9EikuJ7
nFulRYIjBc8QRhc5o+ZJF8ehafX8uGdKywtPvu12ioiy8OoSVPQm8FFdATYTSdZ4
WUiRHTPCV0yQ/q0sxQ30R5eqKZRc5Rf0wFqdIC/HOl+GKV7jDHsvyz1NA4AJHwjj
Jk9WhE15c05+8QoevADXTJXxICLr3xE7brbqxVhKws5O2aMJzjGJSkcrMeWD8Hmz
c/hkzC4q08oFj/2HEfqPA/W6eC/v2hAPz+OOb/vtLVYjIspB6DesZtuiceHstPit
7pPHodBKMy8X4CQBSX1Wz9DehEW3psQI/oZukQ8flznIsMhgii0=
=LGAC
-----END PGP SIGNATURE-----

[0001-gnu-Add-xmagnify.patch (text/plain, attachment)]

[0001-gnu-Add-xmagnify.patch.sig (application/octet-stream, attachment)]

Message #8 received at 34325 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Miloradovsky <andrew <at> interpretmath.pw>
To: 34325 <at> debbugs.gnu.org
Subject: A better patch
Date: Tue, 5 Feb 2019 06:13:16 +0000

[Message part 1 (text/plain, inline)]

OK. Managed to build `pre-inst-env` and run `guix lint`, fixed couple
minor issues.

[0001-gnu-Add-xmagnify.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #13 received at 34325-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Andrew Miloradovsky <andrew <at> interpretmath.pw>
Cc: 34325-done <at> debbugs.gnu.org
Subject: Re: [bug#34325] A better patch
Date: Tue, 05 Feb 2019 10:15:05 +0100

Hi Andrew,

> OK. Managed to build `pre-inst-env` and run `guix lint`, fixed couple
> minor issues.
>
> From 2267b26f8d38fb40e58d62e3e6fcdaff01001384 Mon Sep 17 00:00:00 2001
> From: Andrew Miloradovsky <andrew <at> interpretmath.pw>
> Date: Mon, 4 Feb 2019 23:28:23 +0000
> Subject: [PATCH] gnu: Add xmagnify
>
> Tiny screen magnifier for X11
>
> * gnu/packages/accessibility.scm (xmagnify): New variable.

Thank you very much for your patch.  For a first patch this is near
perfect, congratulations!

> +(define-public xmagnify
> +  (let ((commit "56da280173e9d0bd7b3769e07ba485cb4db35869")
> +        (revision "0.1.0"))

The “revision” variable is used internally to ensure that the version
string increases monotonically.  Git commit hashes are random, so a
future commit could end up lower in a sorted list that an older commit.
That’s why we put a “revision” string before the commit hash.  The
revision usually starts at 1 and is incremented each time the commit
hash is updated.

In this case we can do without this because the last commit is also the
tag “0.1.0”, which we can use directly.

> +    (package
> +     (name "xmagnify")
> +     (version "0.1.0")
> +     (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gitlab.com/amiloradovsky/magnify.git")
> +                    (commit commit)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1ngnp5f5zl3v35vhbdyjpymy6mwrs0476fm5nd7dzkba7n841jdh"))))
> +     (inputs `(("libX11" ,libx11)
> +               ("xproto" ,xproto)))

xproto does not seem to be needed.

> +     (build-system gnu-build-system)
> +     (arguments
> +      `(#:tests? #f
> +        #:make-flags '("CC=gcc")
> +        #:phases
> +        (modify-phases %standard-phases
> +                       (replace 'configure
> +                                (lambda _
> +                                  (substitute*
> +                                   '("Makefile") (("/usr")
> +                                                  (assoc-ref %outputs "out")))
> +                                  #t)))))

You can specify the “prefix” variable instead of patching the Makefile.

> +     (home-page "https://gitlab.com/amiloradovsky/magnify")
> +     (synopsis "Tiny screen magnifier for X11")
> +     (description
> +      "Magnifies a screen region by an integer positive factor and
> +draws the result on a window.  Useful as an accessibility tool, which
> +works with every X Window System based GUI (depends only on libX11);
> +or as an assistant for graphic designers, who need to select
> +individual pixels.")

Here we should use complete sentences.

> +     (license license:gpl2+))))

This is a dual license, which should be noted in a comment.

I pushed the patch to the master branch with commit 16bb27f28 after
performing these changes and adding a copyright line for you.

Thanks again!

--
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.