GNU bug report logs - #34364
Add package: Emacs-shroud; Emacs interface for shroud

Previous Next

Package: guix-patches;

Reported by: Amar Singh <nly <at> disroot.org>

Date: Thu, 7 Feb 2019 09:13:02 UTC

Severity: normal

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34364 in the body.
You can then email your comments to 34364 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#34364; Package guix-patches. (Thu, 07 Feb 2019 09:13:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Amar Singh <nly <at> disroot.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 07 Feb 2019 09:13:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Amar Singh <nly <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: Add package: Emacs-shroud; Emacs interface for shroud
Date: Thu, 07 Feb 2019 14:41:45 +0530
This is not a polished software by any means.
This is an interface for the shroud password manager
https://dthompson.us/projects/shroud.html

Patch:

From b7f9ec3820158d2b6fdde64dfed0fa7233ec5951 Mon Sep 17 00:00:00 2001
From: Amar Singh <nly <at> disroot.org>
Date: Thu, 7 Feb 2019 14:37:25 +0530
Subject: [PATCH] add emacs-shroud; emacs interface for shroud

Signed-off-by: Amar Singh <nly <at> disroot.org>
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 960518f9d..d43153b55 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -8518,6 +8518,28 @@ close, copy, cut, paste, undo, redo.")
 standard Unix password manager\").")
     (license license:gpl2+)))
 
+(define-public emacs-shroud
+  (package
+   (name "emacs-shroud")
+   (version "0.1")
+   (source (origin
+            (method url-fetch)
+            (uri
+             (string-append "https://github.com/o-nly/" name "/archive/release-" version ".tar.gz"))
+            (sha256
+             (base32
+              "0jxfa2fa6r0ay9c6nf4xwz5vddb1v45cgaxkgdxxhck0l527i3yc"))))
+   (build-system emacs-build-system)
+   (propagated-inputs
+    `(("emacs-f" ,emacs-f)
+      ("emacs-s" ,emacs-s)
+      ("shroud" ,shroud)))
+   (home-page "http://nly.info.tm:9001/emacs/shroud.el")
+   (synopsis "Shroud (gpg) support for Emacs")
+   (description
+    "This package provides functions for working with shroud password manager.")
+   (license license:gpl3+)))
+
 (define-public emacs-pass
   (package
     (name "emacs-pass")
-- 
2.20.1




Information forwarded to guix-patches <at> gnu.org:
bug#34364; Package guix-patches. (Wed, 20 Feb 2019 21:37:02 GMT) Full text and rfc822 format available.

Message #8 received at 34364 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Amar Singh <nly <at> disroot.org>
Cc: 34595-done <at> debbugs.gnu.org, 34364 <at> debbugs.gnu.org
Subject: Re: bug#34595: [PATCH] gnu: Add emacs-shroud
Date: Wed, 20 Feb 2019 22:36:33 +0100
Hi,

> Shroud is a password manager written in Guile which uses GnuPG in the
> backend. This package is an Emacs interface to Shroud using the Buffers
> User Interface library.

You have previously already submitted a variant of this:

    https://issues.guix.info/issue/34364

Please don’t open more tickets for this but instead send updates to the
same ticket.  I’m closing this issue, because what you attached is not a
git formatted patch.

> +(define-public nly/emacs-shroud

We don’t use personal prefixes like “nly/” in Guix.

> +  (package
> +   (name "emacs-shroud")
> +   (version "ad5de6d")

A version string must be monotonically increasing over time.  Commit
hashes don’t do that, so we use (git-version last-release revision
commit) instead.

We prefer releases over arbitrary commits.  Since you are the developer,
could you please tell us what the difference is between this version and
the previous release?  Could you make a new release instead?

> +   (build-system emacs-build-system)
> +   (propagated-inputs
> +    `(("emacs-f" ,emacs-f)
> +      ("emacs-s" ,emacs-s)
> +      ("emacs-bui" ,emacs-bui)
> +      ("shroud" ,shroud)))
> +   (home-page "http://nly.info.tm:9001/emacs/shroud.el")
> +   (synopsis "Shroud (gpg) support for Emacs")

Why “(gpg)”?  It’s probably better to say “Shroud password manager
interface for Emacs”.

> +   (description
> +    "This package provides functions for working with shroud password
> manager.")

I’d not say “functions”.  How about

   This package provides an Emacs minor mode for working with the Shroud
   password manager.

Could you please send an updated patch?

--
Ricardo





Information forwarded to guix-patches <at> gnu.org:
bug#34364; Package guix-patches. (Wed, 20 Feb 2019 21:46:02 GMT) Full text and rfc822 format available.

Message #11 received at 34364 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Amar Singh <nly <at> disroot.org>, 34595-done <at> debbugs.gnu.org,
 34364 <at> debbugs.gnu.org
Subject: Re: bug#34595: [PATCH] gnu: Add emacs-shroud
Date: Wed, 20 Feb 2019 15:44:32 -0600
Ricardo Wurmus writes:

>
> A version string must be monotonically increasing over time.  Commit
> hashes don’t do that, so we use (git-version last-release revision
> commit) instead.
>
> We prefer releases over arbitrary commits.  Since you are the developer,
> could you please tell us what the difference is between this version and
> the previous release?  Could you make a new release instead?

To the OP, there are several packages that use this form. You can look
at some and pretty much directly copy their content and fill in your
relevant information.




Information forwarded to guix-patches <at> gnu.org:
bug#34364; Package guix-patches. (Sun, 21 Apr 2019 20:10:01 GMT) Full text and rfc822 format available.

Message #14 received at 34364 <at> debbugs.gnu.org (full text, mbox):

From: nly <at> disroot.org
To: 34364 <at> debbugs.gnu.org
Subject: Re: bug#34595: [PATCH] gnu: Add emacs-shroud
Date: Sun, 21 Apr 2019 20:09:12 +0000
February 21, 2019 3:07 AM, "Ricardo Wurmus" <rekado <at> elephly.net> wrote:

> Hi,
> 
>> Shroud is a password manager written in Guile which uses GnuPG in the
>> backend. This package is an Emacs interface to Shroud using the Buffers
>> User Interface library.
> 
> You have previously already submitted a variant of this:
> 
> https://issues.guix.info/issue/34364
> 
> Please don’t open more tickets for this but instead send updates to the
> same ticket. I’m closing this issue, because what you attached is not a
> git formatted patch.

Thanks for closing the other issue, i was oblivious of debbugs until today.

> 
>> +(define-public nly/emacs-shroud
> 
> We don’t use personal prefixes like “nly/” in Guix.
> 
>> + (package
>> + (name "emacs-shroud")
>> + (version "ad5de6d")
> 
> A version string must be monotonically increasing over time. Commit
> hashes don’t do that, so we use (git-version last-release revision
> commit) instead.
> 
> We prefer releases over arbitrary commits. Since you are the developer,
> could you please tell us what the difference is between this version and
> the previous release? Could you make a new release instead?
> 

Thanks, got it. Now looks like (git-version "v1" "1" commit)

>> + (build-system emacs-build-system)
>> + (propagated-inputs
>> + `(("emacs-f" ,emacs-f)
>> + ("emacs-s" ,emacs-s)
>> + ("emacs-bui" ,emacs-bui)
>> + ("shroud" ,shroud)))
>> + (home-page "http://nly.info.tm:9001/emacs/shroud.el")
>> + (synopsis "Shroud (gpg) support for Emacs")
> 
> Why “(gpg)”? It’s probably better to say “Shroud password manager
> interface for Emacs”.

New synopsis: Emacs interface for Shroud password manager

> 
>> + (description
>> + "This package provides functions for working with shroud password
>> manager.")
> 
> I’d not say “functions”. How about
> 
> This package provides an Emacs minor mode for working with the Shroud
> password manager.

This package doesn't include any minor-mode so I assume it would become misleading.

> 
> Could you please send an updated patch?
> 
> --
> Ricardo

I hope web mail doesn't html-ize the patch.

This is great, It feels awesome to get in a personal package I've been using for months.

Thanks,
Amar

From 0309576d26ce92ec2324c0505599da95408b1235 Mon Sep 17 00:00:00 2001
From: Amar Singh <nly <at> disroot.org>
Date: Mon, 22 Apr 2019 01:28:32 +0530
Subject: [PATCH] gnu: Add emacs-shroud.

* gnu/packages/emacs-xyz.scm (emacs-shroud): New variable.
---
 gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 54663496fe..d7c1245f43 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15306,3 +15306,35 @@ numbers within that region will be incremented/decremented (unlike in Vim).
 
 It is a fork of https://github.com/cofi/evil-numbers, which is unmaintained.")
       (license license:gpl3+))))
+
+(define-public emacs-shroud
+  (let
+      ((commit "dc68f5538692bf07376cd5395b87102025549f32"))
+    (package
+      (name "emacs-shroud")
+      (version
+       (git-version "v1" "1" commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/o-nly/emacs-shroud")
+           (commit commit)))
+         (file-name
+          (git-file-name name version))
+         (sha256
+          (base32
+           "17a3z5p252nbj3y7rwbvx1jk2bizzdcina6vw8blnks4dvv30k87"))))
+      (build-system emacs-build-system)
+      (inputs
+       `(("emacs-f" ,emacs-f)
+         ("emacs-bui" ,emacs-bui)
+         ("shroud" ,shroud)))
+      (home-page "http://git.nly.info.tm:9001/shroud.git")
+      (synopsis "Emacs interface for Shroud password manager")
+      (description
+       "This package provides functions for working with shroud
+password manager using Elisp, a reader for Shroud DB, and an Buffers
+User Interface for using shroud password database.")
+      (license license:gpl3+))))
-- 
2.21.0




Information forwarded to guix-patches <at> gnu.org:
bug#34364; Package guix-patches. (Sun, 26 May 2019 16:37:02 GMT) Full text and rfc822 format available.

Message #17 received at 34364 <at> debbugs.gnu.org (full text, mbox):

From: Amar Singh <nly <at> disroot.org>
To: 34364 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-shroud.
Date: Sun, 26 May 2019 22:05:52 +0530
[Message part 1 (text/plain, inline)]
Updated emacs-shroud. It should be usable now.

[0001-gnu-Add-emacs-shroud.patch (text/x-patch, attachment)]

Reply sent to Marius Bakke <mbakke <at> fastmail.com>:
You have taken responsibility. (Mon, 27 Jan 2020 22:14:02 GMT) Full text and rfc822 format available.

Notification sent to Amar Singh <nly <at> disroot.org>:
bug acknowledged by developer. (Mon, 27 Jan 2020 22:14:03 GMT) Full text and rfc822 format available.

Message #22 received at 34364-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Amar Singh <nly <at> disroot.org>, 34364-done <at> debbugs.gnu.org
Subject: Re: [bug#34364] Add package: Emacs-shroud; Emacs interface for shroud
Date: Mon, 27 Jan 2020 23:13:46 +0100
[Message part 1 (text/plain, inline)]
This was pushed in a38525789cdb6b4baa440cdf9f265085d4378ec5.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 25 Feb 2020 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 58 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.