GNU bug report logs - #34371
[PATCH] gnu: emacs: Add modules support.

Previous Next

Package: guix-patches;

Reported by: Pierre-Antoine Rouby <contact <at> parouby.fr>

Date: Thu, 7 Feb 2019 16:46:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34371 in the body.
You can then email your comments to 34371 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#34371; Package guix-patches. (Thu, 07 Feb 2019 16:46:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Pierre-Antoine Rouby <contact <at> parouby.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 07 Feb 2019 16:46:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre-Antoine Rouby <contact <at> parouby.fr>
To: guix-patches <at> gnu.org
Cc: Pierre-Antoine Rouby <contact <at> parouby.fr>
Subject: [PATCH] gnu: emacs: Add modules support.
Date: Thu,  7 Feb 2019 17:43:47 +0100
* gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
---
 gnu/packages/emacs.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 7e8dcadf9..40d280f3e 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -115,6 +115,7 @@
     (build-system glib-or-gtk-build-system)
     (arguments
      `(#:tests? #f  ; no check target
+       #:configure-flags (list "--with-modules")
        #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'fix-/bin/pwd
-- 
2.20.1





Information forwarded to guix-patches <at> gnu.org:
bug#34371; Package guix-patches. (Fri, 15 Feb 2019 21:17:01 GMT) Full text and rfc822 format available.

Message #8 received at 34371 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Pierre-Antoine Rouby <contact <at> parouby.fr>
Cc: 34371 <at> debbugs.gnu.org
Subject: Re: [bug#34371] [PATCH] gnu: emacs: Add modules support.
Date: Fri, 15 Feb 2019 22:16:03 +0100
Hello Pierre-Antoine,

Pierre-Antoine Rouby <contact <at> parouby.fr> skribis:

> * gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
> ---
>  gnu/packages/emacs.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 7e8dcadf9..40d280f3e 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -115,6 +115,7 @@
>      (build-system glib-or-gtk-build-system)
>      (arguments
>       `(#:tests? #f  ; no check target
> +       #:configure-flags (list "--with-modules")

What effect does it have?  (I guess I’m a noob!)

If the Emacsfolks among us are fine with it, then so be it!

Thank you,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#34371; Package guix-patches. (Mon, 18 Feb 2019 22:59:01 GMT) Full text and rfc822 format available.

Message #11 received at 34371 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Pierre-Antoine Rouby <contact <at> parouby.fr>, 34371 <at> debbugs.gnu.org
Subject: Re: [bug#34371] [PATCH] gnu: emacs: Add modules support.
Date: Mon, 18 Feb 2019 23:58:11 +0100
Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello Pierre-Antoine,
>
> Pierre-Antoine Rouby <contact <at> parouby.fr> skribis:
>
>> * gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
>> ---
>>  gnu/packages/emacs.scm | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 7e8dcadf9..40d280f3e 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -115,6 +115,7 @@
>>      (build-system glib-or-gtk-build-system)
>>      (arguments
>>       `(#:tests? #f  ; no check target
>> +       #:configure-flags (list "--with-modules")
>
> What effect does it have?  (I guess I’m a noob!)
>
> If the Emacsfolks among us are fine with it, then so be it!

This allows one to build and load native C modules.  It’s a heavy-weight
extension mechanism (that one could use to extend Emacs with Guile
support, for example).

I don’t object to this change.

-- 
Ricardo





Information forwarded to guix-patches <at> gnu.org:
bug#34371; Package guix-patches. (Mon, 18 Feb 2019 23:06:01 GMT) Full text and rfc822 format available.

Message #14 received at 34371 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Pierre-Antoine Rouby <contact <at> parouby.fr>, 34371 <at> debbugs.gnu.org
Subject: Re: [bug#34371] [PATCH] gnu: emacs: Add modules support.
Date: Mon, 18 Feb 2019 17:05:41 -0600
Ricardo Wurmus writes:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Hello Pierre-Antoine,
>>
>> Pierre-Antoine Rouby <contact <at> parouby.fr> skribis:
>>
>>> * gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
>>> ---
>>>  gnu/packages/emacs.scm | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index 7e8dcadf9..40d280f3e 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -115,6 +115,7 @@
>>>      (build-system glib-or-gtk-build-system)
>>>      (arguments
>>>       `(#:tests? #f  ; no check target
>>> +       #:configure-flags (list "--with-modules")
>>
>> What effect does it have?  (I guess I’m a noob!)
>>
>> If the Emacsfolks among us are fine with it, then so be it!
>
> This allows one to build and load native C modules.  It’s a heavy-weight
> extension mechanism (that one could use to extend Emacs with Guile
> support, for example).
>
> I don’t object to this change.

Agreed with Ricardo,

I think this change is great, it is something I have been doing in my
own recipe for Emacs. Move it upstream, for sure.

Brett Gilio




Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 04 Mar 2019 13:41:01 GMT) Full text and rfc822 format available.

Notification sent to Pierre-Antoine Rouby <contact <at> parouby.fr>:
bug acknowledged by developer. (Mon, 04 Mar 2019 13:41:02 GMT) Full text and rfc822 format available.

Message #19 received at 34371-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 34371-done <at> debbugs.gnu.org, Pierre-Antoine Rouby <contact <at> parouby.fr>
Subject: Re: [bug#34371] [PATCH] gnu: emacs: Add modules support.
Date: Mon, 04 Mar 2019 14:40:28 +0100
Hi,

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Hello Pierre-Antoine,
>>
>> Pierre-Antoine Rouby <contact <at> parouby.fr> skribis:
>>
>>> * gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
>>> ---
>>>  gnu/packages/emacs.scm | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index 7e8dcadf9..40d280f3e 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -115,6 +115,7 @@
>>>      (build-system glib-or-gtk-build-system)
>>>      (arguments
>>>       `(#:tests? #f  ; no check target
>>> +       #:configure-flags (list "--with-modules")
>>
>> What effect does it have?  (I guess I’m a noob!)
>>
>> If the Emacsfolks among us are fine with it, then so be it!
>
> This allows one to build and load native C modules.  It’s a heavy-weight
> extension mechanism (that one could use to extend Emacs with Guile
> support, for example).
>
> I don’t object to this change.

Alright, applied.

Thanks Ricardo and Brett for chiming in!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 02 Apr 2019 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 361 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.