Received: (at 34376) by debbugs.gnu.org; 19 Jul 2019 21:12:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 19 17:12:19 2019 Received: from localhost ([127.0.0.1]:56600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hoaAs-0006oi-Pi for submit <at> debbugs.gnu.org; Fri, 19 Jul 2019 17:12:19 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eggert@HIDDEN>) id 1hoaAo-0006oR-5W for 34376 <at> debbugs.gnu.org; Fri, 19 Jul 2019 17:12:17 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 849361616C2; Fri, 19 Jul 2019 14:12:07 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SYk_dBL9HCgA; Fri, 19 Jul 2019 14:12:06 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 799191626B7; Fri, 19 Jul 2019 14:12:06 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bcdDKSEhAtQH; Fri, 19 Jul 2019 14:12:06 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 531201616C2; Fri, 19 Jul 2019 14:12:06 -0700 (PDT) From: Paul Eggert <eggert@HIDDEN> Subject: [bug-diffutils] bug#34376: How to submit a bug fix? To: Richard Gering <Richard.Gering@HIDDEN>, 34376 <at> debbugs.gnu.org References: <MWHPR18MB12322710F0FDBFFA856FFA99FA690@HIDDEN> Organization: UCLA Computer Science Department Message-ID: <26e8ca9a-5cd6-641b-b387-55bd2322e22a@HIDDEN> Date: Fri, 19 Jul 2019 14:12:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <MWHPR18MB12322710F0FDBFFA856FFA99FA690@HIDDEN> Content-Type: multipart/mixed; boundary="------------06BE3AC17A9606912379013D" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 34376 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------06BE3AC17A9606912379013D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Richard Gering wrote: > Are you interested in receiving these fixes? If so, how would you like me to submit them? Create a patch file or send the modified source files (small) in their entirety. A patch file would be better. 'git format-patch' generates a good format; the attached patch uses that format. system.h says this: It's possible for two distinct files on a buggy file system to have the same attributes, but it's not worth slowing down all implementations (or complicating the configuration) to cater to these rare cases in buggy implementations. Please keep that in mind when proposing a patch. > I'm curious how gnulib-tests/setlocale.c is supposed to get compiled, as the code relies on a localename.h file that is neither included nor generated, and I couldn't find any documentation towards this file either Thanks for reporting that. I installed the attached patch to work around the problem. --------------06BE3AC17A9606912379013D Content-Type: text/x-patch; name="0001-maint-avoid-Gnulib-setlocale-module.patch" Content-Disposition: attachment; filename="0001-maint-avoid-Gnulib-setlocale-module.patch" Content-Transfer-Encoding: quoted-printable From 73b78140bb8ab6e125f3cced7e37624b6384d7a4 Mon Sep 17 00:00:00 2001 From: Paul Eggert <eggert@HIDDEN> Date: Fri, 19 Jul 2019 14:09:53 -0700 Subject: [PATCH] maint: avoid Gnulib setlocale module MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Problem reported for MS-Windows by Richard Gering (Bug#34376). Diffutils doesn=E2=80=99t need any of the Gnulib fixes for setlocale. * bootstrap.conf (gnulib_tool_option_extras): Avoid the setlocale module. --- bootstrap.conf | 1 + 1 file changed, 1 insertion(+) diff --git a/bootstrap.conf b/bootstrap.conf index 4671349..7d5ea62 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -101,6 +101,7 @@ XGETTEXT_OPTIONS=3D$XGETTEXT_OPTIONS'\\\ gnulib_tool_option_extras=3D"--tests-base=3Dgnulib-tests --with-tests --avoid=3Dlocalename --avoid=3Dlock + --avoid=3Dsetlocale --symlink --makefile-name=3Dgnulib.mk " --=20 2.17.1 --------------06BE3AC17A9606912379013D--
bug-diffutils@HIDDEN
:bug#34376
; Package diffutils
.
Full text available.Received: (at submit) by debbugs.gnu.org; 8 Feb 2019 01:32:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 07 20:32:53 2019 Received: from localhost ([127.0.0.1]:38722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1grv2C-0002dC-1o for submit <at> debbugs.gnu.org; Thu, 07 Feb 2019 20:32:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <Richard.Gering@HIDDEN>) id 1gruF8-0001Iy-PK for submit <at> debbugs.gnu.org; Thu, 07 Feb 2019 19:42:12 -0500 Received: from lists.gnu.org ([209.51.188.17]:53677) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <Richard.Gering@HIDDEN>) id 1gruEy-0002Ri-H2 for submit <at> debbugs.gnu.org; Thu, 07 Feb 2019 19:42:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <Richard.Gering@HIDDEN>) id 1gruEx-0005xR-FB for bug-diffutils@HIDDEN; Thu, 07 Feb 2019 19:42:00 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE, UNPARSEABLE_RELAY autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <Richard.Gering@HIDDEN>) id 1gruEu-0002Pu-Bz for bug-diffutils@HIDDEN; Thu, 07 Feb 2019 19:41:58 -0500 Received: from m9a0001g.houston.softwaregrp.com ([15.124.64.66]:33356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <Richard.Gering@HIDDEN>) id 1gruEt-0002NH-OA for bug-diffutils@HIDDEN; Thu, 07 Feb 2019 19:41:56 -0500 Received: FROM m9a0001g.houston.softwaregrp.com (15.121.0.190) BY m9a0001g.houston.softwaregrp.com WITH ESMTP FOR bug-diffutils@HIDDEN; Fri, 8 Feb 2019 00:41:27 +0000 Received: from M4W0334.microfocus.com (2002:f78:1192::f78:1192) by M9W0067.microfocus.com (2002:f79:be::f79:be) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Fri, 8 Feb 2019 00:41:40 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (15.124.8.12) by M4W0334.microfocus.com (15.120.17.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Fri, 8 Feb 2019 00:41:40 +0000 Received: from MWHPR18MB1232.namprd18.prod.outlook.com (10.175.6.18) by MWHPR18MB1166.namprd18.prod.outlook.com (10.173.124.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.17; Fri, 8 Feb 2019 00:40:38 +0000 Received: from MWHPR18MB1232.namprd18.prod.outlook.com ([fe80::80db:fd0c:5407:abab]) by MWHPR18MB1232.namprd18.prod.outlook.com ([fe80::80db:fd0c:5407:abab%10]) with mapi id 15.20.1580.019; Fri, 8 Feb 2019 00:40:38 +0000 From: Richard Gering <Richard.Gering@HIDDEN> To: "bug-diffutils@HIDDEN" <bug-diffutils@HIDDEN> Subject: How to submit a bug fix? Thread-Topic: How to submit a bug fix? Thread-Index: AdS/RfbfE5idRpI5Q/mTtsQpH0SsVg== Date: Fri, 8 Feb 2019 00:40:38 +0000 Message-ID: <MWHPR18MB12322710F0FDBFFA856FFA99FA690@HIDDEN> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Richard.Gering@HIDDEN; x-originating-ip: [205.142.227.101] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MWHPR18MB1166; 6:/d4ZSpmeccnhnZkZIlqR2w0qV8xGrKI4mo+O+ZI1ke+YzvnlKWRzyrS6QQisnup+p+c7m61W6IRZLAKJIWGRTaYT0Jfy+lIHrnnWdVc11JEdl2QJg96MGc5yx5ZLrhUTQkpXChjIkQvez2iFQu0dgOdOP+PGAVOPd8O6uGnaZh9DaTZ09rg0bVJFk/HzU5RA4PrQWdz/ZIUvILuXWtCQZMrs5KCAmHlZwrZF1y6ROdj9gcwx1KLxYbms0x3PdYxfytgUHVMFrC0f/SIg3SbkAn4wHjc7xn1ECN+sVndJXvZJD7JSddeWOc/SuKv7kItcoffJoQ3vhJ/pTjuuR1db4DGJVBl9m0VXcqMe9WW4E2E5bKaYzqocqzRoYWqT3NUKjd10Z838QI0/c8AWNvEtSyg65uoCunQlltv9EP24gdueKkAN+Wa5NzuwMjRAHzJur6AelnHby+IF30DPIhr9TA==; 5:nFQ1ictkmxs6+QGjO327bnAtmWOAVUHLHcuYnfPeQF/hBBiu6XdaOu8NzwlqN+dF3gr128IUeyaN5sGffM0yTRKLpKJMs4ovcFlGZePRw+dU5SF5TVBcyL7ZZOefQjHKTpq/0ijVMJm2lBagJQAc8O4hK4o8iv1TdlqlLgLs3SI5juJSV62T/vqfEV33zMiANsOcaH7vlV0KHj0NsxqlVw==; 7:K5wdYO34jtp6VwG9hPhTEoIXPWzXxBvalNNFJilN3hoAwrYWrFeGhOWCGxRdOb0iSGtzcsH9iD5KjhEZq93h7ZlupbgeaYkC37mwAr2pRzNGJbsbCcQ31KK4ZOOqhPcQL63MBJ2aF2BqiX4ow1O+zw== x-ms-office365-filtering-correlation-id: 6ca59328-c909-41ec-d577-08d68d5e0bca x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020); SRVR:MWHPR18MB1166; x-ms-traffictypediagnostic: MWHPR18MB1166: x-microsoft-antispam-prvs: <MWHPR18MB1166FB971B6736C85BFED49EFA690@HIDDEN> x-forefront-prvs: 094213BFEA x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(376002)(136003)(39860400002)(396003)(366004)(189003)(199004)(51874003)(8936002)(102836004)(72206003)(6506007)(97736004)(8676002)(478600001)(81156014)(256004)(2501003)(81166006)(66066001)(6436002)(5640700003)(14454004)(4744005)(186003)(6916009)(86362001)(9686003)(6306002)(486006)(54896002)(476003)(68736007)(71190400001)(33656002)(2351001)(6116002)(74316002)(53936002)(71200400001)(7736002)(316002)(55016002)(106356001)(3846002)(790700001)(105586002)(26005)(7696005)(99286004)(2906002)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR18MB1166; H:MWHPR18MB1232.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microfocus.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: mcM3zV00ZderuXmiVKiZie81uUGV7FNr8wom4n0G40erXJejhIuar06i8EZPEZFUqOkBKBSCAbgKNK5ReQntA38Z5/mPkMS6S8lA7nt9Gb7S6VR+yYFi2o2ZZVFFAIz/+rXt+E0w3IiYvqMw30z2MQLtULeFEsYCTP5l60DRX4D2cbzbO8Rjpn1OmCe9PnY/CHWHvGdAEfna44tLN4fgcOGdhgNuX+fBIl8GE+DRNJpH7rcfZsA3RC7dj9TajhxyusNRfZ5ePJCFI/jcJ1Hgrfz3TZoCEvOc54GoM3Ugj8q8GeEnhkVrx5ZXf9RyjY/9T6iyBuGG9nQ5GjmLtdOuWe4/vKq2s6a7EanZHdNo39wrJB1EzAk3k/Vdi2MOmN6oT/NBcAox19O2Y4ghhu6PE3/e9Bi1ARcs5JVa1OcZpmE= Content-Type: multipart/alternative; boundary="_000_MWHPR18MB12322710F0FDBFFA856FFA99FA690MWHPR18MB1232namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6ca59328-c909-41ec-d577-08d68d5e0bca X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2019 00:40:38.2687 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1166 X-OriginatorOrg: microfocus.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 15.124.64.66 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 07 Feb 2019 20:32:50 -0500 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --_000_MWHPR18MB12322710F0FDBFFA856FFA99FA690MWHPR18MB1232namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Greetings, I discovered a bug in GNU diff 3.7 that causes it to not report differences= on Windows if two files have the same size and timestamp. A fix for this bug was made. I also had to make some changes to allow the c= ode to get cross-compiled via Mingw64. Are you interested in receiving these fixes? If so, how would you like me t= o submit them? Create a patch file or send the modified source files (small= ) in their entirety. Unrelated, but I'm curious how gnulib-tests/setlocale.c is supposed to get = compiled, as the code relies on a localename.h file that is neither include= d nor generated, and I couldn't find any documentation towards this file ei= ther. It is easily solved by creating a stub localename.h file, but is that= the expected solution? Thanks in advance for your reply. I look forward to hearing from you. With kind regards, - Richard. --_000_MWHPR18MB12322710F0FDBFFA856FFA99FA690MWHPR18MB1232namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr= osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:= //www.w3.org/TR/REC-html40"> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"= > <meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)"> <style><!-- /* Font Definitions */ @font-face {font-family:SimSun; panose-1:2 1 6 0 3 1 1 1 1 1;} @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} @font-face {font-family:"\@SimSun"; panose-1:2 1 6 0 3 1 1 1 1 1;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0in; margin-bottom:.0001pt; font-size:11.0pt; font-family:"Calibri",sans-serif; mso-fareast-language:ZH-CN;} a:link, span.MsoHyperlink {mso-style-priority:99; color:#0563C1; text-decoration:underline;} a:visited, span.MsoHyperlinkFollowed {mso-style-priority:99; color:#954F72; text-decoration:underline;} span.EmailStyle17 {mso-style-type:personal-compose; font-family:"Calibri",sans-serif; color:windowtext;} .MsoChpDefault {mso-style-type:export-only; font-family:"Calibri",sans-serif; mso-fareast-language:ZH-CN;} @page WordSection1 {size:8.5in 11.0in; margin:1.0in 1.0in 1.0in 1.0in;} div.WordSection1 {page:WordSection1;} --></style><!--[if gte mso 9]><xml> <o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" /> </xml><![endif]--><!--[if gte mso 9]><xml> <o:shapelayout v:ext=3D"edit"> <o:idmap v:ext=3D"edit" data=3D"1" /> </o:shapelayout></xml><![endif]--> </head> <body lang=3D"EN-US" link=3D"#0563C1" vlink=3D"#954F72"> <div class=3D"WordSection1"> <p class=3D"MsoNormal">Greetings,<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">I discovered a bug in GNU diff 3.7 that causes it to= not report differences on Windows if two files have the same size and time= stamp.<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">A fix for this bug was made. I also had to make some= changes to allow the code to get cross-compiled via Mingw64.<o:p></o:p></p= > <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">Are you interested in receiving these fixes? If so, = how would you like me to submit them? Create a patch file or send the modif= ied source files (small) in their entirety.<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">Unrelated, but I'm curious how gnulib-tests/setlocal= e.c is supposed to get compiled, as the code relies on a localename.h file = that is neither included nor generated, and I couldn't find any documentati= on towards this file either. It is easily solved by creating a stub localename.h file, but is that the expect= ed solution?<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">Thanks in advance for your reply. I look forward to = hearing from you.<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">With kind regards,<o:p></o:p></p> <p class=3D"MsoNormal"><o:p> </o:p></p> <p class=3D"MsoNormal">- Richard.<o:p></o:p></p> </div> </body> </html> --_000_MWHPR18MB12322710F0FDBFFA856FFA99FA690MWHPR18MB1232namp_--
Richard Gering <Richard.Gering@HIDDEN>
:bug-diffutils@HIDDEN
.
Full text available.bug-diffutils@HIDDEN
:bug#34376
; Package diffutils
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.