GNU bug report logs - #34393
[PATCH] gnu: terminals: Add termbox-truecolor

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34393 in the body.
You can then email your comments to 34393 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Amirouche Boubekki <amirouche <at> hypermove.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: terminals: Add termbox-truecolor
Date: Sat, 09 Feb 2019 00:12:00 +0100

[0001-gnu-Add-termbox-truecolor.patch (text/x-diff, attachment)]

Message #8 received at 34393 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Amirouche Boubekki <amirouche <at> hypermove.net>
Cc: 34393 <at> debbugs.gnu.org
Subject: Re: [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor
Date: Fri, 8 Feb 2019 22:38:30 -0600

[Message part 1 (text/plain, inline)]

> +(define-public termbox-truecolor
> +  (package
> +    (name "termbox-truecolor")
> +    (version "2019.01.06-c3afbfd")

Could you include a revision number here too?  (See "Version Numbers"
in the manual)

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/amirouche/termbox-truecolor.git")
> +                    (commit "c3afbfd8f31cce70ffb8c4ddd153489d9e363780")))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "179py858dhhxkj6la84b224r2fjwavygf4daw4dgl3gvv8i07ryj"))))
> +    (build-system waf-build-system)
> +    (arguments
> +     `(#:tests? #f))
> +    (synopsis "Library for writing text-based user interfaces (with true-color support)")

Maybe: "Text-based user interface library"

The true-color support can be mentioned in the description.

> +    (description "Termbox is a library that provides minimalistic API which

"...provides a minimalistic ..."
             ^

> +allows the programmer to write text-based user interfaces.
> +
> +It is based on a simple abstraction: viewing terminals as a table of

I think the paragraph break isn't necessary here.

> +fixed-size cells and input being a stream of structured messages.  Copy &
> +pasting and wide characters (mostly Chinese, Japanese, Korean (CJK)
> +characters) are not really supported.")
> +    (home-page "https://github.com/amirouche/termbox-truecolor/tree/truecolor")
> +    (license license:expat)))

Otherwise looks good to me,

`~Eric

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 34393 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Amirouche Boubekki <amirouche <at> hypermove.net>
Cc: 34393 <at> debbugs.gnu.org
Subject: Re: [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor
Date: Sat, 09 Feb 2019 09:58:00 +0100

Hi Amirouche,

> From c97de00efc8dfe17a2cedda69033eaa710c42a6e Mon Sep 17 00:00:00 2001
> From: Amirouche <amirouche.boubekki <at> gmail.com>
> Date: Sat, 9 Feb 2019 00:07:48 +0100
> Subject: [PATCH] gnu: Add termbox-truecolor.
>
> * gnu/packages/terminals.scm (termbox-truecolor): New variable.

Thanks for the patch!

[…]
> +(define-public termbox-truecolor
> +  (package
> +    (name "termbox-truecolor")
> +    (version "2019.01.06-c3afbfd")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/amirouche/termbox-truecolor.git")
> +                    (commit "c3afbfd8f31cce70ffb8c4ddd153489d9e363780")))

It’s better to let-bind the commit and then use (git-version "1.1.0"
commit), because the last release was 1.1.0.

“2019.01.06” is not a version string and it would always be considered a
more recent version than other releases because 2019 is larger than most
major release numbers.
> +    (arguments
> +     `(#:tests? #f))

Could you tell us why the tests are disabled?  If there are no tests
please add a comment “; there are no tests”.

> +    (synopsis "Library for writing text-based user interfaces (with true-color support)")

I think “guix lint” said something about this synopsis being too long.
Could you shorten it a bit?

> +    (home-page
> "https://github.com/amirouche/termbox-truecolor/tree/truecolor")

I think the “tree/truecolor” bit can be removed.

-- 
Ricardo

Message #14 received at 34393 <at> debbugs.gnu.org (full text, mbox):

From: amirouche <at> hyper.dev
To: 34393 <at> debbugs.gnu.org
Subject: Notice
Date: Wed, 01 May 2019 03:14:43 +0200

I just noticed your comments. I will work on them tomorrow.

There is also the problem that upstream doesn't provide pkg-config file 
: /

Message #17 received at 34393 <at> debbugs.gnu.org (full text, mbox):

From: amirouche <at> hyper.dev
To: 34393 <at> debbugs.gnu.org
Subject: Re: Notice
Date: Wed, 01 May 2019 13:04:57 +0200

[Message part 1 (text/plain, inline)]

On 2019-05-01 03:14, amirouche <at> hyper.dev wrote:
> I just noticed your comments. I will work on them tomorrow.

Here is a new patch.

This is a fork of the upstream package which add truecolor support.

[0001-gnu-add-termbox-truecolor.patch (text/x-diff, attachment)]

Message #20 received at 34393 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Amirouche Boubekki <amirouche <at> hypermove.net>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 34393 <at> debbugs.gnu.org,
 Eric Bavier <ericbavier <at> centurylink.net>
Subject: Re: bug#34393: [PATCH] gnu: terminals: Add termbox-truecolor
Date: Tue, 12 Apr 2022 12:08:14 +0200

Hi,

Thanks for the submission.


What is the status of this old patch submission [1]?

1: <http://issues.guix.gnu.org/issue/34393>


Since the last interaction is from 2 years, 49 weeks, 3 days ago, I
propose to rebase or close.


Cheers,
simon

Message #25 received at 34393-done <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Amirouche Boubekki <amirouche <at> hypermove.net>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 34393-done <at> debbugs.gnu.org,
 Eric Bavier <ericbavier <at> centurylink.net>
Subject: Re: bug#34393: [PATCH] gnu: terminals: Add termbox-truecolor
Date: Thu, 19 May 2022 23:18:04 +0200

Hi,

On Tue, 12 Apr 2022 at 12:08, zimoun <zimon.toutoune <at> gmail.com> wrote:

> What is the status of this old patch submission [1]?
>
> 1: <http://issues.guix.gnu.org/issue/34393>
>
>
> Since the last interaction is from 2 years, 49 weeks, 3 days ago, I
> propose to rebase or close.

Since no one is willing to rebase, I am closing.  Feel free to reopen.


Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.