GNU bug report logs - #34393
[PATCH] gnu: terminals: Add termbox-truecolor

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Amirouche Boubekki <amirouche@HIDDEN>; Keywords: patch; dated Fri, 8 Feb 2019 23:13:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 34393 <at> debbugs.gnu.org:


Received: (at 34393) by debbugs.gnu.org; 1 May 2019 11:05:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 01 07:05:03 2019
Received: from localhost ([127.0.0.1]:43526 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hLn2t-0005TU-5L
	for submit <at> debbugs.gnu.org; Wed, 01 May 2019 07:05:03 -0400
Received: from relay12.mail.gandi.net ([217.70.178.232]:37481)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <amirouche@HIDDEN>) id 1hLn2q-0005T1-Q2
 for 34393 <at> debbugs.gnu.org; Wed, 01 May 2019 07:05:02 -0400
Received: from webmail.gandi.net (webmail14.sd4.0x35.net [10.200.201.14])
 (Authenticated sender: amirouche@HIDDEN)
 by relay12.mail.gandi.net (Postfix) with ESMTPA id 12FD420000F
 for <34393 <at> debbugs.gnu.org>; Wed,  1 May 2019 11:04:57 +0000 (UTC)
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_b348e324106a864168e3a7369a91d3f2"
Date: Wed, 01 May 2019 13:04:57 +0200
From: amirouche@HIDDEN
To: 34393 <at> debbugs.gnu.org
Subject: Re: Notice
In-Reply-To: <3bc02708adb4cb3312ea9f6696793bb6@HIDDEN>
References: <3bc02708adb4cb3312ea9f6696793bb6@HIDDEN>
Message-ID: <7debf6baea2c012f2ce37ae46aef9821@HIDDEN>
X-Sender: amirouche@HIDDEN
User-Agent: Roundcube Webmail/1.3.8
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 34393
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=_b348e324106a864168e3a7369a91d3f2
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

On 2019-05-01 03:14, amirouche@HIDDEN wrote:
> I just noticed your comments. I will work on them tomorrow.

Here is a new patch.

This is a fork of the upstream package which add truecolor support.
--=_b348e324106a864168e3a7369a91d3f2
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=0001-gnu-add-termbox-truecolor.patch
Content-Disposition: attachment;
 filename=0001-gnu-add-termbox-truecolor.patch;
 size=2573

RnJvbSA2NGZiMzljMWQxZDQzNmViNmIwNDQyMzhjZTMxNzc4NDRiZGIzOWJjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbWlyb3VjaGUgPGFtaXJvdWNoZStkZXZAaHlwZXIuZGV2PgpE
YXRlOiBXZWQsIDEgTWF5IDIwMTkgMTI6NTk6NTMgKzAyMDAKU3ViamVjdDogW1BBVENIXSBnbnU6
IGFkZCB0ZXJtYm94LXRydWVjb2xvcgoKKiBnbnUvcGFja2FnZXMvdGVybWluYWxzLnNjbSAodGVy
bWJveC10cnVlY29sb3IpOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL3Rlcm1pbmFs
cy5zY20gfCAyOCArKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwg
MjggaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy90ZXJtaW5hbHMuc2Nt
IGIvZ251L3BhY2thZ2VzL3Rlcm1pbmFscy5zY20KaW5kZXggZDA1MzFiMGMxNC4uNzk3NTkxMjZh
ZCAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL3Rlcm1pbmFscy5zY20KKysrIGIvZ251L3BhY2th
Z2VzL3Rlcm1pbmFscy5zY20KQEAgLTE0LDYgKzE0LDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAx
OCBHYWJyaWVsIEhvbmRldCA8Z2FicmllbGhvbmRldEBnbWFpbC5jb20+CiA7OzsgQ29weXJpZ2h0
IMKpIDIwMTkgUnV0Z2VyIEhlbGxpbmcgPHJoZWxsaW5nQG15a29sYWIuY29tPgogOzs7IENvcHly
aWdodCDCqSAyMDE4LCAyMDE5IEVyaWMgQmF2aWVyIDxiYXZpZXJAbWVtYmVyLmZzZi5vcmc+Cis7
OzsgQ29weXJpZ2h0IMKpIDIwMTgsIDIwMTkgQW1pcm91Y2hlIEJvdWJla2tpIDxhbWlyb3VjaGVA
aHlwZXIuZGV2PgogOzs7CiA7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsK
QEAgLTM3LDYgKzM4LDcgQEAKICAgIzp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5c3RlbSBnbGli
LW9yLWd0aykKICAgIzp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5c3RlbSBnbykKICAgIzp1c2Ut
bW9kdWxlIChndWl4IGJ1aWxkLXN5c3RlbSBweXRob24pCisgICM6dXNlLW1vZHVsZSAoZ3VpeCBi
dWlsZC1zeXN0ZW0gd2FmKQogICAjOnVzZS1tb2R1bGUgKGd1aXggZG93bmxvYWQpCiAgICM6dXNl
LW1vZHVsZSAoZ3VpeCBnaXQtZG93bmxvYWQpCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBwYWNrYWdl
cykKQEAgLTg4OCw2ICs4OTAsMzIgQEAgcGVyLWxpbmUgZnVsbHNjcmVlbiB0ZXJtaW5hbCByZW5k
ZXJpbmcsIGFuZCBrZXlib2FyZCBpbnB1dCBldmVudCByZXBvcnRpbmcuIikKIChkZWZpbmUtcHVi
bGljIHB5dGhvbjItY3VydHNpZXMKICAgKHBhY2thZ2Utd2l0aC1weXRob24yIHB5dGhvbi1jdXJ0
c2llcykpCiAKKyhkZWZpbmUtcHVibGljIHRlcm1ib3gtdHJ1ZWNvbG9yCisgIChsZXQgKChjb21t
aXQgIjk2MmEzZDhiZWUwNGRmNzVjNDcxODdhOTkxMDQ2NDcxOGVhODQwYWEiKQorICAgICAgICAo
cmV2aXNpb24gIjAiKSkKKyAgICAocGFja2FnZQorICAgICAgKG5hbWUgInRlcm1ib3gtdHJ1ZWNv
bG9yIikKKyAgICAgICh2ZXJzaW9uIChnaXQtdmVyc2lvbiAiMS4xLjIiIHJldmlzaW9uIGNvbW1p
dCkpCisgICAgICAoc291cmNlIChvcmlnaW4KKyAgICAgICAgICAgICAgICAobWV0aG9kIGdpdC1m
ZXRjaCkKKyAgICAgICAgICAgICAgICAodXJpIChnaXQtcmVmZXJlbmNlCisgICAgICAgICAgICAg
ICAgICAgICAgKHVybCAiaHR0cHM6Ly9naXRodWIuY29tL2FtaXJvdWNoZS90ZXJtYm94LXRydWVj
b2xvci5naXQiKQorICAgICAgICAgICAgICAgICAgICAgIChjb21taXQgY29tbWl0KSkpCisgICAg
ICAgICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24pKQorICAg
ICAgICAgICAgICAgIChzaGEyNTYKKyAgICAgICAgICAgICAgICAgKGJhc2UzMgorICAgICAgICAg
ICAgICAgICAgIjBqa3djeng3bDM2anJwMTFzcDl5cmh2Z2FmZzgxMWtzeHM3dmw0bG43azZidzg1
cW1tODEiKSkpKQorICAgICAgKGJ1aWxkLXN5c3RlbSB3YWYtYnVpbGQtc3lzdGVtKQorICAgICAg
KGFyZ3VtZW50cworICAgICAgIGAoIzp0ZXN0cz8gI2YpKSA7OyBubyB0ZXN0cworICAgICAgKHN5
bm9wc2lzICJUZXh0LWJhc2VkIHVzZXIgaW50ZXJmYWNlcyBsaWJyYXJ5IikKKyAgICAgIChkZXNj
cmlwdGlvbiAiVGVybWJveCBpcyBhIGxpYnJhcnkgdGhhdCBwcm92aWRlcyBhIG1pbmltYWxpc3Rp
YworQVBJIHdoaWNoIGFsbG93cyB0aGUgcHJvZ3JhbW1lciB0byB3cml0ZSB0ZXh0LWJhc2VkIHVz
ZXIgaW50ZXJmYWNlcyB3aXRoCit0cnVlLWNvbG9yIHN1cHBvcnQuICBJdCBpcyBiYXNlZCBvbiBh
IHNpbXBsZSBhYnN0cmFjdGlvbjogdmlld2luZyB0ZXJtaW5hbHMgYXMKK2EgdGFibGUgb2YgZml4
ZWQtc2l6ZSBjZWxscyBhbmQgaW5wdXQgYmVpbmcgYSBzdHJlYW0gb2Ygc3RydWN0dXJlZCBtZXNz
YWdlcy4iKQorICAgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9naXRodWIuY29tL2FtaXJvdWNoZS90
ZXJtYm94LXRydWVjb2xvci8iKQorICAgICAgKGxpY2Vuc2UgbGljZW5zZTpleHBhdCkpKSkKKwog
KGRlZmluZS1wdWJsaWMgdG1hdGUKICAgKHBhY2thZ2UKICAgICAobmFtZSAidG1hdGUiKQotLSAK
Mi4xOS4xCgo=
--=_b348e324106a864168e3a7369a91d3f2--




Information forwarded to guix-patches@HIDDEN:
bug#34393; Package guix-patches. Full text available.

Message received at 34393 <at> debbugs.gnu.org:


Received: (at 34393) by debbugs.gnu.org; 1 May 2019 01:14:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 30 21:14:49 2019
Received: from localhost ([127.0.0.1]:42904 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hLdpg-0003td-T4
	for submit <at> debbugs.gnu.org; Tue, 30 Apr 2019 21:14:49 -0400
Received: from relay12.mail.gandi.net ([217.70.178.232]:44493)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <amirouche@HIDDEN>) id 1hLdpe-0003tU-QH
 for 34393 <at> debbugs.gnu.org; Tue, 30 Apr 2019 21:14:47 -0400
Received: from webmail.gandi.net (webmail14.sd4.0x35.net [10.200.201.14])
 (Authenticated sender: amirouche@HIDDEN)
 by relay12.mail.gandi.net (Postfix) with ESMTPA id 9CF7320000F
 for <34393 <at> debbugs.gnu.org>; Wed,  1 May 2019 01:14:43 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 01 May 2019 03:14:43 +0200
From: amirouche@HIDDEN
To: 34393 <at> debbugs.gnu.org
Subject: Notice
Message-ID: <3bc02708adb4cb3312ea9f6696793bb6@HIDDEN>
X-Sender: amirouche@HIDDEN
User-Agent: Roundcube Webmail/1.3.8
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 34393
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

I just noticed your comments. I will work on them tomorrow.

There is also the problem that upstream doesn't provide pkg-config file 
: /




Information forwarded to guix-patches@HIDDEN:
bug#34393; Package guix-patches. Full text available.

Message received at 34393 <at> debbugs.gnu.org:


Received: (at 34393) by debbugs.gnu.org; 10 Feb 2019 20:46:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 10 15:46:27 2019
Received: from localhost ([127.0.0.1]:42825 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gsvzd-000339-T2
	for submit <at> debbugs.gnu.org; Sun, 10 Feb 2019 15:46:26 -0500
Received: from sender-of-o51.zoho.com ([135.84.80.216]:21073)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rekado@HIDDEN>) id 1gsvzb-00032w-HG
 for 34393 <at> debbugs.gnu.org; Sun, 10 Feb 2019 15:46:24 -0500
ARC-Seal: i=1; a=rsa-sha256; t=1549702690; cv=none; d=zoho.com; s=zohoarc; 
 b=VdBbfKM7xWvl32MYneB7sNR+R4piIn7ozbmpH5TbFBKp8YLu9FkhBmwl45E7q4oZDNcYKbQQHgJ94KPCNWe2TJjEniyYJ9WIVZ6o8wGqYWH7Xvkn6QTThG4u22HCUw8Uz/v0EIfjDCCSLOq0YZvSPlnRNw5b86P8pG29eILj+Kw=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc; t=1549702690;
 h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To:ARC-Authentication-Results;
 bh=UDpHJcgLgJMJ6O85J99Y1zJuc9ZMymbtu+YdI7CTfIo=; 
 b=QEzvREpi/EJnV6V5OpnaG85Ul4uXScl1KAdMSag+Q+2fOrzIAo6WK4OL3C086g+SrhGDdPLeXiXe857v7azkisbCh0xPK18gJXaZRUQXqTmOgBUukbAqr/HouX1pRH40vVruBx7ggmJ5DK0+MfOCCpd27B0XY/qH6aRCJPY4pQ8=
ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass  header.i=elephly.net;
 spf=pass  smtp.mailfrom=rekado@HIDDEN;
 dmarc=pass header.from=<rekado@HIDDEN> header.from=<rekado@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1549702690; 
 s=zoho; d=elephly.net; i=rekado@HIDDEN;
 h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding;
 l=1535; bh=UDpHJcgLgJMJ6O85J99Y1zJuc9ZMymbtu+YdI7CTfIo=;
 b=AtGU7xzAyXvy2+uDP7D0YkY+uTP1CXqDL8dkupxKIj0KwKQLyZReYgU4ZnFbs9Gx
 PIevxeGO9cD+vKuMkSt3gWG+NlJdJpalYymVmuUPqmfkuFig4suuGvlDLBWma4eozXu
 itNmhOWEzLECN3wYbH2ZmVNt2swP6GG0DIWkqWfo=
Received: from localhost (p3E9E9F79.dip0.t-ipconnect.de [62.158.159.121]) by
 mx.zohomail.com with SMTPS id 1549702687707429.5576190627809;
 Sat, 9 Feb 2019 00:58:07 -0800 (PST)
References: <21686c5a9ff5047728ed5277a6bdd5a0@HIDDEN>
User-agent: mu4e 1.0; emacs 26.1
From: Ricardo Wurmus <rekado@HIDDEN>
To: Amirouche Boubekki <amirouche@HIDDEN>
Subject: Re: [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor
In-reply-to: <21686c5a9ff5047728ed5277a6bdd5a0@HIDDEN>
X-URL: https://elephly.net
X-PGP-Key: https://elephly.net/rekado.pubkey
X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
Date: Sat, 09 Feb 2019 09:58:00 +0100
Message-ID: <878sypmj8n.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-ZohoMailClient: External
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 34393
Cc: 34393 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Hi Amirouche,

> From c97de00efc8dfe17a2cedda69033eaa710c42a6e Mon Sep 17 00:00:00 2001
> From: Amirouche <amirouche.boubekki@HIDDEN>
> Date: Sat, 9 Feb 2019 00:07:48 +0100
> Subject: [PATCH] gnu: Add termbox-truecolor.
>
> * gnu/packages/terminals.scm (termbox-truecolor): New variable.

Thanks for the patch!

[=E2=80=A6]
> +(define-public termbox-truecolor
> +  (package
> +    (name "termbox-truecolor")
> +    (version "2019.01.06-c3afbfd")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/amirouche/termbox-truecolor=
.git")
> +                    (commit "c3afbfd8f31cce70ffb8c4ddd153489d9e363780")))

It=E2=80=99s better to let-bind the commit and then use (git-version "1.1.0"
commit), because the last release was 1.1.0.

=E2=80=9C2019.01.06=E2=80=9D is not a version string and it would always be=
 considered a
more recent version than other releases because 2019 is larger than most
major release numbers.
> +    (arguments
> +     `(#:tests? #f))

Could you tell us why the tests are disabled?  If there are no tests
please add a comment =E2=80=9C; there are no tests=E2=80=9D.

> +    (synopsis "Library for writing text-based user interfaces (with true=
-color support)")

I think =E2=80=9Cguix lint=E2=80=9D said something about this synopsis bein=
g too long.
Could you shorten it a bit?

> +    (home-page
> "https://github.com/amirouche/termbox-truecolor/tree/truecolor")

I think the =E2=80=9Ctree/truecolor=E2=80=9D bit can be removed.

--=20
Ricardo





Information forwarded to guix-patches@HIDDEN:
bug#34393; Package guix-patches. Full text available.

Message received at 34393 <at> debbugs.gnu.org:


Received: (at 34393) by debbugs.gnu.org; 9 Feb 2019 04:38:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 08 23:38:41 2019
Received: from localhost ([127.0.0.1]:40356 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gsKPZ-0002wT-1w
	for submit <at> debbugs.gnu.org; Fri, 08 Feb 2019 23:38:41 -0500
Received: from mail.onyx.syn-alias.com ([206.152.134.66]:56787
 helo=smtp.centurylink.net)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ericbavier@HIDDEN>) id 1gsKPW-0002wF-AJ
 for 34393 <at> debbugs.gnu.org; Fri, 08 Feb 2019 23:38:38 -0500
DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402;
 c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1549687112;
 h=From:Subject:Date:To:MIME-Version:Content-Type;
 bh=FWasgEDmWXZRLTLnavxcfL7lErU=;
 b=11plw90EISXOEt7juouc9E1Odc9FMOPXAWLkN21o6RRMSb8Nu8qsDXdVCfKMs64C
 XXkW9LEGhuKXg4h7AWCQws4qQN5kDzRs/gq3jkFi8ivcMJVew90zYQmSK0nb4ba0
 PYZL+X0PzcO87DZGVUc0Mc4cWDez/izbhwiLcKWgDgRAd1fB3xsReQLxNiAFXwMQ
 4f6xfxAP5vrUzPheVLb6JtxeMlhREXU5RC7VxAjJTAdHW159LPYwL7Y02mrwJnbN
 KxYfE3qAkxfsHawi2dOUl84JaO3ukk23UTSBTSm+1k32OI9Uz0iU7ctPsIiU8rnp
 FbXK751EzsubQhWwqp+zbg==;
X_CMAE_Category: , ,
X-CNFS-Analysis: v=2.3 cv=KKEk82No c=1 sm=1 tr=0
 a=QyxltsrUb1TgOUMZEPHifA==:117 a=QyxltsrUb1TgOUMZEPHifA==:17
 a=KGjhK52YXX0A:10 a=CFTnQlWoA9kA:10 a=zSv6zi-ZgakA:10 a=JbbA2ytKAAAA:20
 a=go0sLycNt5No5HmBh_YA:9 a=CjuIK1q_8ugA:10 a=ApkQbetODnjY0NvBSUgA:9
 a=Tn4yfnTJZh7cbF3OKAw8:22
X-CM-Score: 0
X-Scanned-by: Cloudmark Authority Engine
X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ=
Authentication-Results: smtp04.onyx.dfw.sync.lan
 smtp.user=ericbavier@HIDDEN; auth=pass (LOGIN)
Received: from [97.116.114.155] ([97.116.114.155:43006] helo=localhost)
 by smtp.centurylink.net (envelope-from <ericbavier@HIDDEN>)
 (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA
 (cipher=AES256-GCM-SHA384) 
 id 3D/58-30837-8495E5C5; Fri, 08 Feb 2019 23:38:32 -0500
Date: Fri, 8 Feb 2019 22:38:30 -0600
From: Eric Bavier <ericbavier@HIDDEN>
To: Amirouche Boubekki <amirouche@HIDDEN>
Subject: Re: [bug#34393] [PATCH] gnu: terminals: Add termbox-truecolor
Message-ID: <20190208223830.1cdda4e3@HIDDEN>
In-Reply-To: <21686c5a9ff5047728ed5277a6bdd5a0@HIDDEN>
References: <21686c5a9ff5047728ed5277a6bdd5a0@HIDDEN>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/FH/Sd_pVErPGqxan5ubDA7j"; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 34393
Cc: 34393 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--Sig_/FH/Sd_pVErPGqxan5ubDA7j
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

> +(define-public termbox-truecolor
> +  (package
> +    (name "termbox-truecolor")
> +    (version "2019.01.06-c3afbfd")

Could you include a revision number here too?  (See "Version Numbers"
in the manual)

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/amirouche/termbox-truecolor=
.git")
> +                    (commit "c3afbfd8f31cce70ffb8c4ddd153489d9e363780")))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "179py858dhhxkj6la84b224r2fjwavygf4daw4dgl3gvv8i07ryj"))=
))
> +    (build-system waf-build-system)
> +    (arguments
> +     `(#:tests? #f))
> +    (synopsis "Library for writing text-based user interfaces (with true=
-color support)")

Maybe: "Text-based user interface library"

The true-color support can be mentioned in the description.

> +    (description "Termbox is a library that provides minimalistic API wh=
ich

"...provides a minimalistic ..."
             ^

> +allows the programmer to write text-based user interfaces.
> +
> +It is based on a simple abstraction: viewing terminals as a table of

I think the paragraph break isn't necessary here.

> +fixed-size cells and input being a stream of structured messages.  Copy &
> +pasting and wide characters (mostly Chinese, Japanese, Korean (CJK)
> +characters) are not really supported.")
> +    (home-page "https://github.com/amirouche/termbox-truecolor/tree/true=
color")
> +    (license license:expat)))

Otherwise looks good to me,

`~Eric

--Sig_/FH/Sd_pVErPGqxan5ubDA7j
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlxeWUYACgkQ/XPKxxnT
JWYCmA//eIQd2l+/MnvZyJh4UARjytmAbzCaHPyOXXPAcoW7E+NBWCNjNBfw6kgF
nkdELBmD5lXdUk5ECecWxbqNATy+dayhfSQPeReqrpakCgLfF9K5ZWsg1f2VmT12
o5PF0VE4rSINYw5Rf2dUef8e2g9Gs+QJ8E8uPwRTdtAXUBD6Bk2BNxjdXrxdDsGp
FLc16w/OjJjEeFOY6+2nm+Gcxfa3CRtT5+miNLiWHqNfGRjF2t5+ngIvjGp5r7Bt
3gKiMPQBNHseweAJhBF2H8WQt/kIFNj6J0ggLBRKWBmsKq3v58GydkGiRg/Aclwr
mB65LSggTEpoiumCQ6uy/QIngFasQZq0ORYh8uJ0xOiYVkXDrvgLJ40QSpHIpGQD
OqMQ8RrpX/voO86MCWmEsyukVO/iJ9Vn8PvAyRu7Uy9bQZIQajsZjbhv/gU9VeZO
RSHeaB1OMpOMND3kNh/yFtB9RHp0r/zEA9maclGTvtiHotv0a0Zc4My2KXgt+QTa
A+JiPMGZnj5S8AIc8+u/rkwxm66dpdYAaVrKlbO1Co/3oQ/qDDLUSowrJl5C3dL9
9/7SdimVsDaPDcz8QI6SilRCubnJdtbyoQ0Kp/PQjBd1qhtVsJHXdU5rTr9gehVa
v41JkM+7G4XvKnzKSU9S8IB4QkHlVFn6MniCcHgauabN69tH1g4=
=mqfr
-----END PGP SIGNATURE-----

--Sig_/FH/Sd_pVErPGqxan5ubDA7j--




Information forwarded to guix-patches@HIDDEN:
bug#34393; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 8 Feb 2019 23:12:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 08 18:12:19 2019
Received: from localhost ([127.0.0.1]:40294 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gsFJh-0003FC-0G
	for submit <at> debbugs.gnu.org; Fri, 08 Feb 2019 18:12:19 -0500
Received: from eggs.gnu.org ([209.51.188.92]:46040)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <amirouche@HIDDEN>) id 1gsFJd-0003Eu-9n
 for submit <at> debbugs.gnu.org; Fri, 08 Feb 2019 18:12:13 -0500
Received: from lists.gnu.org ([209.51.188.17]:37617)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <amirouche@HIDDEN>)
 id 1gsFJY-00023i-4s
 for submit <at> debbugs.gnu.org; Fri, 08 Feb 2019 18:12:08 -0500
Received: from eggs.gnu.org ([209.51.188.92]:60416)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <amirouche@HIDDEN>) id 1gsFJW-0000vw-Tg
 for guix-patches@HIDDEN; Fri, 08 Feb 2019 18:12:07 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_NONE,
 URIBL_BLOCKED autolearn=disabled version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <amirouche@HIDDEN>) id 1gsFJV-00022K-RS
 for guix-patches@HIDDEN; Fri, 08 Feb 2019 18:12:06 -0500
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:40623)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <amirouche@HIDDEN>)
 id 1gsFJV-000200-Gj
 for guix-patches@HIDDEN; Fri, 08 Feb 2019 18:12:05 -0500
Received: from webmail.gandi.net (webmail1.sd4.0x35.net [10.200.201.1])
 (Authenticated sender: amirouche@HIDDEN)
 by relay8-d.mail.gandi.net (Postfix) with ESMTPA id C5A4D1BF208
 for <guix-patches@HIDDEN>; Fri,  8 Feb 2019 23:12:00 +0000 (UTC)
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_6a4d079373e55621116e7d77f92bc62c"
Date: Sat, 09 Feb 2019 00:12:00 +0100
From: Amirouche Boubekki <amirouche@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: terminals: Add termbox-truecolor
Message-ID: <21686c5a9ff5047728ed5277a6bdd5a0@HIDDEN>
X-Sender: amirouche@HIDDEN
User-Agent: Roundcube Webmail/1.1.2
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 217.70.183.201
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=_6a4d079373e55621116e7d77f92bc62c
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=0001-gnu-Add-termbox-truecolor.patch
Content-Disposition: attachment;
 filename=0001-gnu-Add-termbox-truecolor.patch;
 size=2549

RnJvbSBjOTdkZTAwZWZjOGRmZTE3YTJjZWRkYTY5MDMzZWFhNzEwYzQyYTZlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbWlyb3VjaGUgPGFtaXJvdWNoZS5ib3ViZWtraUBnbWFpbC5j
b20+CkRhdGU6IFNhdCwgOSBGZWIgMjAxOSAwMDowNzo0OCArMDEwMApTdWJqZWN0OiBbUEFUQ0hd
IGdudTogQWRkIHRlcm1ib3gtdHJ1ZWNvbG9yLgoKKiBnbnUvcGFja2FnZXMvdGVybWluYWxzLnNj
bSAodGVybWJveC10cnVlY29sb3IpOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL3Rl
cm1pbmFscy5zY20gfCAyOSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNo
YW5nZWQsIDI5IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvdGVybWlu
YWxzLnNjbSBiL2dudS9wYWNrYWdlcy90ZXJtaW5hbHMuc2NtCmluZGV4IDdmNTJjNmVmZC4uMGZm
MGVkYTM1IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvdGVybWluYWxzLnNjbQorKysgYi9nbnUv
cGFja2FnZXMvdGVybWluYWxzLnNjbQpAQCAtMTMsNiArMTMsNyBAQAogOzs7IENvcHlyaWdodCDC
qSAyMDE4IEFydW4gSXNhYWMgPGFydW5pc2FhY0BzeXN0ZW1yZWJvb3QubmV0PgogOzs7IENvcHly
aWdodCDCqSAyMDE4IEdhYnJpZWwgSG9uZGV0IDxnYWJyaWVsaG9uZGV0QGdtYWlsLmNvbT4KIDs7
OyBDb3B5cmlnaHQgwqkgMjAxOSBSdXRnZXIgSGVsbGluZyA8cmhlbGxpbmdAbXlrb2xhYi5jb20+
Cis7OzsgQ29weXJpZ2h0IMKpIDIwMTkgQW1pcm91Y2hlIEJvdWJla2tpIDxhbWlyb3VjaGVAaHlw
ZXJtb3ZlLm5ldD4KIDs7OwogOzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7
CkBAIC0zNiw2ICszNyw3IEBACiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBidWlsZC1zeXN0ZW0gZ2xp
Yi1vci1ndGspCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBidWlsZC1zeXN0ZW0gZ28pCiAgICM6dXNl
LW1vZHVsZSAoZ3VpeCBidWlsZC1zeXN0ZW0gcHl0aG9uKQorICAjOnVzZS1tb2R1bGUgKGd1aXgg
YnVpbGQtc3lzdGVtIHdhZikKICAgIzp1c2UtbW9kdWxlIChndWl4IGRvd25sb2FkKQogICAjOnVz
ZS1tb2R1bGUgKGd1aXggZ2l0LWRvd25sb2FkKQogICAjOnVzZS1tb2R1bGUgKGd1aXggcGFja2Fn
ZXMpCkBAIC0xMDE1LDMgKzEwMTcsMzAgQEAgYXJiaXRyYXJ5IHByb2dyYW1zIG9mIHlvdXIgY2hv
aWNlLiAgVGhpcyBpcyB1c2VmdWwgZm9yIGJyb3dzaW5nIHRoZSBoaXN0b3J5CiBjb21mb3J0YWJs
eSBpbiBhIHBhZ2VyIG9yIGVkaXRvci4KIEBlbmQgaXRlbWl6ZSIpCiAgICAgKGxpY2Vuc2UgbGlj
ZW5zZTpncGwzKykpKQorCisoZGVmaW5lLXB1YmxpYyB0ZXJtYm94LXRydWVjb2xvcgorICAocGFj
a2FnZQorICAgIChuYW1lICJ0ZXJtYm94LXRydWVjb2xvciIpCisgICAgKHZlcnNpb24gIjIwMTku
MDEuMDYtYzNhZmJmZCIpCisgICAgKHNvdXJjZSAob3JpZ2luCisgICAgICAgICAgICAgIChtZXRo
b2QgZ2l0LWZldGNoKQorICAgICAgICAgICAgICAodXJpIChnaXQtcmVmZXJlbmNlCisgICAgICAg
ICAgICAgICAgICAgICh1cmwgImh0dHBzOi8vZ2l0aHViLmNvbS9hbWlyb3VjaGUvdGVybWJveC10
cnVlY29sb3IuZ2l0IikKKyAgICAgICAgICAgICAgICAgICAgKGNvbW1pdCAiYzNhZmJmZDhmMzFj
Y2U3MGZmYjhjNGRkZDE1MzQ4OWQ5ZTM2Mzc4MCIpKSkKKyAgICAgICAgICAgICAgKGZpbGUtbmFt
ZSAoZ2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24pKQorICAgICAgICAgICAgICAoc2hhMjU2Cisg
ICAgICAgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgICAgICAgIjE3OXB5ODU4ZGhoeGtqNmxh
ODRiMjI0cjJmandhdnlnZjRkYXc0ZGdsM2d2djhpMDdyeWoiKSkpKQorICAgIChidWlsZC1zeXN0
ZW0gd2FmLWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIGAoIzp0ZXN0cz8gI2Yp
KQorICAgIChzeW5vcHNpcyAiTGlicmFyeSBmb3Igd3JpdGluZyB0ZXh0LWJhc2VkIHVzZXIgaW50
ZXJmYWNlcyAod2l0aCB0cnVlLWNvbG9yIHN1cHBvcnQpIikKKyAgICAoZGVzY3JpcHRpb24gIlRl
cm1ib3ggaXMgYSBsaWJyYXJ5IHRoYXQgcHJvdmlkZXMgbWluaW1hbGlzdGljIEFQSSB3aGljaAor
YWxsb3dzIHRoZSBwcm9ncmFtbWVyIHRvIHdyaXRlIHRleHQtYmFzZWQgdXNlciBpbnRlcmZhY2Vz
LgorCitJdCBpcyBiYXNlZCBvbiBhIHNpbXBsZSBhYnN0cmFjdGlvbjogdmlld2luZyB0ZXJtaW5h
bHMgYXMgYSB0YWJsZSBvZgorZml4ZWQtc2l6ZSBjZWxscyBhbmQgaW5wdXQgYmVpbmcgYSBzdHJl
YW0gb2Ygc3RydWN0dXJlZCBtZXNzYWdlcy4gIENvcHkgJgorcGFzdGluZyBhbmQgd2lkZSBjaGFy
YWN0ZXJzIChtb3N0bHkgQ2hpbmVzZSwgSmFwYW5lc2UsIEtvcmVhbiAoQ0pLKQorY2hhcmFjdGVy
cykgYXJlIG5vdCByZWFsbHkgc3VwcG9ydGVkLiIpCisgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9n
aXRodWIuY29tL2FtaXJvdWNoZS90ZXJtYm94LXRydWVjb2xvci90cmVlL3RydWVjb2xvciIpCisg
ICAgKGxpY2Vuc2UgbGljZW5zZTpleHBhdCkpKQotLSAKMi4xOS4xCgo=
--=_6a4d079373e55621116e7d77f92bc62c--





Acknowledgement sent to Amirouche Boubekki <amirouche@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#34393; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.