GNU bug report logs - #34451
26.1; doc-view-toggle-display chokes if default major-mode is text-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34451 in the body.
You can then email your comments to 34451 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Roland Winkler" <winkler <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1;
 doc-view-toggle-display chokes if default major-mode is text-mode
Date: Mon, 11 Feb 2019 21:42:52 -0600

Start `emacs -Q'
eval  (setq-default major-mode 'text-mode)
visit a pdf or postscript file
Type C-c C-c twice
doc-view-toggle-display: Wrong type argument: stringp, nil

The problem is that doc-view-toggle-display assumes that if the
major-mode is text-mode the user is viewing the document's text
contents.  But that's incorrect if the default value of major-mode
is text-mode so that this mode is also used for a "raw" pdf or
postscript file.


In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
 of 2018-05-29 built on regnitz
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description:	Ubuntu 16.04.5 LTS

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
text-mode
DocView: using cached files!
Type C-c C-c to toggle between editing or viewing the document. [2 times]
doc-view-toggle-display: Wrong type argument: stringp, nil

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 THREADS LCMS2

Important settings:
  value of $LC_COLLATE: C
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: 
  locale-coding-system: utf-8-unix

Message #10 received at 34451-done <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: "Roland Winkler" <winkler <at> gnu.org>
Cc: 34451-done <at> debbugs.gnu.org
Subject: Re: bug#34451: 26.1;
 doc-view-toggle-display chokes if default major-mode is text-mode
Date: Sat, 09 Mar 2019 22:08:11 +0100

"Roland Winkler" <winkler <at> gnu.org> writes:

> Start `emacs -Q'
> eval  (setq-default major-mode 'text-mode)
> visit a pdf or postscript file
> Type C-c C-c twice
> doc-view-toggle-display: Wrong type argument: stringp, nil
>
> The problem is that doc-view-toggle-display assumes that if the
> major-mode is text-mode the user is viewing the document's text
> contents.  But that's incorrect if the default value of major-mode is
> text-mode so that this mode is also used for a "raw" pdf or postscript
> file.

Right, thanks for the pointer.  Now I use a separate mode (which is
actually just `view-mode' with a doc-view-specific value for
major-mode).

Bye,
Tassilo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.