GNU bug report logs - #34471
[PATCH] Fix jumping to the current error in xref

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34471 in the body.
You can then email your comments to 34471 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Felicián Németh <felician.nemeth <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix jumping to the current error in xref
Date: Wed, 13 Feb 2019 21:35:46 +0100

[Message part 1 (text/plain, inline)]

I sometimes find useful to return to the current reference after examining
its context. However, xref--next-error-function fails to jump to the
current reference. The following steps reproduce the problem.

emacs -Q lisp/progmodes/xref.el
M-? xref-make RET
n RET
M-<
C-u 0 M-g n

I know next-error + previous-error is a workaround, but the patch fixes the
bug.

Thanks,
Felicián

[Message part 2 (text/html, inline)]

[0001-Fix-jumping-to-the-current-error-in-xref.patch (text/x-patch, attachment)]

Message #8 received at 34471 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Felicián Németh <felician.nemeth <at> gmail.com>,
 Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 34471 <at> debbugs.gnu.org
Subject: Re: bug#34471: [PATCH] Fix jumping to the current error in xref
Date: Fri, 22 Feb 2019 09:47:04 +0200

> From: Felicián Németh
> 	<felician.nemeth <at> gmail.com>
> Date: Wed, 13 Feb 2019 21:35:46 +0100
> 
> I sometimes find useful to return to the current reference after examining its context. However,
> xref--next-error-function fails to jump to the current reference. The following steps reproduce the problem.
> 
> emacs -Q lisp/progmodes/xref.el
> M-? xref-make RET
> n RET
> M-<
> C-u 0 M-g n
> 
> I know next-error + previous-error is a workaround, but the patch fixes the bug.

Dmitry, any comments?  Should I install this?

Thanks.

Message #11 received at 34471 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Felicián Németh <felician.nemeth <at> gmail.com>,
 Eli Zaretskii <eliz <at> gnu.org>
Cc: "34471 <at> debbugs.gnu.org" <34471 <at> debbugs.gnu.org>
Subject: Re: bug#34471: [PATCH] Fix jumping to the current error in xref
Date: Fri, 22 Feb 2019 21:36:32 +0300

[Message part 1 (text/html, inline)]

Message #16 received at 34471-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 34471-done <at> debbugs.gnu.org, felician.nemeth <at> gmail.com
Subject: Re: bug#34471: [PATCH] Fix jumping to the current error in xref
Date: Sat, 23 Feb 2019 11:38:04 +0200

> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Cc: "34471 <at> debbugs.gnu.org" <34471 <at> debbugs.gnu.org>
> Date: Fri, 22 Feb 2019 21:36:32 +0300
> 
>   I know next-error + previous-error is a workaround, but the patch fixes the bug.
> 
>  Dmitry, any comments? Should I install this?
> 
> I didn't have a chance to try it yet, but the code looks okay. Please install if it works for you. 

Pushed to the master branch, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.