GNU bug report logs - #34493
[PATCH] services: xorg: Enable override of xserver-arguments.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34493 in the body.
You can then email your comments to 34493 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: xorg: Enable override of xserver-arguments.
Date: Fri, 15 Feb 2019 19:32:47 +0100

[Message part 1 (text/plain, inline)]

Hi!

Here's a patch I have been using in order to use Emacs in lockstep mode;
it took me some time to figure out that listening to TCP is turned off
by default and where to enable it.

Not sure if it warrants a whole example in the documentation, though.
Also, I chose not to move "-logverbose" "-verbose" and"-terminate"
to the default arguments, these are still hardcoded.

Greetings,
janneke

[0001-services-xorg-Enable-override-of-xserver-arguments.patch (text/x-patch, inline)]

From f1685ca38dc0c55056eed0002f194b6081b6339a Mon Sep 17 00:00:00 2001
From: Jan Nieuwenhuizen <janneke <at> gnu.org>
Date: Fri, 15 Feb 2019 19:13:55 +0100
Subject: [PATCH] services: xorg: Enable override of xserver-arguments.

* gnu/services/xorg.scm (xorg-start-command): Add parameter #:xserver-arguments.
* doc/guix.texi (X Window): Document it.
---
 doc/guix.texi         | 18 ++++++++++++++++++
 gnu/services/xorg.scm |  7 ++++---
 2 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 1ac077d98a..31c99fab03 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -13123,6 +13123,7 @@ type @code{<sddm-configuration>}.
   [#:fonts %default-xorg-fonts] @
   [#:configuration-file (xorg-configuration-file @dots{})] @
   [#:xorg-server @var{xorg-server}]
+  [#:xserver-arguments '("-nolisten" "tcp")]
 Return a @code{startx} script in which @var{modules}, a list of X module
 packages, and @var{fonts}, a list of X font directories, are available.  See
 @code{xorg-wrapper} for more details on the arguments.  The result should be
@@ -13131,6 +13132,23 @@ used in place of @code{startx}.
 Usually the X server is started by a login manager.
 @end deffn
 
+@cindex -listen tcp
+@cindex -nolisten tcp
+This procedure is useful to override command line options for the X server,
+such as having it listen to over TCP:
+
+@example
+(operating-system
+  ...
+  (services
+    (modify-services %desktop-services
+      (slim-service-type config =>
+        (slim-configuration
+          (inherit config)
+          (startx (xorg-start-command
+                   #:xserver-arguments '("-listen" "tcp"))))))))
+@end example
+
 @deffn {Scheme Procedure} xorg-configuration-file @
   [#:modules %default-xorg-modules] @
   [#:fonts %default-xorg-fonts] @
diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
index 1efb275794..50ed0d3b9a 100644
--- a/gnu/services/xorg.scm
+++ b/gnu/services/xorg.scm
@@ -290,7 +290,8 @@ in place of @code{/usr/bin/X}."
                              (configuration-file
                               (xorg-configuration-file #:modules modules
                                                        #:fonts fonts))
-                             (xorg-server xorg-server))
+                             (xorg-server xorg-server)
+                             (xserver-arguments '("-nolisten" "tcp")))
   "Return a @code{startx} script in which @var{modules}, a list of X module
 packages, and @var{fonts}, a list of X font directories, are available.  See
 @code{xorg-wrapper} for more details on the arguments.  The result should be
@@ -303,8 +304,8 @@ used in place of @code{startx}."
   (define exp
     ;; Write a small wrapper around the X server.
     #~(apply execl #$X #$X ;; Second #$X is for argv[0].
-             "-logverbose" "-verbose" "-nolisten" "tcp" "-terminate"
-             (cdr (command-line))))
+             "-logverbose" "-verbose" "-terminate" #$@xserver-arguments
+              (cdr (command-line))))
 
   (program-file "startx" exp))
 
-- 
2.20.1

[Message part 3 (text/plain, inline)]

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Message #8 received at 34493 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jan Nieuwenhuizen <janneke <at> gnu.org>
Cc: 34493 <at> debbugs.gnu.org
Subject: Re: [bug#34493] [PATCH] services: xorg: Enable override of
 xserver-arguments.
Date: Sat, 16 Feb 2019 22:21:34 +0100

Hello,

Jan Nieuwenhuizen <janneke <at> gnu.org> skribis:

> Here's a patch I have been using in order to use Emacs in lockstep mode;
> it took me some time to figure out that listening to TCP is turned off
> by default and where to enable it.

I see; I didn’t know about Lockstep, this looks fun.

> Not sure if it warrants a whole example in the documentation, though.
> Also, I chose not to move "-logverbose" "-verbose" and"-terminate"
> to the default arguments, these are still hardcoded.

OK.

>>From f1685ca38dc0c55056eed0002f194b6081b6339a Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <janneke <at> gnu.org>
> Date: Fri, 15 Feb 2019 19:13:55 +0100
> Subject: [PATCH] services: xorg: Enable override of xserver-arguments.
>
> * gnu/services/xorg.scm (xorg-start-command): Add parameter #:xserver-arguments.
> * doc/guix.texi (X Window): Document it.

[...]

> +@cindex -listen tcp
> +@cindex -nolisten tcp

Maybe: @cindex @code{-listen tcp}, for X11.

Otherwise LGTM, thank you!

Ludo’.

Message #13 received at 34493-done <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 34493-done <at> debbugs.gnu.org
Subject: Re: [bug#34493] [PATCH] services: xorg: Enable override of
 xserver-arguments.
Date: Sun, 17 Feb 2019 08:50:52 +0100

Ludovic Courtès writes:

>> +@cindex -listen tcp
>> +@cindex -nolisten tcp
>
> Maybe: @cindex @code{-listen tcp}, for X11.

Nice, done.

> Otherwise LGTM, thank you!

Thanks, pushed to master as 24f11b06bbd2c7f4a236a5ef4b6d9c7bf5be47a8

janneke

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.