GNU bug report logs - #34497
Add odamex

Previous Next

Package: guix-patches;

Reported by: <pkill9 <at> runbox.com>

Date: Sat, 16 Feb 2019 06:05:02 UTC

Severity: normal

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34497 in the body.
You can then email your comments to 34497 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#34497; Package guix-patches. (Sat, 16 Feb 2019 06:05:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to <pkill9 <at> runbox.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 16 Feb 2019 06:05:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: <pkill9 <at> runbox.com>
To: "guix-patches" <guix-patches <at> gnu.org>
Subject: Add odamex
Date: Sat, 16 Feb 2019 06:04:05 +0000 (GMT)
This patch adds Odamex, a port of Doom focused on multiplayer support. https://odamex.net/



Information forwarded to guix-patches <at> gnu.org:
bug#34497; Package guix-patches. (Sun, 17 Feb 2019 10:26:02 GMT) Full text and rfc822 format available.

Message #8 received at 34497 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: pkill9 <at> runbox.com
Cc: 34497 <at> debbugs.gnu.org
Subject: Re: [bug#34497] Add odamex
Date: Sun, 17 Feb 2019 12:25:41 +0200
[Message part 1 (text/plain, inline)]
On Sat, Feb 16, 2019 at 06:04:05AM +0000, pkill9 <at> runbox.com wrote:
> This patch adds Odamex, a port of Doom focused on multiplayer support. https://odamex.net/
> 

Looks like you forgot to attach the patch :)

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#34497; Package guix-patches. (Sun, 17 Feb 2019 14:30:02 GMT) Full text and rfc822 format available.

Message #11 received at 34497 <at> debbugs.gnu.org (full text, mbox):

From: <pkill9 <at> runbox.com>
To: "Efraim Flashner" <efraim <at> flashner.co.il>
Cc: 34497 <34497 <at> debbugs.gnu.org>
Subject: Re: [bug#34497] Add odamex
Date: Sun, 17 Feb 2019 14:28:57 +0000 (GMT)
[Message part 1 (text/plain, inline)]
Oops! Here it is

On Sun, 17 Feb 2019 12:25:41 +0200, Efraim Flashner <efraim <at> flashner.co.il> wrote:

> On Sat, Feb 16, 2019 at 06:04:05AM +0000, pkill9 <at> runbox.com wrote:
> > This patch adds Odamex, a port of Doom focused on multiplayer support. https://odamex.net/
> > 
> 
> Looks like you forgot to attach the patch :)
> 
> -- 
> Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted


[0001-gnu-Add-odamex.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#34497; Package guix-patches. (Wed, 20 Feb 2019 20:48:02 GMT) Full text and rfc822 format available.

Message #14 received at 34497 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: pkill9 <at> runbox.com
Cc: 34497 <34497 <at> debbugs.gnu.org>, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#34497] Add odamex
Date: Wed, 20 Feb 2019 21:47:00 +0100
Hi pkill9,

> * gnu/packages/games.scm (odamex): New variable.
[…]
> +       (uri (string-append
> +             "mirror://sourceforge/odamex/Odamex/"
> +             version
> +             "/odamex-src-"
> +             version
> +             ".tar.gz"))

Please put this on fewer lines.

> +       (sha256
> +        (base32
> +         "1sh6lqj7vsdmnqz17hw0b6vy7xx6dp41k2sdw99ympsfa2xd1d2j"))))
> +    (build-system cmake-build-system)
> +    (arguments `(#:tests? #f)) ;; No tests

Please use just one semicolon.

> +    (inputs
> +     `(("sdl" ,(@ (gnu packages sdl) sdl))
> +       ("sdl-mixer" ,(@ (gnu packages sdl) sdl-mixer))
> +       ("zlib" ,(@ (gnu packages compression) zlib))
> +       ("libpng" ,(@ (gnu packages image) libpng))
> +       ("alsa-lib" ,(@ (gnu packages linux) alsa-lib))))

This is not okay.  Please just use the plain variable names.

> +    (home-page "https://odamex.net/")
> +    (synopsis "Multiplayer Doom port")
> +    (description "Odamex is a free, cross-platform modification of the Doom
> +engine that allows players to easily join servers dedicated to playing Doom
> +online.")

Please remove “free” — all software in Guix is Free Software.

> +    (license license:gpl2)))

Looks like this is actually gpl2+ as evidenced by files like this:

    https://github.com/odamex/odamex/blob/master/server/src/d_netinfo.cpp#L12

Could you please send an updated patch?

-- 
Ricardo





Information forwarded to guix-patches <at> gnu.org:
bug#34497; Package guix-patches. (Thu, 21 Feb 2019 13:05:02 GMT) Full text and rfc822 format available.

Message #17 received at 34497 <at> debbugs.gnu.org (full text, mbox):

From: <pkill9 <at> runbox.com>
To: "Ricardo Wurmus" <rekado <at> elephly.net>
Cc: 34497 <34497 <at> debbugs.gnu.org>, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#34497] Add odamex
Date: Thu, 21 Feb 2019 13:04:51 +0000 (GMT)
[Message part 1 (text/plain, inline)]
Here is an updated patch.

On Wed, 20 Feb 2019 21:47:00 +0100, Ricardo Wurmus <rekado <at> elephly.net> wrote:

> 
> Hi pkill9,
> 
> > * gnu/packages/games.scm (odamex): New variable.
> […]
> > +       (uri (string-append
> > +             "mirror://sourceforge/odamex/Odamex/"
> > +             version
> > +             "/odamex-src-"
> > +             version
> > +             ".tar.gz"))
> 
> Please put this on fewer lines.
> 
> > +       (sha256
> > +        (base32
> > +         "1sh6lqj7vsdmnqz17hw0b6vy7xx6dp41k2sdw99ympsfa2xd1d2j"))))
> > +    (build-system cmake-build-system)
> > +    (arguments `(#:tests? #f)) ;; No tests
> 
> Please use just one semicolon.
> 
> > +    (inputs
> > +     `(("sdl" ,(@ (gnu packages sdl) sdl))
> > +       ("sdl-mixer" ,(@ (gnu packages sdl) sdl-mixer))
> > +       ("zlib" ,(@ (gnu packages compression) zlib))
> > +       ("libpng" ,(@ (gnu packages image) libpng))
> > +       ("alsa-lib" ,(@ (gnu packages linux) alsa-lib))))
> 
> This is not okay.  Please just use the plain variable names.
> 
> > +    (home-page "https://odamex.net/")
> > +    (synopsis "Multiplayer Doom port")
> > +    (description "Odamex is a free, cross-platform modification of the Doom
> > +engine that allows players to easily join servers dedicated to playing Doom
> > +online.")
> 
> Please remove “free” — all software in Guix is Free Software.
> 
> > +    (license license:gpl2)))
> 
> Looks like this is actually gpl2+ as evidenced by files like this:
> 
>     https://github.com/odamex/odamex/blob/master/server/src/d_netinfo.cpp#L12
> 
> Could you please send an updated patch?
> 
> -- 
> Ricardo


[0001-gnu-Add-odamex.patch (text/x-patch, attachment)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sat, 23 Mar 2019 20:58:02 GMT) Full text and rfc822 format available.

Notification sent to <pkill9 <at> runbox.com>:
bug acknowledged by developer. (Sat, 23 Mar 2019 20:58:02 GMT) Full text and rfc822 format available.

Message #22 received at 34497-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: <pkill9 <at> runbox.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 34497 <34497-done <at> debbugs.gnu.org>,
 Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#34497] Add odamex
Date: Sat, 23 Mar 2019 21:57:00 +0100
Hello pkill9,

<pkill9 <at> runbox.com> skribis:

> Here is an updated patch.

> From 353f9444cd71c1e93978cf9b113e3f8743f385a8 Mon Sep 17 00:00:00 2001
> From: Pkill -9 <pkill9 <at> runbox.com>
> Date: Thu, 21 Feb 2019 13:02:07 +0000
> Subject: [PATCH] gnu: Add odamex.
>
> * gnu/packages/games.scm (odamex): New variable.

Applied, finally.  Thank you and apologies for the delay!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 21 Apr 2019 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 343 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.