GNU bug report logs - #34579
[PATCH] services: desktop: Fix define for the upower-service procedure.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34579 in the body.
You can then email your comments to 34579 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: desktop: Fix define for the upower-service
 procedure.
Date: Tue, 19 Feb 2019 20:54:26 +0000

* gnu/services/desktop.scm (upower-service): Fill in the replacement for
upower-service.
---
 gnu/services/desktop.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index ce63969dc8..7940f28a26 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -306,6 +306,7 @@ used by GNOME.")
                                    (time-critical 300)
                                    (time-action 120)
                                    (critical-power-action 'hybrid-sleep))
+  upower-service-type
   "Return a service that runs @uref{http://upower.freedesktop.org/,
 @command{upowerd}}, a system-wide monitor for power consumption and battery
 levels, with the given configuration settings.  It implements the
-- 
2.20.1

Message #8 received at 34579 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Mark H Weaver <mhw <at> netris.org>
Cc: 34567 <at> debbugs.gnu.org, 34579 <at> debbugs.gnu.org
Subject: Re: bug#34567: Bogus 'upower-service' deprecation message
Date: Tue, 19 Feb 2019 21:11:43 +0000

[Message part 1 (text/plain, inline)]

Mark H Weaver <mhw <at> netris.org> writes:

> My OS config includes a reference to 'upower-service', which is now
> deprecated, but the deprecation message is bogus:
>
>   mhw <at> jojen ~$ guix system build /etc/config.scm --verbosity=1
>   /etc/config.scm:149:19: warning: 'slim-service' is deprecated, use 'slim-service-type' instead
>   /etc/config.scm:156:19: warning: 'upower-service' is deprecated, use 'Return a service that runs @uref{http://upower.freedesktop.org/,
>   @command{upowerd}}, a system-wide monitor for power consumption and battery
>   levels, with the given configuration settings.  It implements the
>   @code{org.freedesktop.UPower} D-Bus interface, and is notably used by GNOME.' instead
>   building /gnu/store/nwdjz1mkvcc4ic65mgw5i94ig3qzp8kf-libjpeg-turbo-2.0.2.tar.gz.drv...
>   [...]

Haha, that is quite bogus. I didn't realise define-deprecated took two
arguments. I've sent a patch to fix this here [1].

1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34579

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 34579 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 34579 <at> debbugs.gnu.org
Subject: Re: [bug#34579] [PATCH] services: desktop: Fix define for the
 upower-service procedure.
Date: Wed, 20 Feb 2019 12:58:28 +0100

Christopher Baines <mail <at> cbaines.net> writes:

> * gnu/services/desktop.scm (upower-service): Fill in the replacement for
> upower-service.
> ---
>  gnu/services/desktop.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
> index ce63969dc8..7940f28a26 100644
> --- a/gnu/services/desktop.scm
> +++ b/gnu/services/desktop.scm
> @@ -306,6 +306,7 @@ used by GNOME.")
>                                     (time-critical 300)
>                                     (time-action 120)
>                                     (critical-power-action 'hybrid-sleep))
> +  upower-service-type
>    "Return a service that runs @uref{http://upower.freedesktop.org/,
>  @command{upowerd}}, a system-wide monitor for power consumption and battery
>  levels, with the given configuration settings.  It implements the

Looks fine to me.  Thanks!

-- 
Ricardo

Message #16 received at 34579-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 34579-done <at> debbugs.gnu.org
Subject: Re: [bug#34579] [PATCH] services: desktop: Fix define for the
 upower-service procedure.
Date: Sun, 24 Feb 2019 21:49:51 +0000

[Message part 1 (text/plain, inline)]

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Christopher Baines <mail <at> cbaines.net> writes:
>
>> * gnu/services/desktop.scm (upower-service): Fill in the replacement for
>> upower-service.
>> ---
>>  gnu/services/desktop.scm | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
>> index ce63969dc8..7940f28a26 100644
>> --- a/gnu/services/desktop.scm
>> +++ b/gnu/services/desktop.scm
>> @@ -306,6 +306,7 @@ used by GNOME.")
>>                                     (time-critical 300)
>>                                     (time-action 120)
>>                                     (critical-power-action 'hybrid-sleep))
>> +  upower-service-type
>>    "Return a service that runs @uref{http://upower.freedesktop.org/,
>>  @command{upowerd}}, a system-wide monitor for power consumption and battery
>>  levels, with the given configuration settings.  It implements the
>
> Looks fine to me.  Thanks!

Great, I've pushed this to master now as
bb65f66ce0e5feee2d997a8526e10fc9f31e97fd.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 34579-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 34567-done <at> debbugs.gnu.org, Mark H Weaver <mhw <at> netris.org>,
 34579-done <at> debbugs.gnu.org
Subject: Re: bug#34567: Bogus 'upower-service' deprecation message
Date: Sat, 09 Mar 2019 19:29:07 +0100

Christopher Baines <mail <at> cbaines.net> skribis:

> Mark H Weaver <mhw <at> netris.org> writes:
>
>> My OS config includes a reference to 'upower-service', which is now
>> deprecated, but the deprecation message is bogus:
>>
>>   mhw <at> jojen ~$ guix system build /etc/config.scm --verbosity=1
>>   /etc/config.scm:149:19: warning: 'slim-service' is deprecated, use 'slim-service-type' instead
>>   /etc/config.scm:156:19: warning: 'upower-service' is deprecated, use 'Return a service that runs @uref{http://upower.freedesktop.org/,
>>   @command{upowerd}}, a system-wide monitor for power consumption and battery
>>   levels, with the given configuration settings.  It implements the
>>   @code{org.freedesktop.UPower} D-Bus interface, and is notably used by GNOME.' instead
>>   building /gnu/store/nwdjz1mkvcc4ic65mgw5i94ig3qzp8kf-libjpeg-turbo-2.0.2.tar.gz.drv...
>>   [...]
>
> Haha, that is quite bogus. I didn't realise define-deprecated took two
> arguments. I've sent a patch to fix this here [1].
>
> 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34579

This was fixed in bb65f66ce0e5feee2d997a8526e10fc9f31e97fd, closing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.