GNU bug report logs - #34646
[PATCH] gnu: openssh: Add libedit support.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34646 in the body.
You can then email your comments to 34646 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Gábor Boskovits <boskovits <at> gmail.com>
Subject: [PATCH] gnu: openssh: Add libedit support.
Date: Mon, 25 Feb 2019 14:08:46 +0100

* gnu/packages/ssh.scm (openssh)[native-inputs]: Add pkg-config.
[inputs]: Add libedit.
[arguments](configure-flags): Add --with-libedit.
---
 gnu/packages/ssh.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
index 1928ea7634..968118ad19 100644
--- a/gnu/packages/ssh.scm
+++ b/gnu/packages/ssh.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2017 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2017 Nils Gillmann <ng0 <at> n0.is>
 ;;; Copyright © 2018 Manuel Graf <graf <at> init.at>
+;;; Copyright © 2019 Gábor Boskovits <boskovits <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -39,6 +40,7 @@
   #:use-module (gnu packages gperf)
   #:use-module (gnu packages groff)
   #:use-module (gnu packages guile)
+  #:use-module (gnu packages libedit)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages logging)
   #:use-module (gnu packages m4)
@@ -154,8 +156,10 @@ a server that supports the SSH-2 protocol.")
               (base32
                "1b8sy6v0b8v4ggmknwcqx3y1rjcpsll0f1f8f4vyv11x4ni3njvb"))))
    (build-system gnu-build-system)
-   (native-inputs `(("groff" ,groff)))
-   (inputs `(("openssl" ,openssl)
+   (native-inputs `(("groff" ,groff)
+                    ("pkg-config" ,pkg-config)))
+   (inputs `(("libedit" ,libedit)
+             ("openssl" ,openssl)
              ("pam" ,linux-pam)
              ("mit-krb5" ,mit-krb5)
              ("zlib" ,zlib)
@@ -175,6 +179,9 @@ a server that supports the SSH-2 protocol.")
                                           (assoc-ref %build-inputs "mit-krb5")
                                           "/bin")
 
+                          ;; libedit needed for sftp completion
+                          "--with-libedit"
+
                           ;; Enable PAM support in sshd.
                           "--with-pam")
 
-- 
2.20.1

Message #8 received at 34646 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 34646 <at> debbugs.gnu.org
Subject: Re: bug#34646: Acknowledgement ([PATCH] gnu: openssh: Add libedit
 support.)
Date: Mon, 25 Feb 2019 14:16:32 +0100

Hello,

This is to enable sftp completion support.
The problem was noticed by tune on IRC.
Wdyt?

Best regards,
g_bor

Message #11 received at 34646 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Gábor Boskovits <boskovits <at> gmail.com>
Cc: 34646 <at> debbugs.gnu.org
Subject: Re: [bug#34646] Acknowledgement ([PATCH] gnu: openssh: Add libedit
 support.)
Date: Mon, 25 Feb 2019 23:44:10 -0500

[Message part 1 (text/plain, inline)]

On Mon, Feb 25, 2019 at 02:16:32PM +0100, Gábor Boskovits wrote:
> Hello,
> 
> This is to enable sftp completion support.
> The problem was noticed by tune on IRC.
> Wdyt?

Sounds good, I did some basic tests.  But can you try updating libedit
to the latest release before pushing?

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 34646-done <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 34646-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: openssh: Add libedit support.
Date: Wed, 27 Feb 2019 00:22:45 +0100

Libedit updated in 1094f1216f21a52453b54b43ff88b856f4fac94d.
Patch pushed as 618631f3683e7caf5b0336ce06abf62a25ce119b.
Closing.

Thanks for the review.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.