GNU bug report logs - #34653
[PATCH] gnu: twitchy: Update to 3.4.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34653 in the body.
You can then email your comments to 34653 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Timo Eisenmann <eisenmann <at> fn.de>
To: guix-patches <at> gnu.org
Cc: Timo Eisenmann <eisenmann <at> fn.de>
Subject: [PATCH] gnu: twitchy: Update to 3.4.
Date: Mon, 25 Feb 2019 19:38:54 +0100

* gnu/packages/video.scm: (twitchy): Update to 3.4.
[arguments]: Add phase 'patch-paths' to substitute in the absolute path to
'streamlink'.
---
 gnu/packages/video.scm | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index b0c875befe..52f151bd78 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -32,6 +32,7 @@
 ;;; Copyright © 2018 Mark Meyer <mark <at> ofosos.org>
 ;;; Copyright © 2018 Gábor Boskovit <boskovits <at> gmail.com>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe <at> gmail.com>
+;;; Copyright © 2019 Timo Eisenmann <eisenmann <at> fn.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1999,10 +2000,10 @@ from sites like Twitch.tv and pipes them into a video player of choice.")
   (deprecated-package "livestreamer" streamlink))
 
 (define-public twitchy
-  (let ((commit "0c0f925b9c7ff2aed4a3b0046561cb794143c398")) ;Fixes tests.
+  (let ((commit "9beb36d80b16662414129693e74fa3a2fd97554e")) ; 3.4 has no tag
     (package
       (name "twitchy")
-      (version (git-version "3.2" "1" commit))
+      (version (git-version "3.4" "1" commit))
       (source
        (origin
          (method git-fetch)
@@ -2012,11 +2013,18 @@ from sites like Twitch.tv and pipes them into a video player of choice.")
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "02aizvsr744sh8bdqvwwsmp2qpczlzn8fy76h5dyd3517n9nlcz9"))))
+           "0di03h1j9ipp2bbnxxlxz07v87icyg2hmnsr4s7184z5ql8kpzr7"))))
       (build-system python-build-system)
       (arguments
        '(#:phases
          (modify-phases %standard-phases
+           (add-after 'unpack 'patch-paths
+             (lambda* (#:key inputs #:allow-other-keys)
+               (substitute* "twitchy/twitchy_play.py"
+                 (("\"streamlink ")
+                  (string-append "\"" (assoc-ref inputs "streamlink")
+                                 "/bin/streamlink ")))
+               #t))
            (add-before 'check 'check-setup
              (lambda _
                (setenv "HOME" (getcwd)) ;Needs to write to ‘$HOME’.
-- 
2.20.1

Message #8 received at 34653 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Timo Eisenmann <eisenmann <at> fn.de>
Cc: 34653 <at> debbugs.gnu.org
Subject: Re: [bug#34653] [PATCH] gnu: twitchy: Update to 3.4.
Date: Mon, 25 Feb 2019 21:34:32 -0500

[Message part 1 (text/plain, inline)]

On Mon, Feb 25, 2019 at 07:38:54PM +0100, Timo Eisenmann wrote:
> * gnu/packages/video.scm: (twitchy): Update to 3.4.
> [arguments]: Add phase 'patch-paths' to substitute in the absolute path to
> 'streamlink'.

Thanks! Pushed as 04b6e9c5dffb0830338dda39d90cf7b2d165b3fc

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.