GNU bug report logs - #34692
[PATCH] gnu: add r-statcheck.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34692 in the body.
You can then email your comments to 34692 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: add r-statcheck.
Date: Fri,  1 Mar 2019 09:07:56 +0100

---
 gnu/packages/cran.scm | 38 +++++++++++++++++++++++++++++++-------
 1 file changed, 31 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 54031fa87a..111152d2d0 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -3736,19 +3736,43 @@ published results; and a routine for graphical display.")
 supports arbitrary vertex/edge/graph attributes.")
     (license license:gpl2+)))
 
+(define-public r-statcheck
+  (package
+    (name "r-statcheck")
+    (version "1.3.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "statcheck" version))
+       (sha256
+        (base32
+         "0ivybdcrymlsfv6pg6p5bv70qdvgxf2vgp0kf4r0pf2fcvav1mcp"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-ggplot2" ,r-ggplot2)
+       ("r-plyr" ,r-plyr)
+       ("r-rmarkdown" ,r-rmarkdown)))
+    (home-page
+     "https://cran.r-project.org/web/packages/statcheck")
+    (synopsis
+     "Extract Statistics from Articles and Recompute p Values")
+    (description
+     "Extract statistics from articles and recompute p values.")
+    (license license:gpl2)))
+
 (define-public r-statnet-common
   (package
     (name "r-statnet-common")
     (version "4.2.0")
     (source
-      (origin
-        (method url-fetch)
-        (uri (cran-uri "statnet.common" version))
-        (sha256
-          (base32
-            "0q942g6kqmqxfss1cxb3yg8y5r1k1h5cyy99s1cfisrn6hqc6xhi"))))
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "statnet.common" version))
+       (sha256
+        (base32
+         "0q942g6kqmqxfss1cxb3yg8y5r1k1h5cyy99s1cfisrn6hqc6xhi"))))
     (properties
-      `((upstream-name . "statnet.common")))
+     `((upstream-name . "statnet.common")))
     (build-system r-build-system)
     (propagated-inputs
      `(("r-coda" ,r-coda)))
-- 
2.20.1

Message #8 received at 34692 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Nicolò Balzarotti <anothersms <at> gmail.com>
Cc: 34692 <at> debbugs.gnu.org
Subject: Re: [bug#34692] [PATCH] gnu: add r-statcheck.
Date: Thu, 07 Mar 2019 20:43:54 +0100

Hi Nicolò,

thanks for your patches.

Unfortunately, this patch includes unrelated changes (to
r-statnet-common) and does not have a proper commit summary.  The
changes adding r-statcheck lack a proper description (you should use
full sentences).

Would you like to send another patch addressing these issues?

Please also send related patches to the same bug number.  You can do
this by sending a cover letter to guix-patches <at> gnu.org, wait for the
acknowledgement, and then send the patches to the address mentioned in
the acknowledgement email.  This makes it easier for us to see in what
order related patches need to be applied.

Thanks!

--
Ricardo

Message #11 received at 34692 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolò Balzarotti <anothersms <at> gmail.com>,
 34692 <at> debbugs.gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: Re: [bug#34692] [PATCH] gnu: add r-statcheck.
Date: Sat, 23 Mar 2019 21:58:54 +0100

Hi Nicolò,

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> Unfortunately, this patch includes unrelated changes (to
> r-statnet-common) and does not have a proper commit summary.  The
> changes adding r-statcheck lack a proper description (you should use
> full sentences).
>
> Would you like to send another patch addressing these issues?

Did you have a chance to look into that, Nicolò?

Thanks in advance!

Ludo’.

Message #14 received at 34692 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Ricardo Wurmus <rekado <at> elephly.net>,
 "34692 <at> debbugs.gnu.org" <34692 <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: add r-statcheck.
Date: Sat, 23 Mar 2019 21:18:32 +0000

[Message part 1 (text/plain, inline)]

Hi, sorry for the delay!
I'll try to have a look tomorrow :)

Nicolò

Il giorno sabato 23 marzo 2019, Ludovic Courtès <ludo <at> gnu.org> ha scritto:
> Hi Nicolò,
>
> Ricardo Wurmus <rekado <at> elephly.net> skribis:
>
>> Unfortunately, this patch includes unrelated changes (to
>> r-statnet-common) and does not have a proper commit summary.  The
>> changes adding r-statcheck lack a proper description (you should use
>> full sentences).
>>
>> Would you like to send another patch addressing these issues?
>
> Did you have a chance to look into that, Nicolò?
>
> Thanks in advance!
>
> Ludo’.
>

[Message part 2 (text/html, inline)]

Message #17 received at 34692 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: "34692 <at> debbugs.gnu.org" <34692 <at> debbugs.gnu.org>
Subject: Re: [bug#34692] [PATCH] gnu: add r-statcheck.
Date: Wed, 11 Dec 2019 10:00:13 +0100

[Message part 1 (text/plain, inline)]

Nicolò Balzarotti <anothersms <at> gmail.com> writes:

> Hi, sorry for the delay!
> I'll try to have a look tomorrow :)
>
> Nicolò
>
> Il giorno sabato 23 marzo 2019, Ludovic Courtès <ludo <at> gnu.org> ha scritto:
>> Hi Nicolò,
>>
>> Ricardo Wurmus <rekado <at> elephly.net> skribis:
>>
>>> Unfortunately, this patch includes unrelated changes (to
>>> r-statnet-common) and does not have a proper commit summary.  The
>>> changes adding r-statcheck lack a proper description (you should use
>>> full sentences).
>>>
>>> Would you like to send another patch addressing these issues?
>>
>> Did you have a chance to look into that, Nicolò?
>>
>> Thanks in advance!
>>
>> Ludo’.
>>

I have to admit, today is not March 24th, but finally here's the updated
patch (no new versions have been released since btw).

Sorry for the delay and thanks!
Nicolò

[0001-gnu-Add-r-statcheck.patch (text/x-patch, attachment)]

Message #22 received at 34692-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Nicolò Balzarotti <anothersms <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 34692-done <at> debbugs.gnu.org
Subject: Re: [bug#34692] [PATCH] gnu: add r-statcheck.
Date: Wed, 11 Dec 2019 11:15:01 +0100

Nicolò Balzarotti <anothersms <at> gmail.com> writes:

> I have to admit, today is not March 24th, but finally here's the updated
> patch (no new versions have been released since btw).

Excellent, thank you!  I have applied it (after reflowing the
description with M-q).

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.