GNU bug report logs - #34693
[PATCH] services: mpd: add more configuration options

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34693 in the body.
You can then email your comments to 34693 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: mpd: add more configuration options
Date: Fri,  1 Mar 2019 09:07:58 +0100

* gnu/services/audio.scm (<mpd-configuration>): Add 'db-file', 'state-file'
  and 'sticker-file' fields.
---
 gnu/services/audio.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index 6629433780..ebfe05abd0 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -42,6 +42,12 @@
                 (default "~/Music"))
   (playlist-dir mpd-configuration-playlist-dir
                 (default "~/.mpd/playlists"))
+  (db-file      mpd-configuration-db-file
+                (default "~/.mpd/tag_cache"))
+  (state-file   mpd-configuration-state-file
+                (default "~/.mpd/state"))
+  (sticker-file mpd-configuration-sticker-file
+                (default "~/.mpd/sticker.sql"))
   (port         mpd-configuration-port
                 (default "6600"))
   (address      mpd-configuration-address
@@ -61,6 +67,9 @@
         `(("user" ,mpd-configuration-user)
           ("music_directory" ,mpd-configuration-music-dir)
           ("playlist_directory" ,mpd-configuration-playlist-dir)
+          ("db_file" ,mpd-configuration-db-file)
+          ("state_file" ,mpd-configuration-state-file)
+          ("sticker_file" ,mpd-configuration-sticker-file)
           ("port" ,mpd-configuration-port)
           ("bind_to_address" ,mpd-configuration-address)))))
 
-- 
2.20.1

Message #8 received at 34693 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolò Balzarotti <anothersms <at> gmail.com>
Cc: 34693 <at> debbugs.gnu.org
Subject: Re: [bug#34693] [PATCH] services: mpd: add more configuration options
Date: Fri, 08 Mar 2019 12:34:39 +0100

Hi Nicolò,

Nicolò Balzarotti <anothersms <at> gmail.com> skribis:

> * gnu/services/audio.scm (<mpd-configuration>): Add 'db-file', 'state-file'
>   and 'sticker-file' fields.

Could you update doc/guix.texi to document these new fields, and send an
updated patch?

Thank you for this patch!

Ludo’.

Message #11 received at 34693 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: 34693 <at> debbugs.gnu.org
Cc: nixo <nicolo <at> nixo.xyz>
Subject: [PATCH] services: mpd: add more configuration options
Date: Fri,  8 Mar 2019 14:29:17 +0100

From: nixo <nicolo <at> nixo.xyz>

* gnu/services/audio.scm (<mpd-configuration>): Add 'db-file', 'state-file'
  and 'sticker-file' fields.
* doc/guix.texi (Music Player Daemon): Document it.
---
 doc/guix.texi          | 9 +++++++++
 gnu/services/audio.scm | 9 +++++++++
 2 files changed, 18 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index 9fb5cff06d..c5857acd0c 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -20175,6 +20175,15 @@ The directory to scan for music files.
 @item @code{playlist-dir} (default: @code{"~/.mpd/playlists"})
 The directory to store playlists.
 
+@item @code{db-file} (default: @code{"~/.mpd/tag_cache"})
+The location of the music database.
+
+@item @code{state-file} (default: @code{"~/.mpd/state"})
+The location of the file that stores current MPD's state.
+
+@item @code{sticker-file} (default: @code{"~/.mpd/sticker.sql"})
+The location of the sticker database.
+
 @item @code{port} (default: @code{"6600"})
 The port to run mpd on.
 
diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index 6629433780..ebfe05abd0 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -42,6 +42,12 @@
                 (default "~/Music"))
   (playlist-dir mpd-configuration-playlist-dir
                 (default "~/.mpd/playlists"))
+  (db-file      mpd-configuration-db-file
+                (default "~/.mpd/tag_cache"))
+  (state-file   mpd-configuration-state-file
+                (default "~/.mpd/state"))
+  (sticker-file mpd-configuration-sticker-file
+                (default "~/.mpd/sticker.sql"))
   (port         mpd-configuration-port
                 (default "6600"))
   (address      mpd-configuration-address
@@ -61,6 +67,9 @@
         `(("user" ,mpd-configuration-user)
           ("music_directory" ,mpd-configuration-music-dir)
           ("playlist_directory" ,mpd-configuration-playlist-dir)
+          ("db_file" ,mpd-configuration-db-file)
+          ("state_file" ,mpd-configuration-state-file)
+          ("sticker_file" ,mpd-configuration-sticker-file)
           ("port" ,mpd-configuration-port)
           ("bind_to_address" ,mpd-configuration-address)))))
 
-- 
2.20.1

Message #16 received at 34693-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolò Balzarotti <anothersms <at> gmail.com>
Cc: 34693-done <at> debbugs.gnu.org, nixo <nicolo <at> nixo.xyz>
Subject: Re: [bug#34693] [PATCH] services: mpd: add more configuration options
Date: Fri, 15 Mar 2019 23:08:13 +0100

Hi Nicolò,

Nicolò Balzarotti <anothersms <at> gmail.com> skribis:

> From: nixo <nicolo <at> nixo.xyz>
>
> * gnu/services/audio.scm (<mpd-configuration>): Add 'db-file', 'state-file'
>   and 'sticker-file' fields.
> * doc/guix.texi (Music Player Daemon): Document it.

Applied, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.