GNU bug report logs - #34697
[PATCH] gnu: add r-lintr.

Previous Next

Package: guix-patches;

Reported by: Nicolò Balzarotti <anothersms <at> gmail.com>

Date: Fri, 1 Mar 2019 08:14:07 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34697 in the body.
You can then email your comments to 34697 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#34697; Package guix-patches. (Fri, 01 Mar 2019 08:14:07 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolò Balzarotti <anothersms <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 01 Mar 2019 08:14:10 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: add r-lintr.
Date: Fri,  1 Mar 2019 09:07:53 +0100
---
 gnu/packages/cran.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index f3bd3ded8d..a9b775f67e 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -10726,3 +10726,34 @@ using @code{S3}.")
     (description
      "This package provides a friendly interface for the construction of regular expressions.")
     (license license:expat)))
+
+(define-public r-lintr
+  (package
+    (name "r-lintr")
+    (version "1.0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "lintr" version))
+       (sha256
+        (base32
+         "0vlsgq13g2ddv3wqcxaaf7yki9yjj3j1agkh91vqlvbi90i6s8mx"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-codetools" ,r-codetools)
+       ("r-crayon" ,r-crayon)
+       ("r-digest" ,r-digest)
+       ("r-httr" ,r-httr)
+       ("r-igraph" ,r-igraph)
+       ("r-jsonlite" ,r-jsonlite)
+       ("r-knitr" ,r-knitr)
+       ("r-rex" ,r-rex)
+       ("r-rstudioapi" ,r-rstudioapi)
+       ("r-stringdist" ,r-stringdist)
+       ("r-testthat" ,r-testthat)))
+    (home-page "https://github.com/jimhester/lintr")
+    (synopsis "A 'Linter' for R Code")
+    (description
+     "Checks adherence to a given style, syntax errors and possible semantic issues.  Supports on the fly checking of R code edited with 'RStudio IDE', 'Emacs', 'Vim', 'Sublime Text' and 'Atom'.")
+    (license license:expat)))
+
-- 
2.20.1





Information forwarded to guix-patches <at> gnu.org:
bug#34697; Package guix-patches. (Thu, 07 Mar 2019 19:48:02 GMT) Full text and rfc822 format available.

Message #8 received at 34697 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Nicolò Balzarotti <anothersms <at> gmail.com>
Cc: 34697 <at> debbugs.gnu.org
Subject: Re: [bug#34697] [PATCH] gnu: add r-lintr.
Date: Thu, 07 Mar 2019 20:47:15 +0100
Hi Nicolò,

thank you for this patch.

Unfortunately, there are a couple of problems with the synopsis and the
description.  “./pre-inst-env guix lint r-lintr” will tell you about
some of the issues.  For R packages in particular please make sure that
single straight quotes as in “'RStudio'” are removed.

Please also review the Contributing section in the Guix manual for
information on what should appear in the commit message.

Could you please send an updated patch as a reply to this message?

Thanks!

--
Ricardo





Information forwarded to guix-patches <at> gnu.org:
bug#34697; Package guix-patches. (Wed, 11 Dec 2019 08:47:02 GMT) Full text and rfc822 format available.

Message #11 received at 34697 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 34697 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: Add r-xmlparsedata.
Date: Wed, 11 Dec 2019 09:19:47 +0100
* gnu/packages/cran.scm (r-xmlparsedata): New variable.
---
 gnu/packages/cran.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 11d254001f..0a878dc340 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -14695,6 +14695,29 @@ they are often difficult to interpret.  Rex allows you to build complex
 regular expressions from human readable expressions")
     (license license:expat)))
 
+(define-public r-xmlparsedata
+  (package
+    (name "r-xmlparsedata")
+    (version "1.0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "xmlparsedata" version))
+       (sha256
+        (base32
+         "0gjr3l5z5dp276lchr2649as1rkj56d2mlvbr66yg393zzw50lsh"))))
+    (properties `((upstream-name . "xmlparsedata")))
+    (build-system r-build-system)
+    (home-page
+     "https://github.com/r-lib/xmlparsedata#readme")
+    (synopsis
+     "Parse Data of @code{R} Code as an @code{XML} Tree")
+    (description
+     "Convert the output of @code{utils::getParseData()} to an @code{XML}
+tree, that one can search via @code{XPath}, and easier to manipulate in
+general.")
+    (license license:expat)))
+
 (define-public r-sctransform
   (package
     (name "r-sctransform")
-- 
2.24.0





Information forwarded to guix-patches <at> gnu.org:
bug#34697; Package guix-patches. (Wed, 11 Dec 2019 08:48:02 GMT) Full text and rfc822 format available.

Message #14 received at 34697 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 34697 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: Add r-cyclocomp.
Date: Wed, 11 Dec 2019 09:19:47 +0100
* gnu/packages/cran.scm (r-cyclocomp): New variable.
---
 gnu/packages/cran.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 0a878dc340..9ff1dd3104 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -14718,6 +14718,35 @@ tree, that one can search via @code{XPath}, and easier to manipulate in
 general.")
     (license license:expat)))
 
+(define-public r-cyclocomp
+  (package
+    (name "r-cyclocomp")
+    (version "1.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "cyclocomp" version))
+       (sha256
+        (base32
+         "0gky3svk02wiajw7nfjh30684h3qxili4bvsab0m7b6cggw6bgyd"))))
+    (properties `((upstream-name . "cyclocomp")))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-callr" ,r-callr)
+       ("r-crayon" ,r-crayon)
+       ("r-desc" ,r-desc)
+       ("r-remotes" ,r-remotes)
+       ("r-withr" ,r-withr)))
+    (home-page
+     "https://github.com/MangoTheCat/cyclocomp")
+    (synopsis "Cyclomatic Complexity of R Code")
+    (description
+     "Cyclomatic complexity is a software metric (measurement), used to
+indicate the complexity of a program.  It is a quantitative measure of the
+number of linearly independent paths through a program's source code.  It was
+developed by @cite{Thomas J. McCabe, Sr. in 1976}.")
+    (license license:expat)))
+
 (define-public r-sctransform
   (package
     (name "r-sctransform")
-- 
2.24.0





Information forwarded to guix-patches <at> gnu.org:
bug#34697; Package guix-patches. (Wed, 11 Dec 2019 08:48:02 GMT) Full text and rfc822 format available.

Message #17 received at 34697 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 34697 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: Add r-lintr.
Date: Wed, 11 Dec 2019 09:19:47 +0100
* gnu/packages/cran.scm (r-lintr): New variable.
---
 gnu/packages/cran.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 9ff1dd3104..07432c2785 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -14747,6 +14747,40 @@ number of linearly independent paths through a program's source code.  It was
 developed by @cite{Thomas J. McCabe, Sr. in 1976}.")
     (license license:expat)))
 
+(define-public r-lintr
+  (package
+    (name "r-lintr")
+    (version "2.0.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "lintr" version))
+       (sha256
+        (base32
+         "09gbci4v5n4gsfzminly8332fw7faxdi1kkyvpa10dydx02sjcwb"))))
+    (properties `((upstream-name . "lintr")))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-codetools" ,r-codetools)
+       ("r-crayon" ,r-crayon)
+       ("r-cyclocomp" ,r-cyclocomp)
+       ("r-digest" ,r-digest)
+       ("r-httr" ,r-httr)
+       ("r-jsonlite" ,r-jsonlite)
+       ("r-knitr" ,r-knitr)
+       ("r-rex" ,r-rex)
+       ("r-rstudioapi" ,r-rstudioapi)
+       ("r-stringdist" ,r-stringdist)
+       ("r-testthat" ,r-testthat)
+       ("r-xml2" ,r-xml2)
+       ("r-xmlparsedata" ,r-xmlparsedata)))
+    (home-page "https://github.com/jimhester/lintr")
+    (synopsis "Linter for R Code")
+    (description "Checks adherence to a given style, syntax errors and
+possible semantic issues.  Supports on the fly checking of R code edited with
+@code{RStudio IDE}, @code{Emacs} and @code{Vim}.")
+    (license license:expat)))
+
 (define-public r-sctransform
   (package
     (name "r-sctransform")
-- 
2.24.0





Reply sent to Ricardo Wurmus <rekado <at> elephly.net>:
You have taken responsibility. (Wed, 11 Dec 2019 11:13:01 GMT) Full text and rfc822 format available.

Notification sent to Nicolò Balzarotti <anothersms <at> gmail.com>:
bug acknowledged by developer. (Wed, 11 Dec 2019 11:13:01 GMT) Full text and rfc822 format available.

Message #22 received at 34697-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Nicolò Balzarotti <anothersms <at> gmail.com>
Cc: 34697-done <at> debbugs.gnu.org
Subject: Re: [PATCH 3/3] gnu: Add r-lintr.
Date: Wed, 11 Dec 2019 12:12:02 +0100
Nicolò Balzarotti <anothersms <at> gmail.com> writes:

> * gnu/packages/cran.scm (r-lintr): New variable.

I pushed these three patches with minor changes.

Thanks!

-- 
Ricardo





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 08 Jan 2020 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 102 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.