GNU bug report logs - #34698
[PATCH] gnu: add org-noter.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34698 in the body.
You can then email your comments to 34698 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: add org-noter.
Date: Fri,  1 Mar 2019 09:07:52 +0100

---
 gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 871721af3a..decab4f292 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9285,6 +9285,38 @@ timestamps and date-time format strings library for Emacs.")
        "This package creates Graphviz directed graphs from Org files.")
       (license license:gpl3+))))
 
+(define-public emacs-org-noter
+  (package
+    (name "emacs-org-noter")
+    (version "1.3.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://stable.melpa.org/packages/org-noter-"
+             version
+             ".el"))
+       (sha256
+        (base32
+         "1hczwva73gsyanl1ldhdvql01gy0hy2g861yzkaklyb763sx58x4"))))
+    (build-system emacs-build-system)
+    (propagated-inputs `(("emacs-org" ,emacs-org)))
+    (home-page
+     "https://github.com/weirdNox/org-noter")
+    (synopsis
+     "A synchronized, Org-mode, document annotator")
+    (description
+     "The idea is to let you create notes that are kept in sync when you scroll through the
+document, but that are external to it - the notes themselves live in an Org-mode file. As
+such, this leverages the power of Org-mode (the notes may have outlines, latex fragments,
+babel, etc...) while acting like notes that are made /in/ the document.
+
+Also, I must thank Sebastian for the original idea and inspiration!
+Link to the original Interleave package:
+https://github.com/rudolfochrist/interleave
+")
+    (license license:gpl3)))
+
 (define-public emacs-npm-mode
   (package
     (name "emacs-npm-mode")
-- 
2.20.1

Message #8 received at 34698 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolò Balzarotti <anothersms <at> gmail.com>
Cc: 34698 <at> debbugs.gnu.org
Subject: Re: [bug#34698] [PATCH] gnu: add org-noter.
Date: Fri, 15 Mar 2019 23:20:28 +0100

Hello,

Nicolò Balzarotti <anothersms <at> gmail.com> skribis:

> ---
>  gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

Could you add a commit log that follows our conventions?

> +       (method url-fetch)
> +       (uri (string-append
> +             "https://stable.melpa.org/packages/org-noter-"
> +             version
> +             ".el"))

Since files on MELPA are unversioned and regularly modified in place,
could you instead use the upstream URL (presumably the GitHub repo)?

> +    (synopsis
> +     "A synchronized, Org-mode, document annotator")
         ^
‘guix lint’ probably complains about this; please remove the “A”.

> +    (description
> +     "The idea is to let you create notes that are kept in sync when you scroll through the
> +document, but that are external to it - the notes themselves live in an Org-mode file. As
> +such, this leverages the power of Org-mode (the notes may have outlines, latex fragments,
> +babel, etc...) while acting like notes that are made /in/ the document.
> +
> +Also, I must thank Sebastian for the original idea and inspiration!
> +Link to the original Interleave package:
> +https://github.com/rudolfochrist/interleave

Please change the description to describe the package contents from the
viewpoint of an outsider.  See the guidelines at
<https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.

> +    (license license:gpl3)))

The source file header explicitly says “or any later version”, so it
should be ‘license:gpl3+’.

Could you send an updated patch?

Thank you,
Ludo’.

Message #13 received at 34698-done <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 34698-done <at> debbugs.gnu.org,
 Nicolò Balzarotti <anothersms <at> gmail.com>
Subject: Re: [bug#34698] [PATCH] gnu: add org-noter.
Date: Mon, 09 Dec 2019 22:55:51 -0600

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello,
>
> Nicolò Balzarotti <anothersms <at> gmail.com> skribis:
>
>> ---
>>  gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>
> Could you add a commit log that follows our conventions?
>
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://stable.melpa.org/packages/org-noter-"
>> +             version
>> +             ".el"))
>
> Since files on MELPA are unversioned and regularly modified in place,
> could you instead use the upstream URL (presumably the GitHub repo)?
>
>> +    (synopsis
>> +     "A synchronized, Org-mode, document annotator")
>          ^
> ‘guix lint’ probably complains about this; please remove the “A”.
>
>> +    (description
>> +     "The idea is to let you create notes that are kept in sync when you scroll through the
>> +document, but that are external to it - the notes themselves live in an Org-mode file. As
>> +such, this leverages the power of Org-mode (the notes may have outlines, latex fragments,
>> +babel, etc...) while acting like notes that are made /in/ the document.
>> +
>> +Also, I must thank Sebastian for the original idea and inspiration!
>> +Link to the original Interleave package:
>> +https://github.com/rudolfochrist/interleave
>
> Please change the description to describe the package contents from the
> viewpoint of an outsider.  See the guidelines at
> <https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.
>
>> +    (license license:gpl3)))
>
> The source file header explicitly says “or any later version”, so it
> should be ‘license:gpl3+’.
>
> Could you send an updated patch?
>
> Thank you,
> Ludo’.
>
>
>
>

Hi Ludo' and Nicolò,

Closing this as it was added in commit
576cb396eac4e8cea2b54d96382f8e77f3584e89 on 2019-06-13.

Thanks!

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.