GNU bug report logs - #34719
emacs-json-mode check phase failing

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34719 in the body.
You can then email your comments to 34719 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: mikadoZero <mikadozero <at> yandex.com>
To: bug-guix <at> gnu.org
Subject: emacs-json-mode check phase failing
Date: Sat, 2 Mar 2019 21:44:33 -0500

When I add `emacs-json-mode` to my Guix SD configuration and run `guix system reconfigure` I get this error:

building /gnu/store/3m18s0yhkyikgb2z1ivr321h4vrhi9nl-emacs-json-reformat-0.0.6.drv..
.                                                                                  
\ 'check' phasebuilder for `/gnu/store/3m18s0yhkyikgb2z1ivr321h4vrhi9nl-emacs-json-r
eformat-0.0.6.drv' failed with exit code 1                                         
build of /gnu/store/3m18s0yhkyikgb2z1ivr321h4vrhi9nl-emacs-json-reformat-0.0.6.drv f
ailed                                                                              
View build log at '/var/log/guix/drvs/3m/18s0yhkyikgb2z1ivr321h4vrhi9nl-emacs-json-r
eformat-0.0.6.drv.bz2'.                                                            
cannot build derivation `/gnu/store/snlxnxmjdibdis1vvbbxgmpi9r4anb3x-emacs-json-mode
-1.7.0.drv': 1 dependencies couldn't be built                                      
guix system: error: build of `/gnu/store/snlxnxmjdibdis1vvbbxgmpi9r4anb3x-emacs-json
-mode-1.7.0.drv' failed

The log ends with:

starting phase `check'
.Test json-reformat-test:json-reformat-region backtrace:

  signal(ert-test-failed (((should (string= "{\n    \"name\": \"John S
  ert-fail(((should (string= "{\n    \"name\": \"John Smith\",\n    \"
  (if (unwind-protect (setq value-132 (apply fn-130 args-131)) (setq f
  (let (form-description-134) (if (unwind-protect (setq value-132 (app
  (let ((value-132 'ert-form-evaluation-aborted-133)) (let (form-descr
  (let* ((fn-130 (function string=)) (args-131 (condition-case err (le
  (lambda nil (let* ((fn-130 (function string=)) (args-131 (condition-
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name json-reformat-test:json-reformat-regi
  ert-run-or-rerun-test(#s(ert--stats :selector (and t) :tests [#s(ert
  ert-run-tests((and t) (lambda (event-type &rest event-args) (cond ((
  ert-runner/run-tests-batch((and t))
  (let ((stats (ert-runner/run-tests-batch selector))) (kill-emacs (if
  ert-runner/run-tests-batch-and-exit((and t))
  (if ert-runner-verbose (ert-runner/run-tests-batch-and-exit ert-runn
  (let ((test-files (ert-runner--test-files tests)) (test-helper (f-ex
  ert-runner/run()
  apply(ert-runner/run nil)
  commander--handle-command(nil)
  commander-parse(nil)
  (if commander-parsing-done nil (commander-parse (or commander-args (
  eval-buffer(#<buffer  *load*> nil "/gnu/store/xj17vzrd65p60n9wifadzm
  load-with-code-conversion("/gnu/store/xj17vzrd65p60n9wifadzmkjliknsn
  load("/gnu/store/xj17vzrd65p60n9wifadzmkjliknsnv5-emacs-ert-runner-0
  command-line-1(("-scriptload" "/gnu/store/xj17vzrd65p60n9wifadzmkjli
  command-line()
  normal-top-level()

Test json-reformat-test:json-reformat-region condition:

    (ert-test-failed
     ((should
       (string= "{
    \"name\": \"John Smith\",
    \"age\": 33,
    \"breakfast\": [
        \"milk\",
        \"bread\",
        \"egg\"
    ]
}"
                (with-temp-buffer ... ... ...)))
      :form
      (string= "{
    \"name\": \"John Smith\",
    \"age\": 33,
    \"breakfast\": [
        \"milk\",
        \"bread\",
        \"egg\"
    ]
}" "{
    \"breakfast\": [
        \"milk\",
        \"bread\",
        \"egg\"
    ],
    \"age\": 33,
    \"name\": \"John Smith\"
}")
      :value nil))

F........

Ran 10 tests in 0.555 seconds
1 unexpected results:
   FAILED  json-reformat-test:json-reformat-region
Backtrace:
           4 (primitive-load "/gnu/store/f3q1xjz02yszgg2rq3phs57vgqd…")
In ice-9/eval.scm:
   191:35  3 (_ #f)
In srfi/srfi-1.scm:
   863:16  2 (every1 #<procedure 6d6bc0 at /gnu/store/djq0g2g74z8gg…> …)
In /gnu/store/djq0g2g74z8ggyv09v32z2w6izfrxlx0-module-import/guix/build/gnu-build-sy
stem.scm:                                                                          
   799:28  1 (_ _)
In /gnu/store/djq0g2g74z8ggyv09v32z2w6izfrxlx0-module-import/guix/build/utils.scm:
    616:6  0 (invoke _ . _)

/gnu/store/djq0g2g74z8ggyv09v32z2w6izfrxlx0-module-import/guix/build/utils.scm:616:6
: In procedure invoke:                                                             
Throw to key `srfi-34' with args `(#<condition &invoke-error [program: "ert-runner" 
arguments: () exit-status: 1 term-signal: #f stop-signal: #f] 774e80>)'.

Message #8 received at 34719 <at> debbugs.gnu.org (full text, mbox):

From: mikadoZero <mikadozero <at> yandex.com>
To: 34719 <at> debbugs.gnu.org
Subject: `guix describe` output
Date: Sun, 3 Mar 2019 08:00:43 -0500

The output of `guix describe` is:

guix 35556d7
  repository URL: https://git.savannah.gnu.org/git/guix.git
  branch: master
  commit: 35556d7da01f00ffdbc9b3218ef2669dd28e3b62

Message #11 received at 34719 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 34719 <at> debbugs.gnu.org,
	mikadozero <at> yandex.com
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: emacs-json-reformat: Fix test.
Date: Sun, 10 Mar 2019 00:16:53 +0300

This patch deletes a test which tries to compare JSON objects order.

* gnu/packages/emacs-xyz.scm (emacs-json-reformat): Delete
'json-reformat-test:json-reformat-region' test.
---
 gnu/packages/emacs-xyz.scm | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 30248f673a..b359777923 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26,7 +26,7 @@
 ;;; Copyright © 2017 George Clemmer <myglc2 <at> gmail.com>
 ;;; Copyright © 2017, 2018 Feng Shu <tumashu <at> 163.com>
 ;;; Copyright © 2017 Jan Nieuwenhuizen <janneke <at> gnu.org>
-;;; Copyright © 2017, 2018 Oleg Pykhalov <go.wigust <at> gmail.com>
+;;; Copyright © 2017, 2018, 2019 Oleg Pykhalov <go.wigust <at> gmail.com>
 ;;; Copyright © 2017 Mekeor Melire <mekeor.melire <at> gmail.com>
 ;;; Copyright © 2017 Peter Mikkelsen <petermikkelsen10 <at> gmail.com>
 ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
@@ -7032,7 +7032,19 @@ running a customisable handler command (@code{ignore} by default). ")
        ("ert-runner" ,emacs-ert-runner)))
     (arguments
      `(#:tests? #t
-       #:test-command '("ert-runner")))
+       #:test-command '("ert-runner")
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'delete-json-objects-order-test
+           (lambda _
+             (emacs-batch-edit-file "test/json-reformat-test.el"
+               `(progn (progn (goto-char (point-min))
+                              (re-search-forward
+                               "ert-deftest json-reformat-test:json-reformat-region")
+                              (beginning-of-line)
+                              (kill-sexp))
+                       (basic-save-buffer)))
+             #t)))))
     (home-page "https://github.com/gongo/json-reformat")
     (synopsis "Reformatting tool for JSON")
     (description "@code{json-reformat} provides a reformatting tool for
-- 
2.21.0

Message #16 received at 34719-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: mikadozero <at> yandex.com
Cc: 34719-done <at> debbugs.gnu.org
Subject: Re: bug#34719: [PATCH] gnu: emacs-json-reformat: Fix test.
Date: Mon, 11 Mar 2019 20:36:49 +0300

[Message part 1 (text/plain, inline)]

Hi mikadoZero,

Thank you for the report.

You could try ‘guix reconfigure’ after ‘guix pull’.

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> This patch deletes a test which tries to compare JSON objects order.
>
> * gnu/packages/emacs-xyz.scm (emacs-json-reformat): Delete
> 'json-reformat-test:json-reformat-region' test.
> ---
>  gnu/packages/emacs-xyz.scm | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 30248f673a..b359777923 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm

Pushed to master:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=34e3d028b9d180535108432a46b9569be6ab4dc5

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 34719-done <at> debbugs.gnu.org (full text, mbox):

From: mikadoZero <mikadozero <at> yandex.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 34719-done <at> debbugs.gnu.org
Subject: Re: bug#34719: [PATCH] gnu: emacs-json-reformat: Fix test.
Date: Mon, 11 Mar 2019 22:20:07 -0400

Oleg Pykhalov writes:

> Hi mikadoZero,
>
> Thank you for the report.
>
> You could try ‘guix reconfigure’ after ‘guix pull’.

Thanks that fixes the error I was getting.

Do you think this failing test should be reported to it's upstream?  I
looked at it's GitHub issues page.  This failing test has not been
reported yet.  When I was looking I think I saw that you had submitted
an issue for another failing test.  That issue is still not resolved.

Message #22 received at 34719-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: mikadoZero <mikadozero <at> yandex.com>
Cc: 34719-done <at> debbugs.gnu.org
Subject: Re: bug#34719: [PATCH] gnu: emacs-json-reformat: Fix test.
Date: Tue, 12 Mar 2019 21:44:01 +0300

[Message part 1 (text/plain, inline)]

mikadoZero <mikadozero <at> yandex.com> writes:

[…]

> Do you think this failing test should be reported to it's upstream?  I
> looked at it's GitHub issues page.  This failing test has not been
> reported yet.  When I was looking I think I saw that you had submitted
> an issue for another failing test.  That issue is still not resolved.

I think we could be quite until the developer has a time to work on
emacs-json-reformat (until new commits appear in master branch or
another activity) as he mentioned in #33 issue.  Failing tests are bad
but overall the program works good enough for users.

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.