GNU bug report logs - #34756
26.1.92; Minor typos across manuals

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34756 in the body.
You can then email your comments to 34756 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1.92; Minor typos across manuals
Date: Tue, 05 Mar 2019 08:41:21 +0000

[Message part 1 (text/plain, inline)]

Severity: minor
Tags: patch

[0001-Fix-some-plural-Message-IDs-typos-in-Gnus-docs.patch (text/x-diff, attachment)]

[0002-Fix-possessive-it-s-its-typos-in-manuals.patch (text/x-diff, attachment)]

[0003-Fix-an-other-another-typos-in-manuals.patch (text/x-diff, attachment)]

[Message part 5 (text/plain, inline)]

Are the three attached patches acceptable for the emacs-26 branch?
If so, should I add this bug number to all or none of them?

Thanks,

-- 
Basil

In GNU Emacs 26.1.92 (build 5, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2019-03-05 built on thunk
Repository revision: 52fd40068e0f8b41bd29eaec1334299eb86d0bff
Windowing system distributor 'The X.Org Foundation', version 11.0.12003000
System Description:	Debian GNU/Linux buster/sid

Message #8 received at 34756 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 34756 <at> debbugs.gnu.org
Subject: Re: bug#34756: 26.1.92; Minor typos across manuals
Date: Tue, 05 Mar 2019 18:17:05 +0200

> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> Date: Tue, 05 Mar 2019 08:41:21 +0000
> 
> Are the three attached patches acceptable for the emacs-26 branch?

Documentation changes should always go to the release branch, unless
they document features only available on master.

> If so, should I add this bug number to all or none of them?

It's okay to push all of them under the same bug number, and even in a
single commit.  There's no need to distinguish between changes that
correct typos, they are all "alike" for all practical purposes.

Thanks.

Message #15 received at 34756-done <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 34756-done <at> debbugs.gnu.org
Subject: Re: bug#34756: 26.1.92; Minor typos across manuals
Date: Tue, 05 Mar 2019 20:44:12 +0000

fixed 34756 26.2
quit

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
>> Date: Tue, 05 Mar 2019 08:41:21 +0000
>> 
>> Are the three attached patches acceptable for the emacs-26 branch?
>
> Documentation changes should always go to the release branch, unless
> they document features only available on master.
>
>> If so, should I add this bug number to all or none of them?
>
> It's okay to push all of them under the same bug number, and even in a
> single commit.  There's no need to distinguish between changes that
> correct typos, they are all "alike" for all practical purposes.

Thanks for clarifying, I've now pushed to the release branch.  Let me
know if anything is amiss, e.g. if signed commits are frowned upon.

-- 
Basil

Message #18 received at 34756 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 34756 <at> debbugs.gnu.org
Subject: Re: bug#34756: 26.1.92; Minor typos across manuals
Date: Tue, 05 Mar 2019 20:48:16 +0000

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Thanks for clarifying, I've now pushed to the release branch.  Let me
> know if anything is amiss, e.g. if signed commits are frowned upon.

Ugh, I got the Changelog format slightly wrong.  Sorry about that.

-- 
Basil

Message #21 received at 34756 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 34756 <at> debbugs.gnu.org
Subject: Re: bug#34756: 26.1.92; Minor typos across manuals
Date: Wed, 06 Mar 2019 05:39:05 +0200

> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> Cc: <34756-done <at> debbugs.gnu.org>
> Date: Tue, 05 Mar 2019 20:44:12 +0000
> 
> if signed commits are frowned upon.

They are; see CONTRIBUTE.

Message #24 received at 34756 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 34756 <at> debbugs.gnu.org
Subject: Re: bug#34756: 26.1.92; Minor typos across manuals
Date: Wed, 06 Mar 2019 18:06:46 +0200

> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> Cc: <34756 <at> debbugs.gnu.org>
> Date: Tue, 05 Mar 2019 20:48:16 +0000
> 
> Ugh, I got the Changelog format slightly wrong.

You did?  Where?

Message #27 received at 34756 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 34756 <at> debbugs.gnu.org
Subject: Re: bug#34756: 26.1.92; Minor typos across manuals
Date: Wed, 13 Mar 2019 17:31:02 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
>> Cc: <34756-done <at> debbugs.gnu.org>
>> Date: Tue, 05 Mar 2019 20:44:12 +0000
>> 
>> if signed commits are frowned upon.
>
> They are; see CONTRIBUTE.

I checked CONTRIBUTE, but I only saw mention of "Signed-off-by:" lines,
not GPG signing.  Is the latter also unwelcome?  I assumed not, given
the existence of a Project Member GPG Keyring on Savannah.

-- 
Basil

Message #30 received at 34756 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 34756 <at> debbugs.gnu.org
Subject: Re: bug#34756: 26.1.92; Minor typos across manuals
Date: Wed, 13 Mar 2019 17:35:41 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
>> Cc: <34756 <at> debbugs.gnu.org>
>> Date: Tue, 05 Mar 2019 20:48:16 +0000
>> 
>> Ugh, I got the Changelog format slightly wrong.
>
> You did?  Where?

I forgot to denote file names with a leading asterisk:
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=099ef446c2c1014727cfe98268fe468eb2e8828b

-- 
Basil

Message #33 received at 34756 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 34756 <at> debbugs.gnu.org
Subject: Re: bug#34756: 26.1.92; Minor typos across manuals
Date: Wed, 13 Mar 2019 20:14:58 +0200

> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> Cc: <34756 <at> debbugs.gnu.org>
> Date: Wed, 13 Mar 2019 17:31:02 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> >> Cc: <34756-done <at> debbugs.gnu.org>
> >> Date: Tue, 05 Mar 2019 20:44:12 +0000
> >> 
> >> if signed commits are frowned upon.
> >
> > They are; see CONTRIBUTE.
> 
> I checked CONTRIBUTE, but I only saw mention of "Signed-off-by:" lines,
> not GPG signing.

Well, you didn't really explain what you meant by "signed commits".

> Is the latter also unwelcome?  I assumed not, given the existence of
> a Project Member GPG Keyring on Savannah.

I don't think this was ever discussed.  Are there any GPG signed
commits in the repository?

Message #36 received at 34756 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 34756 <at> debbugs.gnu.org
Subject: Re: bug#34756: 26.1.92; Minor typos across manuals
Date: Wed, 13 Mar 2019 21:32:24 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
>> Cc: <34756 <at> debbugs.gnu.org>
>> Date: Wed, 13 Mar 2019 17:31:02 +0000
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> >> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
>> >> Cc: <34756-done <at> debbugs.gnu.org>
>> >> Date: Tue, 05 Mar 2019 20:44:12 +0000
>> >> 
>> >> if signed commits are frowned upon.
>> >
>> > They are; see CONTRIBUTE.
>> 
>> I checked CONTRIBUTE, but I only saw mention of "Signed-off-by:" lines,
>> not GPG signing.
>
> Well, you didn't really explain what you meant by "signed commits".

True; sorry about that.

>> Is the latter also unwelcome?  I assumed not, given the existence of
>> a Project Member GPG Keyring on Savannah.
>
> I don't think this was ever discussed.  Are there any GPG signed
> commits in the repository?

Yes, predominantly those of Nicolas Petton.  I listed them thusly:
git log --since=2018-01-01 --format='%h %aI %GS' | awk 'NF>2'

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.