GNU bug report logs - #34779
[PATCH] gnu: neovim: Partially fix #34616.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34779 in the body.
You can then email your comments to 34779 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Gábor Boskovits <boskovits <at> gmail.com>
Subject: [PATCH] gnu: neovim: Partially fix #34616.
Date: Thu,  7 Mar 2019 10:19:56 +0100

* gnu/packages/vim.scm (neovim)[arguments](phases): Add phase 'patch-tic.

This fixes a segmentation fault in neovim, where an error return value
is passed in as a pointer.
---
 gnu/packages/vim.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm
index 5e1e9b852c..105e2751e5 100644
--- a/gnu/packages/vim.scm
+++ b/gnu/packages/vim.scm
@@ -693,6 +693,12 @@ are detected, the user is notified.")))
        #:configure-flags '("-DPREFER_LUA:BOOL=YES")
        #:phases
        (modify-phases %standard-phases
+         ;; TODO: remove 'patch-tic on update
+         ;; see: https://github.com/nvim/neovim/issues/9687
+         (add-after 'unpack 'patch-tic
+           (lambda _
+             (substitute* "src/nvim/tui/tui.c"
+               (("value != NULL") "value != NULL && value != (char *)-1"))))
          (add-after 'unpack 'set-lua-paths
            (lambda* (#:key inputs #:allow-other-keys)
              (let* ((lua-version "5.2")
-- 
2.21.0

Message #8 received at 34779 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 34779 <at> debbugs.gnu.org
Cc: Gábor Boskovits <boskovits <at> gmail.com>
Subject: [PATCH v2] gnu: neovim: Partially fix #34616.
Date: Thu,  7 Mar 2019 10:35:12 +0100

* gnu/packages/vim.scm (neovim)[arguments](phases): Add phase 'patch-tic.

This fixes a segmentation fault in neovim, where an error return value
is passed in as a pointer.
---
 gnu/packages/vim.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm
index 5e1e9b852c..a6f4395f53 100644
--- a/gnu/packages/vim.scm
+++ b/gnu/packages/vim.scm
@@ -693,6 +693,12 @@ are detected, the user is notified.")))
        #:configure-flags '("-DPREFER_LUA:BOOL=YES")
        #:phases
        (modify-phases %standard-phases
+         ;; TODO: remove 'patch-tic on update
+         ;; see: https://github.com/neovim/neovim/issues/9687
+         (add-after 'unpack 'patch-tic
+           (lambda _
+             (substitute* "src/nvim/tui/tui.c"
+               (("value != NULL") "value != NULL && value != (char *)-1"))))
          (add-after 'unpack 'set-lua-paths
            (lambda* (#:key inputs #:allow-other-keys)
              (let* ((lua-version "5.2")
-- 
2.21.0

Message #13 received at 34779-done <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 34779-done <at> debbugs.gnu.org
Subject: gnu: neovim: Partially fix #34616
Date: Thu, 7 Mar 2019 11:19:52 +0100

Pushed to master as 0a10abf73e7bb1d5f751229c709903a0f66574d2.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.