GNU bug report logs - #34828
psmisc description vague

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34828 in the body.
You can then email your comments to 34828 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: mikadoZero <mikadozero <at> yandex.com>
To: bug-guix <at> gnu.org
Subject: psmisc description vague
Date: Tue, 12 Mar 2019 14:15:05 -0400

The description for the psmisc package would be more helpful if it
listed the utilities that it included.  As it is I do not know what I
will get after installing.

An example of a description that is more helpful is procps.

Message #8 received at 34828 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: mikadoZero <mikadozero <at> yandex.com>
Cc: 34828 <at> debbugs.gnu.org
Subject: Re: bug#34828: psmisc description vague
Date: Wed, 13 Mar 2019 15:48:27 +0100

Hi,

mikadoZero <mikadozero <at> yandex.com> skribis:

> The description for the psmisc package would be more helpful if it
> listed the utilities that it included.  As it is I do not know what I
> will get after installing.
>
> An example of a description that is more helpful is procps.

I would recommend against turning descriptions into lists of commands
just for the sake of package search (we should instead have another
mechanism to determine which package provides a given command), but
listing key commands is useful for a package like this one.

Would you like to propose a patch?

Ludo’.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: mikadoZero <mikadozero <at> yandex.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] bug#34828 gnu: psmisc: Make package description more
 informative
Date: Sat, 23 Mar 2019 19:54:45 -0400

This patch is for bug#34828.  It makes the description for psmisc
more informative.

This is one of my first patches submitted to Guix.  Feedback is
appreciated.

Passed:
`guix lint psmisc`
`guix build --rounds=4 psmisc`

------------


From 95f47eadb05de56a542d1be8f630e5ec4aa81485 Mon Sep 17 00:00:00 2001
From: mikadoZero <mikadozero <at> yandex.com>
Date: Sat, 23 Mar 2019 19:23:33 -0400
Subject: [PATCH] gnu: psmisc: Make package description more informative.

* gnu/packages/linux.scm (psmisc):
The content for the description is taken from the psmisc readme.
---
 gnu/packages/linux.scm | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 311bc6fa5..5365aa97d 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -33,6 +33,7 @@
 ;;; Copyright © 2018 Pierre Langlois <pierre.langlois <at> gmx.com>
 ;;; Copyright © 2018 Vasile Dumitrascu <va511e <at> yahoo.com>
 ;;; Copyright © 2019 Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
+;;; Copyright © 2019 mikadoZero <mikadozero <at> yandex.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -602,9 +603,21 @@ at login.  Local and dynamic reconfiguration are its key features.")
     (synopsis
      "Small utilities that use the proc file system")
     (description
-     "This PSmisc package is a set of some small useful utilities that
-use the proc file system.  We're not about changing the world, but
-providing the system administrator with some help in common tasks.")
+     "A package of small utilities that use the proc file-system.
+@itemize @bullet
+@item
+fuser - Identifies processes using files or sockets
+@item
+killall - kills processes by name, e.g. killall -HUP named
+@item
+prtstat - prints statistics of a process
+@item
+pslog - prints log path(s) of a process
+@item
+pstree - shows the currently running processes as a tree
+@item
+peekfd - shows the data travelling over a file descriptor
+@end itemize")
     (license license:gpl2+)))
 
 (define-public util-linux
-- 
2.21.0

Message #18 received at 34828-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 62348-done <at> debbugs.gnu.org, 34828-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Update psmisc to 23.6.
Date: Sat, 16 Sep 2023 15:43:24 +0200

Hi mikadoZero & Bruno,

I pushed #62348 patches 1 & 2 to master as 
32b4f59433df620ab8f4b9a6c523f8ef9500d75d et al.  I fixed a minor typo 
(‘file-system’) and added a full stop.

The update patch (3/3) went to core-updates as 
725b2528a65edf7425762b99330ab1c9bd33bc86.

Thanks!

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.