GNU bug report logs - #34856
[PATCH] *sum --help: add note about binary/text mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34856 in the body.
You can then email your comments to 34856 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kamil Dudka <kdudka <at> redhat.com>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] *sum --help: add note about binary/text mode
Date: Thu, 14 Mar 2019 13:48:01 +0100

* src/md5sum.c (usage): Make it clear that there is no difference
between binary mode and text mode on GNU systems.

Bug: https://bugzilla.redhat.com/406981
Bug: https://bugzilla.redhat.com/1688740
---
 src/md5sum.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/md5sum.c b/src/md5sum.c
index 3532f7b7a..f75b6de02 100644
--- a/src/md5sum.c
+++ b/src/md5sum.c
@@ -287,7 +287,10 @@ The following five options are useful only when verifying checksums:\n\
 The sums are computed as described in %s.  When checking, the input\n\
 should be a former output of this program.  The default mode is to print a\n\
 line with checksum, a space, a character indicating input mode ('*' for binary,\
-\n' ' for text or where binary is insignificant), and name for each FILE.\n"),
+\n' ' for text or where binary is insignificant), and name for each FILE.\n\
+\n\
+Note: There is no difference between binary mode and text mode on GNU systems.\
+\n"),
               DIGEST_REFERENCE);
       emit_ancillary_info (PROGRAM_NAME);
     }
-- 
2.17.2

Message #10 received at 34856-done <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Kamil Dudka <kdudka <at> redhat.com>, 34856-done <at> debbugs.gnu.org
Subject: Re: bug#34856: [PATCH] *sum --help: add note about binary/text mode
Date: Mon, 18 Mar 2019 09:11:59 +0100

On 3/14/19 1:48 PM, Kamil Dudka wrote:
> +Note: There is no difference between binary mode and text mode on GNU systems.\

Thanks for the patch - I see this is a downstream patch in Fedora since
several years.

I changed the Subject line to conform to our 'commit-msg' hook:

  md5sum,b2sum,sha*sum: --help: add note about binary/text mode

and pushed at:

  https://git.sv.gnu.org/cgit/coreutils.git/commit/?id=ae61b10663

Have a nice day,
Berny

Message #13 received at 34856-done <at> debbugs.gnu.org (full text, mbox):

From: Kamil Dudka <kdudka <at> redhat.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: 34856-done <at> debbugs.gnu.org
Subject: Re: bug#34856: [PATCH] *sum --help: add note about binary/text mode
Date: Mon, 18 Mar 2019 10:19:36 +0100

On Monday, March 18, 2019 9:11:59 AM CET Bernhard Voelker wrote:
> On 3/14/19 1:48 PM, Kamil Dudka wrote:
> > +Note: There is no difference between binary mode and text mode on GNU
> > systems.\
> Thanks for the patch - I see this is a downstream patch in Fedora since
> several years.

Yes, our long term plan is to move all such patches upstream or drop them.

> I changed the Subject line to conform to our 'commit-msg' hook:
> 
>   md5sum,b2sum,sha*sum: --help: add note about binary/text mode
> 
> and pushed at:
> 
>   https://git.sv.gnu.org/cgit/coreutils.git/commit/?id=ae61b10663

Thanks!

Kamil

> Have a nice day,
> Berny

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.