GNU bug report logs - #34900
Add emacs-semantic-refactor

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34900 in the body.
You can then email your comments to 34900 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: guix-patches <at> gnu.org
Subject: Add emacs-semantic-refactor
Date: Sun, 17 Mar 2019 23:04:50 -0400 (EDT)

[Message part 1 (text/plain, inline)]

Hi Guix,

The attached patch adds the emacs-semantic-refactor package.

When reviewing this patch some particular things to look out for/questions 
I have:

0) There are different sections in the (gnu packages emacs-xyz) module 
that are delineated by comments (e.g. Emacs Hacking, Web Browsing, and 
Miscellaneous). I've added the definition of emacs-semantic-refactor near 
the end of the file in the Miscellaneous section. I wonder if this is 
correct or if it should go in the Emacs Hacking section. Paredit, which 
would be used in similar scenarios to semantic-refactor is in the Emacs 
Hacking section.

1) The upstream source contains a number of animated gif files 
demonstrating usage in the srefactor-demos directory. I do not see a build 
process for these, and assume they were created by hand. Are we free to 
distribute these in Guix?

2) semantic-refactor has an optional integration with projectile whose 
availability is checked for with (featurep 'projectile). I have not added 
projectile as an input or propagated-input. Is this OK?

3) I'm still new to writing package definitions, so extra scrutiny is 
warranted, particularly for the synopsis and description.

All the best,
Jack

[0001-gnu-Add-emacs-semantic-refactor.patch (text/x-diff, attachment)]

Message #10 received at 34900-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Jack Hill <jackhill <at> jackhill.us>, 34900-done <at> debbugs.gnu.org
Subject: Re: [bug#34900] Add emacs-semantic-refactor
Date: Thu, 21 Mar 2019 20:49:58 +0100

[Message part 1 (text/plain, inline)]

Jack Hill <jackhill <at> jackhill.us> writes:

> Hi Guix,
>
> The attached patch adds the emacs-semantic-refactor package.

Thanks!

> When reviewing this patch some particular things to look out for/questions 
> I have:
>
> 0) There are different sections in the (gnu packages emacs-xyz) module 
> that are delineated by comments (e.g. Emacs Hacking, Web Browsing, and 
> Miscellaneous). I've added the definition of emacs-semantic-refactor near 
> the end of the file in the Miscellaneous section. I wonder if this is 
> correct or if it should go in the Emacs Hacking section. Paredit, which 
> would be used in similar scenarios to semantic-refactor is in the Emacs 
> Hacking section.

I don't have a good answer, so I went with your initial approach.

> 1) The upstream source contains a number of animated gif files 
> demonstrating usage in the srefactor-demos directory. I do not see a build 
> process for these, and assume they were created by hand. Are we free to 
> distribute these in Guix?

As long as they are free to use and redistribute (i.e. not under a
separate license), it should be okay for Guix.  GIFs generally don't
come with build instructions :-)

> 2) semantic-refactor has an optional integration with projectile whose 
> availability is checked for with (featurep 'projectile). I have not added 
> projectile as an input or propagated-input. Is this OK?

Great!  Optional dependencies are typically not propagated.

> 3) I'm still new to writing package definitions, so extra scrutiny is 
> warranted, particularly for the synopsis and description.

I added a "This package provides a ..." prefix to the description to
provide a little more context for the prospective reader.

Pushed as ea4a1e5d0b13b5c548804ac854e6eb30c5149ce4, thank you!

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 34900 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 34900 <at> debbugs.gnu.org
Subject: Re: [bug#34900] Add emacs-semantic-refactor
Date: Thu, 21 Mar 2019 16:05:32 -0400 (EDT)

On Thu, 21 Mar 2019, Marius Bakke wrote:

> Pushed as ea4a1e5d0b13b5c548804ac854e6eb30c5149ce4, thank you!

Thanks for the review!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.