GNU bug report logs - #34904
[PATCH] Update elixir to 1.8.1.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34904 in the body.
You can then email your comments to 34904 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Smith <robertsmith <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update elixir to 1.8.1.
Date: Mon, 18 Mar 2019 15:54:52 +0100

[Message part 1 (text/plain, inline)]

Hello,

Excited to be submitting my first patch to guix!
The following patch updates elixir from 1.6.6 to 1.8.1.
This was almost a trivial patch, however the full path of the git 
executable
was causing a line to go over 80 chars, which caused a syntax check in 
the
elixir Makefile to fail. I added a quick workaround to use elixir's own 
syntax
checker to fix the affected file (by putting each argument to the fn on 
its own line)
before the test is run.

Best,

Robert

[0001-Update-elixir-to-1.8.1.patch (text/x-diff, attachment)]

Message #10 received at 34904-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Robert Smith <robertsmith <at> posteo.net>, 34904-done <at> debbugs.gnu.org
Subject: Re: [bug#34904] [PATCH] Update elixir to 1.8.1.
Date: Thu, 21 Mar 2019 20:54:51 +0100

[Message part 1 (text/plain, inline)]

Hi Robert,

Robert Smith <robertsmith <at> posteo.net> writes:

> Hello,
>
> Excited to be submitting my first patch to guix!

It's a thrill, right? :-)

> The following patch updates elixir from 1.6.6 to 1.8.1.
> This was almost a trivial patch, however the full path of the git 
> executable
> was causing a line to go over 80 chars, which caused a syntax check in 
> the
> elixir Makefile to fail. I added a quick workaround to use elixir's own 
> syntax
> checker to fix the affected file (by putting each argument to the fn on 
> its own line)
> before the test is run.

Heh.  Nice workaround!  I added a commit message that follows our
convention, added the patch to "gnu/local.mk", and pushed the patch
in commit 2f87048dbe14097b9fe19ec470e2628cfca7fdbf.

Thank you, and welcome!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.