GNU bug report logs - #34927
Curl is not configured to use its dependency libssh2

Previous Next

Package: guix;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Wed, 20 Mar 2019 20:55:02 UTC

Severity: normal

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34927 in the body.
You can then email your comments to 34927 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#34927; Package guix. (Wed, 20 Mar 2019 20:55:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Leo Famulari <leo <at> famulari.name>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Wed, 20 Mar 2019 20:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: bug-guix <at> gnu.org
Subject: Curl is not configured to use its dependency libssh2
Date: Wed, 20 Mar 2019 16:40:52 -0400
[Message part 1 (text/plain, inline)]
While working on a libssh2 update [0] I noticed that curl was not
keeping a reference to libssh2, even though libssh2 is an input of the
curl build.

Our curl package is missing the required configuration option:

------
SSH support:      no      (--with-libssh2)
------

I assume that our curl package did build with SSH support in the past,
but I'm not sure.

It's unfortunate that we have to use a graft to update libssh2 even
though only a few dozen packages refer to it, because of this curl
issue.

What should we do about curl? Should we remove libssh2 from its inputs,
or enable the build-time --with-libssh2 configuration option?

[0] 
https://bugs.gnu.org/34926
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#34927; Package guix. (Wed, 20 Mar 2019 23:55:02 GMT) Full text and rfc822 format available.

Message #8 received at 34927 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>, 34927 <at> debbugs.gnu.org
Subject: Re: bug#34927: Curl is not configured to use its dependency libssh2
Date: Thu, 21 Mar 2019 00:54:02 +0100
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:

> While working on a libssh2 update [0] I noticed that curl was not
> keeping a reference to libssh2, even though libssh2 is an input of the
> curl build.
>
> Our curl package is missing the required configuration option:
>
> ------
> SSH support:      no      (--with-libssh2)
> ------
>
> I assume that our curl package did build with SSH support in the past,
> but I'm not sure.
>
> It's unfortunate that we have to use a graft to update libssh2 even
> though only a few dozen packages refer to it, because of this curl
> issue.
>
> What should we do about curl? Should we remove libssh2 from its inputs,
> or enable the build-time --with-libssh2 configuration option?

Since no one apparently uses it, let's just remove it.  I'm something of
a curl power user and did not know it even had SSH support!

In the mean time, if curl is the only "heavy" user of libssh2, we
can give it a non-public or hidden libssh2 package that stays on version
1.8.0 to avoid the graft.  WDYT?
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#34927; Package guix. (Thu, 21 Mar 2019 17:39:02 GMT) Full text and rfc822 format available.

Message #11 received at 34927 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 34927 <at> debbugs.gnu.org
Subject: Re: bug#34927: Curl is not configured to use its dependency libssh2
Date: Thu, 21 Mar 2019 13:38:12 -0400
[Message part 1 (text/plain, inline)]
On Thu, Mar 21, 2019 at 12:54:02AM +0100, Marius Bakke wrote:
> Since no one apparently uses it, let's just remove it.  I'm something of
> a curl power user and did not know it even had SSH support!
> 
> In the mean time, if curl is the only "heavy" user of libssh2, we
> can give it a non-public or hidden libssh2 package that stays on version
> 1.8.0 to avoid the graft.  WDYT?

Good idea! Done in af8f7eb4f2a664c2d0fb3faabaf2e80c72993ef6

I'll leave this bug open until curl either uses libssh2 or we remove the
dependency.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#34927; Package guix. (Thu, 21 Mar 2019 19:07:02 GMT) Full text and rfc822 format available.

Message #14 received at 34927 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 34927 <at> debbugs.gnu.org, guix-sysadmin <at> gnu.org
Subject: Re: bug#34927: Curl is not configured to use its dependency libssh2
Date: Thu, 21 Mar 2019 20:06:24 +0100
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:

> On Thu, Mar 21, 2019 at 12:54:02AM +0100, Marius Bakke wrote:
>> Since no one apparently uses it, let's just remove it.  I'm something of
>> a curl power user and did not know it even had SSH support!
>> 
>> In the mean time, if curl is the only "heavy" user of libssh2, we
>> can give it a non-public or hidden libssh2 package that stays on version
>> 1.8.0 to avoid the graft.  WDYT?
>
> Good idea! Done in af8f7eb4f2a664c2d0fb3faabaf2e80c72993ef6

This commit changed the cURL derivation, so I pushed a followup in
c1f4e6491cecc5d121ef371a8fb2aa0a07030d36.

I think using the "hidden?" property will leave the derivation
unchanged (as opposed to (hidden-package ...)).

@guix-sysadmin: Can you cancel evaluation 4309 on Berlin?
[signature.asc (application/pgp-signature, inline)]

Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Thu, 21 Mar 2019 20:38:02 GMT) Full text and rfc822 format available.

Notification sent to Leo Famulari <leo <at> famulari.name>:
bug acknowledged by developer. (Thu, 21 Mar 2019 20:38:02 GMT) Full text and rfc822 format available.

Message #19 received at 34927-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 34927-done <at> debbugs.gnu.org, guix-sysadmin <at> gnu.org
Subject: Re: bug#34927: Curl is not configured to use its dependency libssh2
Date: Thu, 21 Mar 2019 16:37:00 -0400
[Message part 1 (text/plain, inline)]
On Thu, Mar 21, 2019 at 08:06:24PM +0100, Marius Bakke wrote:
> This commit changed the cURL derivation, so I pushed a followup in
> c1f4e6491cecc5d121ef371a8fb2aa0a07030d36.

Oops... I did check that the libssh2 derivation had not changed, but I
didn't expect the order of the inputs in the curl package definition to
affect the derivation. Thanks for you quick fix!

> I think using the "hidden?" property will leave the derivation
> unchanged (as opposed to (hidden-package ...)).

(hidden-package) does work to preserve the derivation — the issue was
the inputs ordering in the curl package definition. I pushed another
followup to use it.
[signature.asc (application/pgp-signature, inline)]

Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 21 Mar 2019 20:40:02 GMT) Full text and rfc822 format available.

Reply sent to Marius Bakke <mbakke <at> fastmail.com>:
You have taken responsibility. (Thu, 21 Mar 2019 21:03:01 GMT) Full text and rfc822 format available.

Notification sent to Leo Famulari <leo <at> famulari.name>:
bug acknowledged by developer. (Thu, 21 Mar 2019 21:03:02 GMT) Full text and rfc822 format available.

Message #26 received at 34927-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 34927-done <at> debbugs.gnu.org
Subject: Re: bug#34927: Curl is not configured to use its dependency libssh2
Date: Thu, 21 Mar 2019 22:02:01 +0100
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:

> On Thu, Mar 21, 2019 at 08:06:24PM +0100, Marius Bakke wrote:
>> This commit changed the cURL derivation, so I pushed a followup in
>> c1f4e6491cecc5d121ef371a8fb2aa0a07030d36.
>
> Oops... I did check that the libssh2 derivation had not changed, but I
> didn't expect the order of the inputs in the curl package definition to
> affect the derivation. Thanks for you quick fix!
>
>> I think using the "hidden?" property will leave the derivation
>> unchanged (as opposed to (hidden-package ...)).
>
> (hidden-package) does work to preserve the derivation — the issue was
> the inputs ordering in the curl package definition. I pushed another
> followup to use it.

Oops, indeed it does..  I must have mixed it up with something else,
thanks for correcting my flawed assumption :-)
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 19 Apr 2019 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 345 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.