GNU bug report logs - #34956
Fix for define-compilation-mode

Previous Next

Package: emacs;

Reported by: Troy Hinckley <t.macman <at> gmail.com>

Date: Sat, 23 Mar 2019 15:54:02 UTC

Severity: minor

Tags: fixed

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34956 in the body.
You can then email your comments to 34956 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#34956; Package emacs. (Sat, 23 Mar 2019 15:54:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Troy Hinckley <t.macman <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 23 Mar 2019 15:54:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troy Hinckley <t.macman <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Fix for define-compilation-mode
Date: Sat, 23 Mar 2019 07:26:34 -0600

[Message part 1 (text/plain, inline)]
Hello,
This a is small patch that removes compilation-buffer-name-function-from
define-compilation-mode. compilation-buffer-name-function is used before
the major-mode is loaded, therefore overriding it in
define-compilation-mode is ineffectual. Removing it from the list of
overridden variables will ensure that it is not mistaken for a variable
that can be major mode specific. Also the function compilation-start takes
an optional argument name-function, so there is already a mechanism to
override it.

[Message part 2 (text/html, inline)]
[0001-Remove-compilation-buffer-name-function-from-derived.patch (application/octet-stream, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34956; Package emacs. (Thu, 04 Apr 2019 23:43:01 GMT) Full text and rfc822 format available.

Message #8 received at 34956 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Troy Hinckley <t.macman <at> gmail.com>
Cc: 34956 <at> debbugs.gnu.org
Subject: Re: bug#34956: Fix for define-compilation-mode
Date: Thu, 04 Apr 2019 19:42:03 -0400

severity 34956 minor
tags 34956 fixed
close 34956 27.1
quit

Troy Hinckley <t.macman <at> gmail.com> writes:

> This a is small patch that removes compilation-buffer-name-function-from
> define-compilation-mode. compilation-buffer-name-function is used before
> the major-mode is loaded, therefore overriding it in
> define-compilation-mode is ineffectual. Removing it from the list of
> overridden variables will ensure that it is not mistaken for a variable
> that can be major mode specific. Also the function compilation-start takes
> an optional argument name-function, so there is already a mechanism to
> override it.

Pushed to master.

[1: 905f619519]: 2019-04-04 19:39:42 -0400
  Don't check comp-buffer-name-function in derived mode (Bug#34956)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=905f6195191a518b7bb2dbdf6eacae41d31fc54e
Severity set to 'minor' from 'normal' Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 04 Apr 2019 23:43:02 GMT) Full text and rfc822 format available.
Added tag(s) fixed. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 04 Apr 2019 23:43:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 27.1, send any further explanations to 34956 <at> debbugs.gnu.org and Troy Hinckley <t.macman <at> gmail.com> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 04 Apr 2019 23:43:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 03 May 2019 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 360 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.