GNU bug report logs - #34993
27.0.50; Repeated call to custom-add-option in esh-mode.el

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Mon, 25 Mar 2019 14:12:01 UTC

Severity: minor

Tags: fixed, patch

Found in version 27.0.50

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34993 in the body.
You can then email your comments to 34993 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#34993; Package emacs. (Mon, 25 Mar 2019 14:12:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Mauro Aranda <maurooaranda <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 25 Mar 2019 14:12:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: 27.0.50; Repeated call to custom-add-option in esh-mode.el
Date: Mon, 25 Mar 2019 11:11:11 -0300

[Message part 1 (text/plain, inline)]
Tags: patch

esh-mode.el has a repeated call to 'custom-add-option':
(custom-add-option 'eshell-pre-command-hook 'eshell-push-command-mark)

From context, I assume the latter was intended for a different second
argument.  The patch is attached.

Best regards,
Mauro.

[Message part 2 (text/html, inline)]
[0001-Fix-repeated-call-to-custom-add-option-in-esh-mode.e.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34993; Package emacs. (Thu, 04 Apr 2019 02:57:02 GMT) Full text and rfc822 format available.

Message #8 received at 34993 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 34993 <at> debbugs.gnu.org
Subject: Re: bug#34993: 27.0.50;
 Repeated call to custom-add-option in esh-mode.el
Date: Wed, 03 Apr 2019 22:56:29 -0400

tags 34993 fixed
close 34993 27.1
quit

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> esh-mode.el has a repeated call to 'custom-add-option':
> (custom-add-option 'eshell-pre-command-hook 'eshell-push-command-mark)
>
> From context, I assume the latter was intended for a different second
> argument.  The patch is attached.

Yep, looks like a copy-pasto, I pushed your patch to master.

[1: 64925714ef]: 2019-04-03 22:41:39 -0400
  Fix repeated 'custom-add-option' in esh-mode.el (Bug#34993)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=64925714ef6b4d7485e5aee7a8ac063c20c07bc5
Added tag(s) fixed. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 04 Apr 2019 02:57:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 27.1, send any further explanations to 34993 <at> debbugs.gnu.org and Mauro Aranda <maurooaranda <at> gmail.com> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 04 Apr 2019 02:57:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 02 May 2019 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 351 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.