GNU bug report logs - #35025
[PATCH 1/1] htmlfontify-buffer read-only text

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35025 in the body.
You can then email your comments to 35025 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Brumlow <m <at> brumlow.io>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH 1/1] htmlfontify-buffer read-only text
Date: Wed, 27 Mar 2019 17:22:27 -0500

[Message part 1 (text/plain, inline)]

When trying to htmlfontify read only text I ran into a issue when 
trying to copy
a read only ERC buffer. It failed because the text copied had the 
property of
being read only. I found where hfy-fontify-buffer tries to remove 
the text
properties but fails to do so because the text is read only.

By adding (inhibit-read-only t) in the let statement at the top of 
the function
I was able to correct this issue.

Patch attached.

[htmlfontify.diff (text/x-diff, inline)]

diff --git a/lisp/htmlfontify.el b/lisp/htmlfontify.el
index 9fc029ec58..131d719fad 100644
--- a/lisp/htmlfontify.el
+++ b/lisp/htmlfontify.el
@@ -1652,7 +1652,8 @@ hfy-fontify-buffer
 SRCDIR, if set, is the directory being htmlfontified.
 FILE, if set, is the file name."
   (if srcdir (setq srcdir (directory-file-name srcdir)))
-  (let* ( (html-buffer        (hfy-buffer))
+  (let* ( (inhibit-read-only             t)
+          (html-buffer        (hfy-buffer))
           (css-sheet                   nil)
           (css-map                     nil)
           (invis-ranges                nil)

Message #8 received at 35025 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Brumlow <m <at> brumlow.io>
Cc: 35025 <at> debbugs.gnu.org
Subject: Re: bug#35025: [PATCH 1/1] htmlfontify-buffer read-only text
Date: Sun, 23 Jun 2019 20:10:44 +0200

Michael Brumlow <m <at> brumlow.io> writes:

> When trying to htmlfontify read only text I ran into a issue when
> trying to copy a read only ERC buffer. It failed because the text
> copied had the property of being read only. I found where
> hfy-fontify-buffer tries to remove the text properties but fails to do
> so because the text is read only.
>
> By adding (inhibit-read-only t) in the let statement at the top of the
> function I was able to correct this issue.

Thanks; applied to Emacs 27.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.