GNU bug report logs - #35033
[PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35033 in the body.
You can then email your comments to 35033 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Timo Eisenmann <eisenmann <at> fn.de>
To: guix-patches <at> gnu.org
Cc: Timo Eisenmann <eisenmann <at> fn.de>
Subject: [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
Date: Thu, 28 Mar 2019 21:00:54 +0100

* gnu/packages/video.scm (mpv)[arguments]: Add phase 'patch-paths' to
substitute in the absolute path to 'youtube-dl'.
---
 gnu/packages/video.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 55a1931530..3c5ade55a3 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1326,6 +1326,13 @@ SVCD, DVD, 3ivx, DivX 3/4/5, WMV and H.264 movies.")
     (arguments
      '(#:phases
        (modify-phases %standard-phases
+         (add-after
+          'unpack 'patch-paths
+          (lambda* (#:key inputs #:allow-other-keys)
+            (let ((ytdl (assoc-ref inputs "youtube-dl")))
+              (substitute* "player/lua/ytdl_hook.lua"
+                (("\"youtube-dl\",")
+                 (string-append "\"" ytdl "/bin/youtube-dl\","))))))
          (add-before
           'configure 'setup-waf
           (lambda* (#:key inputs #:allow-other-keys)
-- 
2.21.0

Message #8 received at 35033 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Timo Eisenmann <eisenmann <at> fn.de>
Cc: 35033 <at> debbugs.gnu.org
Subject: Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
Date: Wed, 03 Apr 2019 22:24:12 +0200

Hi Timo,

Timo Eisenmann <eisenmann <at> fn.de> skribis:

> * gnu/packages/video.scm (mpv)[arguments]: Add phase 'patch-paths' to
> substitute in the absolute path to 'youtube-dl'.

I think it’s a case where it may be more appropriate to look for
‘youtube-dl’ in $PATH because ‘youtube-dl’ is updated frequently.

WDYT?

Thanks,
Ludo’.

Message #11 received at 35033 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35033 <at> debbugs.gnu.org, Timo Eisenmann <eisenmann <at> fn.de>
Subject: Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
Date: Thu, 04 Apr 2019 02:06:31 +0530

[Message part 1 (text/plain, inline)]

We normally don't require the user to install dependencies such as
youtube-dl into the profile. I think we should retain that behaviour
even in this case with mpv. It would mean fewer surprises for the
user. If I'm guessing correctly, mpv doesn't require a lot of effort to
rebuild.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 35033 <at> debbugs.gnu.org (full text, mbox):

From: Timo Eisenmann <eisenmann <at> fn.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35033 <at> debbugs.gnu.org
Subject: Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
Date: Thu, 4 Apr 2019 00:48:34 +0200

On Wed, 03 Apr 2019 22:24:12 +0200
Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi Timo,
> 
> Timo Eisenmann <eisenmann <at> fn.de> skribis:
> 
> > * gnu/packages/video.scm (mpv)[arguments]: Add phase 'patch-paths'
> > to substitute in the absolute path to 'youtube-dl'.
> 
> I think it’s a case where it may be more appropriate to look for
> ‘youtube-dl’ in $PATH because ‘youtube-dl’ is updated frequently.
> 
> WDYT?

I think we should make mpv's youtube-dl feature work by default instead
of requiring the user to install youtube-dl into their profile.
That being said if, for some reason, someone does not want to update mpv
and still use a newer version of youtube-dl, they can do so by linking
the youtube-dl binary into mpv's config dir (by default: ~/.config/mpv).

> 
> Thanks,
> Ludo’.

Message #19 received at 35033-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Timo Eisenmann <eisenmann <at> fn.de>
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 35033-done <at> debbugs.gnu.org
Subject: Re: [bug#35033] [PATCH] gnu: mpv: Set absolute path to 'youtube-dl'.
Date: Mon, 08 Apr 2019 10:29:54 +0200

Hello,

Timo Eisenmann <eisenmann <at> fn.de> skribis:

> On Wed, 03 Apr 2019 22:24:12 +0200
> Ludovic Courtès <ludo <at> gnu.org> wrote:

[...]

>> I think it’s a case where it may be more appropriate to look for
>> ‘youtube-dl’ in $PATH because ‘youtube-dl’ is updated frequently.
>> 
>> WDYT?
>
> I think we should make mpv's youtube-dl feature work by default instead
> of requiring the user to install youtube-dl into their profile.

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

> We normally don't require the user to install dependencies such as
> youtube-dl into the profile. I think we should retain that behaviour
> even in this case with mpv. It would mean fewer surprises for the
> user. If I'm guessing correctly, mpv doesn't require a lot of effort to
> rebuild.

Alright, that makes sense (and indeed, mpv builds very quickly.)

I added a #t at the end of the phase and committed.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.