GNU bug report logs - #35041
tee: use STDIN_FILENO instead of 0

Previous Next

Package: coreutils;

Reported by: Martin Castillo <castilma <at> uni-bremen.de>

Date: Fri, 29 Mar 2019 18:18:02 UTC

Severity: normal

Done: Pádraig Brady <P <at> draigBrady.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35041 in the body.
You can then email your comments to 35041 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-coreutils <at> gnu.org:
bug#35041; Package coreutils. (Fri, 29 Mar 2019 18:18:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Martin Castillo <castilma <at> uni-bremen.de>:
New bug report received and forwarded. Copy sent to bug-coreutils <at> gnu.org. (Fri, 29 Mar 2019 18:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Martin Castillo <castilma <at> uni-bremen.de>
To: bug-coreutils <at> gnu.org
Subject: tee: use STDIN_FILENO instead of 0
Date: Fri, 29 Mar 2019 19:16:41 +0100
I was reading through tee.c and saw
231:      bytes_read = read (0, buffer, sizeof buffer);

Maybe it should read
read(STDIN_FILENO, buffer, sizeof buffer);
?

Greetings,
Martin Castillo
-- 
GPG: 7FDE 7190 2F73 2C50 236E  403D CC13 48F1 E644 08EC




Reply sent to Pádraig Brady <P <at> draigBrady.com>:
You have taken responsibility. (Sat, 30 Mar 2019 22:10:01 GMT) Full text and rfc822 format available.

Notification sent to Martin Castillo <castilma <at> uni-bremen.de>:
bug acknowledged by developer. (Sat, 30 Mar 2019 22:10:01 GMT) Full text and rfc822 format available.

Message #10 received at 35041-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Martin Castillo <castilma <at> uni-bremen.de>, 35041-done <at> debbugs.gnu.org
Subject: Re: bug#35041: tee: use STDIN_FILENO instead of 0
Date: Sat, 30 Mar 2019 15:09:51 -0700
On 29/03/19 11:16, Martin Castillo wrote:
> I was reading through tee.c and saw
> 231:      bytes_read = read (0, buffer, sizeof buffer);
> 
> Maybe it should read
> read(STDIN_FILENO, buffer, sizeof buffer);
> ?
> 
> Greetings,
> Martin Castillo

Pushed:
https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=ba36d51

marking this as done.

thanks,
Pádraig




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 28 Apr 2019 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 337 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.