GNU bug report logs - #35148
[PATCH] change wordstar-mode into a minor mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35148 in the body.
You can then email your comments to 35148 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mark Oteiza <mvoteiza <at> udel.edu>
To: bug-gnu-emacs <at> gnu.org
Cc: Douglas Quagliana <dquagliana <at> gmail.com>
Subject: Re: [PATCH] change wordstar-mode into a minor mode
Date: Thu, 4 Apr 2019 13:53:21 -0400

Hi,

I recently got some testing/confirmation that this does work as
expected, so pinging the list again to ask what I should do here.
I don't have strong feelings over whether this gets nudged out of
obsolete/ or gets moved over to ELPA.

The original thread is here:
https://lists.gnu.org/archive/html/emacs-devel/2017-02/msg00467.html

On 12/02/17 at 12:32pm, Mark Oteiza wrote:
> I was poking through obsolete/ the other day and happened upon
> ws-mode.el and subsequently the thread
> 
> https://lists.gnu.org/archive/html/emacs-devel/2015-05/msg00127.html
> 
> The following changes `wordstar-mode' into a minor mode, and also
> adds a global minor mode `global-wordstar-mode', which will turn on
> wordstar-mode in all buffers except the minibuffer.
> 
> diff --git a/lisp/obsolete/ws-mode.el b/lisp/obsolete/ws-mode.el
> index 62cccf725a..f977bc089e 100644
> --- a/lisp/obsolete/ws-mode.el
> +++ b/lisp/obsolete/ws-mode.el
> @@ -1,4 +1,4 @@
> -;;; ws-mode.el --- WordStar emulation mode for GNU Emacs
> +;;; ws-mode.el --- WordStar emulation mode for GNU Emacs -*- lexical-binding: t -*-
>  
>  ;; Copyright (C) 1991, 2001-2017 Free Software Foundation, Inc.
>  
> @@ -24,9 +24,20 @@
>  
>  ;;; Commentary:
>  
> -;; This emulates WordStar, with a major mode.
> +;; This provides emulation of WordStar with a minor mode.
>  
>  ;;; Code:
> +
> +(defgroup wordstar nil
> +  "WordStar emulation within Emacs."
> +  :prefix "wordstar-"
> +  :prefix "ws-"
> +  :group 'emulations)
> +
> +(defcustom wordstar-mode-lighter " WordStar"
> +  "Lighter shown in the modeline for `wordstar' mode."
> +  :type 'string)
> +
>  (defvar wordstar-C-k-map
>    (let ((map (make-keymap)))
>      (define-key map " " ())
> @@ -98,8 +109,7 @@ wordstar-C-o-map
>      (define-key map "wh" 'split-window-right)
>      (define-key map "wo" 'other-window)
>      (define-key map "wv" 'split-window-below)
> -    map)
> -  "")
> +    map))
>  
>  (defvar wordstar-C-q-map
>    (let ((map (make-keymap)))
> @@ -174,12 +184,9 @@ wordstar-mode-map
>  ;; wordstar-C-j-map not yet implemented
>  (defvar wordstar-C-j-map nil)
>  
> -
> -(put 'wordstar-mode 'mode-class 'special)
> -
>  ;;;###autoload
> -(define-derived-mode wordstar-mode fundamental-mode "WordStar"
> -  "Major mode with WordStar-like key bindings.
> +(define-minor-mode wordstar-mode
> +  "Minor mode with WordStar-like key bindings.
>  
>  BUGS:
>   - Help menus with WordStar commands (C-j just calls help-for-help)
> @@ -189,8 +196,18 @@ wordstar-mode
>   - Search and replace (C-q a) is only available in forward direction
>  
>  No key bindings beginning with ESC are installed, they will work
> -Emacs-like.")
> -
> +Emacs-like."
> +  :group 'wordstar
> +  :lighter wordstar-mode-lighter
> +  :keymap wordstar-mode-map)
> +
> +(defun turn-on-wordstar-mode ()
> +  (when (and (not (minibufferp))
> +             (not wordstar-mode))
> +    (wordstar-mode 1)))
> +
> +(define-globalized-minor-mode global-wordstar-mode wordstar-mode
> +  turn-on-wordstar-mode)
>  
>  (defun wordstar-center-paragraph ()
>    "Center each line in the paragraph at or after point.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mark Oteiza <mvoteiza <at> udel.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: [PATCH] change wordstar-mode into a minor mode
Date: Sun, 21 Apr 2019 12:33:56 -0400

Bumping for attention.  I'll push this in a few days or so otherwise.

On 04/04/19 at 01:53pm, Mark Oteiza wrote:
> Hi,
> 
> I recently got some testing/confirmation that this does work as
> expected, so pinging the list again to ask what I should do here.
> I don't have strong feelings over whether this gets nudged out of
> obsolete/ or gets moved over to ELPA.
> 
> The original thread is here:
> https://lists.gnu.org/archive/html/emacs-devel/2017-02/msg00467.html
> 
> On 12/02/17 at 12:32pm, Mark Oteiza wrote:
> > I was poking through obsolete/ the other day and happened upon
> > ws-mode.el and subsequently the thread
> > 
> > https://lists.gnu.org/archive/html/emacs-devel/2015-05/msg00127.html
> > 
> > The following changes `wordstar-mode' into a minor mode, and also
> > adds a global minor mode `global-wordstar-mode', which will turn on
> > wordstar-mode in all buffers except the minibuffer.
> > 
> > diff --git a/lisp/obsolete/ws-mode.el b/lisp/obsolete/ws-mode.el
> > index 62cccf725a..f977bc089e 100644
> > --- a/lisp/obsolete/ws-mode.el
> > +++ b/lisp/obsolete/ws-mode.el
> > @@ -1,4 +1,4 @@
> > -;;; ws-mode.el --- WordStar emulation mode for GNU Emacs
> > +;;; ws-mode.el --- WordStar emulation mode for GNU Emacs -*- lexical-binding: t -*-
> >  
> >  ;; Copyright (C) 1991, 2001-2017 Free Software Foundation, Inc.
> >  
> > @@ -24,9 +24,20 @@
> >  
> >  ;;; Commentary:
> >  
> > -;; This emulates WordStar, with a major mode.
> > +;; This provides emulation of WordStar with a minor mode.
> >  
> >  ;;; Code:
> > +
> > +(defgroup wordstar nil
> > +  "WordStar emulation within Emacs."
> > +  :prefix "wordstar-"
> > +  :prefix "ws-"
> > +  :group 'emulations)
> > +
> > +(defcustom wordstar-mode-lighter " WordStar"
> > +  "Lighter shown in the modeline for `wordstar' mode."
> > +  :type 'string)
> > +
> >  (defvar wordstar-C-k-map
> >    (let ((map (make-keymap)))
> >      (define-key map " " ())
> > @@ -98,8 +109,7 @@ wordstar-C-o-map
> >      (define-key map "wh" 'split-window-right)
> >      (define-key map "wo" 'other-window)
> >      (define-key map "wv" 'split-window-below)
> > -    map)
> > -  "")
> > +    map))
> >  
> >  (defvar wordstar-C-q-map
> >    (let ((map (make-keymap)))
> > @@ -174,12 +184,9 @@ wordstar-mode-map
> >  ;; wordstar-C-j-map not yet implemented
> >  (defvar wordstar-C-j-map nil)
> >  
> > -
> > -(put 'wordstar-mode 'mode-class 'special)
> > -
> >  ;;;###autoload
> > -(define-derived-mode wordstar-mode fundamental-mode "WordStar"
> > -  "Major mode with WordStar-like key bindings.
> > +(define-minor-mode wordstar-mode
> > +  "Minor mode with WordStar-like key bindings.
> >  
> >  BUGS:
> >   - Help menus with WordStar commands (C-j just calls help-for-help)
> > @@ -189,8 +196,18 @@ wordstar-mode
> >   - Search and replace (C-q a) is only available in forward direction
> >  
> >  No key bindings beginning with ESC are installed, they will work
> > -Emacs-like.")
> > -
> > +Emacs-like."
> > +  :group 'wordstar
> > +  :lighter wordstar-mode-lighter
> > +  :keymap wordstar-mode-map)
> > +
> > +(defun turn-on-wordstar-mode ()
> > +  (when (and (not (minibufferp))
> > +             (not wordstar-mode))
> > +    (wordstar-mode 1)))
> > +
> > +(define-globalized-minor-mode global-wordstar-mode wordstar-mode
> > +  turn-on-wordstar-mode)
> >  
> >  (defun wordstar-center-paragraph ()
> >    "Center each line in the paragraph at or after point.

Message #11 received at 35148 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mark Oteiza <mvoteiza <at> udel.edu>
Cc: 35148 <at> debbugs.gnu.org
Subject: Re: bug#35148: [PATCH] change wordstar-mode into a minor mode
Date: Sun, 23 Jun 2019 19:45:48 +0200

Mark Oteiza <mvoteiza <at> udel.edu> writes:

> Bumping for attention.  I'll push this in a few days or so otherwise.

This was apparently done, so I'm now closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.