GNU bug report logs - #35172
[PATCH] gnu: Add git-lfs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35172 in the body.
You can then email your comments to 35172 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kkebreau <at> posteo.net>
Subject: [PATCH] gnu: Add git-lfs.
Date: Sat,  6 Apr 2019 10:35:33 -0400

* gnu/packages/version-control.scm (git-lfs): New variable.
---
 gnu/packages/version-control.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 50284182c9..091bc988cf 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -23,6 +23,7 @@
 ;;; Copyright © 2018 Timothy Sample <samplet <at> ngyro.com>
 ;;; Copyright © 2018 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2019 Jovany Leandro G.C <bit4bit <at> riseup.net>
+;;; Copyright © 2019 Kei Kebreau <kkebreau <at> posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -47,6 +48,7 @@
   #:use-module (guix git-download)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system go)
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages apr)
@@ -2137,3 +2139,27 @@ design goals are to reduce the pain of resolving merge conflicts by finding
 the smallest possible conflicts and to allow a merge to be saved, tested,
 interrupted, published, and collaborated on while in progress.")
     (license license:gpl2+)))
+
+(define-public git-lfs
+  (package
+    (name "git-lfs")
+    (version "2.7.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/git-lfs/git-lfs")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "10v38w8qfz0x8750kv31n8gg2dimvq4wz40m374pd1xaypfs9670"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/git-lfs/git-lfs"))
+    (home-page "https://git-lfs.github.com/")
+    (synopsis "Git extension for versioning large files")
+    (description
+     "Git Large File Storage (LFS) replaces large files such as audio samples,
+videos, datasets, and graphics with text pointers inside Git, while storing the
+file contents on a remote server like GitHub.com or GitHub Enterprise.")
+    (license license:expat)))
-- 
2.21.0

Message #8 received at 35172 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: 35172 <at> debbugs.gnu.org
Subject: Re: [bug#35172] [PATCH] gnu: Add git-lfs.
Date: Sat, 06 Apr 2019 10:55:02 -0400

Kei Kebreau <kkebreau <at> posteo.net> writes:

> +(define-public git-lfs
> +  (package
> +    (name "git-lfs")
> +    (version "2.7.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/git-lfs/git-lfs")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "10v38w8qfz0x8750kv31n8gg2dimvq4wz40m374pd1xaypfs9670"))))
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/git-lfs/git-lfs"))
> +    (home-page "https://git-lfs.github.com/")
> +    (synopsis "Git extension for versioning large files")
> +    (description
> +     "Git Large File Storage (LFS) replaces large files such as audio samples,
> +videos, datasets, and graphics with text pointers inside Git, while storing the
> +file contents on a remote server like GitHub.com or GitHub Enterprise.")

I realize that I can remove the GitHub promotion from the description
without any loss of understanding.

> +    (license license:expat)))

This is my first Go package, so any corrections or tips are especially
appreciated!

Message #11 received at 35172 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 35172 <at> debbugs.gnu.org
Subject: Re: [bug#35172] [PATCH] gnu: Add git-lfs.
Date: Thu, 18 Apr 2019 17:43:09 +0200

Hello,

Kei Kebreau <kkebreau <at> posteo.net> skribis:

> Kei Kebreau <kkebreau <at> posteo.net> writes:
>
>> +(define-public git-lfs
>> +  (package
>> +    (name "git-lfs")
>> +    (version "2.7.1")
>> +    (source (origin
>> +              (method git-fetch)
>> +              (uri (git-reference
>> +                    (url "https://github.com/git-lfs/git-lfs")
>> +                    (commit (string-append "v" version))))
>> +              (file-name (git-file-name name version))
>> +              (sha256
>> +               (base32
>> +                "10v38w8qfz0x8750kv31n8gg2dimvq4wz40m374pd1xaypfs9670"))))
>> +    (build-system go-build-system)
>> +    (arguments
>> +     '(#:import-path "github.com/git-lfs/git-lfs"))
>> +    (home-page "https://git-lfs.github.com/")
>> +    (synopsis "Git extension for versioning large files")
>> +    (description
>> +     "Git Large File Storage (LFS) replaces large files such as audio samples,
>> +videos, datasets, and graphics with text pointers inside Git, while storing the
>> +file contents on a remote server like GitHub.com or GitHub Enterprise.")
>
> I realize that I can remove the GitHub promotion from the description
> without any loss of understanding.

Agreed.

>> +    (license license:expat)))
>
> This is my first Go package, so any corrections or tips are especially
> appreciated!

I’m no nothing about Go, but it LGTM!  If something is broken, don’t
worry, people will tell you.  ;-)

Thank you,
Ludo’.

Message #16 received at 35172-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35172-done <at> debbugs.gnu.org
Subject: Re: [bug#35172] [PATCH] gnu: Add git-lfs.
Date: Sat, 20 Apr 2019 16:42:00 -0400

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello,
>
> Kei Kebreau <kkebreau <at> posteo.net> skribis:
>
>> Kei Kebreau <kkebreau <at> posteo.net> writes:
>>
>>> +(define-public git-lfs
>>> +  (package
>>> +    (name "git-lfs")
>>> +    (version "2.7.1")
>>> +    (source (origin
>>> +              (method git-fetch)
>>> +              (uri (git-reference
>>> +                    (url "https://github.com/git-lfs/git-lfs")
>>> +                    (commit (string-append "v" version))))
>>> +              (file-name (git-file-name name version))
>>> +              (sha256
>>> +               (base32
>>> +                "10v38w8qfz0x8750kv31n8gg2dimvq4wz40m374pd1xaypfs9670"))))
>>> +    (build-system go-build-system)
>>> +    (arguments
>>> +     '(#:import-path "github.com/git-lfs/git-lfs"))
>>> +    (home-page "https://git-lfs.github.com/")
>>> +    (synopsis "Git extension for versioning large files")
>>> +    (description
>>> + "Git Large File Storage (LFS) replaces large files such as audio
>>> samples,
>>> +videos, datasets, and graphics with text pointers inside Git,
>>> while storing the
>>> +file contents on a remote server like GitHub.com or GitHub Enterprise.")
>>
>> I realize that I can remove the GitHub promotion from the description
>> without any loss of understanding.
>
> Agreed.
>
>>> +    (license license:expat)))
>>
>> This is my first Go package, so any corrections or tips are especially
>> appreciated!
>
> I’m no nothing about Go, but it LGTM!  If something is broken, don’t
> worry, people will tell you.  ;-)
>

:-)

> Thank you,
> Ludo’.

Pushed to master, thank you for reviewing!

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 35172-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 35172-done <at> debbugs.gnu.org
Subject: Re: [bug#35172] [PATCH] gnu: Add git-lfs.
Date: Sun, 21 Apr 2019 14:50:45 +0200

Kei Kebreau <kkebreau <at> posteo.net> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:

[...]

>> I’m no nothing about Go, but it LGTM!  If something is broken, don’t
    ^^^^^

Ouch, what have I written here?!  Anyway, thanks for git-lfs!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.