GNU bug report logs - #35193
[PATCH 0/3] Add python-mypy and required packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35193 in the body.
You can then email your comments to 35193 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: JesseJohnGildersleve <JesseJohnGildersleve <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH 0/3] Add python-mypy and required packages
Date: Mon, 08 Apr 2019 13:44:38 +0000

The next 3 patches will add python-mypy, and its dependencies python-typed-ast and python-mypy-extension/python2-mypy-extension. This is a program for type checking python code.

Message #8 received at 35193 <at> debbugs.gnu.org (full text, mbox):

From: JesseJohnGildersleve <JesseJohnGildersleve <at> protonmail.com>
To: "35193 <at> debbugs.gnu.org" <35193 <at> debbugs.gnu.org>
Subject: [PATCH 1/3] Add python-typed-ast
Date: Mon, 08 Apr 2019 14:20:56 +0000

From ad2b363f11805002bee96d1471bff8471c0a1711 Mon Sep 17 00:00:00 2001
From: frozenpigs <purpjuice <at> protonmail.com>
Date: Mon, 8 Apr 2019 14:34:19 +0100
Subject: [PATCH 1/3] gnu: add python-typed-ast

---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 014026d06e..b5bfd6a261 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -59,6 +59,7 @@
 ;;; Copyright © 2018 Vagrant Cascadian <vagrant <at> debian.org>
 ;;; Copyright © 2019 Brett Gilio <brettg <at> posteo.net>
 ;;; Copyright © 2019 Sam <smbaines8 <at> gmail.com>
+;;; Copyright © 2019 Jesse Gildersleve <jessejohngildersleve <at> protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -15319,3 +15320,25 @@ processes may share the same data.")
     (description "A Sphinx extension to convert SVG images to PDF in case the builder does not support
 SVG images natively (e.g. LaTeX).")
     (license license:bsd-3)))
+
+(define-public python-typed-ast
+  (package
+    (name "python-typed-ast")
+    (version "1.3.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "typed-ast" version))
+       (sha256
+        (base32
+         "095l1jfxk1k2z5sijbirg2s5a01r4ig3715zqa075xzf0zx8lvb0"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/python/typed_ast")
+    (synopsis "Fork of Python 2 and 3 ast modules with type comment support")
+    (description "Typed_ast is a Python 3 package that provides a Python 2.7 and
+Python 3 parser similar to the standard ast library.  Unlike ast, the parsers in
+typed_ast include PEP 484 type comments and are independent of the version of Python
+under which they are run.  The typed_ast parsers produce the standard Python AST
+(plus type comments), and are both fast and correct, as they are based on the
+CPython 2.7 and 3.6 parsers.")
+    (license license:asl2.0)))
--
2.21.0

Message #11 received at 35193 <at> debbugs.gnu.org (full text, mbox):

From: JesseJohnGildersleve <JesseJohnGildersleve <at> protonmail.com>
To: "35193 <at> debbugs.gnu.org" <35193 <at> debbugs.gnu.org>
Subject: [PATCH 2/3] Add python-mypy-extensions
Date: Mon, 08 Apr 2019 14:21:53 +0000

From e968e9787457781552fa229f6d1c5f15e473de1c Mon Sep 17 00:00:00 2001
From: frozenpigs <purpjuice <at> protonmail.com>
Date: Mon, 8 Apr 2019 14:35:01 +0100
Subject: [PATCH 2/3] gnu: add python-mypy-extensions and
 python2-mypy-extensions

---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index b5bfd6a261..27f1e1de08 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15342,3 +15342,26 @@ under which they are run.  The typed_ast parsers produce the standard Python AST
 (plus type comments), and are both fast and correct, as they are based on the
 CPython 2.7 and 3.6 parsers.")
     (license license:asl2.0)))
+
+(define-public python-mypy-extensions
+  (package
+    (name "python-mypy-extensions")
+    (version "0.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "mypy_extensions" version))
+       (sha256
+        (base32
+         "04h8brrbbx151dfa2cvvlnxgmb5wa00mhd2z7nd20s8kyibfkq1p"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-typing" ,python-typing)))
+    (home-page "http://www.mypy-lang.org/")
+    (synopsis "Experimental type system extensions for programs checked with mypy")
+    (description "The “mypy_extensions” module defines experimental extensions to the
+standard “typing” module that are supported by the mypy typechecker.")
+    (license license:expat)))
+
+(define-public python2-mypy-extensions
+  (package-with-python2 python-mypy-extensions))
--
2.21.0

Message #14 received at 35193 <at> debbugs.gnu.org (full text, mbox):

From: JesseJohnGildersleve <JesseJohnGildersleve <at> protonmail.com>
To: "35193 <at> debbugs.gnu.org" <35193 <at> debbugs.gnu.org>
Subject: [PATCH 3/3] Add python-mypy
Date: Mon, 08 Apr 2019 14:23:33 +0000

From e3d67303de7f73c6af6eab6360ee3a414e175488 Mon Sep 17 00:00:00 2001
From: frozenpigs <purpjuice <at> protonmail.com>
Date: Mon, 8 Apr 2019 14:35:50 +0100
Subject: [PATCH 3/3] gnu: add python-mypy

---
 gnu/packages/python-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 27f1e1de08..1cb5cfaade 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15365,3 +15365,30 @@ standard “typing” module that are supported by the mypy typechecker.")

 (define-public python2-mypy-extensions
   (package-with-python2 python-mypy-extensions))
+
+(define-public python-mypy
+  (package
+    (name "python-mypy")
+    (version "0.700")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "mypy" version))
+       (sha256
+        (base32
+         "1zxfi5s9hxrz0hbaj4n513az17l44pxl80r62ipjc0bsmbcic2xi"))))
+    (build-system python-build-system)
+    ;; FIXME: mypy issue #5562, requires pytest
+    (arguments '(#:tests? #f))
+    (propagated-inputs
+     `(("python-mypy-extensions" ,python-mypy-extensions)
+       ("python-typed-ast" ,python-typed-ast)
+       ("python-psutil" ,python-psutil)))
+    (home-page "http://www.mypy-lang.org/")
+    (synopsis "Optional static typing for Python (mypyc-compiled version)")
+    (description "Add type annotations to your Python programs, and use mypy to type check
+them.  Mypy is essentially a Python linter on steroids, and it can catch many programming
+errors by analyzing your program, without actually having to run it.  Mypy has a powerful
+type system with features such as type inference, gradual typing, generics and union
+types.")
+    (license license:expat)))
--
2.21.0

Message #17 received at 35193 <at> debbugs.gnu.org (full text, mbox):

From: wednesday <jessejohngildersleve <at> zohomail.eu>
To: 35193 <at> debbugs.gnu.org
Cc: wednesday <jessejohngildersleve <at> zohomail.eu>
Subject: [PATCH v2 1/3] gnu: Add python-typed-ast
Date: Tue, 30 Apr 2019 16:29:12 +0100

* gnu/packages/python-xyz.scm (python-typed-ast): New public variable.
---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 35147ebfa7..79271f0e41 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -59,6 +59,7 @@
 ;;; Copyright © 2018 Vagrant Cascadian <vagrant <at> debian.org>
 ;;; Copyright © 2019 Brett Gilio <brettg <at> posteo.net>
 ;;; Copyright © 2019 Sam <smbaines8 <at> gmail.com>
+;;; Copyright © 2019 Jesse John Gildersleve <jessejohngildersleve <at> zohomail.eu>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -15630,3 +15631,25 @@ processes may share the same data.")
     (description "A Sphinx extension to convert SVG images to PDF in case the builder does not support
 SVG images natively (e.g. LaTeX).")
     (license license:bsd-3)))
+
+(define-public python-typed-ast
+  (package
+    (name "python-typed-ast")
+    (version "1.3.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "typed-ast" version))
+       (sha256
+        (base32
+         "1m7pr6qpana3cvqwiw7mlvrgvmw27ch5mx1592572xhlki8g85ak"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/python/typed_ast")
+    (synopsis "Fork of Python 2 and 3 ast modules with type comment support")
+    (description "Typed_ast is a Python 3 package that provides a Python 2.7 and
+Python 3 parser similar to the standard ast library.  Unlike ast, the parsers in
+typed_ast include PEP 484 type comments and are independent of the version of Python
+under which they are run.  The typed_ast parsers produce the standard Python AST
+(plus type comments), and are both fast and correct, as they are based on the
+CPython 2.7 and 3.6 parsers.")
+    (license license:asl2.0)))
-- 
2.21.0

Message #20 received at 35193 <at> debbugs.gnu.org (full text, mbox):

From: wednesday <jessejohngildersleve <at> zohomail.eu>
To: 35193 <at> debbugs.gnu.org
Cc: wednesday <jessejohngildersleve <at> zohomail.eu>
Subject: [PATCH v2 0/3] Updating and fixing mypy packages
Date: Tue, 30 Apr 2019 16:29:11 +0100

In these patches I updated the packages related to mypy, as well as mypy.
In addition to that I fixed an issue with python-mypy-extensions that was
causing mypy to fail when checking python3.

Also these patches were formatted and sent with git send-email, unlike
the other ones, so hopefully you'll have an easier time applying them.

wednesday (3):
  gnu: Add python-typed-ast
  gnu: Add python-mypy-extensions
  gnu: Add python-mypy

 gnu/packages/python-xyz.scm | 76 +++++++++++++++++++++++++++++++++++++
 1 file changed, 76 insertions(+)

-- 
2.21.0

Message #23 received at 35193 <at> debbugs.gnu.org (full text, mbox):

From: wednesday <jessejohngildersleve <at> zohomail.eu>
To: 35193 <at> debbugs.gnu.org
Cc: wednesday <jessejohngildersleve <at> zohomail.eu>
Subject: [PATCH v2 2/3] gnu: Add python-mypy-extensions
Date: Tue, 30 Apr 2019 16:29:13 +0100

* gnu/packages/python-xyz.scm (python-mypy-extensions,
  python2-mypy-extensions): New public variables.
---
 gnu/packages/python-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 79271f0e41..01c065fc83 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15653,3 +15653,29 @@ under which they are run.  The typed_ast parsers produce the standard Python AST
 (plus type comments), and are both fast and correct, as they are based on the
 CPython 2.7 and 3.6 parsers.")
     (license license:asl2.0)))
+
+(define-public python-mypy-extensions
+  (package
+    (name "python-mypy-extensions")
+    (version "0.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "mypy_extensions" version))
+       (sha256
+        (base32
+         "04h8brrbbx151dfa2cvvlnxgmb5wa00mhd2z7nd20s8kyibfkq1p"))))
+    (build-system python-build-system)
+    (home-page "http://www.mypy-lang.org/")
+    (synopsis "Experimental type system extensions for programs checked with mypy")
+    (description "The @code{mypy_extensions} module defines experimental extensions to the
+standard @code{typing} module that are supported by the mypy typechecker.")
+    (license license:expat)))
+
+(define-public python2-mypy-extensions
+  (let ((mypy (package-with-python2
+                   (strip-python2-variant python-mypy-extensions))))
+    (package (inherit mypy)
+             (propagated-inputs
+              `(("python2-typing" ,python2-typing)
+                ,@(package-propagated-inputs mypy))))))
-- 
2.21.0

Message #26 received at 35193 <at> debbugs.gnu.org (full text, mbox):

From: wednesday <jessejohngildersleve <at> zohomail.eu>
To: 35193 <at> debbugs.gnu.org
Cc: wednesday <jessejohngildersleve <at> zohomail.eu>
Subject: [PATCH v2 3/3] gnu: Add python-mypy
Date: Tue, 30 Apr 2019 16:29:14 +0100

* gnu/packages/python-xyz.scm (python-mypy): New public variable.
---
 gnu/packages/python-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 01c065fc83..c528d2849d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15679,3 +15679,30 @@ standard @code{typing} module that are supported by the mypy typechecker.")
              (propagated-inputs
               `(("python2-typing" ,python2-typing)
                 ,@(package-propagated-inputs mypy))))))
+
+(define-public python-mypy
+  (package
+    (name "python-mypy")
+    (version "0.701")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "mypy" version))
+       (sha256
+        (base32
+         "05479r3gbq17r22hyhxjg49smx5q864pgx8ayy23rsdj4w6z2r2p"))))
+    (build-system python-build-system)
+    ;; FIXME: tests freeze at 80%
+    (arguments '(#:tests? #f))
+    (propagated-inputs
+     `(("python-mypy-extensions" ,python-mypy-extensions)
+       ("python-typed-ast" ,python-typed-ast)
+       ("python-psutil" ,python-psutil)))
+    (home-page "http://www.mypy-lang.org/")
+    (synopsis "Optional static typing for Python 3 and 2 (PEP 484)")
+    (description "Add type annotations to your Python programs, and use mypy to type check
+them.  Mypy is essentially a Python linter on steroids, and it can catch many programming
+errors by analyzing your program, without actually having to run it.  Mypy has a powerful
+type system with features such as type inference, gradual typing, generics and union
+types.")
+    (license license:expat)))
-- 
2.21.0

Message #29 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: Re: [bug#35193] [PATCH v2 3/3] gnu: Add python-mypy
Date: Thu, 27 Jun 2019 16:11:07 +0200

On 2019-04-30 17:29, wednesday wrote:
> * gnu/packages/python-xyz.scm (python-mypy): New public variable.
> ---
>   gnu/packages/python-xyz.scm | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
> 
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 01c065fc83..c528d2849d 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -15679,3 +15679,30 @@ standard @code{typing} module that are supported by the mypy typechecker.")
>                (propagated-inputs
>                 `(("python2-typing" ,python2-typing)
>                   ,@(package-propagated-inputs mypy))))))
> +
> +(define-public python-mypy
> +  (package
> +    (name "python-mypy")
> +    (version "0.701")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "mypy" version))
> +       (sha256
> +        (base32
> +         "05479r3gbq17r22hyhxjg49smx5q864pgx8ayy23rsdj4w6z2r2p"))))
> +    (build-system python-build-system)
> +    ;; FIXME: tests freeze at 80%

We really would like to understand why these fail and mitigate if possible.

Have you reported this upstream?

> +    (arguments '(#:tests? #f))
> +    (propagated-inputs
> +     `(("python-mypy-extensions" ,python-mypy-extensions)
> +       ("python-typed-ast" ,python-typed-ast)
> +       ("python-psutil" ,python-psutil)))
> +    (home-page "http://www.mypy-lang.org/")
> +    (synopsis "Optional static typing for Python 3 and 2 (PEP 484)")
> +    (description "Add type annotations to your Python programs, and use mypy to type check
> +them.  

This phrase is a little eh weird. Could you rephrase to something like 
"Mypy checks type annotations..." or "Mypy is a ..."?

> Mypy is essentially a Python linter on steroids, and it can catch many programming
> +errors by analyzing your program, without actually having to run it.  Mypy has a powerful
> +type system with features such as type inference, gradual typing, generics and union
> +types.")
> +    (license license:expat)))


The LICENSE file contains this: "Portions of mypy are licensed under 
different licenses.  The files under stdlib-samples are licensed under 
the PSF 2 License, reproduced below."

Could you update the patch when you get an answer from upstream?

Thanks for the patch. :)

-- 
Cheers Swedebugia

Message #34 received at 35193-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: wednesday <jessejohngildersleve <at> zohomail.eu>
Cc: swedebugia <swedebugia <at> riseup.net>, 35193-done <at> debbugs.gnu.org
Subject: Re: bug#35193: [PATCH 0/3] Add python-mypy and required packages
Date: Fri, 02 Apr 2021 23:20:21 -0400

Hi!

swedebugia <swedebugia <at> riseup.net> writes:

> On 2019-04-30 17:29, wednesday wrote:
>> * gnu/packages/python-xyz.scm (python-mypy): New public variable.
>> ---
>>   gnu/packages/python-xyz.scm | 27 +++++++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>> diff --git a/gnu/packages/python-xyz.scm
>> b/gnu/packages/python-xyz.scm
>> index 01c065fc83..c528d2849d 100644
>> --- a/gnu/packages/python-xyz.scm
>> +++ b/gnu/packages/python-xyz.scm
>> @@ -15679,3 +15679,30 @@ standard @code{typing} module that are supported by the mypy typechecker.")
>>                (propagated-inputs
>>                 `(("python2-typing" ,python2-typing)
>>                   ,@(package-propagated-inputs mypy))))))
>> +
>> +(define-public python-mypy
>> +  (package
>> +    (name "python-mypy")
>> +    (version "0.701")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "mypy" version))
>> +       (sha256
>> +        (base32
>> +         "05479r3gbq17r22hyhxjg49smx5q864pgx8ayy23rsdj4w6z2r2p"))))
>> +    (build-system python-build-system)
>> +    ;; FIXME: tests freeze at 80%
>
> We really would like to understand why these fail and mitigate if possible.
>
> Have you reported this upstream?
>
>> +    (arguments '(#:tests? #f))
>> +    (propagated-inputs
>> +     `(("python-mypy-extensions" ,python-mypy-extensions)
>> +       ("python-typed-ast" ,python-typed-ast)
>> +       ("python-psutil" ,python-psutil)))
>> +    (home-page "http://www.mypy-lang.org/")
>> +    (synopsis "Optional static typing for Python 3 and 2 (PEP 484)")
>> +    (description "Add type annotations to your Python programs, and use mypy to type check
>> +them.  
>
> This phrase is a little eh weird. Could you rephrase to something like
> "Mypy checks type annotations..." or "Mypy is a ..."?
>
>> Mypy is essentially a Python linter on steroids, and it can catch many programming
>> +errors by analyzing your program, without actually having to run it.  Mypy has a powerful
>> +type system with features such as type inference, gradual typing, generics and union
>> +types.")
>> +    (license license:expat)))
>
>
> The LICENSE file contains this: "Portions of mypy are licensed under
> different licenses.  The files under stdlib-samples are licensed under 
> the PSF 2 License, reproduced below."
>
> Could you update the patch when you get an answer from upstream?
>
> Thanks for the patch. :)

It seems python-mypy and the required dependencies were merged (last
year) from another contributor that probably had failed to notice about
them here.  Thank you nonetheless, and thanks to swedebugia for the
review!

Closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.