GNU bug report logs - #35223
[PATCH] gnu: linux-libre: Set DEVPTS_MULTIPLE_INSTANCES only where needed.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35223 in the body.
You can then email your comments to 35223 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <somebody <at> not-sent-or-endorsed-by.tobias.gr>
To: guix-patches <at> gnu.org
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>
Subject: [PATCH] gnu: linux-libre: Set DEVPTS_MULTIPLE_INSTANCES only where
 needed.
Date: Thu, 11 Apr 2019 01:19:36 +0200

From: Tobias Geerinckx-Rice <me <at> tobias.gr>

* gnu/packages/linux.scm (%default-extra-linux-options): Move obsolete
CONFIG_DEVPTS_MULTIPLE_INSTANCES option…
(linux-libre-4.4): …here.
---
 gnu/packages/linux.scm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 710fd2d299..c80cee6422 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -264,9 +264,7 @@ for ARCH and optionally VARIANT, or #f if there is no such configuration."
     (search-auxiliary-file file)))
 
 (define %default-extra-linux-options
-  `(;; https://lists.gnu.org/archive/html/guix-devel/2014-04/msg00039.html
-    ("CONFIG_DEVPTS_MULTIPLE_INSTANCES" . #t)
-    ;; Modules required for initrd:
+  `(;; Modules required for initrd:
     ("CONFIG_NET_9P" . m)
     ("CONFIG_NET_9P_VIRTIO" . m)
     ("CONFIG_VIRTIO_BLK" . m)
@@ -471,7 +469,13 @@ It has been modified to remove all non-free binary blobs.")
   (make-linux-libre "4.4.178"
                     "1lgsd760md6b32qb5ng3anfq1n754a9d0c4xnf2mjxkimncb1jpp"
                     '("x86_64-linux" "i686-linux")
-                    #:configuration-file kernel-config))
+                    #:configuration-file kernel-config
+                    #:extra-options
+                    (append
+                     `(;; https://lists.gnu.org/archive/html/guix-devel/2014-04/msg00039.html
+                       ;; This option was removed upstream in version 4.7.
+                       ("CONFIG_DEVPTS_MULTIPLE_INSTANCES" . #t))
+                     %default-extra-linux-options)))
 
 (define-public linux-libre-arm-generic
   (make-linux-libre %linux-libre-version
-- 
2.21.0

Message #8 received at 35223 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <somebody <at> not-sent-or-endorsed-by.tobias.gr>
Cc: 35223 <at> debbugs.gnu.org
Subject: Re: [bug#35223] [PATCH] gnu: linux-libre: Set
 DEVPTS_MULTIPLE_INSTANCES only where needed.
Date: Thu, 11 Apr 2019 13:37:23 +0200

Hello,

Tobias Geerinckx-Rice <somebody <at> not-sent-or-endorsed-by.tobias.gr>
skribis:

> From: Tobias Geerinckx-Rice <me <at> tobias.gr>
>
> * gnu/packages/linux.scm (%default-extra-linux-options): Move obsolete
> CONFIG_DEVPTS_MULTIPLE_INSTANCES option…
> (linux-libre-4.4): …here.

So “make config” was emitting a warning on kernels > 4.7, right?

As long as things still work after this patch, go for it!

Thanks,
Ludo’.

Message #11 received at 35223 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35223 <at> debbugs.gnu.org
Subject: Re: [bug#35223] [PATCH] gnu: linux-libre: Set
 DEVPTS_MULTIPLE_INSTANCES only where needed.
Date: Thu, 11 Apr 2019 14:43:56 +0200

[Message part 1 (text/plain, inline)]

Ludo',

Ludovic Courtès wrote:
> Tobias Geerinckx-Rice 
> <somebody <at> not-sent-or-endorsed-by.tobias.gr>
> skribis:
>
>> From: Tobias Geerinckx-Rice <me <at> tobias.gr>
>>
>> * gnu/packages/linux.scm (%default-extra-linux-options): Move 
>> obsolete
>> CONFIG_DEVPTS_MULTIPLE_INSTANCES option…
>> (linux-libre-4.4): …here.
>
> So “make config” was emitting a warning on kernels > 4.7, right?

Oh, maybe; no idea.

I was tweaking my old kustom (pf-)kernel to be Guix-ready and 
noticed that this option was missing.

> As long as things still work after this patch, go for it!

AFAICT: yes.

Thanks!

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 35223-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 35223-done <at> debbugs.gnu.org
Subject: Re: [bug#35223] [PATCH] gnu: linux-libre: Set
 DEVPTS_MULTIPLE_INSTANCES only where needed.
Date: Sun, 14 Apr 2019 20:20:58 +0200

[Message part 1 (text/plain, inline)]

Tobias Geerinckx-Rice wrote:
>>> * gnu/packages/linux.scm (%default-extra-linux-options): Move
>>> obsolete
>>> CONFIG_DEVPTS_MULTIPLE_INSTANCES option…
>>> (linux-libre-4.4): …here.

[…]

>> As long as things still work after this patch, go for it!
>
> AFAICT: yes.

Pushed as 8b4e76249a4d1b4af5da6a8b07f4fb3c92234c07.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.