GNU bug report logs - #35239
27.0.50; Some gnus-msg.el variables are unused

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35239 in the body.
You can then email your comments to 35239 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: 27.0.50; Some gnus-msg.el variables are unused
Date: Fri, 12 Apr 2019 00:04:10 +0100

[Message part 1 (text/plain, inline)]

Severity: minor
Tags: patch

The user options gnus-debug-files and gnus-debug-exclude-variables have
been unused since Emacs 24.1[1].  The following patch marks them as
obsolete, fixes a few custom :types, and also removes the unused
variable gnus-check-before-posting.  WDYT?

[1: 72aba33f59]: Merge changes made in Gnus trunk.
  2011-07-07 23:18:23 +0000
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=72aba33f59d0ba30a01adf7aa7952b5839a8410d

[0001-Fix-some-gnus-msg.el-variables.patch (text/x-diff, inline)]

From 4b4fe3ed5a817f4535871c06ea001dc7d4077a96 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Date: Thu, 11 Apr 2019 23:55:03 +0100
Subject: [PATCH] Fix some gnus-msg.el variables

* lisp/gnus/gnus-msg.el (gnus-gcc-externalize-attachments):
Fix custom :type.
(gnus-debug-files, gnus-debug-exclude-variables): Mark variables
that have been unused since Emacs 24.1 as obsolete.
(gnus-check-before-posting): Remove unused variable.
---
 lisp/gnus/gnus-msg.el | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/lisp/gnus/gnus-msg.el b/lisp/gnus/gnus-msg.el
index b6d649d760..b7a97f19d0 100644
--- a/lisp/gnus/gnus-msg.el
+++ b/lisp/gnus/gnus-msg.el
@@ -158,9 +158,9 @@ gnus-gcc-externalize-attachments
 if nil, attach files as normal parts."
   :version "22.1"
   :group 'gnus-message
-  :type '(choice (const nil :tag "None")
-		 (const all :tag "Any")
-		 (string :tag "Regexp")))
+  :type '(choice (const :tag "None" nil)
+                 (const :tag "Any"  all)
+                 regexp))
 
 (defcustom gnus-gcc-self-resent-messages 'no-gcc-self
   "Like `gcc-self' group parameter, only for unmodified resent messages.
@@ -232,7 +232,9 @@ gnus-debug-files
   "Files whose variables will be reported in `gnus-bug'."
   :version "22.1"
   :group 'gnus-message
-  :type '(repeat (string :tag "File")))
+  :type '(repeat file))
+
+(make-obsolete-variable 'gnus-debug-files "it is no longer used." "24.1")
 
 (defcustom gnus-debug-exclude-variables
   '(mm-mime-mule-charset-alist
@@ -240,7 +242,10 @@ gnus-debug-exclude-variables
   "Variables that should not be reported in `gnus-bug'."
   :version "22.1"
   :group 'gnus-message
-  :type '(repeat (symbol :tag "Variable")))
+  :type '(repeat variable))
+
+(make-obsolete-variable
+ 'gnus-debug-exclude-variables "it is no longer used." "24.1")
 
 (defcustom gnus-discouraged-post-methods
   '(nndraft nnml nnimap nnmaildir nnmh nnfolder nndir)
@@ -340,7 +345,6 @@ gnus-inhibit-posting-styles
 (defvar gnus-article-yanked-articles nil)
 (defvar gnus-message-buffer "*Mail Gnus*")
 (defvar gnus-article-copy nil)
-(defvar gnus-check-before-posting nil)
 (defvar gnus-last-posting-server nil)
 (defvar gnus-message-group-art nil)
 
-- 
2.20.1

[Message part 3 (text/plain, inline)]

Thanks,

-- 
Basil

Gnus v5.13
GNU Emacs 27.0.50 (build 9, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2019-04-11

Message #8 received at 35239 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: 35239 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#35239: 27.0.50; Some gnus-msg.el variables are unused
Date: Tue, 07 May 2019 18:22:19 +0100

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> The user options gnus-debug-files and gnus-debug-exclude-variables have
> been unused since Emacs 24.1[1].  The following patch marks them as
> obsolete, fixes a few custom :types, and also removes the unused
> variable gnus-check-before-posting.  WDYT?
>
> [1: 72aba33f59]: Merge changes made in Gnus trunk.
>   2011-07-07 23:18:23 +0000
>   https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=72aba33f59d0ba30a01adf7aa7952b5839a8410d
>
> From 4b4fe3ed5a817f4535871c06ea001dc7d4077a96 Mon Sep 17 00:00:00 2001
> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> Date: Thu, 11 Apr 2019 23:55:03 +0100
> Subject: [PATCH] Fix some gnus-msg.el variables
>
> * lisp/gnus/gnus-msg.el (gnus-gcc-externalize-attachments):
> Fix custom :type.
> (gnus-debug-files, gnus-debug-exclude-variables): Mark variables
> that have been unused since Emacs 24.1 as obsolete.
> (gnus-check-before-posting): Remove unused variable.
> ---
>  lisp/gnus/gnus-msg.el | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/lisp/gnus/gnus-msg.el b/lisp/gnus/gnus-msg.el
> index b6d649d760..b7a97f19d0 100644
> --- a/lisp/gnus/gnus-msg.el
> +++ b/lisp/gnus/gnus-msg.el
> @@ -158,9 +158,9 @@ gnus-gcc-externalize-attachments
>  if nil, attach files as normal parts."
>    :version "22.1"
>    :group 'gnus-message
> -  :type '(choice (const nil :tag "None")
> -		 (const all :tag "Any")
> -		 (string :tag "Regexp")))
> +  :type '(choice (const :tag "None" nil)
> +                 (const :tag "Any"  all)
> +                 regexp))
>  
>  (defcustom gnus-gcc-self-resent-messages 'no-gcc-self
>    "Like `gcc-self' group parameter, only for unmodified resent messages.
> @@ -232,7 +232,9 @@ gnus-debug-files
>    "Files whose variables will be reported in `gnus-bug'."
>    :version "22.1"
>    :group 'gnus-message
> -  :type '(repeat (string :tag "File")))
> +  :type '(repeat file))
> +
> +(make-obsolete-variable 'gnus-debug-files "it is no longer used." "24.1")
>  
>  (defcustom gnus-debug-exclude-variables
>    '(mm-mime-mule-charset-alist
> @@ -240,7 +242,10 @@ gnus-debug-exclude-variables
>    "Variables that should not be reported in `gnus-bug'."
>    :version "22.1"
>    :group 'gnus-message
> -  :type '(repeat (symbol :tag "Variable")))
> +  :type '(repeat variable))
> +
> +(make-obsolete-variable
> + 'gnus-debug-exclude-variables "it is no longer used." "24.1")
>  
>  (defcustom gnus-discouraged-post-methods
>    '(nndraft nnml nnimap nnmaildir nnmh nnfolder nndir)
> @@ -340,7 +345,6 @@ gnus-inhibit-posting-styles
>  (defvar gnus-article-yanked-articles nil)
>  (defvar gnus-message-buffer "*Mail Gnus*")
>  (defvar gnus-article-copy nil)
> -(defvar gnus-check-before-posting nil)
>  (defvar gnus-last-posting-server nil)
>  (defvar gnus-message-group-art nil)
>  
> -- 
> 2.20.1

Lars, is this change acceptable?

Thanks,

-- 
Basil

Message #11 received at 35239 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 35239 <at> debbugs.gnu.org
Subject: Re: bug#35239: 27.0.50; Some gnus-msg.el variables are unused
Date: Thu, 09 May 2019 14:28:45 -0400

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> Lars, is this change acceptable?

Yes, looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #18 received at 35239-done <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 35239-done <at> debbugs.gnu.org
Subject: Re: bug#35239: 27.0.50; Some gnus-msg.el variables are unused
Date: Sun, 12 May 2019 12:22:08 +0100

tags 35239 fixed
close 35239
quit

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> Lars, is this change acceptable?
>
> Yes, looks good to me.

Thanks, I pushed it to master[1] and am therefore closing this report.

[1: ef62469e56]: Fix some gnus-msg.el variables (bug#35239)
  2019-05-12 11:59:11 +0100
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ef62469e566b6254742e0287b04fd138225e82a8

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.