GNU bug report logs - #35345
[PATCH 0/2] Add missing run-time dependency for TLP (Power management tool for Linux).

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35345 in the body.
You can then email your comments to 35345 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Stefanović <stefanx2ovic <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH 0/2] Add missing run-time dependency for TLP (Power management
 tool for Linux).
Date: Sat, 20 Apr 2019 16:26:31 +0000

Hello.

The first patch will add system (arch-kernel) specific
x86-energy-perf-policy package,
and the second patch will adjust TLP package to use
x86-energy-perf-policy as a optional/system-specific run-time
dependency.

To understand my motivation please take a look at:
- https://linrunner.de/en/tlp/docs/tlp-configuration.html#scaling
the section explaining ENERGY_PERF_POLICY_ON_AC parameter has the
following note:
"Important: this setting requires the kernel module msr and the tool
x86_energy_perf_policy matching your kernel version."

Message #8 received at 35345 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Stefanović <stefanx2ovic <at> gmail.com>
To: 35345 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: Add x86-energy-perf-policy
Date: Sat, 20 Apr 2019 16:45:12 +0000

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-x86-energy-perf-policy.patch (text/x-patch, attachment)]

Message #11 received at 35345 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Stefanović <stefanx2ovic <at> gmail.com>
To: 35345 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: tlp: Add required x86-energy-perf-policy input
 dependency.
Date: Sat, 20 Apr 2019 16:48:19 +0000

[Message part 1 (text/plain, inline)]

[0002-gnu-tlp-Add-required-x86-energy-perf-policy-input-de.patch (text/x-patch, attachment)]

Message #14 received at 35345 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Stefan Stefanović <stefanx2ovic <at> gmail.com>
Cc: 35345 <at> debbugs.gnu.org
Subject: Re: [bug#35345] [PATCH 1/2] gnu: Add x86-energy-perf-policy
Date: Mon, 27 May 2019 16:35:00 +0200

Hi Stefan,

Stefan Stefanović <stefanx2ovic <at> gmail.com> skribis:

> From 79d021f7bd686159ad9cf4dd2f94c360b2a21ae4 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Stefan=20Stefanovi=C4=87?= <stefanx2ovic <at> gmail.com>
> Date: Sat, 20 Apr 2019 15:37:13 +0200
> Subject: [PATCH 1/2] gnu: Add x86-energy-perf-policy.
>
> * gnu/packages/linux.scm (cpupower): New variable.

I fixed up indentation, added a copyright line for you, and committed.

Thanks,
Ludo’.

Message #19 received at 35345-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Stefan Stefanović <stefanx2ovic <at> gmail.com>
Cc: 35345-done <at> debbugs.gnu.org
Subject: Re: [bug#35345] [PATCH 2/2] gnu: tlp: Add required
 x86-energy-perf-policy input dependency.
Date: Mon, 27 May 2019 16:43:24 +0200

Hi,

Stefan Stefanović <stefanx2ovic <at> gmail.com> skribis:

> From a7264289ba328478a1dab1978fe080a5b4f392c2 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Stefan=20Stefanovi=C4=87?= <stefanx2ovic <at> gmail.com>
> Date: Sat, 20 Apr 2019 16:13:37 +0200
> Subject: [PATCH 2/2] gnu: tlp: Add required x86-energy-perf-policy input
>  dependency.
>
> * gnu/packages/linux.scm (tlp)
> [inputs]: Add system specific x86-energy-perf-policy dependency.
> [arguments]<#:phases>['wrap]:
> Adjust bin-directory procedure to return #f on missing input,
> a guard against system specific input dependencies.
> Filter only strings in the path list. Reformat for-each block.
> Add x86-energy-perf-policy in bin-directory input-name list.

I reworded it to use ‘filter-map’ intead of (filter string? …).

> +              ,@(if (member (or (%current-target-system) (%current-system))
> +                            (package-supported-systems x86-energy-perf-policy))

This would not work, because ‘%current-target-system’ returns a
“triplet”, not a “system type”, so I’ve also rephrased it.

Let me know if something’s broken!

Thanks,
Ludo’.

Message #22 received at 35345-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Stefanović <stefanx2ovic <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 35345-done <at> debbugs.gnu.org
Subject: Re: [bug#35345] [PATCH 2/2] gnu: tlp: Add required
 x86-energy-perf-policy input dependency.
Date: Tue, 28 May 2019 18:21:28 +0000

Hi,

The patch you made works fine on my system.
Sorry for the late response.

Your work on correcting, improving and applying my original patch is
appreciated,
thank you.

Stefan.

On 5/27/19, Ludovic Courtès <ludo <at> gnu.org> wrote:
> Hi,
>
> Stefan Stefanović <stefanx2ovic <at> gmail.com> skribis:
>
>> From a7264289ba328478a1dab1978fe080a5b4f392c2 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Stefan=20Stefanovi=C4=87?= <stefanx2ovic <at> gmail.com>
>> Date: Sat, 20 Apr 2019 16:13:37 +0200
>> Subject: [PATCH 2/2] gnu: tlp: Add required x86-energy-perf-policy input
>>  dependency.
>>
>> * gnu/packages/linux.scm (tlp)
>> [inputs]: Add system specific x86-energy-perf-policy dependency.
>> [arguments]<#:phases>['wrap]:
>> Adjust bin-directory procedure to return #f on missing input,
>> a guard against system specific input dependencies.
>> Filter only strings in the path list. Reformat for-each block.
>> Add x86-energy-perf-policy in bin-directory input-name list.
>
> I reworded it to use ‘filter-map’ intead of (filter string? …).
>
>> +              ,@(if (member (or (%current-target-system)
>> (%current-system))
>> +                            (package-supported-systems
>> x86-energy-perf-policy))
>
> This would not work, because ‘%current-target-system’ returns a
> “triplet”, not a “system type”, so I’ve also rephrased it.
>
> Let me know if something’s broken!
>
> Thanks,
> Ludo’.
>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.